[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor updated this revision to Diff 182718. teemperor added a comment. - Moved code into the VisitFunctionDecl function. I don't mind if we clean up that function in a later commit. Thanks for the feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.l

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

teemperor updated this revision to Diff 182761. teemperor added a comment. - Added a comment that the using directives are created by Sema. Also sorry for the late update :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51178/new/ https://reviews.llvm.org/D51178 Files: test/Import/c

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351739: [ASTImporter] Add test for importing anonymous namespaces. (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51178/new/ https:/

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rC351849: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor abandoned this revision. teemperor added a comment. So, the idea of going back to the headers and see if we can potentially remove mm_malloc from the modulemap didn't work out (mostly because a lot of headers include it indirectly). However, when going back to the original issue i not

[PATCH] D56936: Fix handling of overriden methods during ASTImport

teemperor accepted this revision. teemperor added a comment. LGTM, thanks! Comment at: unittests/AST/ASTImporterTest.cpp:2271 +struct D:B { void f(){}; }; + )"; + auto BFP = I think this should be formatted in the same way as the snippet above.

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. teemperor added a project: LLDB. Herald added subscribers: cfe-commits, rnkovacs. `MustBuildLookupTable` must always be called on a primary context as we otherwise trigger an assert, but we don't ensure that this will

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

This revision was automatically updated to reflect the committed changes. Closed by commit rL347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D55475: Misc typos fixes in ./lib folder

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This looks all good to me and from what see this was requested in a previous review (D44188 ). Do you need someone to commit this or did you receive comm

[PATCH] D55475: Misc typos fixes in ./lib folder

This revision was automatically updated to reflect the committed changes. Closed by commit rC348755: Misc typos fixes in ./lib folder (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55475/new/ https://reviews.llvm.org/D55475

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor added a comment. @joerg Yeah, we saw the commit explaining why the original fwd declaration patch was reverted. However, from what I can see, we only have three ways to fix the cyclic dependency between glibc and Clang's internal module: 1. We say that we don't support including mm_ma

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the idea of the patch is right. Not sure tough if having Import take a second parameter is consistent with the other Import functions (and if that even matters). ===

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/ https://reviews.llvm.org/D58743 ___ cfe-commits mailing lis

[PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

teemperor created this revision. teemperor added reviewers: martong, balazske, a.sidorin, shafik. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. We are currently implementing support in LLDB that reconstructs the STL templates from the target program in the expres

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

teemperor updated this revision to Diff 191257. teemperor retitled this revision from "[ASTImporter] Allow adding a shim to the ASTImporter" to "[ASTImporter] Allow adding a import strategy to the ASTImporter". teemperor edited the summary of this revision. teemperor added a comment. Thanks for

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

teemperor planned changes to this revision. teemperor added a comment. I think we could also refactor the strategy into a `PreImport` call. That way we don't break all the user-code out there and it seems less intrusive to the ASTImporter code. I'll update the patch. CHANGES SINCE LAST ACTION

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

teemperor created this revision. teemperor added reviewers: balazske, martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. `ASTImporter::Imported` currently returns a Decl, but that return valu

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL356592: Remove the unused return value in ASTImporter::Imported [NFC] (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191765. teemperor retitled this revision from "[ASTImporter] Allow adding a import strategy to the ASTImporter" to "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior.". teemperor edited the summary of this revision. teemperor a

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191859. teemperor marked 4 inline comments as done. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h clang/l

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added a comment. > Well, I still don't understand how LLDB synthesis the AST. > So you have a C++ module in a .pcm file. This means you could create an AST > from that with ASTReader from it's .clang_ast section, right? In that case > the AST should be complete with all type informat

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191946. teemperor marked 5 inline comments as done. teemperor added a comment. - Removed unused functions. - Fixed two comments that I missed to update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 File

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added a comment. In D59485#1439628 , @martong wrote: > In D59485#1439570 , @martong wrote: > > > In D59485#1439390 , @teemperor > > wrote: > > > > > > Well, I stil

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 192588. teemperor marked an inline comment as done. teemperor added a comment. - Addressed (most of) Aleksei's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/AST

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:590 + new RedirectingImporter(ToContext, ToFileManager, FromContext, + FromFileManager, MinimalImport, LookupTabl)); +}; a_sidorin w

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 192594. teemperor added a comment. Ah, I get it now. Fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTImporter.cpp clang/unittests/

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor added a comment. In D61140#1479111 , @aprantl wrote: > Could we test this by doing -dump-ast of From and To and FileCheck-ing the > output? +1 for this. Importing a simple record should test this? E.g. something like this: diff --git a/cla

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor added a comment. Sorry, that test case actually was a bit too complicated. This seems to work: diff --git a/clang/test/Import/cxx-record-flags/Inputs/F.cpp b/clang/test/Import/cxx-record-flags/Inputs/F.cpp new file mode 100644 index 000..1294c67f68d --- /dev/null +++

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 196955. teemperor retitled this revision from "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior." to "[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.". teemperor edited the summary of this revision

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 197149. teemperor added a comment. - Refactored test according to Gábor's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTImporte

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor added a comment. I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D59485?vs=197149&id=197180#

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor closed this revision. teemperor added a comment. This has been landed as rC359338 but somehow Phabricator didn't close this. Closing this manually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61140/new/ https://reviews.llvm.org/D61140

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

teemperor added a comment. I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB. Otherwise the LLDB part of this patch LGTM. Repository: rG LLVM Githu

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

teemperor resigned from this revision. teemperor added a comment. LGTM for the CloneChecker changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57850/new/ https://reviews.llvm.org/D57850 ___ cfe-commits mailing li

[PATCH] D57956: [www] Add ASTImporter fuzzer project.

teemperor closed this revision. teemperor added a comment. landed in llvm-svn: 354043 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57956/new/ https://reviews.llvm.org/D57956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

teemperor added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1160 +void Driver::handleAutocompletions(const llvm::opt::Arg *A) const { + // Print out all options that start with a given argument. This is used for I think a more generic interface wo

[PATCH] D37180: [modules] Add test for using declaration in classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311991: [modules] Add test for using declaration in classes. (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D37180?vs=112788&id=113044#toc Repository: rL LLVM https://rev

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D37249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL31: [analyzer] Performance optimizations for the CloneChecker (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D34182?vs=108839&id=113361#toc Repository: rL LLVM https:

[PATCH] D37383: [AST] Add TableGen for StmtDataCollectors

teemperor added a comment. @arphaman I suggested tablegen in https://reviews.llvm.org/D36664 because I remembered we had some CMake sanity check about not having an *.inc in our include dir: https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure if it actually fires for

[PATCH] D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup

teemperor updated this revision to Diff 113692. teemperor added a comment. - Rebased and fixed merge conflicts before merging. https://reviews.llvm.org/D34361 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp Index: lib/Analysis/CloneDetection.cpp

[PATCH] D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL312440: [analyzer] MinComplexityConstraint now early exits and only does one macro… (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D34361?vs=113692&id=113693#toc Repository:

[PATCH] D34178: [analyzer] Increase minimum complexity filter of the CloneChecker.

teemperor updated this revision to Diff 113725. teemperor added a comment. - Rebased and updated patch before merging. https://reviews.llvm.org/D34178 Files: lib/StaticAnalyzer/Checkers/CloneChecker.cpp test/Analysis/copypaste/asm.cpp test/Analysis/copypaste/attributes.cpp test/Analysis

[PATCH] D34178: [analyzer] Increase minimum complexity filter of the CloneChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312468: [analyzer] Increase minimum complexity filter of the CloneChecker. (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D34178?vs=113725&id=113726#toc Repository: rL LLV

[PATCH] D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value.

teemperor created this revision. Currently clang segfaults when invoked with `clang --autocomplete=`. This patch adds the necessary boundary checks and some tests for corner cases like this. Repository: rL LLVM https://reviews.llvm.org/D37465 Files: lib/Driver/Driver.cpp test/Driver/aut

[PATCH] D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312533: [Bash-autocomplete] Fix crash when invoking --autocomplete without value. (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D37465?vs=113829&id=113842#toc Repository:

[PATCH] D37383: [AST] Add TableGen for StmtDataCollectors

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. @johannes The blocking reviewer is because it touches clone detection code :) Fine with me, I have some comments on things but nothing that affects this review. LGTM! https://reviews.l

[PATCH] D37557: Refactor RecursiveASTVisitor test for post-order traversal

teemperor created this revision. Herald added subscribers: mgorny, klimek. The new test is now in the right directory with the other ASTVisitor tests and uses now the provided TestVisitor framework. Repository: rL LLVM https://reviews.llvm.org/D37557 Files: unittests/AST/CMakeLists.txt

[PATCH] D37416: Use the VFS from the CompilerInvocation by default

teemperor updated this revision to Diff 114504. teemperor added a comment. Herald added a subscriber: mgorny. - Added test case. https://reviews.llvm.org/D37416 Files: lib/Frontend/CompilerInstance.cpp unittests/Frontend/CMakeLists.txt unittests/Frontend/CompilerInstanceTest.cpp Index: u

[PATCH] D37416: Use the VFS from the CompilerInvocation by default

teemperor updated this revision to Diff 114524. teemperor added a comment. - Moved code from FrontendAction.cpp into createFileManager() https://reviews.llvm.org/D37416 Files: include/clang/Frontend/CompilerInstance.h lib/Frontend/CompilerInstance.cpp lib/Frontend/FrontendAction.cpp uni

[PATCH] D37416: Use the VFS from the CompilerInvocation by default

teemperor updated this revision to Diff 114790. teemperor added a comment. - Rebased diff before merging. https://reviews.llvm.org/D37416 Files: lib/Frontend/CompilerInstance.cpp unittests/Frontend/CMakeLists.txt unittests/Frontend/CompilerInstanceTest.cpp Index: unittests/Frontend/Compi

[PATCH] D37416: Use the VFS from the CompilerInvocation by default

teemperor updated this revision to Diff 114823. teemperor added a comment. - Rebased with the correct diff... https://reviews.llvm.org/D37416 Files: include/clang/Frontend/CompilerInstance.h lib/Frontend/CompilerInstance.cpp lib/Frontend/FrontendAction.cpp unittests/Frontend/CMakeLists.

[PATCH] D37416: Use the VFS from the CompilerInvocation by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL313049: Use the VFS from the CompilerInvocation by default (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D37416?vs=114823&id=114857#toc Repository: rL LLVM https://revie

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor added a comment. @martong Sorry for the delay, feel free to ping me in the future about these patches. I'll review them ASAP now that I'm back in office, so these delay's hopefully won't happen again. I tried applying this patch and it seems it needs to be rebased. I would do it myse

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. On my system clang-format has some complaints, so I think you need to rerun clang-format. Probably caused by the rebasing. I have some minor comments about the TestAST.py (see

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 __

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

teemperor added a comment. The error handling in LLDB seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ cfe-commits mailing list cfe-commits

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

teemperor added a comment. @Jacotot I assume you don't have commit access to merge yourself? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65978/new/ https://reviews.llvm.org/D65978 ___ cfe-commits mailing list cfe-c

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

teemperor accepted this revision. teemperor added a comment. LGTM. Thanks for the patch! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65978/new/ https://reviews.llvm.org/D65978 ___ cfe-commits mailing list cfe-commi

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

This revision was automatically updated to reflect the committed changes. Closed by commit rL368510: [clang] Fixed x86 cpuid NSC signature (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I wonder what's the motivation for making this a setting in the ExternalASTSource? Opposed to e.g. storing a bit in AsmLabelAttr, which we could squeeze in by maybe stealing a

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

teemperor resigned from this revision. teemperor added a comment. This LGTM modulo rjmccall's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D37475: Make MultiplexASTDeserializationListener part of the API [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL331021: Make MultiplexASTDeserializationListener part of the API [NFC] (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D37475?vs=113847&id=144287#toc Repositor

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. Herald added subscribers: cfe-commits, kristina, rnkovacs. Herald added a reviewer: shafik. Herald added a project: clang. That decl kind is currently not implemented. BuiltinTemplateDecl is for decls that are hardcod

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. We don't usually use alternative operator spelling in Clang, but otherwise this LGTM. I'll land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

teemperor added a comment. Landed as ad7211df6f257e39da2e5a11b2456b4488f32a1e Btw, usually patches also need a test (especially if they are less trivial than this one). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

This revision was automatically updated to reflect the committed changes. Closed by commit rGad7211df6f25 (authored by obruns, committed by teemperor). Changed prior to commit: https://reviews.llvm.org/D77468?vs=255059&id=255256#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. From what I understand the whole idea here is to just ask the external AST source to complete the record before we import them? If yes, then this seems like the right idea to m

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

teemperor added a comment. This introduced a compiler warning: /Users/teemperor/1llvm/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1102:23: warning: 'getDecl' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] cons

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for tracking this down, this is a really nasty bug... The fix itself is obviously fine, but I think I'm out of the loop regarding the testing strategy. We talked about a

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor added a comment. In D83008#2131796 , @tschuett wrote: > You could try: > > clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp -emit-llvm > -o /dev/null > > > You could commit the record layouts without your fix to show the differe

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

teemperor added a comment. This broke the Green Dragon build for Clang: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/ FAILED: bin/diagtool : && /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++ -Wdocumentation -fPIC -fvisibility-inlines-hidden -Werror=dat

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

teemperor added a comment. Fixed here to get the bot running again: https://github.com/llvm/llvm-project/commit/7308e1432624f02d4e652ffa70e40d0eaa89fdb3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82585/new/ https://reviews.llvm.org/D82585 __

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor added a comment. I think we are talking about different things. My question was why is this a 'Shell' test (like, a test in the `Shell` directory that uses FileCheck) and not a test in the `API` directory (using Python). An 'API' test could use the proper expression testing tools. And

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___ cfe-commi

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor added a comment. Beside Gabors comment I think I'm happy with this. Thanks! Comment at: clang/unittests/AST/ASTImporterTest.cpp:5939 + +/// An ExternalASTSource that keeps track of the tags is completed. +struct SourceWithCompletedTagList : clang::ExternalASTSource {

[PATCH] D78086: [ASTImporter] Also import overwritten file buffers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f1e81f1c0ac: [ASTImporter] Also import overwritten file buffers (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D84828: [clang] Don't make synthesized accessor stub functions visible twice

This revision was automatically updated to reflect the committed changes. Closed by commit rG442a80292d50: [clang] Don't make synthesized accessor stub functions visible twice (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D84829: [clang] Don't make ObjCIvarDecl visible twice when adding them to an implicit ObjCInterfaceDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG02899d7f1b9a: [clang] Don't make ObjCIvarDecl visible twice when adding them to an implicit… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: r

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm really sorry, I don't understand what kind of review is expected here given the state of this patch. - The patch **still** doesn't include the tests that I asked for in my

[PATCH] D105926: [PowerPC] Extra test case for LDARX

teemperor added a comment. Sorry for raising an unrelated topic here, but I can't reach @Conanap directly via the mail from the git commits: @Conanap could you please create the git branches for your patches in your own Github fork instead of the main LLVM repo? LLVM's policy is to have working

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

teemperor added a comment. Quick note to prevent some confusion: I saw this patch and realized that the LLDB change was only necessary because some Clang code got copy pasted into LLDB. I removed that copy in https://reviews.llvm.org/D106537 so if you see merge conflicts while merging this, you

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think my concerns from D96033 are all addressed by now, so this LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

teemperor added a comment. import-std-module test changes look good to me, thanks for fixing that up. And yes, ideally the tests should never use any libc++ internal names (and LLDB should never print them for those tests). So I think not having those in the here is a step in the right directio

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

teemperor added a comment. Seems like this patch introduced a cyclic dependency between Basic and AST when building with LLVM_ENABLE_MODULES=On: While building module 'Clang_AST' imported from llvm/lldb/include/lldb/Symbol/ClangUtil.h:14: While building module 'Clang_Basic' imported from l

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor updated this revision to Diff 108837. teemperor added a comment. Herald added a subscriber: klimek. - Updated according to Artem's comments. https://reviews.llvm.org/D34182 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/Format/UnwrappedLinePar

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor updated this revision to Diff 108839. teemperor added a comment. (Fixed diff) https://reviews.llvm.org/D34182 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneChecker.cpp Index: lib/StaticAnalyzer/Checkers/CloneChec

[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

teemperor added a comment. In https://reviews.llvm.org/D36067#825867, @xazax.hun wrote: > I like the directions of this patch. > In general, I am in favor of explicitly registering the options from user > defined checkers. > But changing a config option will now break the command line compati

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. E.g. If you add a flag that lands in between the results it breaks. Add `-Wmajor-new-feature` and the test goes red. Same with the flag results or changing the help test for `-std=`. We

[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

teemperor abandoned this revision. teemperor added a comment. I see, thanks for the information! If we don't need to support this in the shell-completion and we shouldn't report invalid arguments, then it seems this review is stuck here. I'll abandon as I don't see any other use case for this c

[PATCH] D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, more publicity means that more shells will make use of it. https://reviews.llvm.org/D36567 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

teemperor added a comment. Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting. I'm wondering what would be a nice way of creating a StmtDataCollector that is faster but only works for single translation units (e.g. it only ha

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

teemperor added a comment. That's a really nice approach to this problem, good job Yuka! See my inline comments for some minor remarks. Comment at: clang/include/clang/Driver/CC1Options.td:104 + const char* Values = +#define GET_CHECKERS +#define CHECKER(FULLNAME, CLASS, DESC

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

teemperor added inline comments. Comment at: clang/lib/Driver/DriverOptions.cpp:14 #include "llvm/Option/Option.h" +#include I think the C++ version of the assert header is more consistent: `#include ` Comment at: llvm/utils/TableGen/OptPa

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Found one more minor comment typo. And could you do your changes to `OptParserEmitter.cpp` all in this patch? Because Rui/Me pointed out those things on this review, so this patch should

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Sorry for the delay, was on vacation. > Since StmtDataCollectors.inc resides in lib I have to use relative paths (so > the include directive looks different depending on the current file

[PATCH] D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0bcd11068fc: [ASTImporter] Add basic support for comparing Stmts and compare function bodies (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c4575e15f06: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

teemperor added a comment. This broke Green Dragon's compiler-rt builds and also my local compiler-rt build. See for example here: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23424/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

<    1   2   3   4   >