teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
Sorry for the delay, was on vacation. > Since StmtDataCollectors.inc resides in lib I have to use relative paths (so > the include directive looks different depending on the current file), we have > to live with this, right? That's right, but do we want this to be in `lib/` ? There users can't access this code to build their own DataCollector (at least when they build against an installed clang version where this inc file doesn't get installed). And if someone uses this file from a clang header by accident we get errors about this missing file with installed clang versions (and I think the build bots don't perform install tests, so it probably breaks silently). We probably also can't just move it into `include/` because `*.inc` files there break some CMake sanity checks IIRC, so I think the best way forward is to tablegen this file which also makes the `StmtDataCollectors.inc` file more readable. > These things should be documented in DataCollection.h I guess. Agreed, could you do that? I think this can go in with just these documentation changes (especially since its GSoC related and we're in the last week), so please add them and then LGTM. Stable hashes and tablegen can be a follow-up patches. https://reviews.llvm.org/D36664 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
