@@ -189,7 +189,7 @@ static StringRef NormalizeGNUAttrSpelling(StringRef
AttrSpelling) {
typedef std::vector> ParsedAttrMap;
-static ParsedAttrMap getParsedAttrList(const RecordKeeper &Records,
jurahul wrote:
I propose the following next steps (once this is
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -189,7 +189,7 @@ static StringRef NormalizeGNUAttrSpelling(StringRef
AttrSpelling) {
typedef std::vector> ParsedAttrMap;
-static ParsedAttrMap getParsedAttrList(const RecordKeeper &Records,
jurahul wrote:
And here's for the entire MLIR tablegen code:
ht
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -189,7 +189,7 @@ static StringRef NormalizeGNUAttrSpelling(StringRef
AttrSpelling) {
typedef std::vector> ParsedAttrMap;
-static ParsedAttrMap getParsedAttrList(const RecordKeeper &Records,
jurahul wrote:
And for all clang-tablegen its here:
https://git
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/106658
>From 664c9fa9ade11150d635b9dbfb4c1ada7e32e8cd Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 29 Aug 2024 20:36:05 -0700
Subject: [PATCH] [TableGen] Add const variants of accessors for backend
Split Reco
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
> > I propose the following next steps (once this is committed):
>
> this timeline looks fine, do you also want to add `[[deprecated]]` once the
> PSA is out? Also, I can help on other LLVM TableGen backends if they haven't
> been updated.
Yeah, once all the upstream backends a
jurahul wrote:
I also did a minor update to the diff: I changed the const versions that used
to return references to vectors to instead return `ArrayRef`.
IMO this will prevent accidental vector copies in code like `auto X =
RC.getAllDerivedDefinitions("yyy")`.
https://github.com/llvm/llvm-pr
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/106658
>From 4e1d789d052c9ae7d0fc3be73307f9d77bc5fa9f Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 29 Aug 2024 20:36:05 -0700
Subject: [PATCH] [TableGen] Add const variants of accessors for backend
Split Reco
jurahul wrote:
I posted the PSA at:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefinitions-api-potential-downstream-breakages/81089
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commit
jurahul wrote:
This is a refactor for better const correctness in TableGen backends. Please
see the discourse thread here:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefinitions-api-potential-downstream-breakages/81089
https://github.com/llvm/llvm-project/pull/10
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/107533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/107692
Change SetTheory::RecSet/RecVec to use const Record pointers.
>From 4fc94659b3c245a30902c95be6d9c7bfd1d55f0a Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Sat, 7 Sep 2024 04:33:09 -0700
Subject: [PATCH] [Tab
@@ -2808,10 +2806,10 @@ RecordRecTy *Record::getType() {
return RecordRecTy::get(TrackedRecords, DirectSCs);
}
-DefInit *Record::getDefInit() {
+DefInit *Record::getDefInit() const {
if (!CorrespondingDefInit) {
-CorrespondingDefInit =
-new (TrackedRecords.get
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/107692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/107692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul deleted
https://github.com/llvm/llvm-project/pull/107692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2808,10 +2806,10 @@ RecordRecTy *Record::getType() {
return RecordRecTy::get(TrackedRecords, DirectSCs);
}
-DefInit *Record::getDefInit() {
+DefInit *Record::getDefInit() const {
if (!CorrespondingDefInit) {
-CorrespondingDefInit =
-new (TrackedRecords.get
@@ -2808,10 +2806,10 @@ RecordRecTy *Record::getType() {
return RecordRecTy::get(TrackedRecords, DirectSCs);
}
-DefInit *Record::getDefInit() {
+DefInit *Record::getDefInit() const {
if (!CorrespondingDefInit) {
-CorrespondingDefInit =
-new (TrackedRecords.get
jurahul wrote:
> lgtm assuming the const_cast goes away in a subsequent change
Thanks. Yeah as I said above, I think we can make the Record* in DefInit const
and then get rid of the const_cast<>. But the mutable for CorrespondingDefInit
will stay, with it serving as a cache.
https://github.c
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/107533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/107692
>From b11f8fbde5cc005e4667877ed60954f36abcec0c Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Sat, 7 Sep 2024 04:33:09 -0700
Subject: [PATCH] [TableGen] Change SetTheory set/vec to use consr Record *
Change S
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/107692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
@Sirraide @Lukacma @SpencerAbson @mshockwave can you PTAL? Or suggest other
reviewers?
https://github.com/llvm/llvm-project/pull/107533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
jurahul wrote:
@AaronBallman can you please help find appropriate folks to review this PR?
https://github.com/llvm/llvm-project/pull/107533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
jurahul wrote:
Fair enough. The formatting changes are unintentional (I just happened to touch
code that was not compliant and clang-format did its thing). How about I split
these per-file/per-emitter/related sets of emitters? I have been doing the same
on LLVM side, just that for clang it was
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108193
Change ASTTableGen to use const Record pointers.
>From 2e365455982c5cd7405beace6807c0b72b2e06d3 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 04:38:23 -0700
Subject: [PATCH] [clang][TableGen
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108195
Migrate Builtins emitter to use const RecordKeeper.
>From 903b02c1656c5bacfa0d97da83584876fa1f2999 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 04:51:40 -0700
Subject: [PATCH] [clang][Tabl
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108199
Change comment command emitter to const RecordKeeper.
>From 5e344e11844fc50ef231c8f8937f5251e76a1150 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 04:59:50 -0700
Subject: [PATCH] [clang][Tab
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108201
None
>From 2e0b2207c6cff650edee1db9da00ef6734366cd2 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:05:26 -0700
Subject: [PATCH] [clang][TableGen] Change HTML Emitter to use const
RecordKe
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108202
None
>From fa77d999f72a5faff0cbab7f4609eab7910dc3d8 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:09:13 -0700
Subject: [PATCH] [clang][TableGen] Change HTML Tags emitter to use const
Rec
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108203
None
>From 3f98162db22fffbeb5d4c140e83c502aef049f9c Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:11:29 -0700
Subject: [PATCH] [clang][TableGen] Change DataCollector to use const
RecordK
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108209
None
>From 34a33e2b31ef10ecad91197dcae67164f5163ace Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:28:22 -0700
Subject: [PATCH] [clangl[TableGen] Change Diagnostic Emitter to use const
Re
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108211
None
>From 49650f70c36c37747da6d73865ebcb7b7a94da2f Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:33:50 -0700
Subject: [PATCH] [clang][TableGen] Change Opcode Emitter to use const
Record
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108213
None
>From b70f6ccab04237caf4e956deee4893dc13557088 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:40:16 -0700
Subject: [PATCH] [clang][TableGen] Change OpenCL emitter to use const
Record
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108216
None
>From f45b440523b4d1043f42b969246900c24025871a Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:51:13 -0700
Subject: [PATCH] [clang][TableGene] Change OptionDoc Emitter to use const
Re
https://github.com/jurahul converted_to_draft
https://github.com/llvm/llvm-project/pull/107533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
@AaronBallman I am adding you as a reviewer, but if there is someone else who
can help review these, please let me know.
https://github.com/llvm/llvm-project/pull/108193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -68,7 +69,8 @@ getCategoryFromDiagGroup(const Record *Group,
// The diag group may the subgroup of one or more other diagnostic groups,
// check these for a category as well.
- const std::vector &Parents = DiagGroupParents.getParents(Group);
+ const std::vector &Paren
@@ -255,20 +257,18 @@ class InferPedantic {
GMap;
DiagGroupParentMap &DiagGroupParents;
- const std::vector &Diags;
- const std::vector DiagGroups;
+ ArrayRef Diags;
jurahul wrote:
Yes. If you look at
https://discourse.llvm.org/t/psa-planned-chang
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,12 +39,13 @@ using namespace llvm;
namespace {
class DiagGroupParentMap {
- RecordKeeper &Records;
- std::map > Mapping;
+ const RecordKeeper &Records;
+ std::map> Mapping;
jurahul wrote:
Sound good, I'll change in the follow on.
https://github.co
@@ -255,20 +257,18 @@ class InferPedantic {
GMap;
DiagGroupParentMap &DiagGroupParents;
- const std::vector &Diags;
- const std::vector DiagGroups;
+ ArrayRef Diags;
jurahul wrote:
Let me know if that answers your question. This PR will unblock som
https://github.com/jurahul deleted
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108209
>From df228c650d4816eacc5b20771d8be294ab8ee134 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 05:28:22 -0700
Subject: [PATCH] [clangl[TableGen] Change Diagnostic Emitter to use const
RecordKe
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108269
Change AttrEmitter to use const RecordKeeper.
>From 5c7d69a1595af72b48dc417f8d3aa89404fbf265 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 11:32:36 -0700
Subject: [PATCH] [clang][TableGen] C
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108274
Change ASTProperties Emitter to use const RecordKeeper.
>From d5396fdc12a6a24960b42ec9f50556b00e42e08e Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 11 Sep 2024 11:51:51 -0700
Subject: [PATCH] [clang][T
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From 7b8c1794d4f2510502349d1151c8266c8b234ac0 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH 1/2] [Support] Detect invalid formatv() calls
- Detect formatv() c
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From 5cfd34a7f0177b52d4616f3c3e03e2ae14bfaae8 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH] [Support] Detect invalid formatv() calls
- Detect formatv() calls
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From d834ebbc8f34143ccaf905c82257742dea61ea9e Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH] [Support] Detect invalid formatv() calls
- Detect formatv() calls
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/105745
>From 9ae8a0361b0d26cf29cc4547658baec0c2654c89 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 22 Aug 2024 08:47:02 -0700
Subject: [PATCH] [Support] Detect invalid formatv() calls
- Detect formatv() calls
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Hi all, this is related to
https://discourse.llvm.org/t/adding-argument-count-validation-for-formatv/80876/1
I still have formatv() and formatvv() functions in the code, but only a handful
instances. So, if this looks ok overall, I will go ahead and rename formatvv()
to formatv
jurahul wrote:
> CI failed FYI.
Yeah, it looked like an unrelated failure. Windows CI passed.
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
jurahul wrote:
> compile-time tests with clang for example
I can check. How do I run them?
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
1 - 100 of 432 matches
Mail list logo
