[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: jsji, daltenty, nemanjai. qiongsiwu1 added a project: clang. Herald added subscribers: steven.zhang, pengfei, mgorny, dschuff. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3443108 , @tlively wrote: > No concerns about the WebAssembly changes. Will the default installation for > folks who don't touch `LLVM_DISTRIBUTION_COMPONENTS` change? Thanks Thomas! No, the default installations t

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a subscriber: momchil.velikov. qiongsiwu1 added a comment. May I get some comments from the rest of the reviewers for the respective platforms? @momchil.velikov @chill: arm @pengfei : x86 @jdoerfert: cuda @yaxunl : opencl @kaz7 : ve @bcain : hexagon @sdardis : mips Thanks so mu

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 422589. qiongsiwu1 added subscribers: abdulras, compnerd. qiongsiwu1 added a comment. Herald added subscribers: pcwang-thead, luke957, s.egerton, simoncook. Addressing review comments: 1. @chill pointed out that the generated headers are missing. The gener

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3448554 , @DavidSpickett wrote: > Is there any reason to have an AArch64 specific section? A lot of the files > do apply to both Arm and AArch64 but for example the mve file Momchil > mentioned does not. > > Would

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 422959. qiongsiwu1 added a comment. Thanks @DavidSpickett !! The patch is updated. The `arm` headers are now split between `arm` and `aarch64`. > Also, what's the feedback mechanism for issues with these listings? Say we > add a new Arm header but forget

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 422996. qiongsiwu1 added a comment. > Also, what's the feedback mechanism for issues with these listings? Say we > add a new Arm header but forget to put it on these lists, who would be the > first to notice? (I admit I'm not very familiar with the proces

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. @DavidSpickett @chill @momchil.velikov May I get some comments on the `arm/aarch64` related code changes? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 __

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3458357 , @DavidSpickett wrote: > Unless I'm missing an existing check, is it possible to check for the > existing files too? I guess not nicely because along with the resource > headers there are lots of internal

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3458967 , @pengfei wrote: >> Maybe I can ask cmake to check for architecture/targets during configuration >> and select the headers automatically, but that is beyond the scope of this >> patch. > > I'm not familar

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3465139 , @rastogishubham wrote: > Hi, this patch causes an issue with the CMake Xcode build configuration, if I > try to use xcode as the generator with CMake, using the build command: > > I used git bisect to fig

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 425780. qiongsiwu1 added reviewers: ye-luo, rastogishubham. qiongsiwu1 added a comment. Herald added a subscriber: sstefan1. This patch is updated to address - https://github.com/llvm/llvm-project/issues/55002 @ye-luo - configuration issue with xcode @rast

[PATCH] D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: jsji, rzurob. qiongsiwu1 added projects: clang, PowerPC. Herald added subscribers: shchenz, mgorny. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. This patch splits out

[PATCH] D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ca6328637b3: [clang][ppc] Creating Seperate Install Target for PPC htm Headers (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12538

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} craig.topper wrote: > There appear to be two installs of ppc_wrapper_files with different > components. Is that intentional? Ah yes this

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} craig.topper wrote: > qiongsiwu1 wrote: > > craig.topper wrote: > > > There appear to be two installs of ppc_wrapper_files with different

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: craig.topper, DavidSpickett, nemanjai. qiongsiwu1 added a project: clang. Herald added subscribers: StephenFan, guansong, kristof.beyls, yaxunl, mgorny. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald ad

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:537 + FILES ${openmp_wrapper_files} + DESTINATION ${header_install_dir} + EXCLUDE_FROM_ALL craig.topper wrote: > Should this be ${header_install_dir}/openmp_wrappers Oh good catch!

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} craig.topper wrote: > qiongsiwu1 wrote: > > craig.topper wrote: > > > qiongsiwu1 wrote: > > > > craig.topper wrote: > > > > > There appear

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f12718ccfd6: [clang] Fixing arm-common, windows only and openmp header install targets (authored by qiongsiwu1). Repository: rG LLVM Github Monor

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468525. qiongsiwu1 added a comment. Address a review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

qiongsiwu1 added a comment. @w2yehia @daltenty may I ask for a review? Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135885/new/ https://reviews.llvm.org/D135885 ___ cfe-commits mailing l

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: shchenz, lkail. qiongsiwu1 added projects: clang, debug-info. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. On AIX, the default tuning option is `dbx` so it is

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 468626. qiongsiwu1 added a comment. Adding one more test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ https://reviews.llvm.org/D136187 Files: clang/lib/Driver/ToolChains/AIX.h clang/l

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 468914. qiongsiwu1 added a comment. Address the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ https://reviews.llvm.org/D136187 Files: clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 469223. qiongsiwu1 removed a project: All. qiongsiwu1 added a comment. Herald added a project: All. Adding two test cases to match `G_NOTUNING`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ http

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/debug-options.c:121 // RUN: %clang -### -c -g %s -target powerpc-ibm-aix-xcoff 2>&1 \ -// RUN: | FileCheck -check-prefix=G_LIMITED -check-prefix=G_DBX %s +//

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4374 + ? llvm::DebuggerKind::Default + : DebuggerTuning); probinson wrote: > Seems like you should be able to return `D

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

qiongsiwu1 updated this revision to Diff 469428. qiongsiwu1 added a comment. Rebase and cleanup some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135885/new/ https://reviews.llvm.org/D135885 Files: clang/test/Driver/lto-aix.c Inde

[PATCH] D136874: [clang][LTO] Passing vec-extabi to the Backend on AIX

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. The followi

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 463878. qiongsiwu1 added a comment. Fix the test failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 463943. qiongsiwu1 added a comment. Fix test case on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464001. qiongsiwu1 added a comment. Try fixing the test case on Windows, hopefully one last time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/li

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464683. qiongsiwu1 added a comment. Address a code review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp c

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464998. qiongsiwu1 added a comment. Address review comments. Remove unnecessary `Twine`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, azat, dblaikie. qiongsiwu1 added projects: clang, LLVM. Herald added subscribers: ormris, StephenFan, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: lldb-

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 updated this revision to Diff 465872. qiongsiwu1 added a comment. Fix a patch upload error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/debug-options-arange

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

qiongsiwu1 added a comment. In D134668#3841312 , @MaskRay wrote: > I think I want to revert this change. `--plugin-opt=` is entirely fine with > lld and GNU gold/ld... And generally the double-dash long options are > preferred. Sure. What we are aiming

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 added a comment. In D135400#3841321 , @MaskRay wrote: > I missed https://reviews.llvm.org/D134668 . See my comment there I don't > think the change is necessary. Thanks for the comment! I posted a reply there. CHANGES SINCE LAST ACTION ht

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

qiongsiwu1 added a comment. In D134668#3841464 , @MaskRay wrote: > Err since `-plugin-opt=` was used a lot of before this change, I think this > is fine for consistency. Ah ok this sounds good to me as well! Just to make sure I understand, we will need

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 updated this revision to Diff 465910. qiongsiwu1 added a comment. Thanks for the review! Comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files: clang/lib/Driver/ToolChains/

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 467119. qiongsiwu1 added a comment. Rebase with latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/l

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: MaskRay, w2yehia, daltenty. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subsc

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: shchenz, lkail, w2yehia, daltenty, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Hera

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 added a comment. Ah I just saw 5d3139aef113881fff9430c96069faf96630a5d8 . Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468307. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: c

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 marked 3 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589 + // On platforms other than AIX, gdb is the default option. + // On AIX, dbx will be automatically pick up in the presense of the +

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468341. qiongsiwu1 added a comment. Clean up testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 updated this revision to Diff 542042. qiongsiwu1 added a comment. Updating a test to see if it passes pre-commit CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 Files: clang/lib/Driver/To

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. We'd like to get this in to LLVM 17 if possible. Please let me know if there are comments/suggestions. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + if (NeedsProfileRT || needsGCovInstrumentation(Args)) +CmdArgs.push_back("-lpthreads"); + w2yehia wrote: > w2yehia wrote: > >

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4582825 , @MaskRay wrote: > Using `%p` should not magically change the behavior and I am unsure the > result is better for PGO. > If we decide to provide such a mode, it needs to be opt-in by adding a new > format

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. In D157280#4586078 , @MaskRay wrote: > Please add a link to https://reviews.llvm.org/D87737 in the summary/commit > message. Will do! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGO

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 updated this revision to Diff 550067. qiongsiwu1 added a comment. Fixing method parameter name format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst clan

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

This revision was automatically updated to reflect the committed changes. Closed by commit rG611ce24114aa: [PGO] Enable `-fprofile-update` for `-fprofile-generate` (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ h

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Thanks for chiming in @phosek ! In D155290#4587438 , @phosek wrote: > Can we avoid the use of `pthread_atfork` and the dependency on pthreads? > Using pthreads inside the profile runtime implementation is problematic in > th

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: MaskRay, davidxl, w2yehia. Herald added subscribers: wlei, ormris, wenlei, hiraditya. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. If there are no comments on whether we should add `-lpthread` for platforms other than AIX, I will land this patch soon, and let the official buildbots check for problems. If there are problems, I will let the bots run a bit (probably a day or so) b

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 updated this revision to Diff 548695. qiongsiwu1 added a comment. Update clang users manual. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst clang/lib/Code

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4574797 , @MaskRay wrote: > In D155290#4572965 , @qiongsiwu1 > wrote: > >> Ping for review. >> >> If there are no comments on whether we should add `-lpthread` for platforms

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 539105. qiongsiwu1 added a comment. Fixing inconsistent braces. Thanks for the feedback @hubert.reinterpretcast ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 F

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. @MaskRay @w2yehia @shchenz could you let me know if there are further comments? I will land this patch if there are none. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D15292

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b66b3417c02: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when… (authored by qiongsiwu1). Repository: rG LLVM Githu

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4490581 , @MaskRay wrote: > We have `TargetOptions::DisableIntegratedAS` (your llc.cpp change). Do you > know why it is not feasible for the places you want to check? I am checking/using `TargetOptions::DisableInte

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 539544. qiongsiwu1 added a comment. Address test case review comments. Thanks so much @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Fi

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41447f6fdfe4: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, davidxl, vsk, ellis. Herald added subscribers: wlei, Enna1, wenlei. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects: cl

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 updated this revision to Diff 540998. qiongsiwu1 added a comment. Revise the tests to use llvm tools to dump profile data to check for profile validity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:795 - /* When PNS >= OldPNS, the last one wins. */ - if (!FilenamePat || parseFilenamePattern(FilenamePat, CopyFilenamePat)) resetFilenam

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 updated this revision to Diff 541005. qiongsiwu1 added a comment. Minor comment spelling fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 Files: clang/lib/Driver/ToolChains/AIX.cpp comp

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D157280 enabled `-fprofile-update` for `-f

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + StringRef Val = A->getValue(); + if (Val == "atomic" || Val == "prefer-atomic") +CmdArgs.push_back("-latomic"); This check here is copied from https://githu

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554523. qiongsiwu1 added a comment. Address code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/fprofile-update.c Ind

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/fprofile-update.c:17 +// AIX specific tests +// RUN: %if system-aix %{ %clang -### %s -fprofile-generate -fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX %}

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554842. qiongsiwu1 added a comment. Address code review. Thanks for the input @w2yehia ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files: clang/lib/Driver/

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6e6abd76cd3: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect (authored by qiongsiwu1). Repository: rG LLVM Githu

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added projects: clang, LLVM. Herald added subscribers: ormris, StephenFan, wenlei, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added sub

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

qiongsiwu1 updated this revision to Diff 478592. qiongsiwu1 added a comment. Address review comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138854/new/ https://reviews.llvm.org/D138854 Files: clang/lib/Driver/ToolCh

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

qiongsiwu1 updated this revision to Diff 478661. qiongsiwu1 added a comment. Fix a clang-format issue in `CommonArgs.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138854/new/ https://reviews.llvm.org/D138854 Files: clang/lib/Driver/ToolCha

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 505181. qiongsiwu1 added a comment. Thanks for the comments @stephenpeckham ! This update addresses all of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Fi

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5250 + if (Args.hasArg(options::OPT_mroptr) || Args.hasArg(options::OPT_mno_roptr)) { +bool HasRoptr = hubert.reinterpretcast wrote: > This only checks for `-m[no-]roptr`

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:21 +// RUN: FileCheck %s --check-prefix=ROPTR +// RUN: %clang -### -target powerpc64-ibm-aix-xcoff -S -mroptr %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=ROPTR MaskRay wrote:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 507752. qiongsiwu1 added a comment. Address code review. Thanks for your comments/suggestions @MaskRay !! - Fixing comments. - Using `--target=` in tests. - Reducing number of RUN lines in tests. @hubert.reinterpretcast I ended up having a mix of tests fo

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:714-716 +if (!Args.hasFlag(options::OPT_fdata_sections, + options::OPT_fno_data_sections, UseSeparateSections) && +Args.hasArg(options::OPT_fno_data_sections)

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509057. qiongsiwu1 added a comment. Fixing LTO data sections error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509091. qiongsiwu1 added a comment. Simplify LTO data section error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509118. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Renaming the `-mroptr` option to `-mxcoff-roptr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. The new option is renamed to `-mxcoff-roptr` to avoid confusions if we are using it during a pure linking job on non-AIX platforms. The option name now implies that it applies to XCOFF only, so silently ignoring the option on other platforms is not that serious a pro

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509342. qiongsiwu1 added a comment. Rebase and address feedback other than test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseN

  1   2   >