[PATCH] D32395: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D31887: [clangd] Add documentation page

Prazek added a comment. In https://reviews.llvm.org/D31887#740727, @malaperle-ericsson wrote: > Would it be possible to commit this? I do not have commit rights. Thanks! Why won't you get commit right? You will probably make some other contribution to clangd, so it will be handy to have it :)

[PATCH] D32678: [clang-tidy] Fix naming convention in modernize-use-emplace

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. Lgtm https://reviews.llvm.org/D32678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32378: Insert invariant.group.barrier for pointers comparisons

Prazek added a comment. In https://reviews.llvm.org/D32378#741989, @hubert.reinterpretcast wrote: > Has it been discussed whether this is something to be addressed in the > optimizer as opposed to the front-end? The example that you showed is excellent. I didn't know that LLVM does the transf

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23 +AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) { + return true; kuhar wrote: > alexfh wrote: > > This should be a node matcher rather than a narrowing mat

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

Prazek accepted this revision. Prazek added a comment. LGTM Repository: rL LLVM https://reviews.llvm.org/D32767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:22 +void ThrowWithNoexceptCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus11) +return; If we handle throw() then it should be CPlusPlus ==

[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32401: [Devirtualization] insert placement new barrier with -O0

Prazek added a comment. Is everyone ok with sending this patch? https://reviews.llvm.org/D32401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32401: [Devirtualization] insert placement new barrier with -O0

This revision was automatically updated to reflect the committed changes. Closed by commit rL303488: [Devirtualization] insert placement new barrier with -O0 (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D32401?vs=96313&id=99667#toc Repository: rL LLVM https://revi

[PATCH] D31830: Emit invariant.group.barrier when using union field

Prazek added a reviewer: mehdi_amini. Prazek added a comment. Ping https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:76 + + for (const auto Parent : Context->getParents(node)) { +if (isCaughtInFunction(Context, Throw, Function, Parent)) unnecessary braces Comment at: cla

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: docs/ReleaseNotes.rst:58 +- New `misc-throw-with-noexcept + `_ check I think this should be in alphabetical order. https://reviews.llvm.o

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

Prazek added a comment. Could you add similar tests as the ones that Stanislaw provied in his patch? Like the one with checking if throw is catched, or the conditional noexcept (by a macro, etc) https://reviews.llvm.org/D3 ___ cfe-commits maili

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added a comment. In https://reviews.llvm.org/D19201#760151, @aaron.ballman wrote: > As an FYI, there is a related check being implemented in clang currently; we > probably should not duplicate this effort. See > https://reviews.llvm.org/D3. I think that clang is the right place for

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek accepted this revision. Prazek added a comment. LGTM, but wait if Aaron will accept it. https://reviews.llvm.org/D19201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33437: Emit available_externally vtables opportunistically

Prazek created this revision. We can emit vtable definition having inline function if they are all emitted. https://reviews.llvm.org/D33437 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGVTables.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumC

[PATCH] D33437: Emit available_externally vtables opportunistically

Prazek updated this revision to Diff 99897. Prazek added a comment. Removed debug print https://reviews.llvm.org/D33437 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGVTables.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumCXXABI.cpp test/Cod

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek created this revision. Herald added subscribers: xazax.hun, mgorny. This check flags usages of ``std::numeric_limits::{min,max}()`` for unspecialized types. It is dangerous because returns T(), which might is rarely minimum or maximum for this type. Consider scenario: 1. Have `typedef lon

<    1   2   3