Prazek added inline comments.
================
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23
+AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) {
+ return true;
----------------
kuhar wrote:
> alexfh wrote:
> > This should be a node matcher rather than a narrowing matcher, and it
> > should be placed to ASTMatchers.h, if there is no such matcher already.
> I wanted to backport this fix to 4.0.1 release after applying it in trunk.
> I thought that adding a new ASTMatcher would introduce an API change in
> clang, and I'm not sure if it's much welcome.
>
> Maybe it would be better to introduce a new matcher in ASTMatchers.h in trunk
> and make it an internal narrowing matcher in the backported patch? What would
> be best?
Why adding new matcher to 4.0.1 release is bad? Will it break anything?
https://reviews.llvm.org/D32767
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
