[libunwind] r295285 - [libunwind][CMake] Use libc++ headers when available

2017-02-15 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Feb 15 23:18:08 2017 New Revision: 295285 URL: http://llvm.org/viewvc/llvm-project?rev=295285&view=rev Log: [libunwind][CMake] Use libc++ headers when available libunwind depends on C++ library headers. When building libunwind as part of LLVM and libc++ is available, use

r295480 - [CMake] Add Fuchsia toolchain CMake cache files

2017-02-17 Thread Petr Hosek via cfe-commits
Author: phosek Date: Fri Feb 17 13:28:54 2017 New Revision: 295480 URL: http://llvm.org/viewvc/llvm-project?rev=295480&view=rev Log: [CMake] Add Fuchsia toolchain CMake cache files These cache files can be used to build Fuchsia toolchain. They also demonstrate the use of multi-target builtins bui

[libcxxabi] r295540 - [CMake][libcxxabi] Update the libc++ test module path

2017-02-17 Thread Petr Hosek via cfe-commits
Author: phosek Date: Fri Feb 17 22:37:59 2017 New Revision: 295540 URL: http://llvm.org/viewvc/llvm-project?rev=295540&view=rev Log: [CMake][libcxxabi] Update the libc++ test module path The libcxx/test/libcxx Python package has been moved into libcxx/utils/libcxx in r294651, but libcxxabi's CMak

r296082 - [Driver] Enable SafeStack for Fuchsia targets

2017-02-23 Thread Petr Hosek via cfe-commits
Author: phosek Date: Thu Feb 23 21:17:41 2017 New Revision: 296082 URL: http://llvm.org/viewvc/llvm-project?rev=296082&view=rev Log: [Driver] Enable SafeStack for Fuchsia targets The runtime support is provided directly by the Fuchsia system C library. Patch by Roland McGrath Differential Revis

[libcxx] r296573 - [libcxx] Support threads on Fuchsia

2017-02-28 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Feb 28 21:09:18 2017 New Revision: 296573 URL: http://llvm.org/viewvc/llvm-project?rev=296573&view=rev Log: [libcxx] Support threads on Fuchsia Differential Revision: https://reviews.llvm.org/D30278 Modified: libcxx/trunk/src/thread.cpp Modified: libcxx/trunk/src/th

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a reviewer: beanz. phosek added subscribers: cfe-commits, ruiu. phosek set the repository for this revision to rL LLVM. Herald added subscribers: mehdi_amini, mgorny. lld has LTO support, if requested we should add a dependency on lld rather than LLVMgol

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

2016-11-14 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a reviewer: beanz. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. These cache files can be used to build Fuchsia Clang toolchain. They also demonstrate the use of multi-t

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek added a comment. It's sufficient, I just tested it. I'm not actually sure if `LLVM_ENABLE_LLD` here is correct, `LLVM_ENABLE_LLD` forces the use of lld, but lld might not be available during first stage. We need `LLVM_ENABLE_LLD` to be set, but only for the second stage (which is somethi

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek added a comment. In https://reviews.llvm.org/D26649#595356, @mehdi_amini wrote: > In https://reviews.llvm.org/D26649#595296, @phosek wrote: > > > It's sufficient, I just tested it. > > > How did you check it? I don't understand how LLVM_ENABLE_LLD is propagated to > stage-2? Sufficient

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek added a comment. In https://reviews.llvm.org/D26649#595367, @mehdi_amini wrote: > OK, but still, LLVM_ENABLE_LLD needs to be passed to stage-2, so it needs to > be actually BOOTSTRAP_LLVM_ENABLE_LLD. > I looked at all the CMake `_PASSTHROUGH` and didn't find it mentioned > anywhere. We

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 77938. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D26649 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek added a comment. AFAIK lld on Darwin doesn't support LTO (last I heard it cannot even self-host at the moment) so I'm not sure if it makes sense to enable it `if(APPLE)`. Repository: rL LLVM https://reviews.llvm.org/D26649 ___ cfe-commits

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-14 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 77950. Repository: rL LLVM https://reviews.llvm.org/D26649 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -511,10 +511,10 @@ set(STAMP_DIR ${CMA

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-15 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 78045. phosek added a comment. Added error message for Darwin, does this look good to you? Repository: rL LLVM https://reviews.llvm.org/D26649 Files: CMakeLists.txt Index: CMakeLists.txt

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-15 Thread Petr Hosek via cfe-commits
phosek added a comment. In https://reviews.llvm.org/D26649#596209, @mehdi_amini wrote: > @beanz : don't you think that it should be handled at the top level and not > in the bootstrap logic? > Right now we don't error when invoking cmake with `-DLLVM_ENABLE_LLD=ON` > and `-DLLVM_ENABLE_LTO=ON

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-15 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 78096. phosek added a comment. I've removed the error message and moved it to https://reviews.llvm.org/D26715. Repository: rL LLVM https://reviews.llvm.org/D26649 Files: CMakeLists.txt Index: CMakeLists.txt

r287179 - [CMake] Support lld with LTO bootstrap

2016-11-16 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Nov 16 17:59:06 2016 New Revision: 287179 URL: http://llvm.org/viewvc/llvm-project?rev=287179&view=rev Log: [CMake] Support lld with LTO bootstrap lld has LTO support, if requested we should add a dependency on lld rather than LLVMgold when doing LTO bootstrap build. Dif

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

2016-11-16 Thread Petr Hosek via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287179: [CMake] Support lld with LTO bootstrap (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D26649?vs=78096&id=78283#toc Repository: rL LLVM https://reviews.llvm.org/D2664

[libcxx] r289418 - [libcxx][CMake] Move the warning to HandleOutOfTreeLLVM

2016-12-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Sun Dec 11 23:05:46 2016 New Revision: 289418 URL: http://llvm.org/viewvc/llvm-project?rev=289418&view=rev Log: [libcxx][CMake] Move the warning to HandleOutOfTreeLLVM This currently gives a warning when building libcxx under runtimes. Differential Revision: https://reviews.

r289668 - [Driver] Allow setting the default linker during build

2016-12-14 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Dec 14 10:46:50 2016 New Revision: 289668 URL: http://llvm.org/viewvc/llvm-project?rev=289668&view=rev Log: [Driver] Allow setting the default linker during build This change allows setting the default linker used by the Clang driver when configuring the build. Different

r300917 - [CMake] Enable ARM target in Fuchsia toolchain

2017-04-20 Thread Petr Hosek via cfe-commits
Author: phosek Date: Thu Apr 20 18:06:53 2017 New Revision: 300917 URL: http://llvm.org/viewvc/llvm-project?rev=300917&view=rev Log: [CMake] Enable ARM target in Fuchsia toolchain This is still used by some users of Fuchsia toolchain. Also include llc and opt which is useful for development and t

[clang-tools-extra] r302688 - [clang-tidy][CMake] Make clang-tidy usable as distribution component

2017-05-10 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed May 10 11:20:54 2017 New Revision: 302688 URL: http://llvm.org/viewvc/llvm-project?rev=302688&view=rev Log: [clang-tidy][CMake] Make clang-tidy usable as distribution component Use add_clang_tool rather than add_clang_executable to support clang-tidy as a distribution com

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a reviewer: davide. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the linker becase on Windows, the filen

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
phosek added a comment. In https://reviews.llvm.org/D25700#572158, @bruno wrote: > Can you add a testcase for that? This is already covered by an existing testcase which was failing on Windows (davide pointed that out to me). Repository: rL LLVM https://reviews.llvm.org/D25700

r284430 - [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Oct 17 17:02:53 2016 New Revision: 284430 URL: http://llvm.org/viewvc/llvm-project?rev=284430&view=rev Log: [Driver] Use stem rather than filename for executable name When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the li

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284430: [Driver] Use stem rather than filename for executable name (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25700?vs=74905&id=74917#toc Repository: rL LLVM https://re

[PATCH] D25838: [Fuchsia] Support for additional architectures

2016-10-20 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a reviewer: rsmith. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. Herald added a subscriber: aemerson. Fuchsia also experimentally supports ARM32 architecture, add it to the list of supported targets. R

[PATCH] D25838: [Fuchsia] Support for 32-bit architectures

2016-10-21 Thread Petr Hosek via cfe-commits
phosek retitled this revision from "[Fuchsia] Support for additional architectures" to "[Fuchsia] Support for 32-bit architectures". phosek updated the summary for this revision. phosek updated this revision to Diff 75496. Repository: rL LLVM https://reviews.llvm.org/D25838 Files: lib/Basic

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-21 Thread Petr Hosek via cfe-commits
phosek added a comment. @EricWF is this fine with you? Repository: rL LLVM https://reviews.llvm.org/D25491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-22 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 75540. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-23 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 75553. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -325,6 +325,11 @@ # Required flags ===

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-23 Thread Petr Hosek via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284950: [libcxx] Use C++14 when building libc++ with musl (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25491?vs=75553&id=75554#toc Repository: rL LLVM https://reviews.llv

[libunwind] r284951 - [libunwind] Add support for Fuchsia

2016-10-23 Thread Petr Hosek via cfe-commits
Author: phosek Date: Sun Oct 23 16:48:47 2016 New Revision: 284951 URL: http://llvm.org/viewvc/llvm-project?rev=284951&view=rev Log: [libunwind] Add support for Fuchsia Fuchsia is a new operating system which uses libunwind as unwinder. Differential Revision: https://reviews.llvm.org/D25899 Mod

[libcxx] r284950 - [libcxx] Use C++14 when building libc++ with musl

2016-10-23 Thread Petr Hosek via cfe-commits
Author: phosek Date: Sun Oct 23 16:48:27 2016 New Revision: 284950 URL: http://llvm.org/viewvc/llvm-project?rev=284950&view=rev Log: [libcxx] Use C++14 when building libc++ with musl musl's pthread implementations use volatile types in their structs which is not being constexpr in C++11 but is in

r285038 - [Basic] Support 32-bit x86 and ARM targets for Fuchsia

2016-10-24 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Oct 24 17:55:57 2016 New Revision: 285038 URL: http://llvm.org/viewvc/llvm-project?rev=285038&view=rev Log: [Basic] Support 32-bit x86 and ARM targets for Fuchsia Fuchsia has experimental support for 32-bit x86 and ARM targets, add them to the list of supported targets.

[PATCH] D25838: [Basic] Support 32-bit x86 and ARM targets for Fuchsia

2016-10-24 Thread Petr Hosek via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285038: [Basic] Support 32-bit x86 and ARM targets for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25838?vs=75496&id=75656#toc Repository: rL LLVM https://review

[PATCH] D25263: [Driver] Allow setting the default linker during build

2016-11-02 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 76720. phosek marked 3 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D25263 Files: CMakeLists.txt include/clang/Config/config.h.cmake include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib

[libunwind] r286308 - [CMake] Get libunwind building under LLVM/runtimes

2016-11-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Nov 8 17:02:49 2016 New Revision: 286308 URL: http://llvm.org/viewvc/llvm-project?rev=286308&view=rev Log: [CMake] Get libunwind building under LLVM/runtimes The new LLVM runtimes directory requires the same conventions to be followed across the runtime projects. These c

[libcxxabi] r286332 - [CMake] Check runtimes subdir when looking for libcxx and libuwind

2016-11-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Nov 8 21:22:19 2016 New Revision: 286332 URL: http://llvm.org/viewvc/llvm-project?rev=286332&view=rev Log: [CMake] Check runtimes subdir when looking for libcxx and libuwind The runtimes subdir is the new location for runtimes, we should include it when looking for libcx

[libcxx] r286333 - [CMake] Check runtimes subdir when looking for libcxxabi

2016-11-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Nov 8 21:22:28 2016 New Revision: 286333 URL: http://llvm.org/viewvc/llvm-project?rev=286333&view=rev Log: [CMake] Check runtimes subdir when looking for libcxxabi The runtimes subdir is the new location for runtimes, we should include it when looking for libcxxabi heade

[libcxxabi] r286334 - Revert "[CMake] Check runtimes subdir when looking for libcxx and libuwind"

2016-11-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Nov 8 21:38:21 2016 New Revision: 286334 URL: http://llvm.org/viewvc/llvm-project?rev=286334&view=rev Log: Revert "[CMake] Check runtimes subdir when looking for libcxx and libuwind" This reverts commit eecb79506d88b268fb0d00cce178213b4aa17933. Modified: libcxxabi/t

[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-10 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. This is a GCC extension, Clang should accept the attribute without a warning for compatibility with GCC. https://llvm.org/bugs/show_bug.cgi?id=30980 Repository: rL LL

[libcxxabi] r286614 - [CMake] Check runtimes subdir when looking for libcxx and libuwind

2016-11-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Fri Nov 11 13:12:58 2016 New Revision: 286614 URL: http://llvm.org/viewvc/llvm-project?rev=286614&view=rev Log: [CMake] Check runtimes subdir when looking for libcxx and libuwind The runtimes subdir is the new location for runtimes, we should include it when looking for libcx

[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-11 Thread Petr Hosek via cfe-commits
phosek added a comment. That makes sense for diagnostics, but this attribute is only an optimization hint, so compiler should be allowed to ignore it. I can take a look how difficult it'd be to actually implement this attribute, but I don't think it's Sema-only attribute. I don't know if there'

[PATCH] D23228: Do not depend on unwind when building standalone

2016-08-06 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a subscriber: cfe-commits. When libcxxabi is being built standalone, unwind dependency is not available, so do not use it even when LLVM unwinder is being requested. https://reviews.llvm.org/D23228 Files: test/CMakeLists.txt Index: test/CMakeLists.t

[libcxxabi] r278058 - Do not depend on unwind when building standalone

2016-08-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Aug 8 17:09:54 2016 New Revision: 278058 URL: http://llvm.org/viewvc/llvm-project?rev=278058&view=rev Log: Do not depend on unwind when building standalone When libcxxabi is being built standalone, unwind dependency is not available, so do not use it even when LLVM unwin

[libunwind] r278067 - Allow building both shared and static library

2016-08-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Aug 8 17:55:48 2016 New Revision: 278067 URL: http://llvm.org/viewvc/llvm-project?rev=278067&view=rev Log: Allow building both shared and static library This change allows building both shared and static version of libunwind in a single build, sharing object files betwee

[libcxx] r278068 - Allow building both shared and static library

2016-08-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Aug 8 17:57:25 2016 New Revision: 278068 URL: http://llvm.org/viewvc/llvm-project?rev=278068&view=rev Log: Allow building both shared and static library This change allows building both shared and static version of libc++ in a single build, sharing object files between b

[libcxxabi] r278076 - Add lib directory to linker paths when using libunwind

2016-08-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Aug 8 19:27:19 2016 New Revision: 278076 URL: http://llvm.org/viewvc/llvm-project?rev=278076&view=rev Log: Add lib directory to linker paths when using libunwind When using libunwind and not building as standalone project, we need to add LLVM library directory to the lis

[libcxxabi] r278169 - Depend directly on unwind when not building standalone

2016-08-09 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Aug 9 16:28:52 2016 New Revision: 278169 URL: http://llvm.org/viewvc/llvm-project?rev=278169&view=rev Log: Depend directly on unwind when not building standalone When using libunwind and not building as standalone project, we can directly depend on the unwind library tar

Re: [PATCH] D12860: [X86] Add -malign-double support

2016-04-29 Thread Petr Hosek via cfe-commits
phosek abandoned this revision. phosek added a comment. Superseded by http://reviews.llvm.org/D19734 http://reviews.llvm.org/D12860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Disable generation of asynchronous unwind tables for RISCV baremetal (PR #81727)

2024-02-19 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/81727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Allow unaligned access on ARMv7 and higher by default (PR #82400)

2024-02-20 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/82400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver,BareMetal] Replace -lclang_rt.builtins{,-$arch}.a with an absolute path (PR #82424)

2024-02-20 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/82424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-07-01 Thread Petr Hosek via cfe-commits
petrhosek wrote: I'd use `std::string_view` as a return value instead of `const char *` as a more idiomatic C++ in which case you don't need to rename the method to `c_str()`. https://github.com/llvm/llvm-project/pull/96921 ___ cfe-commits mailing li

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-07-01 Thread Petr Hosek via cfe-commits
petrhosek wrote: > > I'd use `std::string_view` as a return value instead of `const char *` as a > > more idiomatic C++ in which case you don't need to rename the method to > > `c_str()`. > > I opted for `StringRef`, since that seems more in line w/ the conventions > here, but I'm happy to sw

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-07-01 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/96921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Support using toolchain libc and libc++ for baremetal (PR #96736)

2024-07-01 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/96736 >From db5ae584cc00717d667d423a99d71a8d3ac46805 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Mon, 10 Jun 2024 20:27:52 + Subject: [PATCH 1/3] [Driver] Support using toolchain libc and libc++ for baremeta

[clang] [Driver] Support using toolchain libc and libc++ for baremetal (PR #96736)

2024-07-01 Thread Petr Hosek via cfe-commits
@@ -26,6 +26,20 @@ // RUN: --sysroot=%S/Inputs/baremetal_arm | FileCheck --check-prefix=CHECK-V6M-LIBINC %s // CHECK-V6M-LIBINC-NOT: "-internal-isystem" +// RUN: %clang %s -### --target=armv6m-none-eabi -o %t.out 2>&1 \ +// RUN: -ccc-install-dir %S/Inputs/basic_bareme

[clang] [Driver] Support using toolchain libc and libc++ for baremetal (PR #96736)

2024-07-01 Thread Petr Hosek via cfe-commits
petrhosek wrote: > The description can specify the target triple you are adding support for. > LGTM, but other folks more familiar with your planned changes need to stamp > as well. @nickdesaulniers is on paternity leave but he didn't raise any concerns, @PiJoules is familiar with the changes

[clang] [Driver] Support using toolchain libc and libc++ for baremetal (PR #96736)

2024-07-01 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/96736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-07-03 Thread Petr Hosek via cfe-commits
@@ -183,6 +183,24 @@ message(STATUS "LLVM default target triple: ${LLVM_DEFAULT_TARGET_TRIPLE}") set(LLVM_TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}") +if(CMAKE_C_COMPILER_ID MATCHES "Clang") + set(option_prefix "") + if (CMAKE_C_SIMULATE_ID MATCHES "MSVC") +set(opti

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-07-03 Thread Petr Hosek via cfe-commits
@@ -368,14 +368,22 @@ macro(construct_compiler_rt_default_triple) "Default triple for which compiler-rt runtimes will be built.") endif() - if ("${CMAKE_C_COMPILER_ID}" MATCHES "Clang") + if(CMAKE_C_COMPILER_ID MATCHES "Clang") set(option_prefix "") if

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-07-03 Thread Petr Hosek via cfe-commits
petrhosek wrote: @wzssyqa Is it OK with you if I go ahead and merge this PR? I plan to follow up with further improvements but this is necessary to fix the build of LLVM runtime libraries in the bootstrapping build. https://github.com/llvm/llvm-project/pull/89425 __

[clang-tools-extra] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread Petr Hosek via cfe-commits
petrhosek wrote: We already have set of CMake variables that we use to refer to `bin` or `lib` directory which account for various configurations: https://github.com/llvm/llvm-project/blob/c02e8f762a410e55581866c43636efcd6504c1bd/llvm/CMakeLists.txt#L446-L467 I think we should introduce anothe

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-07-05 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/89425 >From eb2459876526b78c97b04801dd07bd53540b2892 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Tue, 15 Feb 2022 22:59:58 -0800 Subject: [PATCH 1/3] [CMake] Use Clang to infer the target triple When using Clang

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-07-05 Thread Petr Hosek via cfe-commits
petrhosek wrote: > > @wzssyqa Is it OK with you if I go ahead and merge this PR? I plan to > > follow up with further improvements but this is necessary to fix the build > > of LLVM runtime libraries in the bootstrapping build. > > Is there a filed issue linked to this? I filed #97876 and lef

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-07-05 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/89425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Fuchsia] -fvisibility=hidden for baremetal runtimes (PR #98049)

2024-07-08 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/98049 This is a temporary workaround for #97655. >From ba8285b822b190f06ef584e317b4407ce618d8c0 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Mon, 8 Jul 2024 09:54:39 -0700 Subject: [PATCH] [CMake][Fuchsia] -fvisi

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

2024-09-04 Thread Petr Hosek via cfe-commits
petrhosek wrote: This is just a nit, but is there a reason for calling this `FatalError` rather than just `Error`? To me "fatal" usually means something went seriously wrong, but in this case it's just the fact the combination of flags is not supported and in the driver we usually just refer t

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

2024-09-04 Thread Petr Hosek via cfe-commits
petrhosek wrote: I think `Error` and `Warning` would be more consistent actually, especially if `-Werror` also applied to `Warning`; ideally we would also have a custom warning type so you could do e.g. `-Wno-multilib-warning` to suppress these warnings. https://github.com/llvm/llvm-project/p

[clang] NFC: Make clang resource headers an interface library (PR #88317)

2024-04-11 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/88317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Fuchsia] Enable libc++ in the baremetal build (PR #95017)

2024-06-10 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/95017 For now, we include headers and don't use libc++abi. >From f638a3a959bc79f0349fbfd6c79b8f386fb31218 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Mon, 10 Jun 2024 11:10:44 -0700 Subject: [PATCH] [CMake][Fuch

[clang] [CMake][Fuchsia] Enable libc++ in the baremetal build (PR #95017)

2024-06-11 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/95017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-11 Thread Petr Hosek via cfe-commits
petrhosek wrote: Do we really need a full CSS when we're only checking the HTML? Could we just include a super minimal (or even empty) CSS? https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Fuchsia] Add armv7m and armv8m runtimes to Fuchsia Clang toolchain (PR #95337)

2024-06-12 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/95337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][cmake] Copy assets to build directory (PR #95187)

2024-06-12 Thread Petr Hosek via cfe-commits
@@ -25,3 +25,11 @@ install(FILES ../assets/clang-doc-default-stylesheet.css install(FILES ../assets/index.js DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) + +add_custom_target(copy-clang-doc-assets petrhosek wrote: We prefer having a ru

[clang] [Fuchsia] Define wint_t type as unsigned int (PR #95508)

2024-06-13 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/95508 This matches the type used by Fuchsia libc. >From 05fdc445f601f04560ca4106760257d7531b29e0 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Fri, 14 Jun 2024 06:08:16 + Subject: [PATCH] [Fuchsia] Define wint

[clang] [Fuchsia] Define wint_t type as unsigned int (PR #95508)

2024-06-13 Thread Petr Hosek via cfe-commits
petrhosek wrote: Looks like @frobtech already created #95499. https://github.com/llvm/llvm-project/pull/95508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Define wint_t type as unsigned int (PR #95508)

2024-06-13 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/95508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Fuchsia] Use unsigned int for wint_t on *-fuchsia targets (PR #95499)

2024-06-13 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/95499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][cmake] Copy assets to build directory (PR #95187)

2024-06-14 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/95187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][Fuchsia] Support multilib for C++ include dir (PR #95815)

2024-06-17 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/95815 We generate a separate `__config_site` for each multilib and thus need to add the additional include dir if it exists. >From cbd278fe0e49e5297f3d48d5e14f012a81fce570 Mon Sep 17 00:00:00 2001 From: Petr Hosek

[clang] [Driver][Fuchsia] Support multilib for C++ include dir (PR #95815)

2024-06-17 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/95815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Hidden visibility for prof version var (PR #93496)

2024-05-28 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/93496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Correctly apply libdir subdir for multilib (PR #93354)

2024-05-31 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/93354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/89425 When using Clang as a compiler, use Clang to normalize the triple that's used to construct path for runtime library build and install paths. This ensures that paths are consistent and avoids the issue where th

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread Petr Hosek via cfe-commits
petrhosek wrote: This is a re-upload of https://reviews.llvm.org/D140925, I plan to land this change if there are no objections. https://github.com/llvm/llvm-project/pull/89425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [llvm] [cmake] Remove custom linker flag check function (PR #86602)

2024-04-21 Thread Petr Hosek via cfe-commits
petrhosek wrote: I'd actually prefer this not be merged as is. I have already made a similar change locally but during testing I discovered a major issue with `check_linker_flag`: unlike other CMake `check_*` functions, and even `llvm_check_linker_flag`, `check_linker_flag` doesn't apply `CMA

[clang] [CMake][Fuchsia] Include libunwind and libc++abi in baremetal build (PR #100908)

2024-07-27 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/100908 These are needed for baremetal targets as well. >From 5177b4ac9ce9d1b45e80e0613e1cb3363e73bd39 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Sat, 27 Jul 2024 17:10:01 -0700 Subject: [PATCH] [CMake][Fuchsia]

[clang-tools-extra] [clang-doc] add support for block commands in clang-doc html output (PR #101108)

2024-07-30 Thread Petr Hosek via cfe-commits
@@ -418,9 +419,13 @@ genRecordMembersBlock(const llvm::SmallVector &Members, if (Access != "") Access = Access + " "; auto LIBody = std::make_unique(HTMLTag::TAG_LI); -LIBody->Children.emplace_back(std::make_unique(Access)); -LIBody->Children.emplace_back

[clang-tools-extra] [clang-doc] add support for block commands in clang-doc html output (PR #101108)

2024-07-30 Thread Petr Hosek via cfe-commits
@@ -197,7 +197,9 @@ TEST(HTMLGeneratorTest, emitRecordHTML) { Members - private int X + +private int X petrhosek wrote: Either way this should be done in a separate change. https://github.com/llvm/llvm-project/pull/101108

[clang] [Driver] Include crt0.o in the baremetal link (PR #101258)

2024-07-30 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/101258 The common baremetal libc implementations already provide crt0.o and GCC automatically links it so this improves parity. >From 245a552033793bab479c9be805aacf33cfe64493 Mon Sep 17 00:00:00 2001 From: Petr Hose

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-07-30 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/101259 The handling of libc++ and other runtime libraries in the baremetal driver is different from other targets for no particular reason. This change removes the custom in the baremetal driver logic and replaces i

[clang] [CMake][Fuchsia] Include libunwind and libc++abi in baremetal build (PR #100908)

2024-07-31 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/100908 >From 5177b4ac9ce9d1b45e80e0613e1cb3363e73bd39 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Sat, 27 Jul 2024 17:10:01 -0700 Subject: [PATCH] [CMake][Fuchsia] Include libunwind and libc++abi in baremetal bu

[clang] [CMake][Fuchsia] Include libunwind and libc++abi in baremetal build (PR #100908)

2024-07-31 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/100908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Fuchsia] Use standard spelling for Arm baremetal targets (PR #101302)

2024-07-31 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/101302 It's more common to use `none` rather than `unknown` for the OS component in Arm baremetal targets. >From ac8f9a208ffaae64d31c699e2bc026f1cfae9dc8 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Wed, 31 Jul

[clang] Revert "[CMake][Fuchsia] Include libunwind and libc++abi in baremetal build" (PR #101340)

2024-07-31 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/101340 Reverts llvm/llvm-project#100908 >From 33647147cc824557560cbb31e2e09cc99ea6e940 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Wed, 31 Jul 2024 07:26:19 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20"[CMake][Fuc

[clang] Revert "[CMake][Fuchsia] Include libunwind and libc++abi in baremetal build" (PR #101340)

2024-07-31 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/101340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Fuchsia] Build libc++ on top libc for baremetal (PR #99009)

2024-07-16 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/99009 This is mostly a proof of concept requiring a number of workarounds, but demonstrates that it is feasible. >From add4a1681a9cfcfb20443c5652e3166ec739c31b Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Tue, 1

<    2   3   4   5   6   7   8   9   10   >