petrhosek wrote: > > I'd use `std::string_view` as a return value instead of `const char *` as a > > more idiomatic C++ in which case you don't need to rename the method to > > `c_str()`. > > I opted for `StringRef`, since that seems more in line w/ the conventions > here, but I'm happy to switch to `std::string_view` if you'd prefer.
AFAIK the long-term plan is to replace `StringRef` with `std::string_view` but I'm fine using `StringRef` for consistency with the rest of the codebase. https://github.com/llvm/llvm-project/pull/96921 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
