[PATCH] D110463: [CMake] Pass through CMAKE_READELF to subbuilds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd893692024b8: [CMake] Pass through CMAKE_READELF to subbuilds (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. In D110128#3021876 , @thakis wrote: > Note that stage 2 fails, where we're supposed to use lld. So I think this is > probably some compiler-rt test config problem you need to sort out, and not a > fundamental problem with the pat

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#3022332 , @sylvestre.ledru wrote: > @phosek > It was probably my fault (mix of different in-tree / out of tree builds) > Quick question, why the path to `__config_site` contains this triple > `x86_64-pc-linux-gnu` > (in `

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. The reason I removed this behavior in D101194 , aside from extra overhead introduced by the extra checks, is that we've seen cases where people would have both paths on their system which lead to difficult to diagnose issues where Clang

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. A potential solution would be to reintroduce the portion D101194 which would let each driver control the triple spelling (by overriding `getMultiarchTriple`. On Linux, including Debian, that logic is already implemented in https://gith

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3029124 , @MaskRay wrote: > In D110663#3029088 , @phosek wrote: > >> The reason I removed this behavior in D101194 >> , aside from extra overhe

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3029147 , @MaskRay wrote: > In D110663#3029146 , @phosek wrote: > >> In D110663#3029124 , @MaskRay >> wrote: >> >>> In D110663#3029088

[PATCH] D110687: [Driver] Check that short triples are supported for Fuchsia

phosek created this revision. phosek added reviewers: leonardchan, haowei, gulfem. Herald added subscribers: pengfei, s.egerton, simoncook, kristof.beyls. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. {x86_64,aarch64}-unknown-fuchs

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. This is going to break Fuchsia as implemented. We assume that `{x86_64,aarch64}-unknown-fuchsia` and `{x86_64,aarch64}-fuchsia` behave identically and developers are allowed to use whichever spelling they prefer. With this change that's no longer true. This may break oth

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

phosek added a comment. I'm still unsure if this is the right strategy because it creates a dependency cycle. Specifically, you have the LLVM build trigger the build of runtimes, and that build would invoke LLVM build again to ensure that the necessary tools have been built. That shouldn't be n

[PATCH] D110687: [Driver] Check that short triples are supported for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7ae43438a04: [Driver] Check that short triples are supported for Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks for debugging this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625

[PATCH] D110778: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110778/new/ https://reviews.llvm.org/D110778 ___

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

phosek added a comment. Is this needed even with D110888 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110889/new/ https://reviews.llvm.org/D110889 ___ cfe-commits mai

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3041379 , @MaskRay wrote: > In D110663#3029577 , @phosek wrote: > >> This is going to break Fuchsia as implemented. We assume that >> `{x86_64,aarch64}-unknown-fuchsia` and `{x8

[PATCH] D96360: [CMake] Delete LLVM_RUNTIME_BUILD_ID_LINK_TARGETS

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96360/new/ https://reviews.llvm.org/D96360 ___ c

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 322609. phosek retitled this revision from "[CoverageMapping] Don't absolutize source paths" to "Store compilation dir separately in coverage mapping". phosek edited the summary of this revision. Herald added subscribers: llvm-commits, dexonsmith, dang, sstefan

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek added a comment. In D95753#2534895 , @vsk wrote: > Thanks for pointing DW_AT_comp_dir out. For coverage, gating the use of > relative paths on a flag sounds reasonable to me. It should also be possible > to extend the .covmapping format to include

[PATCH] D95772: [DebugInfo] Normalize paths by removing unnecessary dots

phosek added a comment. In D95772#2534103 , @dblaikie wrote: > Does this address @rnk's feedback about symlinks? ( > https://reviews.llvm.org/D87657#2296028 ) It doesn't, I think if we want to handle that case, we'd need to use `sys::fs::real_path` rath

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 323106. phosek marked 2 inline comments as done. phosek added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. I have addressed all the comments and fixed all tests. I'm happy to slice this into multiple patches if you pref

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 323231. phosek added a comment. Documentation updated and test included. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D96838: CodeGen: Set !retain metadata on UsedAttr definitions for Linux/FreeBSD

phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2071 + const llvm::Triple &T = getTarget().getTriple(); + if (T.isOSFreeBSD() || T.isOSLinux()) +GO->setMetadata(llvm::LLVMContext::MD_retain, Would it be possible to also include

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324224. phosek marked an inline comment as done. phosek retitled this revision from "Store compilation dir separately in coverage mapping" to "[Coverage] Store compilation dir separately in coverage mapping". Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>, Mas

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324423. phosek marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:100-101 Dyld += "tsan/"; +if (SanArgs.needsHwasanRt() && SanArgs.needsSharedRt()) + Dyld += "hwasan/"; Dyld += "ld.so.1"; Nit: can you move this above TSan so i

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324733. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/cla

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97ec8fa5bb07: [Coverage] Store compilation dir separately in coverage mapping (authored by phosek). Changed prior to commit: https://reviews.llvm.

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeGen/Cov

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324759. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeGen/Cov

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbd1a333aa1: [Coverage] Store compilation dir separately in coverage mapping (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D97001: [Coverage] Normalize compilation dir as well

phosek created this revision. phosek added a reviewer: vsk. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches debug info behavior. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97001 Files: clang/li

[PATCH] D97001: [Coverage] Normalize compilation dir as well

phosek updated this revision to Diff 325099. phosek added a comment. Test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001 Files: clang/lib/CodeGen/CoverageMappingGen.cpp clang/test/Profile/profil

[PATCH] D97001: [Coverage] Normalize compilation dir as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3275b18f8979: [Coverage] Normalize compilation dir as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

phosek accepted this revision. phosek added a comment. LGTM I'd also suggest renaming `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and `LIBCXX_HERMETIC_STATIC_LIBRARY` to `LIBCXXABI_HIDE_SYMBOLS` and `LIBCXX_HIDE_SYMBOLS` respectively in a follow up change to maintain consistency. Repository: rG LL

[PATCH] D96838: Add GNU attribute 'retain'

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/attr-retain.c:11 +/// Set !retain only on ELF platforms. +// NORETAIN-NOT: !retain + There are no `FileCheck --check-pref

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek added a comment. In D95753#2578724 , @gregmiller wrote: > Hello, we are seeing failures like below: > > Note: Google Test filter = > ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 > [==] Running 1 test from 1 t

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

phosek created this revision. phosek added reviewers: MaskRay, rnk. Herald added subscribers: jansvoboda11, dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We introduce -ffile-compilation-dir shorthand to avoid having to set -f

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek created this revision. phosek added reviewers: vsk, davidxl, keith. Herald added subscribers: jansvoboda11, dexonsmith, dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These flags affect coverage mapping (-fcoverage-mapp

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek added a comment. I realized recently that `-fcoverage-{prefix-map,compilation-dir}` is a more accurate name but I'd be interested in your opinion, I don't feel too strongly about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97434/new

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

phosek updated this revision to Diff 326269. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97433/new/ https://reviews.llvm.org/D97433 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChain

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rG9625d61eb66c: [Driver] Support libc++ in MSVC (authored by phosek). Herald added a subscriber: dang. Changed prior to commit: https://reviews.llvm.org/D101479?vs=347213&id=350507#toc Repository: rG L

[PATCH] D103875: [Fuchsia] Update some of the Fuchsia toolchain flags

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should make the build more self-contained. Repository: rG LLVM Git

[PATCH] D103875: [Fuchsia] Update some of the Fuchsia toolchain flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dba2a026956: [Fuchsia] Update some of the Fuchsia toolchain flags (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103875/new/ https://r

[PATCH] D103916: [CMake] Only include LTO on Apple targets

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added subscribers: inglorion, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We only need libLTO when using ld64. Repository: rG LLVM Gith

[PATCH] D103916: [CMake] Only include LTO on Apple targets

phosek updated this revision to Diff 350662. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103916/new/ https://reviews.llvm.org/D103916 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/F

[PATCH] D103916: [CMake] Only include LTO on Apple targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde98da2eced7: [CMake] Only include LTO on Apple targets (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103918: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to use llvm-otool in our build. Repository: rG LLVM Github Mono

[PATCH] D103918: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf673365e1ce1: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disabling PIC globally also disabled PIC for runtimes which was undesirable

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

phosek added a comment. In D103919#2806198 , @leonardchan wrote: > Should `_LLVM_ENABLE_PIC ON` also be added for the multilibs? It should be propagated automatically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a5afb466553: [CMake][Fuchsia] Use PIC for Fuchsia runtimes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103926: [CMake][Fuchsia] Disable vcruntime for first stage as well

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using vcruntime is breaking libc++ headers so don't use it. Repository:

[PATCH] D103926: [CMake][Fuchsia] Disable vcruntime for first stage as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1683dbf0ddb2: [CMake][Fuchsia] Disable vcruntime for first stage as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103941: [CMake] Don't use libc++ by default on Windows yet

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ has issues when used with -fno-exceptions and vcruntime, don't use i

[PATCH] D103941: [CMake] Don't use libc++ by default on Windows yet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb413e44200e7: [CMake] Don't use libc++ by default on Windows yet (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D101139: Create install targets for scan-build-py.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2813724 , @mstorsjo wrote: > Couldn’t this commit have been kept in, and just reverting the one for using > it in the fuchsia cmake cache? (I’m not using this particular commit myself, > just observing.) The problem i

[PATCH] D104138: Create install targets for scan-build-py.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104138/new/ https://reviews.llvm.org/D104138 ___

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:18 namespace ifstool { void Merger::ConstructJob(Compilation &C, const JobAction &JA,

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

phosek accepted this revision. phosek added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/InterfaceStub/ELFObjHandler.h:25 namespace elfabi { Shouldn't this be in namespace `ifs`? Comment a

[PATCH] D104475: [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

phosek accepted this revision. phosek added a comment. LGTM I'm happy to see that the `noprofile` LLVM attribute is useful in other contexts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104475/new/ https://reviews.llvm.org/D104475 _

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

phosek accepted this revision. phosek added a comment. LGTM Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:70 + } + llvm_unreachable("unknown bitwidth"); +} This shouldn't be needed. Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:82 + } +

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

phosek added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 -void Thread::InitStackAndTls() { +void Thread::InitStackAndTls(const InitState *state) { uptr tls_size; If it's unused then you can omit the argument name to avoid the unu

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:234 + set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "") + set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unkno

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

phosek created this revision. phosek added reviewers: mibintc, andrew.w.kaylor, rjmccall, zahiraam, hans, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D74436

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

phosek updated this revision to Diff 365635. phosek retitled this revision from "[InstrProfiling] Generate runtime hook for ELF platforms" to "[InstrProfiling] Generate runtime hook for Fuchsia". phosek edited the summary of this revision. phosek added a comment. I have reworked the change and re

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG389dc94d4be7: [InstrProfiling] Generate runtime hook for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D98061?vs

[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107893/new/ https://reviews.llvm.org/D107893 ___

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. In D96033#298 , @leonardchan wrote: > We're still hitting the OOMs when building clang-repl with LTO even with > `-DLLVM_PARALLEL_LINK_JOBS=32`. While we don't build this target explicitly > in our toolchain, it is built when

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

phosek added a comment. Rather than hardcoding this only for `clang-repl`, I'd prefer to use a more generic approach. We already have `LLVM_DISTRIBUTION_COMPONENTS` so one possibility would be to set a lit feature for every component. For example, if `LLVM_DISTRIBUTION_COMPONENTS=foo;bar` we w

[PATCH] D107887: scan-build-py: Force the opening in utf-8

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/tools/scan-build-py/lib/libscanbuild/report.py:420 -with open(filename) as handler: +with open(filename, encoding="utf-8") as handler: for line in handler.readlines(): -

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105145/new/ https://reviews.llvm.org/D105145 ___

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

phosek added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or similar shipping vehicules. If you +are a user merely tr

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105765/new/ https://reviews.llvm.org/D105765 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rGd788c44f5cdd: [Support] Improve Caching conformance with Support library behavior (authored by noajshu, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:64-65 CmdArgs.push_back("--pack-dyn-relocs=relr"); +CmdArgs.push_back("-z"); +CmdArgs.push_back("rel");

[PATCH] D113729: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows

phosek created this revision. phosek added a reviewer: haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't build libcxxabi and libunwind for Windows so don't set the correspond

[PATCH] D113729: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8df26e7b4aea: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows (authored by phosek). Repository: rG LLVM Github Monorepo C

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

phosek added a comment. This change seems to have broken two libc++ tests: libc++ :: std/utilities/any/any.nonmembers/any.cast/const_correctness.fail.cpp Script: -- : 'COMPILED WITH'; /b/s/w/ir/x/w/staging/llvm_build/./bin/clang++ /b/s/w/ir/x/w/llvm-project/libcxx/test/std/utilities/

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek added a comment. In D97434#2588755 , @keith wrote: > I personally prefer this, and this is what I landed in swiftc a while back, > but I changed to -fprofile-prefix-map based on feedback from you 😛 > https://reviews.llvm.org/D83154?id=275480#21460

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e56a093eeca: [Driver] Create -ffile-compilation-dir alias (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97433/new/ https://reviews.ll

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8459b8ef39f4: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix… (authored by phosek). Changed prior to commit: https:

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a driver only flag so it has to be expanded when invoking cc1. Repository: rG LLVM Github Monorepo https://r

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

phosek updated this revision to Diff 326601. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97528/new/ https://reviews.llvm.org/D97528 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c Index: clang/test/Driver/clang_

[PATCH] D97528: [Driver] Don't pass -ffile-compilation-dir through to cc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6380c0966b: [Driver] Don't pass -ffile-compilation-dir through to cc1 (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek abandoned this revision. phosek added a comment. No longer needed with `-fcoverage-compilation-dir`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

phosek created this revision. phosek added a reviewer: smeenai. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Match the top-level project name (that is the name developers would use in LLVM_ENABLE

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to enable the use of Polly in Fuchs

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d1983f2d0a0: [CMake] Enable Polly for Fuchsia toolchain build (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:680 +for (StringRef Arg : CmdArgs) { + if (Arg == "-lm" || Arg == "-lc") { +// TODO: Add -lllvmlibc before -lpthread when LLVM libc has pthread This wouldn't handle the

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

phosek added a comment. Have you considered using an input linker script? We could generate `libc.so` that could look something like: INPUT(libllvmlibc.a /lib/libc.so) We would need to pass `--sysroot` to the linker for this to work. The driver could remain completely agnostic of whether you

[PATCH] D98018: [Fuchsia] Enable Polly for first stage as well

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want Polly enabled for both stages of the toolc

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek created this revision. phosek added reviewers: vsk, davidxl. Herald added a subscriber: hiraditya. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When using -fprofile-list to selectively apply instrumentatio

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:1082-1084 auto *User = Function::Create(FunctionType::get(Int32Ty, false), GlobalValue::LinkOnceODRLinkage, getIns

[PATCH] D98018: [Fuchsia] Enable Polly for first stage as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cd2f42521fe: [Fuchsia] Enable Polly for first stage as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

phosek added a comment. We see two test failures that appear to have been introduced by this change: TEST 'Clang :: Driver/compiler-rt-unwind.c' FAILED /b/s/w/ir/x/w/llvm-project/clang/test/Driver/compiler-rt-unwind.c:9:15: error: RTLIB-GCC: expe

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

phosek added a comment. In D98023#2609328 , @mstorsjo wrote: > In D98023#2609318 , @phosek wrote: > >> We see two test failures that appear to have been introduced by this change: > > Hmm - I'm pretty surprised abou

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

phosek added a comment. In D98023#2609368 , @phosek wrote: > In D98023#2609328 , @mstorsjo wrote: > >> In D98023#2609318 , @phosek wrote: >> >>> We see two test failures that

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

phosek added a comment. We use `CLANG_DEFAULT_RTLIB=compiler-rt` for our toolchain and it looks like after this change, two tests started failing: TEST 'Clang :: Driver/compiler-rt-unwind.c' FAILED /b/s/w/ir/x/w/llvm-project/clang/test/Driver/com

<    5   6   7   8   9   10   11   12   13   14   >