[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

phosek added inline comments. Comment at: llvm/utils/gn/secondary/llvm/utils/unittest/unittest.gni:34 +# out/gn/obj/clang/unittests/Format/FormatTests, which seems fine. +output_dir = target_out_dir +deps += [ What if someone explicitly sets `output_d

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56116/new/ https://reviews.llvm.org/D56116 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek added a comment. This is needed for `crtbegin.o`/`crtend.o`, I originally implemented it as part of D28791 but that change is already pretty big so this is an attempt to split independent parts that could land separately into smaller changes. Repositor

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek added a comment. I'd suggest moving this discussion to D28791 since your comments seem to be more related to the content of that change, not the content of this patch. I'm not trying to bypass the discussion in D28791 , I

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek added a comment. I'd be happy to abandon this change if we decide to not move forward with D28791 . I've made that change a parent revision of this change (although they don't necessarily have to land in that order) to make it obvious. Repository: rC

[PATCH] D56181: [CMake][Fuchsia] Include check-lld in the list of bootstrap targets

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett, leonardchan. Herald added subscribers: cfe-commits, mgorny. This allows running lld tests when doing 2-stage toolchain build. Repository: rC Clang https://reviews.llvm.org/D56181 Files: clang/cmake/

[PATCH] D56181: [CMake][Fuchsia] Include check-lld in the list of bootstrap targets

This revision was automatically updated to reflect the committed changes. Closed by commit rC350202: [CMake][Fuchsia] Include check-lld in the list of bootstrap targets (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56181?vs=179786&id=179817#toc Reposit

[PATCH] D56348: [CMake][Fuchsia] Enable --build-id linker flag by default

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This enables passing --build-id to linker by default. Repository: rC Clang https://reviews.llvm.org/D56348 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/cac

[PATCH] D56349: [CMake][Fuchsia] Enable x86 relaxation by default

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This enables x86 relaxation by default. Repository: rC Clang https://reviews.llvm.org/D56349 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-st

[PATCH] D56350: [CMake][Fuchsia] Enable experimental new pass manager by default

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This change enableds experimental new pass manager. Repository: rC Clang https://reviews.llvm.org/D56350 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/cache

[PATCH] D56348: [CMake][Fuchsia] Enable --build-id linker flag by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL350459: [CMake][Fuchsia] Enable --build-id linker flag by default (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56348?v

[PATCH] D56349: [CMake][Fuchsia] Enable x86 relaxation by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC350460: [CMake][Fuchsia] Enable x86 relaxation by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56349?vs=180356&id=180359#toc Repository: rC Clang C

[PATCH] D56350: [CMake][Fuchsia] Enable experimental new pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC350461: [CMake][Fuchsia] Enable experimental new pass manager by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56350?vs=180357&id=180360#toc Repository

[PATCH] D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. We want these to be used for the second stage compiler as well. Repository: rC Clang https://reviews.llvm.org/D56359 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/

[PATCH] D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage

This revision was automatically updated to reflect the committed changes. Closed by commit rL350486: [CMake][Fuchsia] Enable build ID, relaxations for first stage (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D563

[PATCH] D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL350491: [CMake] Use hidden visibility for static libc++ in Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55405?

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371484: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D66324?vs=219219&id=219472#to

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371584: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + paulkirth wrote: > chandlerc wrote: > > Sorry folks, but you can't do this. > > > > You can't depend on AD

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371635: Reland "clang-misexpect: Profile Guided Validation of Performance Annotations… (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D66324?vs=219728&id=219733#t

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

phosek added a comment. @dankm do you still plan to work on this? We would really like to see this landed and we could help if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67719/new/ https://reviews.llvm.org/D67719 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

phosek requested changes to this revision. phosek added a comment. This revision now requires changes to proceed. Actually, can you please add a test akin to https://github.com/llvm/llvm-project/blob/master/clang/test/Lexer/has_feature_memory_sanitizer.cpp? CHANGES SINCE LAST ACTION https://r

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67719/new/ https://reviews.llvm.org/D67719 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65841/new/ https://reviews.llvm.org/D65841 ___

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

phosek added a comment. @dankm is it OK if we take over this change to push it forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68009/new/ https://reviews.llvm.org/D68009 ___ cfe-co

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68423/new/ https://reviews.llvm.org/D68423 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek added a comment. ping? Repository: rCXX libc++ https://reviews.llvm.org/D45529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek updated this revision to Diff 142261. phosek marked an inline comment as done. phosek added a comment. I had something similar in https://reviews.llvm.org/D45304 but Eric suggested removing it. What I haven't realized is that this value is also used to set the SOVERSION so it's indeed nee

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek added a comment. In https://reviews.llvm.org/D45529#1066394, @EricWF wrote: > OK, so we need to bump the SO version -- However I don't want to generate a > __site_config header because of that if the __config header is sufficient. I > would like to see a solution that takes that into acc

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL329983: [CMake] Set the default ABI version for Fuchsia in CMake as well (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL329984: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D455

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek created this revision. phosek added reviewers: dexonsmith, compnerd. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. Darwin driver currently uses libc++ headers that are part of Clang toolchain when available (by default ../include/c++/v1 relative to executable), bu

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. This allows passing additional CMake flags to builtins and runtimes build through Fuchsia cache files. We now also set build type and enable assertions for bu

[PATCH] D46075: [CMake] Enable libc++ for Fuchsia toolchain on Darwin

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. This is necessary in order to get a working C++ compiler on Darwin since Clang expects libc++ headers to be part of the toolchain. Repository: rC Cla

[PATCH] D46075: [CMake] Enable libc++ for Fuchsia toolchain on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rC330855: [CMake] Enable libc++ for Fuchsia toolchain on Darwin (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D46075?vs=143970&id=143974#toc Repository: rC Clan

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In https://reviews.llvm.org/D45639#1068086, @compnerd wrote: > I'm not sure I understand this. The proper location for libc++ on the darwin > layout is in the SDK, not relative to the driver. The default behaviour is > similar to cross-compiling, and with a (derived) S

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In https://reviews.llvm.org/D45639#1078494, @thakis wrote: > > because the headers that are part of Clang toolchain are incompatible with > > the system library > > Do you have details on this? This isn't supposed to be the case as far as I > know. We link chrome/mac aga

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

phosek updated this revision to Diff 144824. phosek marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D45997 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake =

[PATCH] D46361: [CMake][Cache] Stop pretending that Fuchsia is UNIX

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This changes some aspects of the build that are not relevant or useful for Fuchsia like setting the RPATH/RUNPATH. Repository: rC Clang https://reviews.llvm.org/D46361 Files: cla

[PATCH] D46361: [CMake][Cache] Stop pretending that Fuchsia is UNIX

This revision was automatically updated to reflect the committed changes. Closed by commit rC331425: [CMake][Cache] Stop pretending that Fuchsia is UNIX (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D46361?vs=144902&id=144969#toc Repository: rC Clang

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

This revision was automatically updated to reflect the committed changes. Closed by commit rL331717: [CMake] Pass additional CMake flags in Fuchsia cache files (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45997?

[PATCH] D48563: [CMake] Use explicit targets for building Linux runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. Previously we were using default logic when building Linux runtimes in Fuchsia toolchain, but that leads to various issues due to how the CMake logic in compiler-rt for determining the p

[PATCH] D48564: [CMake] Support passing FUCHSIA_SDK as the only variable

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Now that the structure of Fuchsia SDK has been formalized, we no longer need to pass all the different CFLAGS/LDFLAGS to the CMake build separately, we can sim

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

phosek added inline comments. Comment at: CMakeLists.txt:191 +# are cross-compiling. +if(NOT CMAKE_SYSROOT AND NOT CMAKE_CROSSCOMPILING AND NOT LLVM_USE_SANITIZER MATCHES "Memory.*") set (LIBXML2_FOUND 0) This isn't going to cause a problem for us since we al

[PATCH] D48564: [CMake] Support passing FUCHSIA_SDK as the only variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL335708: [CMake] Support passing FUCHSIA_SDK as the only variable (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48564?vs

[PATCH] D48563: [CMake] Use explicit targets for building Linux runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rC335812: [CMake] Use explicit targets for building Linux runtimes (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D48563?vs=152759&id=153259#toc Repository: rC C

[PATCH] D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. First stage build is only a minimal build where we don't need a multiarch support. Repository: rC Clang https://reviews.llvm.org/D48707 Files: clang/cm

[PATCH] D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build

phosek updated this revision to Diff 153270. phosek edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D48707 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake ===

[PATCH] D48701: [CMake] Rename cxx_headers back to cxx-headers.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D48701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D48700: [CMake] Make bootstrap and compiler-rt depend on cxx-headers.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D48701: [CMake] Rename cxx_headers back to cxx-headers.

phosek added a comment. It's not obvious to me how anything could depend on `cxx-header`s target (not the component) since that target did not exist until r334468 which has landed only recently (just before r334477). The motivation behind this change was just consistency since all other targets

[PATCH] D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This is currently breaking because Linux target sysroots rely on case sensitive filesystem which is not by default enabled on macOS. Repository: rC Clang https://reviews.llvm.org/D4

[PATCH] D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build

This revision was automatically updated to reflect the committed changes. Closed by commit rC335917: [CMake] Build static runtimes for host in Fuchsia first stage (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D48707?vs=153270&id=153383#toc Repository:

[PATCH] D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC335919: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D48710?vs=153275&id=153385#toc Repository

[PATCH] D49345: [CMake] Use correct variable as header install prefix

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, beanz. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. This variable is already set in CMakeLists.txt but it wasn't used which means that the headers get installed into a wrong location when the per target

[PATCH] D49345: [CMake] Use correct variable as header install prefix

phosek added a comment. Thank you! Repository: rCXX libc++ https://reviews.llvm.org/D49345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49345: [CMake] Use correct variable as header install prefix

This revision was automatically updated to reflect the committed changes. Closed by commit rL337118: [CMake] Use correct variable as header install prefix (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49345?vs=15

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek created this revision. phosek added a reviewer: EricWF. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Currently it's possible to select whether to statically link unwinder or the C++ ABI library, but this option applies to both the shared and static library. However, in

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added a comment. This came up in Fuchsia. Clang driver, add `-lc++` as a dependency. This is sufficient for shared libc++, but for static user has to manually pass `-lc++abi -lunwind`, so for static libc++ we would actually like to combine both libc++abi and libunwind into a single archi

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added inline comments. Comment at: libcxx/CMakeLists.txt:158 +cmake_dependent_option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY_STATIC + "Statically link the ABI library to static library" ON Maybe `LIBCXX_ENABLE_STATIC_ABI_LIBRARY_IN_STATIC_LIBRARY` would be mor

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek updated this revision to Diff 156201. phosek marked 2 inline comments as done. Repository: rCXX libc++ https://reviews.llvm.org/D49502 Files: libcxx/CMakeLists.txt libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/lib/CMakeLists.txt libcxxabi/CMakeLists.txt libcxxabi/src/CMake

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added inline comments. Comment at: libcxx/lib/CMakeLists.txt:269 +AND (TARGET cxxabi_static OR HAVE_LIBCXXABI)) +#if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR +#(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND HAVE_LIBCXXABI)) ---

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek updated this revision to Diff 226355. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/ https://reviews.llvm.org/D69415 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake =

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. phosek updated this revision to Diff 226355. leonardchan accepted this revision. This revision is now accepted and ready to land. This includes

[PATCH] D69415: [CMake] Update Fuchsia build configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fff716ec474: [CMake] Update Fuchsia build configuration (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/ https://reviews.llvm

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:1037 bool InstrProfiling::emitRuntimeHook() { // We expect the linker to be invoked with -u flag f

[PATCH] D83999: [CMake][Fuchsia] Include additional tools in the toolchain

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. These are needed on Windows. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83999 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER -DCMAKE_LINKER=

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d09ecf36175: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.o

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 280305. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b1b4a231a4: [CMake] Simplify CMake handling for zlib (authored by phosek). Herald added subscribers: msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mge

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

phosek created this revision. phosek added reviewers: smeenai, compnerd, mehdi_amini. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antia

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek marked 4 inline comments as done. phosek added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) stephenneuendorffer wrote: > mehdi_amini wrote: > > mehdi_amini wrote: > > > I am a bit unsure that it is d

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

This revision was automatically updated to reflect the committed changes. Closed by commit rG64d99cc6abed: [CMake] Move find_package(ZLIB) to LLVMConfig (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.l

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2694 + +void Generic_GCC::AddGCCMultilibPaths(const Driver &D, + const std::string &SysRoot, The class already has `GCC` in the name, so there's no

[PATCH] D72959: Relative VTables ABI on Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:353 COMPATIBLE_VALUE_LANGOPT(MaxTokens, 32, 0, "Max number of tokens per TU or 0") +LANGOPT(FuchsiaRelativeCXXABIVTables, 1, 0, +"Whether to use clang's relative C++ ABI " ---

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rGd51054217403: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79835?vs=267336&id=268591#toc Reposi

[PATCH] D81514: [Fuchsia] Set projects and runtimes in the cache file

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We make assumptions about what projects and runtimes are enabled when configuring our toolchain build, so we should enable those in the cache file as we

[PATCH] D81514: [Fuchsia] Set projects and runtimes in the cache file

This revision was automatically updated to reflect the committed changes. Closed by commit rGa378c0449507: [Fuchsia] Set projects and runtimes in the cache file (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D81514?vs=269692&id=275579#toc Repository: rG LLVM Github M

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

phosek added inline comments. Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_INTDIR}/lld-link.exe) I don't understand t

[PATCH] D73810: [CMake][Fuchsia] Support for building on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG53e38c85a8a6: [CMake][Fuchsia] Support for building with MSVC (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D73810?vs=241822&id=276815#toc Repository: rG LLVM Github Monorep

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. Herald added a subscriber: dang. In D83154#2134984 , @MaskRay wrote: > -fdebug-prefix-map does not make sense to me because coverage is not debug > info. > I am on the fence whether we need -fcoverage-prefix-map. I created > http

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1a79dc12f3: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.o

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. I had to revert this change because it broke bots that don't have zlib installed. What I haven't realized is that the shadowed variable will only be accessible from the same file. I could move

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 278216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2152747 , @labath wrote: > I wouldn't mind separate (internal) cache variable, though I am somewhat > surprised by this problem. A (non-cache) variable set in one of the parent > scopes should still take precedence over

[PATCH] D82802: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82802/new/ https://reviews.llvm.org/D82802 ___

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 274256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek marked an inline comment as done. phosek added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON"

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 274255. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

phosek added a comment. Herald added a reviewer: MaskRay. We've started seeing `llvm-cov` on our Linux bots with this error: terminating with uncaught exception of type std::__2::system_error: thread constructor failed: Resource temporarily unavailable Specifically, we're running `llvm export

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

phosek added a comment. In D75153#1987272 , @phosek wrote: > We've started seeing `llvm-cov` on our Linux bots with this error: > > terminating with uncaught exception of type std::__2::system_error: thread > constructor failed: Resource temporarily una

[PATCH] D77168: Add a flag to debug automatic variable initialization

phosek added a comment. We've rolled out `-ftrivial-auto-var-init=pattern` to all of Fuchsia several months ago. In my experience, having the `pragma` would have been really valuable during the rollout stage when we've often commented out portion of code while narrowing down the issue, which is

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, s.egerton, simoncook, mgorny, dberris. Herald added a project: clang. While we don't support 32-bit architectures in Fuchsia, these are needed in the early boot phase on x86, so we build just th

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

This revision was automatically updated to reflect the committed changes. Closed by commit rG063128f97930: [Fuchsia] Build compiler-rt builtins for 32-bit x86 (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78687/new/ https://rev

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek created this revision. phosek added reviewers: smeenai, compnerd. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, cfe-commits, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. Rather than handling zlib handling manually, use `find_package` from CMa

<    1   2   3   4   5   6   7   8   9   10   >