phosek added inline comments.
================ Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + ---------------- paulkirth wrote: > chandlerc wrote: > > Sorry folks, but you can't do this. > > > > You can't depend on ADT from compiler-rt currently. > > > > There are at least two problems here: > > > > First problem is that this pollutes the profile library with symbols from > > ADT. That really doesn't seem reasonable without *significant* and invasive > > changes to ADT. Otherwise building LLVM and linking it with the profile > > library will create an ODR violation (imagine different assert levels or > > different versions of LLVM buing built and the host toolchain). > > > > > > Second, and much more critically, we haven't gotten to 100% relicensed on > > ADT, so it is critical that we not depend on it from runtime libraries. > > > > Third, a lot of this code seems to use old license headers. Please do not > > add any code like this to LLVM, and instead use the new LLVM license for > > all new code. > > > > For now, this patch (and any related patches) need to be reverted until > > these are addressed. Especially the license issues. > Sorry, this looks like a mismerge somehow. My patch should't have anything > from compiler-rt. I think maybe a local change got rolled in when Petr landed > my patch. Sorry about that, this was my mistake, it seems two of my stales files got included in when I applied the patch locally. I'll revert the change and reland it correctly. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
