[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek updated this revision to Diff 341001. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101400/new/ https://reviews.llvm.org/D101400 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Driver

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek added a comment. In D101400#2720954 , @MaskRay wrote: > gcc has `--print-multiarch`. Just use `--print-multiarch`? I think our > semantics are compatible. I wasn't aware that GCC already has this option but using the same spelling definitely mak

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek updated this revision to Diff 341015. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101400/new/ https://reviews.llvm.org/D101400 Files: clang/include/clang/Driver/Options.td clang/include/clang/Dri

[PATCH] D101400: [Driver] Add -print-multiarch-triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa921d2d2fb46: [Driver] Add -print-multiarch (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2721390 , @MaskRay wrote: > I thought this was NFC:( > > Yeah, personally I think the previous behavior > (`lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.a`) is > slightly better than the new > `lib/c

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

phosek added a comment. What I think @vitalybuka meant is keeping `sanitizer_platform_limits_fuchsia.h` as you had it, but including it unconditionally. Since the entire file is wrapped in `#if SANITIZER_FUCHSIA ... #endif`, the inclusion would be a no-op on platforms other than Fuchsia so no n

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2721643 , @MaskRay wrote: > multiarch is not consistent within GCC, either (also note that not all GCC > installations are configured with multiarch. `--print-multiarch` prints an > empty line). > I have tried various

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4001 + // probably don't want to allow usage of an ARM ABI on an x86 architecture. + auto SupportedCXXABI = [](const llvm::Triple &T, TargetCXXABI::Kind Kind) { +switch (Kind) {

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. In D101139#2718112 , @aabbaabb wrote: > In D101139#2718057 , @phosek wrote: > >> In D101139#2713530 , @aabbaabb >> wrote: >> >>> The python script

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 341088. Herald added a subscriber: arichardson. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. This revision now requires review to proceed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D890

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek created this revision. phosek added reviewers: hans, rnk, thakis. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements support for using libc++ headers in MSVC toolchain. We only support libc++ headers that are part

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 341262. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/basic_fuchsia_tree/include/aarch64-unkn

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea12d779bc23: [libc++] Support per-target __config_site in per-tar

[PATCH] D101551: [CMake] Set correct CXX_FLAGS for relative-vtables variants

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We overrite CXX_FLAGS to enable relative vtables, but doing so overwrites generic

[PATCH] D101551: [CMake] Set correct CXX_FLAGS for relative-vtables variants

phosek updated this revision to Diff 341570. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101551/new/ https://reviews.llvm.org/D101551 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ===

[PATCH] D101551: [CMake] Set correct CXX_FLAGS for relative-vtables variants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba631240ae9c: [CMake] Set correct CXX_FLAGS for relative-vtables variants (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 341652. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs

[PATCH] D99599: [NewPM] Add an option to dump pass structure

phosek added a comment. It looks like the `BarrierNoop` pass is inserted under `-O0` when any extension is registered . We enable Polly in our toolchain so tha

[PATCH] D99599: [NewPM] Add an option to dump pass structure

phosek added a comment. In D99599#2728092 , @evgeny777 wrote: > Should be fixed with `c81ec19fba27ec` Thank you, our builders went green after that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9959

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put these into a separate files to match other -print-* options tests. Repository: rG LLVM Github Monorepo https://r

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek updated this revision to Diff 342950. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/ https://reviews.llvm.org/D101813 Files: clang/test/Driver/immediate-options.c clang/test/Driver/print

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek updated this revision to Diff 342954. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/ https://reviews.llvm.org/D101813 Files: clang/test/Driver/immediate-options.c clang/test/Driver/print

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek added inline comments. Comment at: clang/test/Driver/print-resource-dir.c:3 +// RUN:-resource-dir=%S/Inputs/resource-dir \ +// RUN: | FileCheck %s -check-prefix=PRINT-RESOURCE-DIR +// PRINT-RESOURCE-DIR: Inputs{{/|\\}}resource-dir MaskRay wrot

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3dbcd24c7d: [Driver] Move -print-runtime-dir and -print-resource-dir tests (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2733622 , @mstorsjo wrote: > In D101479#2733434 , @thakis wrote: > >> In D101479#2733354 , @mstorsjo >> wrote: >> >>> Not sure if we wa

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added a subscriber: pengfei. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. x86 is only used for the bootloader and we use x86-64 libc++ headers in

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2741202 , @mstorsjo wrote: > In D101479#2740895 , @phosek wrote: > >> On other platforms the decision whether to use static or shared is >> controlled by `-static-libstdc++`, do

[PATCH] D102013: [Fuchsia][CMake] Update OSX deployment target

phosek created this revision. phosek added reviewers: leonardchan, haowei, mcgrathr, gulfem. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use correct spelling of CMAKE_OSX_DEPLOYMENT_TARGET and b

[PATCH] D102013: [Fuchsia][CMake] Update OSX deployment target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb191b724b7: [Fuchsia][CMake] Update OSX deployment target (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

phosek abandoned this revision. phosek added a comment. After some further discussion, we've decided to generate a `__config_site` in our build only for the specific purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101967/new/ https://review

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. Looking at `libear/__init__.py`, it's basically replicating CMake build to the point where it even emulates CMake template expansion, see https://github.com/llvm/llvm-project/blob/a3a8a1a15b524d91b5308db68e9d293b34cd88dd/clang/tools/scan-build-py/libear/__init__.py#L204.

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 343507. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs/msvc_libcxx_tree/usr/bin/.keep clang/t

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:249-250 + .flag("+fc++-abi=itanium") + .flag("-fexceptions") + .flag("+fno-exceptions")); We should prob

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:102 + SmallString<128> SysRootDir; + llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", + getDriver().getTargetTriple()); I a

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

phosek created this revision. phosek added reviewers: abidh, jroelofs. phosek added a project: clang. Herald added a subscriber: ki.stfu. phosek requested review of this revision. Herald added a subscriber: cfe-commits. This addresses an issue introduced in D91559

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b00b34b8a05: [BareMetal] Ensure that sysroot always comes after library paths (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 ___

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-Bsymbolic-functions") +endif() ---

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek requested changes to this revision. phosek added inline comments. This revision now requires changes to proceed. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHAR

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:245 .flag("+fno-exceptions")); + // Use the default Itanium C++ ABI. + Multilibs.push_ba

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

phosek accepted this revision. phosek added a comment. LGTM this is something we have a use case for this in Fuchsia as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116503/new/ https://reviews.llvm.org/D116503 __

[PATCH] D116843: [Driver][Gnu] -r: imply -nostdlib like GCC

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116843/new/ https://reviews.llvm.org/D116843 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D116844: [Driver][Fuchsia] -r: imply -nostdlib like GCC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. Thank you! I was going to send the same change but you beat me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116844/new/ https://reviews.

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek added a comment. I don't think the updated logic is correct. For example, in the case of Fuchsia we don't want to take `CLANG_DEFAULT_LINKER` into account, that's why we override `getDefaultLinker`. I assume it's the same for other toolchains that override `getDefaultLinker`. The issue

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek added a comment. In D115045#3175648 , @phosek wrote: > I don't think the updated logic is correct. For example, in the case of > Fuchsia we don't want to take `CLANG_DEFAULT_LINKER` into account, that's why > we override `getDefaultLinker`. I ass

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek added a comment. In D115045#3175760 , @mstorsjo wrote: > In D115045#3175648 , @phosek wrote: > >> Rather, we shouldn't consider `-DCLANG_DEFAULT_LINKER=lld` as a valid value. >> Instead AMDGPU bot should u

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. This change broke our kernel build. I believe that the issue is that the compiler doesn't consider function attributes. This can be trivially reproduced as: $ cat >t.c < EOF $ ./bin/clang -c t.c -o t.o -mno-sse In file included from t.c:1: In file included from

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. Note that GCC had the same issue in the past https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80298 which was later addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114782/new/ https://reviews.llvm.org/D114782

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. In D114782#3184317 , @pengfei wrote: > Hi @phosek , thanks for reporting it. > I would consider it as a misuse of the header file when SSE is not usable, > especially we now have the specific header "x86gprintrin.h" for such > sc

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. In D114782#3184406 , @phosek wrote: > In D114782#3184317 , @pengfei wrote: > >> Hi @phosek , thanks for reporting it. >> I would consider it as a misuse of the header file when SSE is not u

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98887/new/ https://reviews.llvm.org/D98887 ___ c

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. This is still broken, we're seeing multiple failing tests, can we please revert this change for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. They're not part of buildbot but they're not internal, you can see the log here: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8852352747956966400/+/u/clang/test/stdout. I noticed D98862 , but it still hasn

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. In D98493#2636648 , @maxim-kuvyrkov wrote: > In D98493#2636616 , @phosek wrote: > >> They're not part of buildbot but they're not internal, you can see the log >> here: >> https://logs.chr

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. I've tested this locally and it's working for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek updated this revision to Diff 332739. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Fuchsia

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added a comment. In D98061#2623959 , @MaskRay wrote: > I am a bit concerned that whether the file is generated or not is now > dependent on the instrumentation and linker garbage collection. That's a fair concern, do you know about use cases where

[PATCH] D99243: [CMake][Fuchsia] Include llvm-lipo

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to use llvm-lipo for building universal libraries. Repository:

[PATCH] D99243: [CMake][Fuchsia] Include llvm-lipo

This revision was automatically updated to reflect the committed changes. Closed by commit rG39f3e9a9e07d: [CMake][Fuchsia] Include llvm-lipo (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99243/new/ https://reviews.llvm.org/D99

[PATCH] D99321: [clang] Always execute multi-stage install steps

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99321/new/ https://reviews.llvm.org/D99321 ___ c

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

phosek added a comment. @leonardchan would it be possible to break up this patch into multiple changes: - Clang driver - Cache file - `hwasan_new_delete.cpp` - `HWAddressSanitizer.cpp` - `sanitizer_platform_limits_fuchsia.h` - `sanitizer_symbolizer_markup.cpp` - the rest Repository: rG LLVM G

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99361/new/ https://reviews.llvm.org/D99361 ___ c

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM although I'm becoming worried about the impact on build times given the rapidly increasing number of multilib variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334289. phosek retitled this revision from "[libcxx] Support per-target __config in per-target runtime build" to "[libcxx] Support per-target __config_site in per-target runtime build". phosek edited the summary of this revision. phosek added a comment. @ldio

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

phosek updated this revision to Diff 334297. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://reviews.llvm.org/D88452 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuch

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/fuchsia.

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf680050686: [Driver] Move detectLibcxxIncludePath to ToolChain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://revi

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334506. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/fuchsia.cpp clang/test/Driver/linux-header-se

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#2660407 , @MaskRay wrote: > Regarding > > /usr/include/x86_64-unknown-linux-gnu/c++/v1 > /usr/include/c++/v1 > > With GCC multiarch, some `include` search paths are preceded by > machine-os-env specific suffix directo

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334550. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, johnrusso, rbar, asb. Repository: rG LLVM Github Monorepo CH

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#2662434 , @ldionne wrote: > I'm personally not so concerned with the Clang driver side of things, but > primarily with adding more complexity to the libc++ build. Shouldn't we be > driving things from the runtimes build

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:379 + +// Second add the generic one. +P.assign(Path); ldionne wrote: > Doesn't that break `#include_next` if both directories exist? Generally > speaking, I think you only

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION ${LIBCXX_INSTALL_HEA

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION ${LIBCXX_INSTALL_HEA

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/${CMAKE_I

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

phosek added a comment. @beanz do you know if `clang/runtime` is still being used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 ___ cfe-commits mailing list cf

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne I have update the change description to explain the new layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-commits m

[PATCH] D99810: [ifs][elfabi] Merge llvm-elfabi tool into llvm-ifs

phosek added a comment. This change is pretty large so I'm wondering if we could possibly split it into two changes, one that does the purely mechanical renaming of ELF and TBE to IFS, and second one that merges the two tools? Comment at: clang/lib/Driver/ToolChains/Interface

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

phosek added a comment. I'm worried that overriding `CMAKE_INSTALL_PREFIX` is going to break the runtimes build where we build compiler-rt, libcxx, libcxxabi, libunwind in a single CMake build, and compiler-rt always comes first see https://github.com/llvm/llvm-project/blob/98742e42fc50f58d3f2d

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne any more thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you should wait a bit for @pcc or @eugenis to have a chance to to review this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1176-1210 + // If command line flags such as -m32, etc. changed parts of the triple that + // are not just changes to normalization, we also need to update the raw + // triple string that is used to find too

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 337166. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/Too

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne friendly ping. In D89013#2686799 , @ldionne wrote: > I agree the design is clean from the "what we ship" perspective. I really > like the idea of shipping the whole library in a generic spot and only having > one file em

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In D45639#2692142 , @ldionne wrote: > In D45639#2383754 , @smeenai wrote: > >> Just following up on this, cos I'm curious :) I have 12.1 now, and I still >> only see the C++ headers in the t

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

phosek added a comment. I see, it's exposed here https://github.com/llvm/llvm-project/blob/6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619/compiler-rt/include/sanitizer/hwasan_interface.h#L88. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ http

[PATCH] D100869: [libcxx] Stop using use c++ subdirectory for libc++ library

phosek created this revision. phosek added a reviewer: ldionne. Herald added subscribers: libcxx-commits, mgorny. Herald added a project: libunwind. Herald added a reviewer: libunwind. phosek requested review of this revision. Herald added projects: clang, libc++, libc++abi. Herald added a subscrib

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGae8b2cab6740: [Driver] Support default libc++ library location on Darwin (authored by phosek). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In D45639#2702746 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/37191/step_7.txt Should be addressed by rGf5efe0aa048b .

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. Another attempt is rGcaff17e503fe . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/new/ https://reviews.llvm.org/D45639

[PATCH] D100907: [lsan][docs] Clarify supported platforms

phosek added inline comments. Comment at: clang/docs/LeakSanitizer.rst:50 +* Android aarch64/i386/x86_64 +* Fuchsia +* Linux arm/aarch64/mips64/ppc64/ppc64le/riscv64/s390x/i386/x86\_64 You can clarify that Fuchsia supports aarch64 and x86_64. Repository: rG L

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In D45639#2705702 , @ldionne wrote: > In D45639#2703913 , @JDevlieghere > wrote: > >> This breaks `TestAppleSimulatorOSType.py ` on GreenDragon. First failed >> build: http://green.lab.llvm

[PATCH] D100869: [libcxx] Stop using use c++ subdirectory for libc++ library

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf749550cfe9f: [libcxx] Stop using use c++ subdirectory for libc++

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This avoids test failures where extra files exist in the tree, such as the standard library built using the runtimes buil

[PATCH] D92792: [clang] - Also look for devtoolset-10

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf67d3dbdb930: [clang] - Also look for devtoolset-10 (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D92792: [clang] - Also look for devtoolset-10

phosek added a comment. In D92792#2475182 , @stephan.dollberg wrote: > Ping @phosek Merged, sorry about the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

phosek added a comment. I'd prefer to use the target triple rather than introducing a custom flag. With dedicated flags, you might eventually end up in a similar situation as D85802 , that is in the extreme case you might end up with `-f[no-]fuchsia-c++-abi`, `-

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

phosek added a comment. In D93668#2482995 , @rnk wrote: > I guess a triple of -fuchsia-itanium would be a reasonable way of expressing > this. > > Why would we want a feature flag for the wasm C++ ABI? Is there a use case > for using the webassembly C++

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

<    11   12   13   14   15   16   17   >