phosek added a comment. In D115045#3175760 <https://reviews.llvm.org/D115045#3175760>, @mstorsjo wrote:
> In D115045#3175648 <https://reviews.llvm.org/D115045#3175648>, @phosek wrote: > >> Rather, we shouldn't consider `-DCLANG_DEFAULT_LINKER=lld` as a valid value. >> Instead AMDGPU bot should use `-DCLANG_DEFAULT_LINKER=ld.lld`. > > I think this would be a kinda disruptive change; I (and others) specify it as > `-DCLANG_DEFAULT_LINKER=lld` so far: > https://github.com/mstorsjo/llvm-mingw/blob/master/build-llvm.sh#L162 And > other projects too: > https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-clang/PKGBUILD#L204 In that case, perhaps we should consider `-DCLANG_DEFAULT_LINKER=` to set the default value for `-fuse-ld` only and have another variable for `--ld-path`? Open question is if `getDefaultLinker()` should return the name of the linker or the filename. I'd argue for the former which would be consistent with `-DCLANG_DEFAULT_LINKER=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
