MontyKutyi updated this revision to Diff 117367.
MontyKutyi added a comment.
Updated to the latest trunk version.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index: unittests/AST/PostOrderASTVisitor.cpp
=
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi updated this revision to Diff 101929.
MontyKutyi added a comment.
Just added the whole file instead of a small surrounding to be able to check
the `DEF_TRAVERSE_DECL` macro too.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
Index: include/clang/A
MontyKutyi added a comment.
In https://reviews.llvm.org/D34030#967749, @bruno wrote:
> The change seems good to me in general. I wonder if this will hit any broken
> assumption in the code. Did you run other tests beside unittests?
I run the tests available by building the `clang-test` only.
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi updated this revision to Diff 108626.
MontyKutyi added a comment.
I run the clang-format with -style=llvm on the added code parts.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index: unittests/AST/PostOrder
MontyKutyi updated this revision to Diff 108678.
MontyKutyi added a comment.
Did the renamings.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index: unittests/AST/PostOrderASTVisitor.cpp
===
MontyKutyi added a comment.
Any further request on this?
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a reviewer: bruno.
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Could anybody take a look at on this please?
Thanks,
Peter
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MontyKutyi updated this revision to Diff 108013.
MontyKutyi added a comment.
Updated the comment.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
Index: include/clang/AST/RecursiveASTVisitor.h
===
MontyKutyi added a comment.
As I can see the `clang/test` contains a lot of different simple tests, but for
testing this I think it is not enough to run the clang with some arguments on a
specific input. So I should create a new executable which uses the postorder
mode of the RecursiveASTVisit
MontyKutyi updated this revision to Diff 108241.
MontyKutyi added a comment.
Added test for the fix.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index: unittests/AST/PostOrderASTVisitor.cpp
===
MontyKutyi added a comment.
Is there any particular parameter for the clang-format what I should use? If I
just run it without any parameter it changes lines of the original test too.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe
20 matches
Mail list logo