[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

[Peter Siket via Phabricator via cfe-commits]

MontyKutyi updated this revision to Diff 108013.
MontyKutyi added a comment.

Updated the comment.


https://reviews.llvm.org/D34030

Files:
  include/clang/AST/RecursiveASTVisitor.h


Index: include/clang/AST/RecursiveASTVisitor.h
===================================================================
--- include/clang/AST/RecursiveASTVisitor.h
+++ include/clang/AST/RecursiveASTVisitor.h
@@ -1802,11 +1802,10 @@
     TRY_TO(TraverseNestedNameSpecifierLoc(D->getQualifierLoc()));              
\
     if (!getDerived().shouldVisitTemplateInstantiations() &&                   
\
         D->getTemplateSpecializationKind() != TSK_ExplicitSpecialization)      
\
-      /* Returning from here skips traversing the                              
\
-         declaration context of the *TemplateSpecializationDecl                
\
-         (embedded in the DEF_TRAVERSE_DECL() macro)                           
\
-         which contains the instantiated members of the template. */           
\
-      return true;                                                             
\
+      /* Skip traversing the declaration context of the                        
\
+         *TemplateSpecializationDecl (embedded in the DEF_TRAVERSE_DECL()      
\
+         macro) which contains the instantiated members of the template. */    
\
+      ShouldVisitChildren = false;                                             
\
   })
 
 DEF_TRAVERSE_TMPL_SPEC_DECL(Class)



Index: include/clang/AST/RecursiveASTVisitor.h
===================================================================
--- include/clang/AST/RecursiveASTVisitor.h
+++ include/clang/AST/RecursiveASTVisitor.h
@@ -1802,11 +1802,10 @@
     TRY_TO(TraverseNestedNameSpecifierLoc(D->getQualifierLoc()));              \
     if (!getDerived().shouldVisitTemplateInstantiations() &&                   \
         D->getTemplateSpecializationKind() != TSK_ExplicitSpecialization)      \
-      /* Returning from here skips traversing the                              \
-         declaration context of the *TemplateSpecializationDecl                \
-         (embedded in the DEF_TRAVERSE_DECL() macro)                           \
-         which contains the instantiated members of the template. */           \
-      return true;                                                             \
+      /* Skip traversing the declaration context of the                        \
+         *TemplateSpecializationDecl (embedded in the DEF_TRAVERSE_DECL()      \
+         macro) which contains the instantiated members of the template. */    \
+      ShouldVisitChildren = false;                                             \
   })
 
 DEF_TRAVERSE_TMPL_SPEC_DECL(Class)

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits