Author: Peter Collingbourne
Date: 2020-02-06T17:44:43-08:00
New Revision: 7931e8eee3dafe64101dcc1e88276ba81071
URL:
https://github.com/llvm/llvm-project/commit/7931e8eee3dafe64101dcc1e88276ba81071
DIFF:
https://github.com/llvm/llvm-project/commit/7931e8eee3dafe64101dcc1e88276ba81071
Author: pcc
Date: Wed Apr 4 14:55:44 2018
New Revision: 329236
URL: http://llvm.org/viewvc/llvm-project?rev=329236&view=rev
Log:
AArch64: Implement support for the shadowcallstack attribute.
The implementation of shadow call stack on aarch64 is quite different to
the implementation on x86_64. In
Author: Peter Collingbourne
Date: 2023-03-22T15:28:21-07:00
New Revision: 201fdef40dd6ec193d18d39638454a3c972f1fec
URL:
https://github.com/llvm/llvm-project/commit/201fdef40dd6ec193d18d39638454a3c972f1fec
DIFF:
https://github.com/llvm/llvm-project/commit/201fdef40dd6ec193d18d39638454a3c972f1fec
Author: pcc
Date: Fri Dec 16 16:10:52 2016
New Revision: 289996
URL: http://llvm.org/viewvc/llvm-project?rev=289996&view=rev
Log:
IRGen: Fix assertion failure when creating debug info for an integer constant
wider than 64 bits.
Added:
cfe/trunk/test/CodeGen/dbg-const-int128.c
Modified:
c
Author: pcc
Date: Fri Dec 16 17:43:51 2016
New Revision: 290008
URL: http://llvm.org/viewvc/llvm-project?rev=290008&view=rev
Log:
Add explicit triple to test to fix arm bots.
Modified:
cfe/trunk/test/CodeGen/dbg-const-int128.c
Modified: cfe/trunk/test/CodeGen/dbg-const-int128.c
URL:
http://
pcc updated this revision to Diff 70622.
pcc added a comment.
- Refresh
https://reviews.llvm.org/D22642
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cp
Author: pcc
Date: Wed Sep 7 20:14:39 2016
New Revision: 280897
URL: http://llvm.org/viewvc/llvm-project?rev=280897&view=rev
Log:
CodeGen: Clean up implementation of vtable initializer builder. NFC.
- Simplify signature of CreateVTableInitializer function.
- Move vtable component builder to a sep
pcc marked 4 inline comments as done.
Comment at: lib/CodeGen/CGVTables.cpp:588
@@ +587,3 @@
+if (auto *F = dyn_cast(Cache))
+ F->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+Cache = llvm::ConstantExpr::getBitCast(Cache, CGM.Int8PtrTy);
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280897: CodeGen: Clean up implementation of vtable
initializer builder. NFC. (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D22642?vs=70622&id=70632#toc
Repository:
rL LLVM
htt
Author: pcc
Date: Wed Sep 7 20:45:28 2016
New Revision: 280899
URL: http://llvm.org/viewvc/llvm-project?rev=280899&view=rev
Log:
Add explicit casts to size_t to try to appease MSVC.
Modified:
cfe/trunk/include/clang/AST/VTableBuilder.h
Modified: cfe/trunk/include/clang/AST/VTableBuilder.h
U
On Wed, Sep 7, 2016 at 6:44 PM, Richard Smith wrote:
> On 7 Sep 2016 6:23 pm, "Peter Collingbourne" wrote:
>
> pcc marked 4 inline comments as done.
>
>
> Comment at: lib/CodeGen/CGVTables.cpp:588
> @@ +587,3 @@
> +if (auto *F = dyn_cast(Cache))
> + F->setUnname
pcc updated this revision to Diff 70908.
pcc added a comment.
Refresh and split out the inrange changes into a separate patch
https://reviews.llvm.org/D22296
Files:
include/clang/AST/VTableBuilder.h
lib/AST/VTableBuilder.cpp
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGVTT.cpp
lib/CodeGen/CGVT
pcc created this revision.
pcc added reviewers: rsmith, eugenis.
pcc added subscribers: cfe-commits, krasin.
pcc added a dependency: D22296: CodeGen: New vtable group representation:
struct of vtable arrays..
This annotation allows the optimizer to split vtable groups, as permitted by
a change to
pcc added a comment.
This should now be ready for review and unblocked by other changes (I split out
the inrange annotation to https://reviews.llvm.org/D24431).
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: pcc
Date: Mon Sep 12 20:13:19 2016
New Revision: 281285
URL: http://llvm.org/viewvc/llvm-project?rev=281285&view=rev
Log:
Update Clang for D20147 ("DebugInfo: New metadata representation for global
variables.")
Differential Revision: http://reviews.llvm.org/D20415
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281285: Update Clang for D20147 ("DebugInfo: New metadata
representation for global… (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D20415?vs=59260&id=71088#toc
Repository:
rL L
Author: pcc
Date: Fri Sep 16 17:05:53 2016
New Revision: 281785
URL: http://llvm.org/viewvc/llvm-project?rev=281785&view=rev
Log:
CodeGen: Add more checks to nobuiltin.c test, add a negative test.
Modified:
cfe/trunk/test/CodeGen/nobuiltin.c
Modified: cfe/trunk/test/CodeGen/nobuiltin.c
URL:
pcc created this revision.
pcc added reviewers: mehdi_amini, dexonsmith.
pcc added subscribers: llvm-commits, cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: nhaehnle, nemanjai, mehdi_amini, jyknight, qcolombet.
This module flag is used to mark modules which were compi
Author: pcc
Date: Fri Sep 16 17:26:45 2016
New Revision: 281790
URL: http://llvm.org/viewvc/llvm-project?rev=281790&view=rev
Log:
Add target triples to fix test on non-x86.
Modified:
cfe/trunk/test/CodeGen/nobuiltin.c
Modified: cfe/trunk/test/CodeGen/nobuiltin.c
URL:
http://llvm.org/viewvc/
Author: pcc
Date: Fri Sep 16 17:56:12 2016
New Revision: 281796
URL: http://llvm.org/viewvc/llvm-project?rev=281796&view=rev
Log:
Add REQUIRES line.
Modified:
cfe/trunk/test/CodeGen/nobuiltin.c
Modified: cfe/trunk/test/CodeGen/nobuiltin.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/t
Author: pcc
Date: Mon Mar 20 21:02:41 2017
New Revision: 298330
URL: http://llvm.org/viewvc/llvm-project?rev=298330&view=rev
Log:
IRGen: Do not set dllexport on declarations.
Setting dllexport on a declaration has no effect, as we do not emit export
directives for declarations.
Part of the fix f
Author: pcc
Date: Fri Mar 24 14:32:20 2017
New Revision: 298728
URL: http://llvm.org/viewvc/llvm-project?rev=298728&view=rev
Log:
Fix a test so that it actually checks the output.
Modified:
cfe/trunk/test/Modules/module-impl-with-link.c
Modified: cfe/trunk/test/Modules/module-impl-with-link.
Author: pcc
Date: Mon Apr 10 18:54:28 2017
New Revision: 299902
URL: http://llvm.org/viewvc/llvm-project?rev=299902&view=rev
Log:
docs: Use the term "whole-program devirtualization" instead of "virtual
function call optimization".
The former term is probably more familiar to users. Also add refe
Author: pcc
Date: Wed Jan 18 17:55:27 2017
New Revision: 292448
URL: http://llvm.org/viewvc/llvm-project?rev=292448&view=rev
Log:
Move vtable type metadata emission behind a cc1-level flag.
In ThinLTO mode, type metadata will require the module to be written as a
multi-module bitcode file, which
Author: pcc
Date: Wed Jan 18 18:04:44 2017
New Revision: 292450
URL: http://llvm.org/viewvc/llvm-project?rev=292450&view=rev
Log:
Add llvm-dis dependency to check-clang.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/
Author: pcc
Date: Fri Jan 20 16:39:16 2017
New Revision: 292662
URL: http://llvm.org/viewvc/llvm-project?rev=292662&view=rev
Log:
IRGen: Start using the WriteThinLTOBitcode pass.
This is the final change necessary to support CFI with ThinLTO.
Differential Revision: https://reviews.llvm.org/D2884
Author: pcc
Date: Tue Jan 24 13:54:37 2017
New Revision: 292970
URL: http://llvm.org/viewvc/llvm-project?rev=292970&view=rev
Log:
IRGen: Factor out function clang::FindThinLTOModule. NFCI.
Modified:
cfe/trunk/include/clang/CodeGen/BackendUtil.h
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modif
Author: pcc
Date: Tue Jan 24 13:55:38 2017
New Revision: 292972
URL: http://llvm.org/viewvc/llvm-project?rev=292972&view=rev
Log:
IRGen: Factor out function CodeGenAction::loadModule. NFCI.
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenAction.h
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Author: pcc
Date: Thu Jan 26 15:09:48 2017
New Revision: 293209
URL: http://llvm.org/viewvc/llvm-project?rev=293209&view=rev
Log:
IRGen: When loading the main module in the distributed ThinLTO backend, look
for the module containing the summary.
Differential Revision: https://reviews.llvm.org/D2
Author: pcc
Date: Thu Jan 26 15:38:48 2017
New Revision: 293210
URL: http://llvm.org/viewvc/llvm-project?rev=293210&view=rev
Log:
Add missing x86 requirement.
Modified:
cfe/trunk/test/CodeGen/thinlto-multi-module.ll
Modified: cfe/trunk/test/CodeGen/thinlto-multi-module.ll
URL:
http://llvm.o
Author: pcc
Date: Thu Jan 26 17:51:50 2017
New Revision: 293231
URL: http://llvm.org/viewvc/llvm-project?rev=293231&view=rev
Log:
Re-apply r292662, "IRGen: Start using the WriteThinLTOBitcode pass."
The internal build issue has been resolved.
Added:
cfe/trunk/test/CodeGenCXX/type-metadata-th
Author: pcc
Date: Mon Feb 6 21:21:57 2017
New Revision: 294274
URL: http://llvm.org/viewvc/llvm-project?rev=294274&view=rev
Log:
Driver: Do not link safestack with --whole-archive.
This allows it to be used with the other sanitizers.
Differential Revision: https://reviews.llvm.org/D29545
Modif
Author: pcc
Date: Tue Jan 16 20:37:04 2018
New Revision: 322617
URL: http://llvm.org/viewvc/llvm-project?rev=322617&view=rev
Log:
libcxx: Stop using private MSVC macros in the exception implementation.
Inline the provided "fallback" definitions (which seem to always be
taken) that expand to __cde
Author: pcc
Date: Wed Jan 17 11:32:35 2018
New Revision: 322744
URL: http://llvm.org/viewvc/llvm-project?rev=322744&view=rev
Log:
libcxx: Disable CFI in function std::get_temporary_buffer.
The specification of this function mandates a cast to uninitialized
T*, which is forbidden under CFI.
Diffe
Author: pcc
Date: Wed Jan 17 16:33:35 2018
New Revision: 322794
URL: http://llvm.org/viewvc/llvm-project?rev=322794&view=rev
Log:
libcxx: Define set_unexpected, _get_unexpected and __uncaught_exceptions
without dllimport.
It turns out that the MSVC headers define these functions without
dllimpor
Author: pcc
Date: Mon Jan 22 17:59:43 2018
New Revision: 323169
URL: http://llvm.org/viewvc/llvm-project?rev=323169&view=rev
Log:
libcxx: Move Windows threading support into a .cpp file.
This allows us to avoid polluting the namespace of users of
with the definitions in windows.h.
Differential
Author: pcc
Date: Mon Jan 22 18:07:27 2018
New Revision: 323170
URL: http://llvm.org/viewvc/llvm-project?rev=323170&view=rev
Log:
libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t*
filenames on Windows.
This is an MSVC standard library extension. It seems like a reasona
Author: pcc
Date: Tue Jan 23 10:53:33 2018
New Revision: 323237
URL: http://llvm.org/viewvc/llvm-project?rev=323237&view=rev
Log:
libcxx: Rename vasprintf function to __libcpp_vasprintf.
The language standard does not define a function with this name,
so it is part of the user's namespace. This c
Author: pcc
Date: Tue Jan 23 20:30:19 2018
New Revision: 323300
URL: http://llvm.org/viewvc/llvm-project?rev=323300&view=rev
Log:
libcxx: Allow auto-linking to be disabled with a macro.
Some users may have a custom build system which gives a different
name to the libc++ archive (or does not creat
Author: pcc
Date: Wed Jan 24 10:59:58 2018
New Revision: 323362
URL: http://llvm.org/viewvc/llvm-project?rev=323362&view=rev
Log:
IRGen: Emit an inline implementation of __builtin_wmemcmp on MSVCRT platforms.
The MSVC runtime library does not provide a definition of wmemcmp,
so we need an inline
Author: pcc
Date: Wed Jan 24 17:38:43 2018
New Revision: 323397
URL: http://llvm.org/viewvc/llvm-project?rev=323397&view=rev
Log:
[libc++abi] Fix unused function when building with LIBCXXABI_SILENT_TERMINATE
This fixes:
src/cxa_default_handlers.cpp:25:13: error: unused function
'demangling_termi
Author: pcc
Date: Thu Jan 25 17:19:23 2018
New Revision: 323490
URL: http://llvm.org/viewvc/llvm-project?rev=323490&view=rev
Log:
libcxx: Move #include_next out of header guard in wrapper header.
Code on Windows expects to be able to do:
#define _USE_MATH_DEFINES
#include
and receive the de
Author: pcc
Date: Thu Jan 25 17:22:17 2018
New Revision: 323491
URL: http://llvm.org/viewvc/llvm-project?rev=323491&view=rev
Log:
libcxx: Use vcruntime declarations for typeinfo on Windows.
We need to use the vcruntime declarations on Windows to avoid an
ODR violation involving rtti.obj, which pr
Author: pcc
Date: Fri Jan 26 13:23:27 2018
New Revision: 323563
URL: http://llvm.org/viewvc/llvm-project?rev=323563&view=rev
Log:
Fix the BinaryPredicate form of std::is_permutation to not rely on operator==
According to [1], forms 2 and 4 of std::is_permutation should use the passed in
binary pr
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> Is it correct to emit a type check at this point? Looking at [0
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
krasin wrote:
> pcc wrote:
> > pcc wrote:
> > > Is it correct to emit a type
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1928-1933
+SourceLocation CallLoc;
+if (E)
+ CallLoc = E->getExprLoc();
+EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+ CallLoc, Ptr.getPointer(),
+ DeleteTy);
--
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1769
+ SourceLocation CallLoc;
+ if (DE)
+CallLoc = DE->getExprLoc();
DE will always be non-null at this point.
Comment at: test/CodeGenCXX/ubsan-vtable-checks.cpp:23
+ //
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGExprCXX.cpp:1768
QualType ElementType) {
+ CGF.EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+DE-
pcc added inline comments.
Comment at: test/ubsan/TestCases/TypeCheck/null.cpp:1
-// RUN: %clangxx -fsanitize=null %s -O3 -o %t
-// RUN: %run %t l 2>&1 | FileCheck %s --check-prefix=CHECK-LOAD
-// RUN: %expect_crash %run %t s 2>&1 | FileCheck %s --check-prefix=CHECK-STORE
-// RUN
pcc created this revision.
pcc added reviewers: rnk, rsmith.
pcc added a subscriber: cfe-commits.
https://reviews.llvm.org/D26868
Files:
clang/lib/Sema/SemaDeclCXX.cpp
clang/test/SemaCXX/MicrosoftCompatibility.cpp
Index: clang/test/SemaCXX/MicrosoftCompatibility.cpp
Author: pcc
Date: Fri Nov 18 18:30:56 2016
New Revision: 287411
URL: http://llvm.org/viewvc/llvm-project?rev=287411&view=rev
Log:
Sema: As of MSVC 2015, a user-declared move operation causes the deletion of
both copy operations.
Differential Revision: https://reviews.llvm.org/D26868
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287411: Sema: As of MSVC 2015, a user-declared move
operation causes the deletion of… (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D26868?vs=78576&id=78603#toc
Repository:
rL
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Mon Nov 21 18:21:43 2016
New Revision: 287600
URL: http://llvm.org/viewvc/llvm-project?rev=287600&view=rev
Log:
Sema, CodeGen: Ensure that an implicit copy ctor is available more often under
the Microsoft C++ ABI.
This is needed because whether the constructor is deleted can co
Author: pcc
Date: Mon Nov 21 18:43:30 2016
New Revision: 287602
URL: http://llvm.org/viewvc/llvm-project?rev=287602&view=rev
Log:
Fix -Asserts build, and add some more test cases.
Modified:
cfe/trunk/test/CodeGenCXX/uncopyable-args.cpp
Modified: cfe/trunk/test/CodeGenCXX/uncopyable-args.cpp
Author: pcc
Date: Mon Nov 28 16:30:21 2016
New Revision: 288083
URL: http://llvm.org/viewvc/llvm-project?rev=288083&view=rev
Log:
IRGen: Remove all uses of CreateDefaultAlignedLoad.
Differential Revision: https://reviews.llvm.org/D27157
Modified:
cfe/trunk/lib/CodeGen/CGBuilder.h
cfe/tru
Author: pcc
Date: Sun Dec 4 18:02:18 2016
New Revision: 288629
URL: http://llvm.org/viewvc/llvm-project?rev=288629&view=rev
Log:
IRGen: Remove an unused overload of CreateAlignedLoad.
Modified:
cfe/trunk/lib/CodeGen/CGBuilder.h
Modified: cfe/trunk/lib/CodeGen/CGBuilder.h
URL:
http://llvm.o
Author: pcc
Date: Tue Dec 13 14:50:44 2016
New Revision: 289585
URL: http://llvm.org/viewvc/llvm-project?rev=289585&view=rev
Log:
CodeGen: Start using inrange annotations on vtable getelementptr.
This annotation allows the optimizer to split vtable groups, as permitted by
a change to the Itanium
Author: pcc
Date: Tue Dec 13 19:17:59 2016
New Revision: 289621
URL: http://llvm.org/viewvc/llvm-project?rev=289621&view=rev
Log:
LTO: Add support for multi-module bitcode files.
Differential Revision: https://reviews.llvm.org/D27313
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
cfe/tr
Author: pcc
Date: Mon May 1 15:42:32 2017
New Revision: 301832
URL: http://llvm.org/viewvc/llvm-project?rev=301832&view=rev
Log:
Object: Remove ModuleSummaryIndexObjectFile class.
Differential Revision: https://reviews.llvm.org/D32195
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modifie
Author: pcc
Date: Wed May 3 22:36:16 2017
New Revision: 302108
URL: http://llvm.org/viewvc/llvm-project?rev=302108&view=rev
Log:
IR: Use pointers instead of GUIDs to represent edges in the module summary.
NFCI.
When profiling a no-op incremental link of Chromium I found that the functions
compu
Author: pcc
Date: Thu May 4 13:03:25 2017
New Revision: 302176
URL: http://llvm.org/viewvc/llvm-project?rev=302176&view=rev
Log:
Re-apply r302108, "IR: Use pointers instead of GUIDs to represent edges in the
module summary. NFCI."
with a fix for the clang backend.
Modified:
cfe/trunk/lib/Co
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Oct 19, 2016 at 3:38 PM, David Majnemer
wrote:
>
>
> On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: hans
>> Date: Wed Oct 19 13:04:27 2016
>> New Revision: 284624
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=284624&
pcc updated this revision to Diff 75493.
pcc added a comment.
Refresh
https://reviews.llvm.org/D22296
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/CGCXX.cpp
clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/CGVTables.cpp
clang/lib/Code
pcc updated this revision to Diff 75494.
pcc added a comment.
Refresh
https://reviews.llvm.org/D24431
Files:
clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/ItaniumCXXABI.cpp
clang/test/CodeGenCXX/const-init-cxx11.cpp
clang/test/CodeGenCXX/constructor-init.cpp
clang/test/CodeGenCXX/copy
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:934
+ if (CodeGenOpts.SanitizeCfiCrossDso)
+CreateFunctionTypeMetadata(dyn_cast(D), F);
}
It looks like we can get here with declarations that are not of type
`FunctionDecl` (mostly via `
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: pcc
Date: Mon Oct 31 20:18:57 2016
New Revision: 285660
URL: http://llvm.org/viewvc/llvm-project?rev=285660&view=rev
Log:
Bitcode: Simplify BitstreamWriter::EnterBlockInfoBlock() interface.
No block info block should need to define local abbreviations, so we can
always use a code width of
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Tue Nov 1 19:08:19 2016
New Revision: 285773
URL: http://llvm.org/viewvc/llvm-project?rev=285773&view=rev
Log:
Bitcode: Change reader interface to take memory buffers.
As proposed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-October/106595.html
This change also f
Author: pcc
Date: Mon Nov 7 22:17:11 2016
New Revision: 286207
URL: http://llvm.org/viewvc/llvm-project?rev=286207&view=rev
Log:
Bitcode: Decouple block info block state from reader.
As proposed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-October/106630.html
Move block info block
Author: pcc
Date: Tue Nov 8 00:03:43 2016
New Revision: 286214
URL: http://llvm.org/viewvc/llvm-project?rev=286214&view=rev
Log:
IR, Bitcode: Change bitcode reader to no longer own its memory buffer.
Unique ownership is just one possible ownership pattern for the memory buffer
underlying the bit
pcc added a comment.
Ping
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
Ping
https://reviews.llvm.org/D24431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
Seems like a reasonable enough first step. Please add a FIXME to pass these
flags as attributes.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@li
Author: pcc
Date: Fri Nov 11 13:50:39 2016
New Revision: 286624
URL: http://llvm.org/viewvc/llvm-project?rev=286624&view=rev
Log:
Bitcode: Change getModuleSummaryIndex() to return an llvm::Expected.
Differential Revision: https://reviews.llvm.org/D26539
Modified:
cfe/trunk/lib/CodeGen/Backen
pcc added inline comments.
Comment at: include/clang/Driver/Options.td:732
+def fsanitize_thread_memory_access : Flag<["-"],
"fsanitize-thread-memory-access">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enable
pcc added a comment.
Test case?
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
Is it correct to emit a type check at this point? Looking at [0] it l
pcc added a comment.
We normally update the IR tests whenever we change IRgen. If we're missing test
coverage, we should add it before landing this.
https://reviews.llvm.org/D26559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: pcc
Date: Sun Nov 13 01:00:17 2016
New Revision: 286752
URL: http://llvm.org/viewvc/llvm-project?rev=286752&view=rev
Log:
Bitcode: Change module reader functions to return an llvm::Expected.
Differential Revision: https://reviews.llvm.org/D26562
Modified:
cfe/trunk/lib/CodeGen/CGOpen
Author: pcc
Date: Tue Sep 8 18:01:30 2015
New Revision: 247098
URL: http://llvm.org/viewvc/llvm-project?rev=247098&view=rev
Log:
CodeGen: Introduce CodeGenModule::CreateMetadataIdentifierForType.
This function can be used to create a metadata identifier for a specific
type. No functionality chan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247098: CodeGen: Introduce
CodeGenModule::CreateMetadataIdentifierForType. (authored by pcc).
Changed prior to commit:
http://reviews.llvm.org/D12038?vs=32173&id=34276#toc
Repository:
rL LLVM
http:/
Author: pcc
Date: Tue Sep 8 19:01:31 2015
New Revision: 247105
URL: http://llvm.org/viewvc/llvm-project?rev=247105&view=rev
Log:
CodeGen: Add CFI unrelated cast checks to the new pointer code path.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
cfe/trunk/test/CodeGenCXX/cfi-cast.cpp
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247238: CFI: Introduce -fsanitize=cfi-icall flag. (authored
by pcc).
Changed prior to commit:
http://reviews.llvm.org/D11857?vs=33175&id=34403#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11857
Author: pcc
Date: Wed Sep 9 21:17:40 2015
New Revision: 247238
URL: http://llvm.org/viewvc/llvm-project?rev=247238&view=rev
Log:
CFI: Introduce -fsanitize=cfi-icall flag.
This flag causes the compiler to emit bit set entries for functions as well
as runtime bitset checks at indirect call sites.
pcc added inline comments.
Comment at: test/CodeGen/cfi-icall.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall
-fsanitize-trap=cfi-icall -emit-llvm -o - %s | FileCheck --check-prefix=ITANIUM
%s
+// RUN: %clang_cc1 -triple x86_64-pc-windows-msv
Author: pcc
Date: Thu Sep 10 14:18:05 2015
New Revision: 247324
URL: http://llvm.org/viewvc/llvm-project?rev=247324&view=rev
Log:
Driver: Support cfi-icall on all OSs when targeting x86/x86_64.
Modified:
cfe/trunk/lib/Driver/ToolChain.cpp
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/
pcc updated this revision to Diff 31871.
pcc added a comment.
- Create distinct MDNodes for types with internal linkage; replace custom bit
set mangling with mangleTypeName throughout
- Add documentation explaining the difference between this and
-fsanitize=function
http://reviews.llvm.org/D11
pcc added a comment.
> The documentation would probably benefit from some advice about when to use
> each and how they compare.
Added.
Comment at: lib/AST/ItaniumMangle.cpp:4119-4126
@@ +4118,10 @@
+raw_ostream &Out) {
+ if
pcc added a comment.
We should also make blacklists appear in the `--show-includes` output.
Comment at: lib/Frontend/DependencyFile.cpp:416-420
@@ -413,2 +415,7 @@
+ // Add extra dependencies to the end of the list.
+ for (auto ExtraDep : ExtraDeps) {
+AddFilename(ExtraD
pcc added a comment.
> should include the default blacklist (and any explicit blacklists, if they
> were specified)?
Yes, exactly.
Comment at: lib/Frontend/DependencyFile.cpp:416-420
@@ -413,2 +415,7 @@
+ // Add extra dependencies to the end of the list.
+ for (auto Extra
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
pcc added a comment.
You could create a fake resource directory which contains only the
`asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an example
of this kind of thing.
http://reviews.llvm.org/D12021
___
cfe-commits mailing l
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Yes, this can be a separate driver test.
http://reviews.llvm.org/D12021
___
cfe-commits mailing list
cfe-commits@lists
pcc created this revision.
pcc added a reviewer: rsmith.
pcc added subscribers: cfe-commits, Prazek.
This function can be used to create a metadata identifier for a specific
type. No functionality change, but this will be used by D11857 and D12026.
http://reviews.llvm.org/D12038
Files:
lib/Cod
pcc updated this revision to Diff 32179.
pcc added a comment.
Rebase onto http://reviews.llvm.org/D12038
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:3677
@@ +3676,3 @@
+llvm::Metadata *CodeGenModule::CreateMetadataIdentifierForType(QualType T) {
+ llvm::Metadata *&InternalId = MetadataIdMap[T.getCanonicalType()];
+ if (InternalId)
Prazek wr
Can't we just use the --driver-mode flag instead of trying to mangle the
executable name?
Peter
On Thu, Aug 20, 2015 at 09:52:39PM -, Anton Yartsev via cfe-commits wrote:
> Author: ayartsev
> Date: Thu Aug 20 16:52:39 2015
> New Revision: 245621
>
> URL: http://llvm.org/viewvc/llvm-project?r
101 - 200 of 370 matches
Mail list logo
