pcc added inline comments.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:3677
@@ +3676,3 @@
+llvm::Metadata *CodeGenModule::CreateMetadataIdentifierForType(QualType T) {
+  llvm::Metadata *&InternalId = MetadataIdMap[T.getCanonicalType()];
+  if (InternalId)
----------------
Prazek wrote:
> question: so You are storing distinct and normal mdnodes here. Is it faster 
> to grap normal node from this map than to just create new one using get?
Quite possibly (the latter involves string comparisons and possibly memory 
allocation) but they should both have the same complexity so it doesn't matter 
much.


http://reviews.llvm.org/D12038



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to