[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ h

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. In D66035#2175906 , @vchuravy wrote: > In D66035#2175839 , @pmatos wrote: > > > I am interested in continuing this work and have a patch in progress based > > on the current available one h

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos updated this revision to Diff 281154. pmatos added a comment. Initial implementation of reference types in the WebAssembly backend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: .gitlab-ci.

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. Please ignore my `.gitlab-ci.yml`. That's just an internal change that I got uploaded by mistake. I am looking to see this through and start discussion on this with the goal of landing it. At the moment, for example this test crashes: struct { __attribute__((addre

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. There's also this line of work on opaque types that could be potentially interested but seems far from being landed: https://groups.google.com/g/llvm-dev/c/Dw_DYSXGFto/m/OzzK-CkGAwAJ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. Related work: https://reviews.llvm.org/D81977 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos updated this revision to Diff 281540. pmatos added a comment. Update patch to compile against current master branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: .gitlab-ci.yml lld/wasm/

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. I will be splitting the part enabling the target feature through clang into a separate revision as suggested by @tlively Comment at: clang/lib/Basic/Targets/WebAssembly.cpp:43 .Case("exception-handling", HasExceptionHandling) + .Case("refere

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. In D66035#2181659 , @pmatos wrote: > I will be splitting the part enabling the target feature through clang into a > separate revision as suggested by @tlively I just noticed that most of this work landed in an earlier commit: ht

[PATCH] D85022: Need to ensure the datalayout differs when using externref

pmatos created this revision. Herald added subscribers: cfe-commits, jgravelle-google, sbc100, dschuff. Herald added a project: clang. pmatos requested review of this revision. Herald added a subscriber: aheejin. externref needs address space 256. Repository: rG LLVM Github Monorepo https://r

[PATCH] D85022: Need to ensure the datalayout differs when using externref

pmatos abandoned this revision. pmatos added a comment. Mistakingly created - this should have gone to D66035 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85022/new/ https://reviews.llvm.org/D85022 _

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos updated this revision to Diff 282194. pmatos added a comment. Update externref patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basic/Targets/WebAssembly.cpp lld/wasm/Writer

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 10 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/AST/Type.h:1972-1973 + /// Check if this is a WebAssembly Reference Type. + bool isWebAssemblyReferenceType() const; + bool isWebAssemblyExternrefType() const; /// Determ

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:954 10, // wasm_externref, +20, // wasm_funcref }; aaron.ballman wrote: > Where did this value come from? Unsure what you mean here. This is the address space number we a

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. It would be great to get this landed. Can someone pls take a look at it? It's quite independent from the remainder of the work and self-contained. maybe @tlively ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/ne

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. It would be great to get this landed. Can someone pls take a look at it? It's quite independent from the remainder of the work and self-contained. maybe @tlively ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/ne

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. @tlively once D105423 lands, is it enough to test and reland it under this revision or shall i open a new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llv

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 359258. pmatos added a comment. Remove hunks touching LLTs accidentally added before Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/W

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 360055. pmatos added a comment. Rebase on top of main and add non-integral address spaces to emscripten OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: cla

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46667a10039b: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Changed prior to commit: https://review

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos created this revision. pmatos added reviewers: tlively, asb. Herald added subscribers: StephenFan, wingo, dexonsmith, ecnelises, arphaman, martong, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a reviewer: shafik. Herald added a reviewer: aaron.ballman. Herald added a

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos planned changes to this revision. pmatos added a comment. Test `wasm-funcref.c` still fails as type attribute `funcref` semantics are not yet implemented. Not ready to land yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ http

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos updated this revision to Diff 421936. pmatos added a comment. Herald added subscribers: asavonic, jholewinski. Moved the attribute handling to the border between clang and llvm. In the frontend, there's no special handling of address spaces for funcref, but this is added when converting the

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos planned changes to this revision. pmatos added a comment. This still requires some changes, as there are a few unhandled cases where funcref attribute is not handled properly at the edge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 445410. pmatos added a comment. Completely refactored the initial solution to funcref implementation and design. Now it works similarly to the __ptr32 attribute from -fms-extensions. We keep _both_ attribute and address space through the frontend, which is th

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 445490. pmatos added a comment. Updated patch over current main. Fixed all failint tests. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: cl

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 445493. pmatos added a comment. Remove some extraneous spaces I hadn't noticed before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 445524. pmatos added a comment. Cleanedup the code. Ready to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/in

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 446405. pmatos added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 446406. pmatos added a comment. Rebase on top of main. Add missing code in Sema* to ensure the new funcref builtin is checked for. Thanks to @asb for helping fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 446726. pmatos added a comment. Update the patch as there were some missing calls from SemaChecking. Thanks to @asb for spotting it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm

[PATCH] D91428: Add support for multiple program address spaces

pmatos created this revision. pmatos added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jdoerfert, hiraditya, dschuff. Herald added projects: clang, LLVM. pmatos requested review of this revision. Herald added a subscriber: aheejin. Allows for multiple pro

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. This is WIP - there a still a few test failures but I am happy to start getting comments on this. This is in preparation for implementation of reference types for the WebAssembly backend that requires functions to be able to live in multiple address spaces. Repository

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305488. pmatos added a comment. Ensure the program address spaces vector doesn't contain duplicates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files: clang/lib/C

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305521. pmatos added a comment. Fix type check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files: clang/lib/CodeGen/CGException.cpp clang/lib/CodeGen/CodeGenMod

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. The RFC has now been sent to the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146723.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 ___

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. Thanks, @arichardson and @jrtc27 for your comments. I am definitely surprised to find that if you explicitly mark the call with the address space, this patch is not required. At first look, this RFC is not required any more but I need sometime to investigate further. If

[PATCH] D91428: Add support for multiple program address spaces

pmatos abandoned this revision. pmatos added a comment. In D91428#2413292 , @pmatos wrote: > Thanks, @arichardson and @jrtc27 for your comments. > I am definitely surprised to find that if you explicitly mark the call with > the address space, this patch

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 346411. pmatos added a comment. Rebase and update minor details and fix a few lint warnings... Non-functional changes only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D9542

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. @deadalnix @tlively @sbc100 anything missing here to get this landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 ___ cfe-commits mail

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. @tlively thanks for the comments. I am currently taking some time off but I will address your concerns upon my return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 __

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 350599. pmatos added a comment. Fix details requested by @tlively in latest comemnts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/We

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos marked 6 inline comments as done. pmatos added a comment. Hopefully we are close to landing this. :) Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrTable.td:19 [], "table.get\t$res, $table",

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pmatos marked 2 inline comments as done. Closed by commit rG31859f896cf9: Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Repository:

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D95425#2810027 , @DavidSpickett wrote: > Also affecting riscv-v (riscvv?) so I've reverted the change. > > https://lab.llvm.org/buildbot/#/builders/67/builds/3087 Apologies for the breakages and thanks for reverting. I will tak

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos created this revision. pmatos added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. R

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. This patch would have fixed the problems with AArch64 caused by D95425 . However, since that was landed and reverted, this landed: https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b This breaks the test

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a subscriber: reames. pmatos added a comment. Adding @reames to subscribers since he's the author of https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b and might have something to add to the discussion. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2837417 , @tlively wrote: > In D104797#2836475 , @pmatos wrote: > >> @tlively Do you think it would be ok to re-add the code removed in >> `ac81cb7e` but only error if the point

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2838653 , @tlively wrote: > The opaque pointers project is documented here: > https://llvm.org/docs/OpaquePointers.html. It's been making very slow > progress for the past few years but has recently been picking up ste

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 354945. pmatos added a comment. Checks for inttoptr and ptrtoint insts in wasm backend and bails out if necessary. Also addresses @tlively's comments to the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S128

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1138 + +Ops[0] = TableSet; // The new chain is the TableSet itself + } sbc100 wrote: > I was expecting to see a TABLE_SET back to a null after the call here to

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S128

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 355792. pmatos added a comment. Unconditionally set Wasm layout string to include non-integral AS 10 and 20. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: c

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S128

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 355793. pmatos added a comment. Remove FIXME comment on data layout strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/WebAssembl

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 355830. pmatos added a comment. Make the linter happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/WebAssembly.h clang/test/CodeG

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h:69 +if (AS == WasmAddressSpace::EXTERNREF) + return MVT::externref; +else if (AS == WasmAddressSpace::FUNCREF) tlively wrote: > It might be worth a commen

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4facbf213c51: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Repository: rG LLVM Github Monorepo CH

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2854939 , @lebedev.ri wrote: > Reverted again > > > FAIL: LLVM :: CodeGen/WebAssembly/funcref-call.ll (44466 of 44468) > TEST 'LLVM :: CodeGen/WebAssembly/funcref-call.ll'

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. After @arsenm 's commit https://github.com/llvm/llvm-project/commit/990278d026d680942c859be70836ad34a9a716f7, MachineOperands store LLT for size instead of uint64_t and the constructor called from `SelectionDAG::getLoad`, calls `MachineMemOperand` which does: : Machin

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2855322 , @pmatos wrote: > After @arsenm 's commit > https://github.com/llvm/llvm-project/commit/990278d026d680942c859be70836ad34a9a716f7, > MachineOperands store LLT for size instead of uint64_t and the constructor >

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. D105423 implements the required support in LLT of opaque types for this patch to work again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 ___

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 357183. pmatos added a comment. Herald added a subscriber: dexonsmith. Remove some extraneous code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/B

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2864102 , @pmatos wrote: > Remove some extraneous code Argh, sorry. This was meant for another revision and I added code that's not meant for this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 357189. pmatos added a comment. Revert code incorrectly submitted as part of diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/WebA

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 470517. pmatos added a comment. Removed address space wasm_externref which is unnecessary with current design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos planned changes to this revision. pmatos added a comment. Whole integration plan still in the works, so marking as planning changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 470734. pmatos added a comment. Updated this revision on top of D122215 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: cl

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 460696. pmatos marked an inline comment as done. pmatos added a comment. Fix a few of the issues mentioned in the revision comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos planned changes to this revision. pmatos added a comment. Still a few more changes are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 ___ cfe-

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/AST/Type.h:1972-1973 + /// Check if this is a WebAssembly Reference Type. + bool isWebAssemblyReferenceType() const; + bool isWebAssemblyExternrefType() const; /// Determi

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 10 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/AddressSpaces.h:59-60 + wasm_var, + wasm_externref, // This denotes the count of language-specific address spaces and also aaron.ballman wrote: >

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 460706. pmatos marked 4 inline comments as done. pmatos added a comment. Further changes - more to come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 460764. pmatos added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/AddressSpace

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:954 10, // wasm_externref, +20, // wasm_funcref }; aaron.ballman wrote: > pmatos wrote: > > aaron.ballman wrote: > > > Where did

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:952-953 +12, // ptr64 +1, // wasm_var +10, // wasm_externref, }; aaron.ballman wrote: > How did you arrive at these value

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 3 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7332 +def err_attribute_webassembly_funcref : Error< + "'__clang_webassembly_funcref' attribute can only be applied to function pointer types">;

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 461159. pmatos added a comment. Addressed some of the concerns from the comments but not ready for review yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2258 +Width = 0; \ +Align = 8; /* ? */

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 461518. pmatos added a comment. Address further concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos planned changes to this revision. pmatos added a comment. Current patch addresses most of the concerns - also passed through `./clang/tools/clang-format/git-clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://re

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 461544. pmatos added a comment. Address most of the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/include/c

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#4000612 , @MoritzS wrote: > In D122215#3998105 , @pmatos wrote: > >> In D122215#3991648 , @MoritzS >> wrote: >> >>> Thanks for the patc

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 487693. pmatos added a comment. Rebasing on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 487700. pmatos added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/include/clang/Ba

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 487702. pmatos added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 487747. pmatos added a comment. Fix test broken after recent change to opt call. Rebase again on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/i

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. @aaron.ballman Hi Aaron, since you requested an RFC for this. I wonder if you have any comments for this or the other related patches: D122215 , D139010 Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491707. pmatos added a comment. Further tests for use of tables in conditional branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/A

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491784. pmatos added a comment. Simplify and add tests for remaining diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11827 +def err_wasm_builtin_arg_must_be_integer_type : Error < + "%ordinal0 argument must be an integer">; } // end of sema component. ---

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491790. pmatos added a comment. Add missing newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clang/inc

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. @aaron.ballman Thanks for all the comments, I have now finished addressing those. What do you think of the current patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 _

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 493226. pmatos added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 493251. pmatos added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/T

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 493264. pmatos added a comment. Rebase on main and fix a test diagnostic expectation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 493633. pmatos added a comment. Address last comment before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h cl

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb66833d1957: [clang][WebAssembly] Initial support for reference type externref in clang (authored by pmatos). Repository: rG LLVM Github Monorepo

  1   2   3   >