@@ -22,6 +22,12 @@
// RUN: %clang -target armv7-windows -### %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-UNALIGNED-ARM < %t %s
+// RUN: %clang --target=armv6 -### %s 2> %t
+// RUN: FileCheck --check-prefix=CHECK-ALIGNED-ARM < %t %s
+
+// RUN: %clang --target=armv7 -### %s
@@ -305,6 +305,17 @@ X86 Support
Arm and AArch64 Support
^^^
+- ARMv7+ targets now default to allowing unaligned access, except Armv6-M, and
+ Armv8-M without the Main Extension. Baremetal targets should check that the
+ new default will work with their s
ilovepi wrote:
> I would also personally add Armv6 too for consistency, but don't have a
> strong opinion.
I think we should too, but everyone agrees this is a strict improvement, so I'd
prefer to land something now and we can hash out the right thing for ARMv6 as
a follow up. Does that soun
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/82400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -979,6 +980,17 @@ static llvm::Error serializeIndex(ClangDocContext &CDCtx) {
"error creating index file: " +
FileErr.message());
}
+ llvm::SmallString<128> RootPath(CDCtx.OutDirectory);
+ if (llvm
https://github.com/ilovepi commented:
This is almost there. I've left a few minor comments, but I'd like to see
better testing here. I'm awfully surprised we don't need to update any test
lines, other than the 1 JS check. It would really help to see how the output is
changing, if that was capt
@@ -7,6 +7,7 @@
// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Rectangle.html
-check-prefix=HTML-RECTANGLE
// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Circle.html
-check-prefix=HTML-CIRCLE
+// JSON-INDEX: var RootPath = "{{.*}}";
ilove
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,12 +1,19 @@
function genLink(Ref) {
var Path =
`${window.location.protocol}//${window.location.host}/${Ref.Path}`;
+ var isFileProtocol = window.location.protocol.startsWith("file");
+ // we treat the file paths different depending on if we're
+ // serving via a http
@@ -1,12 +1,19 @@
function genLink(Ref) {
var Path =
`${window.location.protocol}//${window.location.host}/${Ref.Path}`;
+ var isFileProtocol = window.location.protocol.startsWith("file");
+ // we treat the file paths different depending on if we're
+ // serving via a http
@@ -80,8 +80,8 @@ function createIndex(Index) {
// Runs after DOM loads
document.addEventListener("DOMContentLoaded", function() {
- // JsonIndex is a variable from another file that contains the index
- // in JSON format
- var Index = JSON.parse(JsonIndex);
- createIndex(
@@ -0,0 +1,7 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
ilovepi wrote:
nit: Can be one line w/ `&&`
https://github.com/llvm/llvm-project/pull/93281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -0,0 +1,7 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "CHECK: var RootPath = \"%t\";" > %t/check.txt
+// RUN: cp "%s" "%t/test.cpp"
ilovepi wrote:
what is this doing? `CHECK` lines belong in the test file, generally. If you
need to split them up som
@@ -0,0 +1,7 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "CHECK: var RootPath = \"%t\";" > %t/check.txt
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --doxygen --executor=standalone -p %t %t/test.cpp
-output=%t/docs
+// RUN: FileCheck %t/check.txt -input-file=%t/doc
@@ -0,0 +1,8 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --doxygen --executor=standalone -p %t %t/test.cpp
-output=../docs
+// RUN: FileCheck %s -input-file=%t/docs/index_json.js
+// RUN: rm -rf %t
+
+// CHECK: var RootPath = "{{.*}}.
@@ -0,0 +1,7 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "CHECK: var RootPath = \"%/t/docs\";" > %t/check.txt
+// RUN: cp "%s" "%t/test.cpp"
ilovepi wrote:
I see you're trying to work around the path inconsistency issues, but that's
just an end-around
@@ -0,0 +1,7 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "CHECK: var RootPath = \"%/t/docs\";" > %t/check.txt
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp
--output=%t/docs
+// RUN: FileCheck %t/check.txt -input-
@@ -0,0 +1,7 @@
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: echo "CHECK: var RootPath = \"%/t/docs\";" > %t/check.txt
+// RUN: cp "%s" "%t/test.cpp"
+// RUN: clang-doc --format=html --executor=standalone -p %t %t/test.cpp
--output=%t/docs
ilovepi wrote:
```sug
@@ -7,6 +7,7 @@
// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Rectangle.html
-check-prefix=HTML-RECTANGLE
// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Circle.html
-check-prefix=HTML-CIRCLE
+// JSON-INDEX: var RootPath = "{{.*}}";
ilove
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/93276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/96921
>From f2251efabbc1a59e87b25285f7173161e6f63d22 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 27 Jun 2024 09:13:01 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/96921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
> I'd use `std::string_view` as a return value instead of `const char *` as a
> more idiomatic C++ in which case you don't need to rename the method to
> `c_str()`.
I opted for `StringRef`, since that seems more in line w/ the conventions here,
but I'm happy to switch to `std::
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/97518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,701 @@
+// RUN: sed 's|$test_dir|%/S|g'
%S/Inputs/advance-project/database_template.json >
%t/build/compile_commands.json
+// RUN: clang-doc --format=html --doxygen --output=%t/docs --executor=all-TUs
%t/build/compile_commands.json
+// RUN: clang-doc --format=md --do
@@ -0,0 +1,701 @@
+// RUN: sed 's|$test_dir|%/S|g'
%S/Inputs/advance-project/database_template.json >
%t/build/compile_commands.json
+// RUN: clang-doc --format=html --doxygen --output=%t/docs --executor=all-TUs
%t/build/compile_commands.json
+// RUN: clang-doc --format=md --do
https://github.com/ilovepi commented:
Thanks for adding more tests. Clang-Doc badly needs more comprehensive test
coverage.
I have a few concerns, however, about the testing strategy. Largely, these
tests seem to check the exact output, rather than spot checking for particular
features. What
@@ -0,0 +1,31 @@
+#include "Array.h"
+
+// Implementation of Array
+
+/**
+* Initializes all elements of the array to their default value.
+*/
+template
+Array::Array() {
+ // Implementation stub
+}
+
+/**
+* Array access operator for Array
+* Provides read and write access to
ilovepi wrote:
seems to fail on windows CI.
https://github.com/llvm/llvm-project/pull/97540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,7 +25,11 @@ set(assets
)
set(asset_dir "${CMAKE_CURRENT_SOURCE_DIR}/../assets")
-set(resource_dir "${CMAKE_BINARY_DIR}/share/clang-doc")
+if(MSVC)
ilovepi wrote:
Doesn't this reflect the compiler and not the build system/project structure?
I'm pretty
@@ -52,4 +56,4 @@ add_custom_target(copy-clang-doc-assets
COMMENT "Copying Clang-Doc Assets"
)
set_target_properties(copy-clang-doc-assets PROPERTIES FOLDER
"Clang-Doc/Assets")
-add_dependencies(clang-doc copy-clang-doc-assets)
+add_dependencies(clang-doc copy-clang-doc-asse
ilovepi wrote:
> > I believe (and the pre-merge testing seems to validate my belief) that this
> > breaks the case where you build with ninja + Visual Studio. Also, I believe
> > the Xcode generator is similar to the Visual Studio generator in that they
> > both are multi-config generators, so
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/97540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -321,7 +321,7 @@ foreach(target
armv6m-unknown-eabi;armv7m-unknown-eabi;armv8m-unknown-eabi)
set(RUNTIMES_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY CACHE
STRING "")
foreach(lang C;CX
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,189 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ilovepi commented:
Overall a good start, but I think we can tighten up the implementation in a few
places, and improve the documentation here quite a bit.
I'd also like to see a somewhat expanded comment block in the header,
describing the overall design of the library. This
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -39,20 +41,27 @@ class Token {
Comment,
};
- Token(std::string Str);
+ Token(StringRef Str);
- Token(std::string Str, char Identifier);
+ Token(StringRef RawBody, StringRef Str, char Identifier);
- std::string getTokenBody() const { return TokenBody; };
+ St
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,189 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,446 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -87,12 +87,13 @@
/// -gcc has lowest priority so -gcc
/// on PATH beats default triple in program path
-// RUN: DEFAULT_TRIPLE=`%t/clang --version | grep "Target:" | cut -d ' ' -f2`
-// RUN: touch %t/$DEFAULT_TRIPLE-gcc && chmod +x %t/$DEFAULT_TRIPLE-gcc
-// RUN: touch %t/%
@@ -87,12 +87,13 @@
/// -gcc has lowest priority so -gcc
/// on PATH beats default triple in program path
-// RUN: DEFAULT_TRIPLE=`%t/clang --version | grep "Target:" | cut -d ' ' -f2`
-// RUN: touch %t/$DEFAULT_TRIPLE-gcc && chmod +x %t/$DEFAULT_TRIPLE-gcc
-// RUN: touch %t/%
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/101108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -632,6 +633,19 @@ static std::unique_ptr genHTML(const CommentInfo
&I) {
return std::move(ParagraphComment);
}
+ if (I.Kind == "BlockCommandComment") {
+auto BlockComment = std::make_unique(HTMLTag::TAG_DIV);
+auto Command = std::make_unique(HTMLTag::TAG_DIV
https://github.com/ilovepi approved this pull request.
LGTM. I left a few minor comments. Feel free to land once those are done and CI
is passing.
https://github.com/llvm/llvm-project/pull/101108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -632,6 +633,19 @@ static std::unique_ptr genHTML(const CommentInfo
&I) {
return std::move(ParagraphComment);
}
+ if (I.Kind == "BlockCommandComment") {
+auto BlockComment = std::make_unique(HTMLTag::TAG_DIV);
+BlockComment->Children.emplace_back(
+st
@@ -59,32 +59,63 @@
// HTML-SHAPE: class Shape
// HTML-SHAPE: Defined at line 8 of file {{.*}}Shape.h
+// HTML-SHAPE: brief
+// HTML-SHAPE: Abstract base class for shapes.
// HTML-SHAPE: Provides a common interface for different types of
shapes.
// HTML-SHAPE: Functions
@@ -59,32 +59,63 @@
// HTML-SHAPE: class Shape
// HTML-SHAPE: Defined at line 8 of file {{.*}}Shape.h
+// HTML-SHAPE: brief
+// HTML-SHAPE: Abstract base class for shapes.
// HTML-SHAPE: Provides a common interface for different types of
shapes.
// HTML-SHAPE: Functions
@@ -632,6 +633,19 @@ static std::unique_ptr genHTML(const CommentInfo
&I) {
return std::move(ParagraphComment);
}
+ if (I.Kind == "BlockCommandComment") {
+auto BlockComment = std::make_unique(HTMLTag::TAG_DIV);
+BlockComment->Children.emplace_back(
+st
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/101255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -431,6 +431,8 @@ struct EnumValueInfo {
// Stores the user-supplied initialization expression for this enumeration
// constant. This will be empty for implicit enumeration values.
SmallString<16> ValueExpr;
+
+ std::vector Description; // Comment description of this f
@@ -372,14 +397,33 @@ genEnumsBlock(const std::vector &Enums,
}
static std::unique_ptr
-genEnumMembersBlock(const llvm::SmallVector &Members) {
+genEnumMembersBlock(const llvm::SmallVector &Members,
+bool HasComments) {
if (Members.empty())
return n
@@ -394,10 +394,20 @@ static void parseEnumerators(EnumInfo &I, const EnumDecl
*D) {
std::string ValueExpr;
if (const Expr *InitExpr = E->getInitExpr())
ValueExpr = getSourceCode(D, InitExpr->getSourceRange());
-
SmallString<16> ValueStr;
E->getInitVal(
@@ -653,15 +697,35 @@ static std::vector>
genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) {
std::vector> Out;
std::string EnumType = I.Scoped ? "enum class " : "enum ";
+ // Determine if enum members have comments attached
+ bool HasComments = false;
+ for (cons
@@ -653,15 +697,35 @@ static std::vector>
genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) {
std::vector> Out;
std::string EnumType = I.Scoped ? "enum class " : "enum ";
+ // Determine if enum members have comments attached
+ bool HasComments = false;
+ for (cons
https://github.com/ilovepi approved this pull request.
LGTM, once that last nit is fixed, assuming CI is passing.
https://github.com/llvm/llvm-project/pull/102647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -87,8 +87,8 @@
/// -gcc has lowest priority so -gcc
/// on PATH beats default triple in program path
-// RUN: DEFAULT_TRIPLE=`%t/clang --version | grep "Target:" | cut -d ' ' -f2`
-// RUN: touch %t/$DEFAULT_TRIPLE-gcc && chmod +x %t/$DEFAULT_TRIPLE-gcc
+// RUN: %clang --ver
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/102647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/101282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -653,22 +695,38 @@ static std::vector>
genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) {
std::vector> Out;
std::string EnumType = I.Scoped ? "enum class " : "enum ";
-
- Out.emplace_back(
- std::make_unique(HTMLTag::TAG_H3, EnumType + I.Name));
- Out.back
@@ -558,15 +568,15 @@ static void populateFunctionInfo(FunctionInfo &I, const
FunctionDecl *D,
static void populateMemberTypeInfo(MemberTypeInfo &I, const FieldDecl *D) {
assert(D && "Expect non-null FieldDecl in populateMemberTypeInfo");
- ASTContext& Context = D->getASTC
https://github.com/ilovepi approved this pull request.
LGTM modulo some minor nits.
https://github.com/llvm/llvm-project/pull/101282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -716,8 +774,8 @@ genHTML(const FunctionInfo &I, const ClangDocContext &CDCtx,
if (!CDCtx.RepositoryUrl)
Out.emplace_back(writeFileDefinition(*I.DefLoc));
else
- Out.emplace_back(writeFileDefinition(
- *I.DefLoc, StringRef{*CDCtx.RepositoryUrl}));
@@ -124,9 +145,37 @@ namespace Vehicles {
// MD-VEHICLES: **brief** specify type of car
// HTML-VEHICLES: namespace Vehicles
-// HTML-VEHICLES: Enums
-// HTML-VEHICLES: enum Car
-// HTML-VEHICLES: Sedan
-// HTML-VEHICLES: SUV
-// HTML-VEHICLES: Pickup
-// HTML-VEHICLES: Hatchb
ilovepi wrote:
Hi, we're seeing a test failure in our x64 linux CI. This was the only commit
in the blame. Can you take a look and revert if it will take a while to fix?
Failing test: LLVM :: tools/llvm-debuginfod-find/cache.test
Bot:
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci
ilovepi wrote:
hmm, it does weirdly seem to be working now. Thanks for taking a look.
@mysterymath you're about the only person I know w/ much knowledge about
debuginfod testing, can you take a look when you get time? It seems like this
could be a flake. If it turns out to be, lets file an i
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/104477
Claim `-c` when using `-S`, so that we don't warn for unused arguments
when they are used together without `-fsyntax-only`.
Fixes #104347
>From 0af4f441447f39df7f496e62f8620d9c8404a5d2 Mon Sep 17 00:00:00 2001
@@ -1,7 +1,14 @@
// RUN: %clang --target=x86_64 -fsyntax-only -E %s 2>&1 | FileCheck %s
--check-prefix=CHECK-PP
// RUN: %clang --target=x86_64 -fsyntax-only -S %s 2>&1 | FileCheck %s
--check-prefix=CHECK-ASM
// RUN: %clang --target=x86_64 -fsyntax-only -c %s 2>&1 | FileCheck
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/104477
>From 0af4f441447f39df7f496e62f8620d9c8404a5d2 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 15 Aug 2024 10:52:13 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/104477
>From 0af4f441447f39df7f496e62f8620d9c8404a5d2 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 15 Aug 2024 10:52:13 -0700
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-
@@ -377,8 +377,10 @@ phases::ID Driver::getFinalPhase(const DerivedArgList &DAL,
// -S only runs up to the backend.
} else if ((PhaseArg = DAL.getLastArg(options::OPT_S))) {
FinalPhase = phases::Backend;
+// Avoid unused argument warnings when combining -S and -c.
+
ilovepi wrote:
Unfortunately, I don't think we have a way to run a patch on post-submit bots
before it lands. I think everyone has been frustrated by that limitation at one
time or another. I usually ask the reporters/bot owners if its possible. If
they're able to help, most contributors are m
@@ -1,370 +1,363 @@
-// RUN: mkdir -p %T/clang-doc/build
-// RUN: mkdir -p %T/clang-doc/include
-// RUN: mkdir -p %T/clang-doc/src
-// RUN: mkdir -p %T/clang-doc/docs
-// RUN: sed 's|$test_dir|%/T/clang-doc|g'
%S/Inputs/clang-doc-project1/database_template.json >
%T/clang-doc/bu
@@ -1,370 +1,363 @@
-// RUN: mkdir -p %T/clang-doc/build
-// RUN: mkdir -p %T/clang-doc/include
-// RUN: mkdir -p %T/clang-doc/src
-// RUN: mkdir -p %T/clang-doc/docs
-// RUN: sed 's|$test_dir|%/T/clang-doc|g'
%S/Inputs/clang-doc-project1/database_template.json >
%T/clang-doc/bu
https://github.com/ilovepi requested changes to this pull request.
Screen shots don't belong in the commit message. Public URLs are often OK for
reference to LLVM source or a standards doc, but do make sure those are
permalinks, and not pointed to somein on say the `main` brnach, which will
ch
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Also, I just noticed that the first comment has an `@` in it. The first comment
in Github is special, as its really the body of the commit message, and will
become that when you hit `Squash and merge`. Your question for @petrhosek may
not even have been sent, as I don't know how
ilovepi wrote:
A few meta comments on the particulars of the commit title and message:
1. Please change the title to only have the [clang-doc] tag. This doesn't
impact `clang` at all. We use the`[tag] Title` convention to make it easy to
understand where the changes are, and what they affect. H
@@ -69,8 +70,15 @@
clang_tidy_headers = os.path.join(
config.test_source_root, "clang-tidy", "checkers", "Inputs", "Headers"
)
+
config.substitutions.append(("%clang_tidy_headers", clang_tidy_headers))
+clang_doc_install = os.path.join(
+os.path.dirname(shutil.which(
@@ -69,8 +70,15 @@
clang_tidy_headers = os.path.join(
config.test_source_root, "clang-tidy", "checkers", "Inputs", "Headers"
)
+
config.substitutions.append(("%clang_tidy_headers", clang_tidy_headers))
+clang_doc_install = os.path.join(
+os.path.dirname(shutil.which(
https://github.com/ilovepi commented:
All of the changes related to allowing a different path belong in their own PR,
or if they're invasive, perhaps multiple PRs.
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commit
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -131,6 +135,12 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+inline bool ends_with(std::string const & value, std::string const & ending)
+{
+if (ending.size() > value.size()) return
@@ -186,19 +196,36 @@ Example usage for a project using a compile commands
database:
std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr);
llvm::SmallString<128> NativeClangDocPath;
llvm::sys::path::native(ClangDocPath, NativeClangDocPath);
-llvm::Sm
@@ -186,19 +196,36 @@ Example usage for a project using a compile commands
database:
std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr);
llvm::SmallString<128> NativeClangDocPath;
llvm::sys::path::native(ClangDocPath, NativeClangDocPath);
-llvm::Sm
ilovepi wrote:
Also, the current PR only has tests for the HTML output. Please file separate
bugs for the other formats, and be sure to follow up with more tests for those
formats.
https://github.com/llvm/llvm-project/pull/93928
___
cfe-commits maili
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
+ for (auto DirIt = llvm::sys::fs::direct
@@ -131,12 +137,55 @@ std::string GetExecutablePath(const char *Argv0, void
*MainAddr) {
return llvm::sys::fs::getMainExecutable(Argv0, MainAddr);
}
+void GetAssetFiles(clang::doc::ClangDocContext &CDCtx) {
+ std::error_code Code;
ilovepi wrote:
nit: I'd
201 - 300 of 1351 matches
Mail list logo
