https://github.com/ilovepi commented:
Overall a good start, but I think we can tighten up the implementation in a few places, and improve the documentation here quite a bit. I'd also like to see a somewhat expanded comment block in the header, describing the overall design of the library. This is a pattern you'll see a lot in LLVM, and its usually appreciated. https://github.com/llvm/llvm-project/pull/105893 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
