[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added inline comments. Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46 template -struct __is_trivially_equality_comparable +struct __libcpp_is_trivially_equality_comparable : integral_constant philnik wrote: > > Mordante wrote: > > > This does

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

philnik added a comment. In D141775#4256381 , @royjacobson wrote: > In D141775#4255923 , @philnik wrote: > >> Is this essentially "is_trivial_for_the_purposes_of_abi"? > > I'd say so. Are you asking for a potenti

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

This revision was automatically updated to reflect the committed changes. Closed by commit rGe98776a180a7: [clang] Add __is_trivially_equality_comparable (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://review

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows types to be considered trivially equality comparable if a de

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: dschuff. Herald added a project: All. philnik requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This attribute is equivalent

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik added a comment. If anybody has a better name for this I'm all ears. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ https://reviews.llvm.org/D151625 ___ cfe-commits mailing list cfe-co

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added subscribers: wlei, wenlei, jdoerfert, dmgreen. Herald added a project: All. philnik requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits, jplehr, sstefan1, MaskRay. Hera

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; Should this also get an extension warning/sho

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

philnik added a comment. In D151623#4380760 , @erichkeane wrote: > Is this a builtin that is supposed to model something in the standard? It > isn't clear to me how this one is supposed to work. No, this is for optimization purposes. It is true when i

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4c4c777308: [clang] Extend __is_trivially_equality_comparable to check for hidden friends (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik added a comment. In D151625#4380735 , @erichkeane wrote: > I'm a little dense today perhaps, but I don't get the use case for this? Can > you ELI-EWG? Is this an attribute we expect our users to use? The name is > horrifyingly long for users

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4380877 , @erichkeane wrote: > What is the justification for this? What exactly are you asking for? Why I'd like to back port it? This would make quite a bit of code in libc++ simpler and avoids pit-falls where an at

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik updated this revision to Diff 527704. philnik marked 2 inline comments as done. philnik added a comment. Herald added a subscriber: jdoerfert. - Address comments - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ http

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

philnik created this revision. philnik added reviewers: erichkeane, aaron.ballman. Herald added subscribers: luke, steakhal, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

philnik added a comment. In D143670#4116118 , @cor3ntin wrote: > Thanks for doing this Aaron. > Did you look in libc++ if they used it anywhere? (I assume they don't) I'm not aware of any uses, and I would be quite surprised if it was used anywhere give

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134887 , @erichkeane wrote: > Looks like I have ot abandon this now? Anyway, fix was committed, but I > forgot the differential-revision line. You can also Close the revision instead of abandoning it to make it obv

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134894 , @erichkeane wrote: > In D144192#4134893 , @philnik wrote: > >> In D144192#4134887 , @erichkeane >> wrote: >> >>> Looks like

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134902 , @erichkeane wrote: > In D144192#4134900 , @philnik wrote: > >> In D144192#4134894 , @erichkeane >> wrote: >> >>> In D144192

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

philnik added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1448 +def Assume : StmtAttr { + let Spellings = [CXX11<"", "assume", 202302>]; + let Documentation = [AssumeDocs]; Izaron wrote: > Honestly I don't have a clue what these numbers `2023

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

philnik added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1448 +def Assume : StmtAttr { + let Spellings = [CXX11<"", "assume", 202302>]; + let Documentation = [AssumeDocs]; tahonermann wrote: > philnik wrote: > > Izaron wrote: > > > Honestly

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. The emitted warnings from the libc++ CI look like a false-positive to me. While the functions are never called, they are used in an unevaluated context. I would expect `-Wunused` warnings to only be emitted when I can just remove the code without problems, which doesn't

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. In D143524#4148024 , @v.g.vassilev wrote: > In D143524#4148006 , @philnik wrote: > >> The emitted warnings from the libc++ CI look like a false-positive to me. >> While the functions are

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. It warns that the deduction guide is unused, but the deduction guide is required suppress `-Wctad-maybe-unsupported`. https://godbolt.org/z/G8bMjYsbn Repository: rC Clang CHANGES SINCE LAST

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. In D143524#4148344 , @v.g.vassilev wrote: > In D143524#4148271 , @philnik wrote: > >> It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. >> It warns that the ded

[PATCH] D150072: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150072 Files: c

[PATCH] D150072: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG465d48748131: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types (authored by philnik). Repository: rG LLVM Github Mo

[PATCH] D150321: [clang] Document extensions from later standards

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150321 Files: c

[PATCH] D150321: [clang] Document extensions from later standards

philnik added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1386 +Relaxed constexpr __cpp_constexpr C++14 C++11 +Designated initializers __cpp_designated_initializersC++20 C++03 +Attributes on e

[PATCH] D150321: [clang] Document extensions from later standards

philnik updated this revision to Diff 521375. philnik marked 5 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150321/new/ https://reviews.llvm.org/D150321 Files: clang/docs/Langua

[PATCH] D150321: [clang] Document extensions from later standards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. philnik marked an inline comment as done. Closed by commit rGb09fad7f8e9c: [clang] Document extensions from later standards (authored by philnik). Changed prior to com

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

philnik added a comment. I have to say I'm not really convinced this change is a good idea. The cases it flags don't really seem in any way ambiguous/erroneous. In D147844#4286364 , @chaitanyav wrote: > @aaron.ballman please take a look. > > I filed a

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

philnik added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:46 - if (lang_opts.CPlusPlus2b) { attributes.emplace_back("assume"); You probably want to `#ifdef` this based on Clang 16/17. Repository: rG LLVM Gith

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

philnik added a comment. In D149573#4310009 , @codemzs wrote: > My change to libcxxabi/test/test_demangle.pass.cpp (last file in the change) > is only one line i.e {"_ZNK5clang4Type16isArithmeticTypeERNS_10ASTContextE", > "clang::Type::isArithmeticType(

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

philnik removed a reviewer: libc++abi. philnik added a comment. In D149573#433 , @codemzs wrote: > In D149573#4310601 , @philnik wrote: > >> In D149573#4310009 , @code

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

philnik added a comment. https://github.com/llvm/llvm-project/issues/60709 seems also pretty scary to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cf

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:732 def UninitializedConstReference : DiagGroup<"uninitialized-const-reference">; +def UninitializedArrayElements : DiagGroup<"uninitialized-array-elements">; def Uninitialized : DiagGroup

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Comment at: clang/test/Parser/cxx-decl.cpp:316 #if __cplusplus >= 201103L -// expected-error@+3 {{expected}} +// expected-error@+2 {{expected}} // expected-error@-3 {{expected ';' after top level declarator}} aaron.ballman wrote:

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 411600. philnik marked an inline comment as done. philnik added a comment. - Fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNot

[PATCH] D120814: [clang-tidy] Add check to perfer pre-increment over post-increment

philnik created this revision. philnik added reviewers: aaron.ballman, JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. R

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. In D114425#3209794 , @craig.topper wrote: > What does the builtin due if __int128 isn't supported? Even though the type > isn't legal the builtin can still be called with a narrower type that would > be implicitly converted. Do

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. In D114425#3216233 , @xbolva00 wrote: > int num = …; > > __builtin_bswap64(num); // works, no error > __builtin_bswap128(num); // should work as well > > Highly likely this case works already with ur patch, so it would be great to

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 396960. philnik added a comment. - Rebased - Error if `__int128` is not supported Should it be tested that the compiler errors when calling `__builtin_bswap128` with __int128 not available? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 397866. philnik marked 3 inline comments as done. philnik added a comment. - Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/Re

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a subscriber: rsmith. philnik added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 395316. philnik added a comment. Is that enough or do you want something more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 395319. philnik added a comment. Added constexpr test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 395338. philnik added a comment. Guarding test now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Bu

<    1   2