philnik removed a reviewer: libc++abi. philnik added a comment. In D149573#4311113 <https://reviews.llvm.org/D149573#4311113>, @codemzs wrote:
> In D149573#4310601 <https://reviews.llvm.org/D149573#4310601>, @philnik wrote: > >> In D149573#4310009 <https://reviews.llvm.org/D149573#4310009>, @codemzs >> wrote: >> >>> My change to libcxxabi/test/test_demangle.pass.cpp (last file in the >>> change) is only one line i.e >>> {"_ZNK5clang4Type16isArithmeticTypeERNS_10ASTContextE", >>> "clang::Type::isArithmeticType(clang::ASTContext&) const"}, but running >>> clang-format on it changes bunch of lines. >> >> Please don't clang-format the test then. There is no need to do it, and the >> changes look rather confusing. I don't really understand why you add it at >> all TBH. This doesn't look like it tests anything from this patch. > > @philnik Thank you for your feedback on the changes to > `libcxxabi/test/test_demangle.pass.cpp`. I apologize for any confusion my > initial approach may have caused. I intended to keep the test file consistent > with the updated function prototype, but I understand your concern about > clang-format's impact on readability. > > I will revert the changes to the test file as you suggested, ensuring it does > not affect the current patch's functionality. I appreciate your guidance and > will consider these aspects in future updates. No worries :D. The clang-format guidelines are a bit confusing, and there is nothing wrong with not knowing all the conventions of the different subprojects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
