@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
nicovank wrote:
Sync with
[ClangTidyMain.cpp](https://github.com/llvm/llvm-project/blob/d36836de0183b9b1939cc679d153e3b313e55c76/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp#L57-L58)?
https://github.com/llvm/llvm-project/blob/d36836de0183b9b1939cc679d153e3b313e55c76/clang-tools-extra/cla
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Vicente Mataix =?utf-8?q?Ferrándiz?= ,
Vicente Mataix =?utf-8?q?Ferrándiz?= ,
Vicente Mataix =?utf-8?q?Ferrándiz?=
Message-ID:
In-Reply-To:
@@ -446,6 +448,12 @@ async def main() -> None:
action="store_true",
help="Allow empty enabled checks.",
)
+pars
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank approved this pull request.
LGTM, thanks!!
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -128,7 +128,12 @@ Changes in existing checks
` check by providing additional
examples and fixing some macro related false positives.
-- Improved :doc:`performance/unnecessary-value-param
+- Improved :doc:`modernize-use-starts-ends-with
+ ` check by adding more
+ match
https://github.com/nicovank approved this pull request.
I saw you have a pending commit access request -- I'll just let you merge this
when you are able to.
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@list
nicovank wrote:
The main changes are here.
https://github.com/llvm/llvm-project/pull/133756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -172,7 +172,7 @@ void test(std::string s, std::string_view sv, sub_string
ss, sub_sub_string sss,
0 != s.compare(0, sv.length(), sv);
// CHECK-MESSAGES: :[[@LINE-1]]:{{[0-9]+}}: warning: use starts_with
- // CHECK-FIXES: s.starts_with(sv);
+ // CHECK-FIXES: !s.starts
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/133140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 79484e3802c16ca2f5d3e8c46b2f8895ce580795 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 13:33:10 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
@@ -245,15 +246,15 @@ def check_no_diagnosis(self, clang_tidy_output: str) ->
None:
def check_fixes(self) -> None:
if self.has_check_fixes:
-try_run(
-[
-"FileCheck",
-"-input-file=" + self.temp_f
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 79484e3802c16ca2f5d3e8c46b2f8895ce580795 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 13:33:10 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nicovank wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
-auto Filter = [Filters](llvm::StringRef Path) {
+auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
nicovank wrote:
Line 520: th
@@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
-auto Filter = [Filters](llvm::StringRef Path) {
+auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
for (auto &Regex : *Filters)
--
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/133140
I'm looking to make some changes in this file, start by typing it.
```
> python3 -m mypy --strict clang-tools-extra/test/clang-tidy/check_clang_tidy.py
Success: no issues found in 1 source file
```
>From ba5
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 48bb3c79069c9bad5ee01865058a155368586b2e Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:28:56 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 48bb3c79069c9bad5ee01865058a155368586b2e Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:28:56 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
@@ -48,15 +48,16 @@
import re
import subprocess
import sys
+from typing import List, Tuple
nicovank wrote:
`list` and `tuple` are Python 3.9: https://peps.python.org/pep-0585/
LLVM minimum Python version is 3.8 for now:
https://github.com/llvm/llvm-project/bl
@@ -71,12 +72,12 @@ def try_run(args, raise_error=True):
# This class represents the appearance of a message prefix in a file.
class MessagePrefix:
-def __init__(self, label):
+def __init__(self, label: str):
nicovank wrote:
Good catch, thank you, I a
@@ -71,12 +72,13 @@ def try_run(args, raise_error=True):
# This class represents the appearance of a message prefix in a file.
class MessagePrefix:
-def __init__(self, label):
+
nicovank wrote:
Note that this space is "on purpose", the formatter wants it
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 6d0068c97341a93ee116878599c13e429082b0a8 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:35:05 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/133140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 6d0068c97341a93ee116878599c13e429082b0a8 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:35:05 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 4df359ed712486c9fc94f1296474cdb06715 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 15:16:32 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 4df359ed712486c9fc94f1296474cdb06715 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 15:16:32 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/133756
See Discourse post here:
https://discourse.llvm.org/t/rfc-using-match-full-lines-in-clang-tidy-tests/85553
I've added `--match-partial-fixes` to all tests that were failing, unless I
noticed the fix was quick
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 3f332176331ff0da2413eae0db9e7f9ce816bbd1 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Apr 2025 13:51:59 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-wh
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 3f332176331ff0da2413eae0db9e7f9ce816bbd1 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Apr 2025 13:51:59 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-wh
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/133756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 446 of 446 matches
Mail list logo