[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,785 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,785 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,785 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,114 @@ +//===--- Mustache.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,114 @@ +//===--- Mustache.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,114 @@ +//===--- Mustache.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] fix incorrect argument names in documentation for ExtraArgs and ExtraArgsBefore (PR #120963)

nicovank wrote: Sync with [ClangTidyMain.cpp](https://github.com/llvm/llvm-project/blob/d36836de0183b9b1939cc679d153e3b313e55c76/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp#L57-L58)? https://github.com/llvm/llvm-project/blob/d36836de0183b9b1939cc679d153e3b313e55c76/clang-tools-extra/cla

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,785 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add support for `-ignore-insert-conflict` in `run-clang-tidy.py` (PR #127066)

Vicente Mataix =?utf-8?q?Ferrándiz?= , Vicente Mataix =?utf-8?q?Ferrándiz?= , Vicente Mataix =?utf-8?q?Ferrándiz?= Message-ID: In-Reply-To: @@ -446,6 +448,12 @@ async def main() -> None: action="store_true", help="Allow empty enabled checks.", ) +pars

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/133756 See Discourse post here: https://discourse.llvm.org/t/rfc-using-match-full-lines-in-clang-tidy-tests/85553 I've added `--match-partial-fixes` to all tests that were failing, unless I noticed the fix was quick

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/133140 I'm looking to make some changes in this file, start by typing it. ``` > python3 -m mypy --strict clang-tools-extra/test/clang-tidy/check_clang_tidy.py Success: no issues found in 1 source file ``` >From ba5

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133140 >From 48bb3c79069c9bad5ee01865058a155368586b2e Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 27 Mar 2025 13:28:56 -0400 Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133140 >From 48bb3c79069c9bad5ee01865058a155368586b2e Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 27 Mar 2025 13:28:56 -0400 Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

@@ -48,15 +48,16 @@ import re import subprocess import sys +from typing import List, Tuple nicovank wrote: `list` and `tuple` are Python 3.9: https://peps.python.org/pep-0585/ LLVM minimum Python version is 3.8 for now: https://github.com/llvm/llvm-project/bl

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

@@ -71,12 +72,12 @@ def try_run(args, raise_error=True): # This class represents the appearance of a message prefix in a file. class MessagePrefix: -def __init__(self, label): +def __init__(self, label: str): nicovank wrote: Good catch, thank you, I a

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

@@ -71,12 +72,13 @@ def try_run(args, raise_error=True): # This class represents the appearance of a message prefix in a file. class MessagePrefix: -def __init__(self, label): + nicovank wrote: Note that this space is "on purpose", the formatter wants it

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133140 >From 6d0068c97341a93ee116878599c13e429082b0a8 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 27 Mar 2025 13:35:05 -0400 Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/133140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133140 >From 6d0068c97341a93ee116878599c13e429082b0a8 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 27 Mar 2025 13:35:05 -0400 Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/133756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133756 >From 4df359ed712486c9fc94f1296474cdb06715 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon, 31 Mar 2025 15:16:32 -0400 Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of --strict-w

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133756 >From 4df359ed712486c9fc94f1296474cdb06715 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon, 31 Mar 2025 15:16:32 -0400 Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of --strict-w

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133756 >From 3f332176331ff0da2413eae0db9e7f9ce816bbd1 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon, 7 Apr 2025 13:51:59 -0400 Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of --strict-wh

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133756 >From 3f332176331ff0da2413eae0db9e7f9ce816bbd1 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon, 7 Apr 2025 13:51:59 -0400 Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of --strict-wh

[clang-tools-extra] [NFC][clang-tidy] Remove {{^}} clauses in some tests (3/N) (PR #135826)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/135826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][clang-tidy] Remove {{^}} clauses in some tests (2/N) (PR #135824)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/135824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

nicovank wrote: > But it might not be a `UnaryOperator`, no? `unaryOperator(...).bind("op")` implies `op` will always be a `UnaryOperator`. https://github.com/llvm/llvm-project/pull/138283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang-tools-extra] [NFC][clang-tidy] Remove {{^}} clauses in some tests (3/N) (PR #135826)

https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/135826 `check_clang_tidy` now matches full lines only, so `{{^}}` clauses are no longer necessary. I am splitting those changes over multiple PRs to make review easier. Numbering them but the actual order doesn't m

[clang-tools-extra] [clang-tidy][NFC][doc] fix typos in docs. (PR #138305)

https://github.com/nicovank approved this pull request. https://github.com/llvm/llvm-project/pull/138305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

https://github.com/nicovank requested changes to this pull request. This is not needed IMO. This is a simple matcher, `op` is expected to always be bound. One might say that it can't hurt to add extra checks, but I don't think that's good justification for adding more code / bloat, even if in

[clang-tools-extra] [clang-tidy] 'modernize-use-starts-ends-with': fixed false positives on `find` and `rfind` (PR #129564)

https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/129564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] 'modernize-use-starts-ends-with': fixed false positives on `find` and `rfind` (PR #129564)

https://github.com/nicovank approved this pull request. LGTM, thanks!! https://github.com/llvm/llvm-project/pull/129564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] 'modernize-use-starts-ends-with': fixed false positives on `find` and `rfind` (PR #129564)

@@ -128,7 +128,12 @@ Changes in existing checks ` check by providing additional examples and fixing some macro related false positives. -- Improved :doc:`performance/unnecessary-value-param +- Improved :doc:`modernize-use-starts-ends-with + ` check by adding more + match

[clang-tools-extra] [clang-tidy] 'modernize-use-starts-ends-with': fixed false positives on `find` and `rfind` (PR #129564)

https://github.com/nicovank approved this pull request. I saw you have a pending commit access request -- I'll just let you merge this when you are able to. https://github.com/llvm/llvm-project/pull/129564 ___ cfe-commits mailing list cfe-commits@list

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

nicovank wrote: The main changes are here. https://github.com/llvm/llvm-project/pull/133756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

@@ -172,7 +172,7 @@ void test(std::string s, std::string_view sv, sub_string ss, sub_sub_string sss, 0 != s.compare(0, sv.length(), sv); // CHECK-MESSAGES: :[[@LINE-1]]:{{[0-9]+}}: warning: use starts_with - // CHECK-FIXES: s.starts_with(sv); + // CHECK-FIXES: !s.starts

[clang-tools-extra] [NFC][clang-tidy] Add type annotations to check_clang_tidy (PR #133140)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/133140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133756 >From 79484e3802c16ca2f5d3e8c46b2f8895ce580795 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon, 31 Mar 2025 13:33:10 -0400 Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of --strict-w

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

@@ -245,15 +246,15 @@ def check_no_diagnosis(self, clang_tidy_output: str) -> None: def check_fixes(self) -> None: if self.has_check_fixes: -try_run( -[ -"FileCheck", -"-input-file=" + self.temp_f

[clang-tools-extra] [clang-tidy] Use --match-full-lines instead of --strict-whitespace in check_clang_tidy (PR #133756)

https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/133756 >From 79484e3802c16ca2f5d3e8c46b2f8895ce580795 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon, 31 Mar 2025 13:33:10 -0400 Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of --strict-w

[clang-tools-extra] [clang-tidy] 'modernize-use-starts-ends-with': fixed false positives on `find` and `rfind` (PR #129564)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/129564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] 'modernize-use-starts-ends-with': fixed false positives on `find` and `rfind` (PR #129564)

nicovank wrote: Thanks! https://github.com/llvm/llvm-project/pull/129564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

@@ -535,7 +535,7 @@ struct FragmentCompiler { } if (Filters->empty()) return std::nullopt; -auto Filter = [Filters](llvm::StringRef Path) { +auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) { nicovank wrote: Line 520: th

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

@@ -535,7 +535,7 @@ struct FragmentCompiler { } if (Filters->empty()) return std::nullopt; -auto Filter = [Filters](llvm::StringRef Path) { +auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) { for (auto &Regex : *Filters) --

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/139307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

https://github.com/nicovank approved this pull request. https://github.com/llvm/llvm-project/pull/139307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

nicovank wrote: Thank you! https://github.com/llvm/llvm-project/pull/139307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CLANGD] [NFC] Fix proposed by sanitizer. (PR #140116)

https://github.com/nicovank approved this pull request. LGTM! AFAICT in this case this won't make an immediate performance difference since fields in this struct are primitives, but may in the future if the struct changes. This probably won't trigger [performance-move-const-arg](https://clang

[clang-tools-extra] [clang-tidy][NFC] Refactor `modernize-use-trailing-return-type-check` check code and tests (PR #140759)

@@ -28,7 +27,7 @@ struct ClassifiedToken { class UseTrailingReturnTypeCheck : public ClangTidyCheck { public: UseTrailingReturnTypeCheck(StringRef Name, ClangTidyContext *Context) - : ClangTidyCheck(Name, Context) {} + : ClangTidyCheck(Name, Context) {}; ---

[clang-tools-extra] [clang-tidy][NFC] Refactor `modernize-use-trailing-return-type-check` check code and tests (PR #140759)

https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/140759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Refactor `modernize-use-trailing-return-type-check` check code and tests (PR #140759)

@@ -39,23 +38,6 @@ class UseTrailingReturnTypeCheck : public ClangTidyCheck { private: Preprocessor *PP = nullptr; nicovank wrote: Is this field still needed now? https://github.com/llvm/llvm-project/pull/140759

<    1   2   3   4   5