https://github.com/nicovank requested changes to this pull request.

This is not needed IMO. This is a simple matcher, `op` is expected to always be 
bound.

One might say that it can't hurt to add extra checks, but I don't think that's 
good justification for adding more code / bloat, even if in this case it's a 
single line. Still, 5% more code for this check counting non-empty non-comment 
lines!

Happy to disagree if any of the maintainers think otherwise.

https://github.com/llvm/llvm-project/pull/138283
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to