thakis added a comment.
After some more debugging, the only thing in this test that's still faiilng on
Windows is the "unsigned-integer-overflow:do_overflow" suppression -- when
llvm-symbolizer gets symbols from PDBs it currently requires the DIA SDK. If
that's not found at cmake time, then llv
thakis created this revision.
thakis added a reviewer: aaron.ballman.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D16394
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.c
thakis created this revision.
thakis added reviewers: rsmith, klimek.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer.
RecursiveASTVisitor used to not visit them, so that they didn't show up in
thakis updated this revision to Diff 45551.
thakis added a comment.
fix test name
http://reviews.llvm.org/D16413
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: include/clang/AST/RecursiveASTVisitor.h
=
Author: nico
Date: Thu Jan 21 11:56:24 2016
New Revision: 258415
URL: http://llvm.org/viewvc/llvm-project?rev=258415&view=rev
Log:
Add an isVirtualAsWritten AST matcher.
http://reviews.llvm.org/D16394
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatche
thakis closed this revision.
thakis added a comment.
r258415, thanks!
http://reviews.llvm.org/D16394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov wrote:
>
> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>
>> thakis added a comment.
>>
>> After some more debugging, the only thing in this test that's still
>> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
>> suppressi
On Thu, Jan 21, 2016 at 1:44 PM, Alexey Samsonov wrote:
>
> On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
>
>> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
>> wrote:
>>
>>>
>>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber
>>> wrote:
>>>
thakis added a comment.
After so
Author: nico
Date: Fri Jan 22 08:12:44 2016
New Revision: 258500
URL: http://llvm.org/viewvc/llvm-project?rev=258500&view=rev
Log:
Replace some tabs with spaces.
Modified:
cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp
Modified: cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cp
thakis closed this revision.
thakis added a comment.
r258503, thanks! (with the extra test)
http://reviews.llvm.org/D16413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Fri Jan 22 09:11:54 2016
New Revision: 258503
URL: http://llvm.org/viewvc/llvm-project?rev=258503&view=rev
Log:
Let RecursiveASTVisitor visit array index VarDecls
An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer.
RecursiveASTVisitor used to not visit
Author: nico
Date: Fri Jan 22 09:49:53 2016
New Revision: 258505
URL: http://llvm.org/viewvc/llvm-project?rev=258505&view=rev
Log:
Try to pacify MSVC.
I'm not sure why it needs these braces, but they help locally.
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Modified: cfe/tru
Fun fact: cl.exe refuses to compile this program:
#include
void f(std::vector v) {
for (int i : v)
do {} while(false);
}
¯\_(ツ)_/¯
On Fri, Jan 22, 2016 at 10:49 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Fri Jan 22 09:49:5
thakis created this revision.
thakis added reviewers: rsmith, rnk.
thakis added a subscriber: cfe-commits.
Herald added subscribers: aemerson, klimek.
RecursiveASTVisitor::TraverseFunctionHelper() traverses a function's
ParmVarDecls by going to the function's getTypeSourceInfo if it exists, and `
Is it possible to emit some -Wmicrosoft warning in cases where this is
necessary?
On Fri, Jan 22, 2016 at 2:26 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Fri Jan 22 13:26:44 2016
> New Revision: 258530
>
> URL: http://llvm.org/viewvc/llvm-projec
Every time we accept something in MS mode that isn't standards compliant,
we should accept it with a warning (for stuff that's harmless, an Extension
warning, for stuff that can lead to bugs a Warning warning), unless it's
really hard to implement.
(See also
https://docs.google.com/presentation/d/
I implemented Reid's suggestion in 258545. I tested that the test runs and
passes when the DIA SDK is around (this is usually the case), and doesn't
run when it isn't.
On Thu, Jan 21, 2016 at 2:09 PM, Alexey Samsonov wrote:
> On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
>
>> On Thu, J
thakis added a subscriber: thakis.
thakis added a comment.
(This is http://llvm.org/PR20796, which has some discussion and test cases. If
you haven't, maybe you want to look at the test cases there. It's possible
they're a subset of your test though.)
http://reviews.llvm.org/D16533
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
libstdc++ is using `= default` instead of `{}` for more and more of its
container classes, because they think DR 253 should be accepted
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60284). Sin
Since it isn't a -### test, the test probably just needs a `// REQUIRES:
x86-registered-target`? Is adding -### a possibility?
On Mon, Jan 25, 2016 at 8:51 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Mon Jan 25 19:51:47 2016
> New Revision: 25877
Author: nico
Date: Thu Jan 28 12:06:31 2016
New Revision: 259063
URL: http://llvm.org/viewvc/llvm-project?rev=259063&view=rev
Log:
Fix strange indent.
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib
Author: nico
Date: Thu Jan 28 13:12:32 2016
New Revision: 259077
URL: http://llvm.org/viewvc/llvm-project?rev=259077&view=rev
Log:
Remove unused parameter.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/
Author: nico
Date: Thu Jan 28 13:25:00 2016
New Revision: 259079
URL: http://llvm.org/viewvc/llvm-project?rev=259079&view=rev
Log:
Include RecordDecls from anonymous unions in the AST.
For
void f() {
union { int i; };
}
clang used to omit the RecordDecl from the anonymous union from the
thakis added a comment.
rnk, I added you because you hacked in this general area a while ago in
r187528. Since Richard is out, do you think you can take a look?
http://reviews.llvm.org/D16478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
thakis added a comment.
In http://reviews.llvm.org/D16478#338653, @rnk wrote:
> The fact that an instantiated type might point to decls from the template
> pattern seems like expected behavior. The parts of the template that are the
> same are supposed to be shared.
>
> Can we dig in to what is
thakis added a comment.
Did this ever land? Looks like it's lgtm'd and ready to go, and it looks like a
useful warning.
http://reviews.llvm.org/D3976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Exactly :-)
On Thu, Jan 28, 2016 at 5:07 PM, Yaron Keren wrote:
> The instantiated does get a new collection of ParmVarDecls while getting
> the pattern Type which points to the pattern ParmVarDecls. So the
> ParmVarDecls pointed in the instantiated are not the same as those pointed
> by its Typ
Shouldn't the new case be in -Wc++11-narrowing instead? This is warning in
similar places where that warning used to warn.
In practice, char arrays seem to be often used for storing binary blobs in
header files, and those are usually initialized with numbers 0...255
instead of -128...127 (why not
Should this be a per-style default? It still only doesn't break webkit
files only by accident, right?
On Mon, Nov 16, 2015 at 10:35 AM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> !!!
>
> Awesome :)
>
> -eric
>
> On Mon, Nov 16, 2015 at 4:41 AM Daniel Jasper via cf
i.e. should SortIncludes be false for -style=WebKit for now?
On Mon, Nov 16, 2015 at 11:19 AM, Nico Weber wrote:
> Should this be a per-style default? It still only doesn't break webkit
> files only by accident, right?
>
> On Mon, Nov 16, 2015 at 10:35 AM, Eric Christopher via cfe-commits <
> cf
thakis added a comment.
Looks good. The reasoning is that without this, projects will put in an `#if
__clang__ no tzcnt` path (e.g.
http://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183408.html), and with
this patch they won't and in a few years when people use build flags that allow
BMI
On Tue, Nov 17, 2015 at 11:32 AM, Craig Topper
wrote:
> craig.topper added a subscriber: craig.topper.
> craig.topper added a comment.
>
> The summary of why this is ok is slightly misleading.
I read this as reason why programs might try to use this, not why this
change here is correct. (This c
This used to build and now doesn't:
std::map, std::allocator>> m;
Maybe the static assert text could say something slightly more friendly
that hints at the pair's first entry having to be const? This is probably
difficult to figure out unless you know this already.
(Real-life version:
https://
Author: nico
Date: Wed Dec 2 20:25:26 2015
New Revision: 254579
URL: http://llvm.org/viewvc/llvm-project?rev=254579&view=rev
Log:
Fix a comment typo from r251874.
Modified:
cfe/trunk/lib/Sema/SemaObjCProperty.cpp
Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp
URL:
http://llvm.org/viewvc
Author: nico
Date: Thu Dec 3 09:40:23 2015
New Revision: 254612
URL: http://llvm.org/viewvc/llvm-project?rev=254612&view=rev
Log:
Make check-clang depend on LTO.
r249143 added test/Driver/darwin-ld-lto.c which requires libLTO.dylib
to pass, but when running `ninja check-clang` in a fresh build d
Author: nico
Date: Thu Dec 3 11:44:51 2015
New Revision: 254622
URL: http://llvm.org/viewvc/llvm-project?rev=254622&view=rev
Log:
Fix Objective-C metadata for properties from class extensions after r251874
After, properties from class extensions no longer show up in
ObjCInterfaceDecl::properties
thakis added a subscriber: thakis.
Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:401
@@ -411,1 +400,3 @@
+.Case("limited", CodeGenOptions::LimitedDebugInfo)
+.Case("standalone", CodeGenOptions::FullDebugInfo));
}
This lets cc
Author: nico
Date: Fri Dec 4 13:14:14 2015
New Revision: 254750
URL: http://llvm.org/viewvc/llvm-project?rev=254750&view=rev
Log:
Fix debug info for Objective-C properties from class extensions after r251874
After r251874, properties from class extensions no longer show up in
ObjCInterfaceDecl::
Author: nico
Date: Fri Dec 4 13:35:45 2015
New Revision: 254754
URL: http://llvm.org/viewvc/llvm-project?rev=254754&view=rev
Log:
Small follow-up to 254750 to get the test added there passing...
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
There's no way to make a flag alias to two flags, so add a /WCL4 flag that maps
to the All, Extra diag groups.
Fixes PR25563.
http://reviews.llvm.org/D15350
Files:
docs/UsersManual.rst
incl
thakis abandoned this revision.
thakis added a comment.
Forgot to add cfe-commits. I'll abandon this and send it out again.
http://reviews.llvm.org/D15349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: nico
Date: Fri Dec 11 16:31:16 2015
New Revision: 255382
URL: http://llvm.org/viewvc/llvm-project?rev=255382&view=rev
Log:
[clang-cl] Let /W4 map to -Wall -Wextra instead of just -Wall.
There's no way to make a flag alias to two flags, so add a /WCL4 flag that
maps to the All, Extra diag
thakis closed this revision.
thakis added a comment.
r255382, thanks!
http://reviews.llvm.org/D15350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
the attached patch changes
delete called on 'dnvd::B' that has virtual functions but non-virtual
destructor
to
delete called on non-final 'dnvd::B' that has virtual functions but
non-virtual destructor
I'm not sure if it should only do this for c++11 and newer – the new
message is true
ply
> the possibility of 'final' being used to fix the issue.
>
test.cc:1:9: warning: 'final' keyword is a C++11 extension
[-Wc++11-extensions]
class C final {};
^
>
> On Sun, Dec 13, 2015 at 1:37 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llv
age%202/logs/stdio
>
> Maybe that's an indication that users don't really want /W4 to go to
> -Wextra?
>
> On Fri, Dec 11, 2015 at 2:31 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nico
>> Date: Fri Dec 11 16:3
Author: nico
Date: Tue Dec 15 11:07:16 2015
New Revision: 255655
URL: http://llvm.org/viewvc/llvm-project?rev=255655&view=rev
Log:
clang-cl: Add an alias for /wd4100
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include
d-parameter errors.
>>
>> http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/5103/steps/build%20stage%202/logs/stdio
>>
>> Maybe that's an indication that users don't really want /W4 to go to
>> -Wextra?
>>
>> On Fri, Dec 11, 2015 at 2
rs/clang-x86-win2008-selfhost/builds/5103/steps/build%20stage%202/logs/stdio
>>>
>>> Maybe that's an indication that users don't really want /W4 to go to
>>> -Wextra?
>>>
>>> On Fri, Dec 11, 2015 at 2:31 PM, Nico Weber via cfe-commits <
>>&
Author: nico
Date: Wed Dec 16 14:07:24 2015
New Revision: 255812
URL: http://llvm.org/viewvc/llvm-project?rev=255812&view=rev
Log:
Let -Wdelete-non-virtual-dtor mention final.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/test/SemaCXX/destructor.cpp
Modified: c
ally relevant/correct to
>>> imply the possibility of 'final' being used to fix the issue.
>>>
>>
>> test.cc:1:9: warning: 'final' keyword is a C++11 extension
>> [-Wc++11-extensions]
>> class C final {};
>> ^
>>
Author: nico
Date: Tue Dec 22 16:30:14 2015
New Revision: 256286
URL: http://llvm.org/viewvc/llvm-project?rev=256286&view=rev
Log:
Make wasm-toolchain.c test pass on Windows.
Modified:
cfe/trunk/test/Driver/wasm-toolchain.c
Modified: cfe/trunk/test/Driver/wasm-toolchain.c
URL:
http://llvm.o
This might have broken the test on Windows:
Command 1 Stderr:
C:\src\chrome\src\third_party\llvm\tools\clang\test\Driver\wasm-toolchain.c:3:13:
error: expected string not found in in
put
// AS_LINK: lld" "-flavor" "ld" "[[temp]]" "-o" "a.out"
^
:5:476: note: scanning from here
"C:/src
Author: nico
Date: Tue Dec 22 16:42:56 2015
New Revision: 256288
URL: http://llvm.org/viewvc/llvm-project?rev=256288&view=rev
Log:
Disable include sorting by default for Chromium style.
Include sorting generally can break .cc files, especially on Windows. Make
this opt-in for Chromium style to g
Well yes, but we have a Windows bot on http://lab.llvm.org:8011/console,
right?
On Tue, Dec 22, 2015 at 5:54 PM, Dan Gohman wrote:
> It appears the reason it was only caught on Windows was that only Windows
> appends ".exe" to executable files. Your change to match lld with {{.*}}
> appended fix
thakis added a subscriber: thakis.
Comment at: compiler-rt/trunk/test/ubsan/TestCases/Integer/suppressions.cpp:1
@@ +1,2 @@
+// RUN: %clangxx -fsanitize=integer -g0 %s -o %t
+
This test fails on Windows. I tried to debug, but the usual way to run tests
seems to n
thakis added a comment.
Here's the error (I still don't know how to run single tests through lit,
though):
C:\src\chrome\src\third_party\llvm-bootstrap>env
UBSAN_OPTIONS=halt_on_error=1:suppressions="C:\src\chrome\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\
thakis added a comment.
It's because FlagParser::is_space() considers ':' as a space, so it thinks c:\
ends after the c and then starts parsing another flag at the \.
Fix ideas: Don't treat : as space while in quotes, or use ; as separator on
Windows.
Repository:
rL LLVM
http://reviews.llv
thakis added a comment.
And this in turn is because env strips the quotes:
C:\src\chrome\src\third_party\llvm-bootstrap>env
UBSAN_OPTIONS=halt_on_error=1:suppressions="C:\src\chrome\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\suppress
thakis added a comment.
I've looked at it some, and couldn't find a way of escaping quotes that lit
doesn't strip but that ubsan accepts.
'"c:\foo"' gets its quotes stripped by lit, so does """c:\foo""". \"c:\foo\"
confuses lit enough that it tries to call lit.util.warning() which doesn't
exis
t;>
>>> http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/5103/steps/build%20stage%202/logs/stdio
>>>
>>> Maybe that's an indication that users don't really want /W4 to go to
>>> -Wextra?
>>>
>>> On Fri, Dec 11, 2015 at
nico wrote:
Is this causing these crashes? http://45.33.8.238/linux/130945/step_7.txt
https://github.com/llvm/llvm-project/pull/71098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
This seems to break check-clang: http://45.33.8.238/linux/131051/step_7.txt
https://github.com/llvm/llvm-project/pull/82037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
nico wrote:
The test is failing at least on my bot:
http://45.33.8.238/linux/131314/step_7.txt
I'm guessing this is some unicode/sed thing? It's a pretty vanilla linux
machine.
(It uses a non-standard non-supported build system, but at least from a
distance that looks unrelated?)
https://gi
nico wrote:
Also failing here https://lab.llvm.org/buildbot/#/builders/259/builds/126 and
here https://lab.llvm.org/buildbot/#/builders/139/builds/59858
Given that the bots have been broken for a few hours now, I'll revert.
https://github.com/llvm/llvm-project/pull/82298
__
Author: Nico Weber
Date: 2024-02-20T20:24:32-05:00
New Revision: 84ed55e11f8d8f434395f869a1caa8485dd0c187
URL:
https://github.com/llvm/llvm-project/commit/84ed55e11f8d8f434395f869a1caa8485dd0c187
DIFF:
https://github.com/llvm/llvm-project/commit/84ed55e11f8d8f434395f869a1caa8485dd0c187.diff
LO
nico wrote:
Wow, that clang/lib/Headers/yvals_core.h hacks is gross, I love it :D
lgtm, and good to land provided you do a quick re-check to confirm that this
doesn't tank compile times now with that part included. Thanks!
https://github.com/llvm/llvm-project/pull/75711
___
nico wrote:
> Somehow `clang.exe -Ofast -O2 -### -Werror
> C:\src\llvm-project\clang\test\Driver\Ofast.c 2>&1` is not producing any
> output for you, despite `-###` being present. I'm not sure why, but all
> windows buildbots seem to be happy with this patch. Can you investigate
> further?
F
nico wrote:
…passing `Wno-msvc-not-found` as suggested above would also make the test go.
But `-c` seems generally nicer here anyways?
https://github.com/llvm/llvm-project/pull/98736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
Author: Nico Weber
Date: 2024-09-06T08:27:41-04:00
New Revision: 5cf3677a7bcdf5a9e603c054bd40c1282db984a9
URL:
https://github.com/llvm/llvm-project/commit/5cf3677a7bcdf5a9e603c054bd40c1282db984a9
DIFF:
https://github.com/llvm/llvm-project/commit/5cf3677a7bcdf5a9e603c054bd40c1282db984a9.diff
LO
nico wrote:
I made that change in 5cf3677a7bcdf5a9e603c054bd40c1282db984a9.
https://github.com/llvm/llvm-project/pull/98736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
I don't have a very strong opinion. I find it surprising in that the clang
driver is supposed to be gcc-compatible, and having to use `clang
-fstrict-aliasing` (but only when targeting Windows) to get the default
behavior looks a bit surprising.
(I agree it's a better default, but
nico wrote:
For this patch here, I don't know if gcc even has a `fms-volatile`. If not,
this here seems less surprising to me than the strict aliasing patch.
https://github.com/llvm/llvm-project/pull/107509
___
cfe-commits mailing list
cfe-commits@lis
Author: Nico Weber
Date: 2024-09-06T09:17:45-04:00
New Revision: c64dac2e6c39f0f7f1c676857e7d34c764b4d632
URL:
https://github.com/llvm/llvm-project/commit/c64dac2e6c39f0f7f1c676857e7d34c764b4d632
DIFF:
https://github.com/llvm/llvm-project/commit/c64dac2e6c39f0f7f1c676857e7d34c764b4d632.diff
LO
nico wrote:
(To be clear, I'm fine with landing this.)
> non conforming two phase lookup by default would also be a concern.
It is! There were quite a few discussions around this. Aha, see #42377.
We usually say the goal is to have a very standards compliant impl, while also
being able to par
nico wrote:
Any chance to put these behind a subgroup? This now fires in a bunch of places
where it didn't before.
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/nico created https://github.com/llvm/llvm-project/pull/94762
For `using std::literals`, we now output:
error: using declaration cannot refer to a namespace
4 | using std::literals;
| ~^
note: did you mean 'using namespace'?
4 |
https://github.com/nico updated https://github.com/llvm/llvm-project/pull/94762
>From 2cbc9f7e066066ffb04480be6bd7e19855086b80 Mon Sep 17 00:00:00 2001
From: Nico Weber
Date: Fri, 7 Jun 2024 11:17:29 -0400
Subject: [PATCH 1/2] [clang] Add fixit for using declaration with a
(qualified) namespace
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/94762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nico Weber
Date: 2024-06-11T14:00:24-04:00
New Revision: 9b4f8acf9dd1cd517f923c6de8274eed80879f6c
URL:
https://github.com/llvm/llvm-project/commit/9b4f8acf9dd1cd517f923c6de8274eed80879f6c
DIFF:
https://github.com/llvm/llvm-project/commit/9b4f8acf9dd1cd517f923c6de8274eed80879f6c.diff
LO
nico wrote:
This causes #95451.
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Can you add something like "use /O2 /clang:-O2 to restore the previous
behavior" to the commit message, on case someone prefers that?
Otherwise LG.
https://github.com/llvm/llvm-project/pull/95406
___
cfe-commits mailing list
cfe-commits@l
nico wrote:
Oh, you have that in the release notes already, even better.
https://github.com/llvm/llvm-project/pull/95406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nico approved this pull request.
https://github.com/llvm/llvm-project/pull/95406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nico created https://github.com/llvm/llvm-project/pull/95546
At least on my Windows machine, these two tests fail due to not being able to
look up `??3@YAXPEAX_K@Z` (which is
`void __cdecl operator delete(void *, unsigned __int64)` in demangled) after
130e93cc26ca. Since they
nico wrote:
Merging to green up tests on a bot. Happy to address post-commit comments in a
follow-up 🙂
https://github.com/llvm/llvm-project/pull/95546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/95546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Looks Like this might break tests: http://45.33.8.238/linux/141118/step_7.txt
Please take a look and revert for now if it takes a while to fix.
https://github.com/llvm/llvm-project/pull/94717
___
cfe-commits mailing list
cfe-commits@lists.
nico wrote:
Looks like breaks check-clang on macOS:
http://45.33.8.238/macm1/83520/step_6.txt
Please take a look and revert for now if it takes a while to fix.
https://github.com/llvm/llvm-project/pull/88101
___
cfe-commits mailing list
cfe-commits@l
nico wrote:
Oh, I think it's just the old ` clang: warning:
'/Users/thakis/src/llvm-project/clang/test/Driver/windows-seh-async-verify.cpp'
treated as the '/U' option [-Wslash-u-filename]`. I'll try pushing a fix.
https://github.com/llvm/llvm-project/pull/88101
Author: Nico Weber
Date: 2024-04-16T08:33:25-04:00
New Revision: e272c37934a06cd80b9b072afc09afae5fd8c218
URL:
https://github.com/llvm/llvm-project/commit/e272c37934a06cd80b9b072afc09afae5fd8c218
DIFF:
https://github.com/llvm/llvm-project/commit/e272c37934a06cd80b9b072afc09afae5fd8c218.diff
LO
nico wrote:
e272c37934a06cd80b9b072afc09afae5fd8c218 might have fixed this. (Didn't test
locally, will check what the bot says.)
https://github.com/llvm/llvm-project/pull/88101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
nico wrote:
Looks like this breaks check-clang on mac:
http://45.33.8.238/macm1/83529/step_6.txt
Please take a look and revert for now if it takes a while to fix.
https://github.com/llvm/llvm-project/pull/83124
___
cfe-commits mailing list
cfe-commit
nico wrote:
Yes, #83124 broke it in the meantime 😅
https://github.com/llvm/llvm-project/pull/88101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,5 +1,5 @@
-// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
-// Issue no: 41441
+// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm
-o - %s | FileCheck %s
+
#include
nico wrote:
Thanks!
https://git
@@ -656,19 +656,29 @@ std::string ToolChain::getCompilerRT(const ArgList &Args,
StringRef Component,
// Check for runtime files in the new layout without the architecture first.
std::string CRTBasename =
buildCompilerRTBasename(Args, Component, Type, /*AddArch=*/fals
https://github.com/nico created https://github.com/llvm/llvm-project/pull/89642
…ries
For ASan, users already manually have to pass in the path to the lib, and for
other libraries they have to pass in the path to the libpath.
With LLVM's unreliable name of the lib (due to
LLVM_ENABLE_PER_TARGE
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/89642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/89642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -656,19 +656,29 @@ std::string ToolChain::getCompilerRT(const ArgList &Args,
StringRef Component,
// Check for runtime files in the new layout without the architecture first.
std::string CRTBasename =
buildCompilerRTBasename(Args, Component, Type, /*AddArch=*/fals
1401 - 1500 of 1693 matches
Mail list logo
