thakis created this revision.
thakis added a reviewer: djasper.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
clang accepts both #include and #import for includes (the latter having an
implicit header guard). Let clang-format interleave both types if
--sort-includes
thakis added inline comments.
Comment at: lib/Format/Format.cpp:1735
@@ -1734,3 +1734,3 @@
llvm::Regex IncludeRegex(
- R"(^[\t\ ]*#[\t\ ]*include[^"<]*(["<][^">]*[">]))");
+ R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))");
SmallVector Matches;
thakis closed this revision.
thakis added a comment.
Landed in r250706 (with rewrapped lines). Thanks!
http://reviews.llvm.org/D13852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Mon Oct 19 11:21:29 2015
New Revision: 250706
URL: http://llvm.org/viewvc/llvm-project?rev=250706&view=rev
Log:
clang-format: Use pipes instead of temporary files for most lit tests.
This makes the format tests look more like most other FileCheck tests in clang.
The multiple-i
On Mon, Oct 19, 2015 at 4:24 AM, Daniel Jasper wrote:
> Hm, seems to me that this is broken either way. If config.h remains first,
> that is good, but the main #include is unlikely to remain second.
>
In practice, the first two lines are a block with two includes: config.h
first and the main hea
thakis added a comment.
djasper: Ping :-)
http://reviews.llvm.org/D13853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Oct 21 12:13:45 2015
New Revision: 250909
URL: http://llvm.org/viewvc/llvm-project?rev=250909&view=rev
Log:
clang-format: Teach --sort-includes to interleave #include and #import.
clang accepts both #include and #import for includes (the latter having an
implicit header gua
thakis closed this revision.
thakis added a comment.
r250909, thanks!
http://reviews.llvm.org/D13853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
1. Make the warning more strict in C mode. r172696 added code to suppress
warnings from macro expansions in system headers, which checks
`SourceMgr.isMacroBodyExpansion(E->IgnoreParens()->getEx
thakis added a comment.
Sorry about all the emails, I didn't realize that editing the description would
send an update every time. Looks like phab's markup language doesn't support
code blocks in lists (https://secure.phabricator.com/T4939). The description
looks ok in email but broken on phab.
thakis added a reviewer: rnk.
thakis added a comment.
rnk: Can you look at this if Richard is still away doing committee thing?
http://reviews.llvm.org/D13969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: nico
Date: Tue Oct 27 14:47:40 2015
New Revision: 251441
URL: http://llvm.org/viewvc/llvm-project?rev=251441&view=rev
Log:
Tweak how -Wunused-value interacts with macros
1. Make the warning more strict in C mode. r172696 added code to suppress
warnings from macro expansions in system h
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
Done and landed in r251441, thanks!
http://reviews.llvm.org/D13969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: nico
Date: Thu Oct 29 15:43:31 2015
New Revision: 251650
URL: http://llvm.org/viewvc/llvm-project?rev=251650&view=rev
Log:
Suppress uninteresting output from crash-recovery-modules.m
No behavior change, but it makes this test a bit easier to debug when it fails.
Modified:
cfe/trunk/t
Author: nico
Date: Thu Oct 29 15:53:49 2015
New Revision: 251653
URL: http://llvm.org/viewvc/llvm-project?rev=251653&view=rev
Log:
Mark InternalDebugOpt driver options as CoreOptions.
Mostly has the effect of making -ccc-print-phases usable from clang-cl.
Modified:
cfe/trunk/include/clang/Dr
I think we more commonly say "function pointer":
$ grep 'pointer-to-function' include/clang/Basic/Diagnostic*td | wc -l
3
$ grep 'function pointer' include/clang/Basic/Diagnostic*td | wc -l
7
For "object pointer" and "pointer-to-object" it's currently a tie. For
"member pointer" and
On Sun, Nov 1, 2015 at 12:01 AM, James Dennett
wrote:
> On Sat, Oct 31, 2015 at 5:50 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> I think we more commonly say "function pointer":
>>
>> $ grep 'pointer-to-fun
On Fri, Oct 30, 2015 at 5:55 PM, John McCall wrote:
> > On Oct 30, 2015, at 5:39 PM, Nico Weber wrote:
> > Hi John,
> >
> > this breaks programs that use __weak and target 10.6, like so:
> >
> > $ cat test.m
> > #import
> > @interface I : NSObject {
> > __weak NSObject* foo_;
> > }
> > - (NSO
On Mon, Nov 2, 2015 at 3:00 PM, John McCall wrote:
> On Nov 2, 2015, at 2:53 PM, Nico Weber wrote:
> On Fri, Oct 30, 2015 at 5:55 PM, John McCall wrote:
>
>> > On Oct 30, 2015, at 5:39 PM, Nico Weber wrote:
>> > Hi John,
>> >
>> > this breaks programs that use __weak and target 10.6, like so:
I played with modules a bit today, and as far as I can tell this is still
broken. If this proves difficult to fix, should this change be reverted for
now? It breaks using modules on Darwin.
On Sun, Mar 13, 2016 at 12:53 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> > On
On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote:
> Sorry, I was supposed to chime in here.
>
> I don't have a strong opinion on this, but I don't think it's a
> problem for us to allow the -gline-tables-only spelling in addition to
> /Zd.
>
> It just doesn't seem like a big deal to me.
>
Do
Hi Erik,
with this change clangs warns on this program:
$ cat test.mm
#import
@interface AXPlatformNodeCocoa : NSObject
@end
@implementation AXPlatformNodeCocoa
- (NSArray*)accessibilityAttributeNames {
NSArray* const kTextfieldAttributes = @[
NSAccessibilityPlaceholderValueAttribute,
];
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks for the quick fix!
https://reviews.llvm.org/D23024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ler from implicit
>>>> instantiation of this method and thus from instantiation of the static
>>>> field as well.
>>>>
>>>> If encapsulation is not an aim, moving template definition into header
>>>> seems to be more natural solutio
Since this flag is new in 3.9, should we merge this there?
On Tue, Aug 9, 2016 at 1:23 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Tue Aug 9 12:23:56 2016
> New Revision: 278139
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278139&view=rev
> Lo
thakis updated this revision to Diff 46577.
thakis added a comment.
just return true
http://reviews.llvm.org/D16478
Files:
lib/Sema/SemaTemplateInstantiate.cpp
Index: lib/Sema/SemaTemplateInstantiate.cpp
===
--- lib/Sema/SemaTem
thakis marked an inline comment as done.
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:1519-1521
@@ -1518,5 +1518,5 @@
TypeLoc TL = T->getTypeLoc().IgnoreParens();
if (!TL.getAs())
return false;
Ack.
http://reviews.llvm.org/D16478
__
thakis updated this revision to Diff 46578.
thakis added a comment.
restore accidentally dropped test
http://reviews.llvm.org/D16478
Files:
lib/Sema/SemaTemplateInstantiate.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTest.cpp
==
Author: nico
Date: Mon Feb 1 16:31:51 2016
New Revision: 259428
URL: http://llvm.org/viewvc/llvm-project?rev=259428&view=rev
Log:
Always build a new TypeSourceInfo for function templates with parameters
RecursiveASTVisitor::TraverseFunctionHelper() traverses a function's
ParmVarDecls by going to
thakis closed this revision.
thakis added a comment.
r259428, thanks! Went with the for-each loop but left the structure as-is -- I
find the comments helpful and it's not clear where they should go else.
http://reviews.llvm.org/D16478
___
cfe-commi
thakis added a comment.
Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to
understand this patch, and I couldn't find anything in that patch that enables
this extension only in Microsoft mode. Trying suppressed-comma-msextension.cpp
locally, it seems to pass without -f
thakis added a subscriber: thakis.
thakis added a comment.
Out of interest, what is this needed for? System headers?
http://reviews.llvm.org/D16770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Thanks!
Maybe it's interesting if I list the instances where this fired in Chromium.
* libwebp calls _mm_set1_epi16(33050) (but then is careful to only use
unsigned intrinsics with this). There's no version of this function that
takes unsigned short, so the only thing to change here was to add a
thakis added a comment.
Thanks for jumping on this so quickly! Hans can probably just stamp this, but I
lack the background, so I must ask:
Comment at: test/SemaCXX/dllimport.cpp:1262
@@ -1261,1 +1261,3 @@
+struct __declspec(dllimport) PR26506_test1 {
+ virtual ~PR26506_test
http://lab.llvm.org:8011/builders/clang-sphinx-docs is still broken:
http://lab.llvm.org:8011/builders/clang-sphinx-docs
FAILED: cd
/home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/build/tools/clang/docs
&& /usr/bin/sphinx-build -b html -d
/home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/build
Author: nico
Date: Sun Feb 7 15:00:17 2016
New Revision: 260056
URL: http://llvm.org/viewvc/llvm-project?rev=260056&view=rev
Log:
Disable failing nozlibcompress.c
This test hasn't been running after it was added until r259976 made
"REQUIRES: nozlib" work, and now that the test runs it fails.
Mo
Author: nico
Date: Sun Feb 7 15:32:17 2016
New Revision: 260058
URL: http://llvm.org/viewvc/llvm-project?rev=260058&view=rev
Log:
Make nozlibcompress.c pass and reenable it.
Modified:
cfe/trunk/test/Driver/nozlibcompress.c
Modified: cfe/trunk/test/Driver/nozlibcompress.c
URL:
http://llvm.o
thakis added a comment.
Cool, lgtm. Maybe we'll have to downgrade this to a warning eventually since cl
allows it, but for now let's see how this goes.
Comment at: test/SemaCXX/dllimport.cpp:1269
@@ +1268,3 @@
+ virtual ~PR26506_test2() {}
+ constexpr PR26506_test2() {} // ex
thakis added a comment.
ping :-)
http://reviews.llvm.org/D16552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
Will do, thanks! In "If the implicit default constructor initializes all
subobjects, no initializer should be required", is "initializes all subobjects
meant recursively? I.e. is this ok according to that language?
`
struct Inner {
Inner() = default;
int i;
Author: nico
Date: Mon Feb 8 16:23:09 2016
New Revision: 260159
URL: http://llvm.org/viewvc/llvm-project?rev=260159&view=rev
Log:
Make ParentMap work with explicit specializations of function templates.
For an explicit specialization, we first build a FunctionDecl, and then
we call SubstDecl() o
Author: nico
Date: Tue Feb 16 13:05:50 2016
New Revision: 260990
URL: http://llvm.org/viewvc/llvm-project?rev=260990&view=rev
Log:
clang-cl: Expose -isystem.
Like cl.exe, clang-cl allows adding system include directories via the
INCLUDE env var. Having a driver flag for this functionality is use
thakis updated this revision to Diff 48107.
thakis added a comment.
Checkpointing; not production quality. I tried implementing the general DR 253
rule, and this patch mostly does that. It currently walks all fields and all
bases for every const record decl; there should probably be a cache for
thakis updated this revision to Diff 48115.
thakis added a comment.
Ok, that was just a bug. Now all libstdc++5.3 cases I tried build. Still not
production-quality, but the overall direction won't change. If you want to
comment on that, please do, else I'll ping this again after I've cleaned it
thakis added a comment.
Nice!
Comment at: include/clang/Basic/DiagnosticGroups.td:294
@@ -293,2 +293,3 @@
def SelTypeCast : DiagGroup<"cast-of-sel-type">;
+def CastCallingConvention : DiagGroup<"cast-calling-convention">;
def FunctionDefInObjCContainer : DiagGroup<"function-de
thakis updated this revision to Diff 48248.
thakis added a comment.
Ok, now cleaned up and caches the "is this ok?" state on a per-record level.
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Seri
thakis added inline comments.
Comment at: include/clang/AST/DeclCXX.h:410
@@ +409,3 @@
+};
+unsigned AllowConstDefaultInit : 3;
+AllowConstDefInitKind allowConstDefInitKind() {
This should be :2 of course.
http://reviews.llvm.org/D16552
__
thakis created this revision.
thakis added a reviewer: kcc.
thakis added a subscriber: cfe-commits.
http://reviews.llvm.org/D17397
Files:
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize-coverage.c
Index: test/Driver/fsanitize-coverage.c
thakis updated this revision to Diff 48373.
thakis marked an inline comment as done.
thakis added a comment.
address comments
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReader
thakis added a comment.
thanks!
Comment at: include/clang/AST/DeclCXX.h:405-416
@@ -404,1 +404,14 @@
+enum AllowConstDefInitKind {
+ ACDI_Unknown,
+ ACDI_Yes,
+ ACDI_No,
+};
+unsigned AllowConstDefaultInit : 3;
+AllowConstDefInitKind allowCons
thakis added inline comments.
Comment at: lib/AST/DeclCXX.cpp:403-413
@@ +402,13 @@
+ for (const auto *F : fields()) {
+if (F->hasInClassInitializer() || F->isMutable() || F->isUnnamedBitfield())
+ continue;
+if (CXXRecordDecl *FieldType = F->getType()->getAsCXXRecor
thakis updated this revision to Diff 48376.
thakis added a comment.
update test
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReaderDecl.cpp
lib/Serialization/ASTWriter.cpp
t
Author: nico
Date: Thu Feb 18 13:32:54 2016
New Revision: 261247
URL: http://llvm.org/viewvc/llvm-project?rev=261247&view=rev
Log:
Make deprecation message for -fsanitize-coverage= with numeric argument
friendlier.
http://reviews.llvm.org/D17397
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.
thakis closed this revision.
thakis added a comment.
261247
http://reviews.llvm.org/D17397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis updated this revision to Diff 48418.
thakis added a comment.
Thanks! All done.
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReaderDecl.cpp
lib/Serialization/ASTWriter.c
Author: nico
Date: Thu Feb 18 19:49:39 2016
New Revision: 261295
URL: http://llvm.org/viewvc/llvm-project?rev=261295&view=rev
Log:
Update cxx_dr_status.html with today's cwg_index.html.
Created by:
cd www
curl -O http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html
./make_cxx_dr_status
Mod
thakis closed this revision.
thakis added a comment.
Thanks! Landed the cxx_dr_status.html update in r261295 and this change in
r261297.
http://reviews.llvm.org/D16552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: nico
Date: Thu Feb 18 19:52:46 2016
New Revision: 261297
URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev
Log:
Implement the likely resolution of core issue 253.
C++11 requires const objects to have a user-provided constructor, even for
classes without any fields. DR 253 relax
Author: nico
Date: Thu Feb 18 20:51:07 2016
New Revision: 261301
URL: http://llvm.org/viewvc/llvm-project?rev=261301&view=rev
Log:
Fix SemaTemplate/instantiate-field.cpp after r261297.
For templates, fields can have incomplete types:
template
struct A2 {
struct B;
B b;
};
Don't t
nmez via cfe-commits
> wrote:
> > On Fri, Feb 19, 2016 at 3:52 AM, Nico Weber via cfe-commits
> > wrote:
> >> Author: nico
> >> Date: Thu Feb 18 19:52:46 2016
> >> New Revision: 261297
> >>
> >> URL: http://llvm.org/viewvc/llvm-pro
On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Thu Feb 18 19:52:46 2016
> > New Revision: 261297
> >
> >
On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith
wrote:
> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:
> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
> > wrote:
> >>
> >> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
gt;>
>> >> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
>> >> wrote:
>> >> > Author: nico
>> >> > Date: Thu Feb 18 19:52:46 2016
>> >> > New Revision: 261297
>> >> >
>> >> > URL: http:
eb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
>>> > wrote:
>>> >>
>>> >> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
>>> >> wrote:
>>> >> > Author: nico
>>> >> > Date: Thu Feb
Author: nico
Date: Tue Feb 23 13:30:43 2016
New Revision: 261674
URL: http://llvm.org/viewvc/llvm-project?rev=261674&view=rev
Log:
Rename Action::begin() to Action::input_begin().
Also introduce inputs() that reutnrs an llvm::iterator_range.
Iterating over A->inputs() is much less mysterious than
On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nico
>> Date: Tue Feb 23 13:30:43 2016
On Tue, Feb 23, 2016 at 3:55 PM, David Blaikie wrote:
>
>
> On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote:
>
>> On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>>
>>>
>>&g
PM, Richard Smith
> >>> wrote:
> >>>>
> >>>> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber
> wrote:
> >>>> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
> >>>> > wrote:
> >>>> >&
Author: nico
Date: Wed Feb 24 14:58:14 2016
New Revision: 261770
URL: http://llvm.org/viewvc/llvm-project?rev=261770&view=rev
Log:
Fix rejects-valid caused by r261297.
r261297 called hasUserProvidedDefaultConstructor() to check if defining a
const object is ok. This is incorrect for this example
, 2016 at 10:32 PM, Nico Weber
> >> > wrote:
> >> >>
> >> >> On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber
> >> >> wrote:
> >> >>>
> >> >>> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith <
> rich...@m
This broke the Windows bot:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10093/steps/build%20stage%201/logs/stdio
FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32
/D_WINDOWS /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291
-wd4345 -wd4351 -wd43
Author: nico
Date: Tue Apr 26 15:40:23 2016
New Revision: 267601
URL: http://llvm.org/viewvc/llvm-project?rev=267601&view=rev
Log:
Try to get at_file_missing.c passing after LLVM r267556.
r267556 made backslashes escape the next character
unconditionally in rsp files. This test echos a path into
Is it needed to parse system headers? In general, we implement things like
this if they're needed for system headers but don't otherwise.
On Wed, Apr 27, 2016 at 6:19 AM, Dmitry Polukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I added example with 'B*' to 'A*' just to make sure tha
Author: nico
Date: Wed Apr 27 12:26:08 2016
New Revision: 267744
URL: http://llvm.org/viewvc/llvm-project?rev=267744&view=rev
Log:
Revert r267691, it caused PR27535.
Removed:
cfe/trunk/test/Modules/Inputs/PR27401/
cfe/trunk/test/Modules/pr27401.cpp
Modified:
cfe/trunk/include/clang/AS
thakis added a subscriber: thakis.
thakis added a comment.
Thanks for the patch! To add to your proposed todo list (which sounds great):
All these stack-using pragmas aren't serialized to pch files at the moment
either. Maybe you want to work on that too (either serialize the stacks, or
emit a
I revert the
> "revert" and commit the fix afterwards?
> Many thanks
> Vassil
> On 27/04/16 19:26, Nico Weber via cfe-commits wrote:
>
>> Author: nico
>> Date: Wed Apr 27 12:26:08 2016
>> New Revision: 267744
>>
>> URL: http://llvm.org/vi
thakis added inline comments.
Comment at: lib/Frontend/HeaderIncludeGen.cpp:106
@@ +105,3 @@
+// it to be there.
+*OutputFile << '\n';
+ }
Doesn't do that for me:
C:\src\ninja>cl /c test.cc /nologo /showIncludes
test.cc
Note: including file: c:\src\ninja
thakis added a comment.
I agree with Brad that it'd be nice if we didn't have to add this :-)
What's the workaround for current cmake releases?
http://reviews.llvm.org/D19881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
thakis added a comment.
(Also, this "only" affects .rc compilations, not regular source compilations --
those don't go through cmcldeps)
http://reviews.llvm.org/D19881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
thakis added a comment.
In http://reviews.llvm.org/D19881#420245, @hans wrote:
> In http://reviews.llvm.org/D19881#420244, @thakis wrote:
>
> > I agree with Brad that it'd be nice if we didn't have to add this :-)
> >
> > What's the workaround for current cmake releases?
>
>
> Passing -DCMAKE_CL_
Author: nico
Date: Thu May 5 06:51:22 2016
New Revision: 268625
URL: http://llvm.org/viewvc/llvm-project?rev=268625&view=rev
Log:
Add a test for PR26076.
r262056 accidentally fixed this. Add a test to ensure it
doesn't regress.
Modified:
cfe/trunk/test/CodeGenCXX/dllexport.cpp
Modified: c
We're getting this crash now with a regression range of 268724:268729 --
i.e. almost certainly this change:
FAILED: obj/net/dns/net.mdns_client.obj
ninja -t msvc -e environment.x64 --
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m64 /nologo
/showIncludes /FC @obj\net\dns\net.mdns_c
Author: nico
Date: Fri May 6 09:34:29 2016
New Revision: 268736
URL: http://llvm.org/viewvc/llvm-project?rev=268736&view=rev
Log:
Revert r268727, it caused PR27666.
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/include/clang/Basic/AddressSpaces.h
cfe/trunk/include/clang/Basi
I verified that this is due to this change. I filed
https://llvm.org/bugs/show_bug.cgi?id=27666 with a reduced repro and
reverted this change in r268736.
On Fri, May 6, 2016 at 9:52 AM, Nico Weber wrote:
> We're getting this crash now with a regression range of 268724:268729 --
> i.e. almost cer
Author: nico
Date: Fri May 6 16:17:32 2016
New Revision: 268797
URL: http://llvm.org/viewvc/llvm-project?rev=268797&view=rev
Log:
Fix sysroot-prefix.c on Windows (/ vs \).
Modified:
cfe/trunk/test/Preprocessor/sysroot-prefix.c
Modified: cfe/trunk/test/Preprocessor/sysroot-prefix.c
URL:
htt
k allow / match \ when running under Windows?
>
Seems overly magical to me. Maybe we should use {{.}} instead of {{/|}}
unless it's really important it's a slash or backslash for the test ;-)
>
> Yaron
>
>
> 2016-05-07 0:17 GMT+03:00 Nico Weber via cfe-commits &
thakis added a subscriber: thakis.
Comment at: lib/Driver/MSVCToolChain.cpp:477
@@ +476,3 @@
+ std::vector VersionBlock(VersionSize);
+ if (!::GetFileVersionInfoA(ClExe.c_str(), 0, VersionSize,
+ VersionBlock.data())) {
We already sta
I asked Reid the same thing on the review. He said he wanted to try the
warning in practice first and maybe polish it a bit before enabling it. (It
was supposed to land in disabled state.)
On Tue, May 10, 2016 at 9:00 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Er, w
thakis added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
amccarth wrote:
> Yes, it looks in
thakis added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
amccarth wrote:
> amccarth wrote:
>
thakis added a comment.
Ok, that seems fine then. Thanks much for checking!
http://reviews.llvm.org/D20136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Visual Studio's C++ standard library headers include intrin.h, so the intrinsic
headers get included a lot more often in Microsoft mode then elsewhere. The
AVX512 intrinsics are a lot of code (0.
thakis closed this revision.
thakis added a comment.
r269675, thanks!
http://reviews.llvm.org/D20291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Mon May 16 13:14:07 2016
New Revision: 269675
URL: http://llvm.org/viewvc/llvm-project?rev=269675&view=rev
Log:
[ms] Reintroduce feature guards in intrinsic headers in Microsoft mode
Visual Studio's C++ standard library headers include intrin.h, so the intrinsic
headers get inc
Hi Michael,
have you see then trhead "The intrinsics headers (especially avx512) are
too big. What to do about it?"? Can you maybe comment on it?
Thanks,
Nico
On Mon, May 16, 2016 at 2:57 PM, Michael Zuckerman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mzuckerm
> Date: Mon M
After this tweak, Chromium builds cleanly with the new warning enabled.
Maybe it's time to turn it on by default.
On Wed, May 11, 2016 at 1:43 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Wed May 11 12:43:13 2016
> New Revision: 269214
>
> URL: http
Is it possible to write a test for this?
On Tue, May 17, 2016 at 10:34 AM, Cameron Desrochers via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cameron314
> Date: Tue May 17 09:34:53 2016
> New Revision: 269769
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269769&view=rev
> Log:
>
Doesn't look like this helped:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12300
On Wed, May 18, 2016 at 9:07 AM, Haojian Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hokein
> Date: Wed May 18 08:07:13 2016
> New Revision: 269918
>
> URL: http://llvm.org/vie
thakis added a subscriber: thakis.
thakis added a comment.
I agree with Aaron. Maybe you could change Matcher.UnresolvedLookupExpr to call
bar() from a new function foo() so that it gets instantiated?
http://reviews.llvm.org/D20369
___
cfe-commits
thakis added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:187
@@ +186,3 @@
+ "}",
+ unresolvedLookupExpr(), true,
+ "-fno-delayed-template-parsing"))
1101 - 1200 of 1693 matches
Mail list logo
