[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

thakis added a comment. This seems to break all tests on all platforms: http://45.33.8.238/linux/35854/step_7.txt As far as I can tell, RenderSCPOptions is called unconditinoally and the error message is emitted at its start, before any Args.hasFlag checks -- so it's emitted every time a windo

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

thakis added a comment. Also, rnk's comment above wasn't addressed as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing l

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

thakis added a comment. reverted in 00065d5cbd02b0f3fccb34881b58bcd0852b3970 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 __

[PATCH] D91302: Handle template instantiations better in clang-tidy check

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/30322/step_8.txt Ptal, and revert for now if it takes a while to fix. (In particular, prefer reverting over disabling the test on win.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. Heads-up: Looks like one of these changes, likely this one for CodeGen, made sanitizer output way larger: https://bugs.chromium.org/p/chromium/issues/detail?id=1161230 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. I verified it's due to this change. https://bugs.chromium.org/p/chromium/issues/detail?id=1161230#c15 has a stand-alone repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 _

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. I reverted this (and a bunch of stuff that landed on top of it) in 7ad666798f12456d9e663e763e17e29007c3728d for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. ...and two more in 1876a2914fe0bedf50f7be6a305f5bf35493e496 . Sorry for the churn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://revie

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

thakis added a comment. Heads up: Breaks a test for us: https://bugs.chromium.org/p/chromium/issues/detail?id=1161542 (No reduced repro yet, might be UB, just fyi at this point.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://re

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

thakis added a comment. Looks like the test doesn't pass on Windows: http://45.33.8.238/win/27342/step_7.txt Please take a look, and revert if it takes a while to fix. Here's the output of the diff on that Win bot: thakis@thakis6-w MINGW64 /c/src/llvm-project (merge) $ diff --strip-trailin

[PATCH] D68997: Allow searching for prebuilt implicit modules.

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3382 } +if (Args.hasFlag(options::OPT_fprebuilt_implicit_modules, false)) + CmdArgs.push_back("-fprebuilt-implicit-modules"); You need to use a fno_ flag as 2nd param if

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. Testing this out: `--target=arm64-apple-macos` now does the right thing, but `-march arm64` sets the target triple to iOS (and hence doesn't pass the a12 cpu either). That's different from what Xcode clang does. Could you upstream whatever causes that difference too? R

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. (If `-mmacosx-version-min` is passed too, open-source clang does the right thing, but for quick command-line testing it'd be nice if both clangs behaved consistently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

thakis added a comment. Very belated update: We've been running with this on our clang/tot bots for a few weeks now and turned this on (or, more accurately stopped turning it off) for "normal" builds today. All tests pass and so far everything's happy. Repository: rG LLVM Github Monorepo CH

[PATCH] D90992: [clang-tidy] Use vfs::FileSystem when getting config

thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:366 } -return OptionsSource(*ParsedOptions, ConfigFile.c_str()); +return OptionsSource(*ParsedOptions, ConfigFile.str()); } This breaks bootstrap builds ag

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5917 // There is no later point when we will see the definition of this // function, so pass it to the consum

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Thanks for the test! I think moving TextDiagnosticsPrinter to Basic is much better than making Format depend on Frontend. If you just want to fix your crash and be done with it, then doing that (and adding your test) is fine. I think the best fix would be to change Basi

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

thakis added a comment. This breaks compillation on windows when using clang as compiler: http://45.33.8.238/win/27605/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 ___

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

thakis added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:91 - // CHECK: @_ZN11rdar93574002ggE = constant [49 x i8] c"{vector >=[4f]}\00" + // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? + //

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

This revision was automatically updated to reflect the committed changes. Closed by commit rG46ca880fcae2: clang: Don't assert on no_unique_address fields in @encode() (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

thakis added a comment. (usual procedure is to revert while investigating test failures instead of commenting out the tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

thakis added a comment. Might break tests: http://45.33.8.238/linux/29238/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88338/new/ https://reviews.llvm.org/D88338 ___ cfe-commits mailing list

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

thakis added a comment. Breaks tests on windows: http://45.33.8.238/win/25123/step_7.txt Please take a look, and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://reviews.llvm.org/D88452 _

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

thakis added a comment. On https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867483277057489840/+/steps/package_clang/0/stdout?format=raw too. Reverted in ba60dc0aa75e86165e260b2c08afafd1c394e95a

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt Can you take a look and revert for now if it takes a while to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88759/new/ https://reviews.llvm.org/D8875

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

thakis added a comment. https://clang.llvm.org/docs/ThinLTO.html#controlling-backend-parallelism should probably be updated to mention "all". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75153/new/ https://reviews.llvm.org/D75153 ___

[PATCH] D91904: [mac/arm] Fix rtti codegen tests when running on an arm mac

thakis created this revision. thakis added a reviewer: rjmccall. Herald added subscribers: kristof.beyls, dschuff. thakis requested review of this revision. Herald added a subscriber: aheejin. [mac/arm] Fix rtti codegen tests when running on an arm mac shouldRTTIBeUnique() returns false for iOS64

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/28408/step_9.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90749/new/ https://reviews.llvm.org/D907

[PATCH] D91916: Remove automatic traversal from forEach matcher

thakis added a comment. Looks like this broke clang-query tests: http://45.33.8.238/linux/33556/step_8.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91916/new/ https://reviews

[PATCH] D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16c0a9a6897: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D92028: Fix driver test from e16c0a9a689719

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. The test failed silently if lld wasn't built alongside clang. But the test uses -###, so the "invalid linker name in -fuse-ld=lld" diag didn't make clang fail, and something else happened to matc

[PATCH] D92028: Fix driver test from e16c0a9a689719

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce85e66358a: Fix driver test from e16c0a9a689719 (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D92028?vs=307335&id=307361#toc Repository: rG

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. New MachO LLD doesn't implement the old -macos_version_min (etc) flags, but it understands the modern platform_version flag. So make the clang driver pass that when using new MachO LLD. Also, wh

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8386dba889: clang: Pass -platform-version to new MachO LLD (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D92037?vs=307365&id=307369#toc Reposi

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

thakis marked an inline comment as done. thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92037/new/ https://reviews.llvm.org/D92037 ___ cfe-commits mailing list cfe-commits@

[PATCH] D74704: Support -fuse-ld=lld for riscv

thakis added inline comments. Herald added subscribers: frasercrmck, NickHung. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + Why do you need this feature? clang invocations that

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019 + default: +break; + case ARM::BI_BitScanForward: Maybe `return None` here and LLVM_UNREACHABLE

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:336 + + // For Release ordering, the failure ordering should be Monotonic. + auto FailureOrdering = SuccessOrdering == Atomi

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

thakis added a comment. Do you have any numbers on false positives / true positives uncovered by this tweak? In general, warning at use time instead of at declaration time tends to be much better for this rate, and we do this differently than gcc in several instances, because the gcc way has so

[PATCH] D92291: clang/test: Remove platform-linker feature

thakis created this revision. thakis added reviewers: serge-sans-paille, leonardchan, vvereschaka. Herald added subscribers: llvm-commits, frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzh

[PATCH] D92291: clang/test: Remove platform-linker feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG61da501b6a1b: clang/test: Remove platform-linker feature (authored by thakis). Herald added a subscriber: jrtc27. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis created this revision. thakis added a reviewer: jyknight. thakis requested review of this revision. This morally reverts D82777 -- turns out that ld64 crashes with many response files, so we must stop passing them to it until the crash is fixed. On the ot

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. In D92357#2424422 , @keith wrote: > Note in your repro case the issue is that the response file doesn't end in a > trailing newline Hm, we also see crashes if we let clang write the response file that's passed to ld64 though. (ie

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. In D92357#2424484 , @keith wrote: > It looks like at least in the `-Wl` case clang passes the file through > directly, Right, that's my point: We see crashes around response files even if we let clang write it. > I _don't_ actua

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. The new MachO lld just grew support for response files in D92149 , so let the clang driver use it. https://reviews.llvm.org/D92399 Files: clang/lib/Driver/T

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. Extracted the darwinnew bits to D92399 . Will rebase this once that's in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits maili

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

thakis updated this revision to Diff 308675. thakis added a comment. fewer build errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92399/new/ https://reviews.llvm.org/D92399 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index: clang/lib/Driver/ToolChains/Darwin.cpp =

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99e2b8b14f4: clang/darwin: Use response files with ld64.lld.darwinnew (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis updated this revision to Diff 308684. thakis edited the summary of this revision. thakis added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index: clang/lib/Driver/Too

[PATCH] D92357: clang/darwin: Don't use response files with ld64

thakis added a comment. In D92357#2426042 , @keith wrote: > I'm a bit worried that without a repro case (outside of the missing newline) > Apple won't get around to fixing this, and in the meantime I'm wondering if > outside of the chromium build system

[PATCH] D92357: clang/darwin: Don't use response files with ld64

This revision was automatically updated to reflect the committed changes. Closed by commit rG68f2ff59d114: clang/darwin: Don't use response files with ld64 (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D91904: [mac/arm] Fix rtti codegen tests when running on an arm mac

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cbf61be8be5: [mac/arm] Fix rtti codegen tests when running on an arm mac (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/29181/step_7.txt PTAL, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.ll

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

thakis added a comment. In D90871#2433804 , @erik.pilkington wrote: > In D90871#2433766 , @thakis wrote: > >> Looks like this breaks tests on Windows: >> http://45.33.8.238/win/29181/step_7.txt >> >> PTAL, and rev

[PATCH] D92704: [clangd] Publish config file errors over LSP

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/29315/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92704/new/ https://reviews.llvm.org/D92704 ___ cfe-c

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

thakis resigned from this revision. thakis added a comment. hans and compnerd got this, no need for so many reviewers :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63473/new/ https://reviews.llvm.org/D63473 ___ cfe-commits mailing list cfe

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

thakis added a comment. Looks like the test is still failing on windows: http://45.33.8.238/win/26155/step_11.txt Ptal, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.o

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

thakis added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89708/new/ https://reviews.llvm.org/D89708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/26253/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llv

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

thakis added a comment. Looks like this broke tests: http://45.33.8.238/linux/31159/step_12.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D8

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

thakis added inline comments. Herald added a subscriber: ormris. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + It looks like this is too clever for gcc5.3: https://bugs.chr

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

thakis added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + thakis wrote: > It looks like this is too clever for gcc5.3: > https://bugs.chromium.org/p/chrom

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. This doe snot lgtm. clang-format should not depend on clangFrontend, see the lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find another fix here (and include a test for

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Can you expand a bit on what exactly is going wrong? (As part of that, please include a test case that shows the crash this is about.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Is it possible to add an automated test for this in clang/test/Format/... using chmod -w in a RUN line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/CodeGen/CGObjC.cpp:3874 if (!CGM.IsOSVersionAtLeastFn) { llvm::FunctionType *FTy = Isn't the rest of the function bas

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

thakis created this revision. thakis added a reviewer: rjmccall. thakis requested review of this revision. Just skip (non-bitfield) zero-sized fields, like we do with empty bases. The class->struct conversion in the test is because -std=c++20 else deletes some default methods due to non-accessib

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. Two pieces of feedback: 1. This fires in system headers on windows, e.g. like so: ../../third_party/wtl/include\./atlapp.h(336,12): error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmeti

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. In D98798#2754449 , @jamieschmeiser wrote: > @thakis, I have some questions about your comments. > Are you sure this is coming from a system header? The path that you gave has > third_party as a directory in the path. Yes. `thir

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. (sorry, accidentally hit cmd-enter, not actually done writing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing lis

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. (Now completed the reply, see phab.) In D98798#2754635 , @xbolva00 wrote: > You dont have to use -Wno-… > > You can use pragma to disable this warning for certain location in the code, > eg include of commctrl.h. commctrl.h is in

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. We share obj files built on linux and on windows. So that's a goal for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102339/new/ https://reviews.llvm.org/D102339 ___ cfe-commi

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. In D102339#2756726 , @aganea wrote: > In D102339#2755867 , @thakis wrote: > >> We share obj files built on linux and on windows. So that's a goal for us. > > Hello @thakis, I believe you do

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

thakis added a comment. (Failed on our bots too -- the new test probably just needs a ` REQUIRES: aarch64-registered-target`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102489/new/ https://reviews.llvm.org/D102489 _

[PATCH] D102495: [clang][deps] Support inferred modules

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/38908/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/ https://reviews.llvm.org/D102495 ___ cfe

[PATCH] D102495: [clang][deps] Support inferred modules

thakis added a comment. Did you see my message about the windows breakage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/ https://reviews.llvm.org/D102495 ___ cfe-commits mailing list cfe-comm

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

thakis added inline comments. Herald added subscribers: llvm-commits, kristina. Herald added a project: LLVM. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:93 +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc ___c

[PATCH] D102647: [Driver][test] Don't assume integrated-as

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Are there any platforms left that don't default to integrated as? Which ones? Is there a tracking bug for switching them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D102261: Introduce SYCL 2020 mode

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/9739/step_7.txt http://45.33.8.238/mac/31615/step_7.txt Please take a look, and please revert for now if it takes a while to fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://re

[PATCH] D102583: -fno-semantic-interposition: Don't set dso_local on GlobalVariable

thakis added a comment. Looks like this breaks check-clang: http://45.33.8.238/linux/47049/step_7.txt http://45.33.8.238/macm1/9850/step_7.txt PTAL! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102583/new/ https://reviews.llvm.org/D102583 __

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/10125/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

thakis added a comment. reverted in d881319cc5606baa7668405a296d0960a83a1e4c for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102693

[PATCH] D55544: Warning: objc-encodings-larger-than=

thakis added a comment. Herald added a subscriber: dang. FYI D96816 made clang emit way smaller encodings by default Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 _

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

thakis added a comment. FYI D96816 made clang emit way smaller encodings by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55640/new/ https://reviews.llvm.org/D55640 ___ cfe-commits mailing list cfe-c

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

thakis added a comment. Looks like this breaks tests http://45.33.8.238/linux/47752/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits mai

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

thakis added a comment. This is breaking check-clang everywhere, eg https://lab.llvm.org/buildbot/#/builders/109/builds/15757 Please run tests before landing, or failing that watch the bots after committing. Reverted in f63adf5b67f7a25b15f81d3a1a207aba4f226dc4 for now. Repository: rG LLVM

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

thakis added a comment. In D91913#2520503 , @hvdijk wrote: > In D91913#2520432 , @zequanwu wrote: > >> In D91913#2520414 , @hvdijk wrote: >> >>> In D91913#2520399

[PATCH] D94820: Support for instrumenting only selected files or functions

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/32075/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.ll

[PATCH] D95472: clang-cl: Add /winsdkdir and /winsdkversion flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5d85cbec58e: clang-cl: Add /winsdkdir and /winsdkversion flags (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, pengfei. Herald added a reviewer: jansvoboda11. thakis requested review of this revision. On non-Windows platforms, --sysroot can be used to make the compiler use a single, hermetic directory for all heade

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added a comment. Maybe we should just go with `Windows Kits/10" -- the space is only seen at the driver->cc1 boundary and it works fine there, and the 10 can be inferred from /winsdkversion. On the other hand, thinking about how to create such a sysroot directory, saying "just copy %vct

[PATCH] D95559: clang: Fix static_assert in a few contexts in microsoft mode

thakis created this revision. thakis added reviewers: hans, rnk. thakis requested review of this revision. Follow-up to D17444 . Fixes PR48904. See bug for details. https://reviews.llvm.org/D95559 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Sema/static-

[PATCH] D95559: clang: Fix static_assert in a few contexts in microsoft mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG764a7a2155c6: clang: Fix static_assert in a few contexts in microsoft mode (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95559?vs=319661&id=3196

[PATCH] D95575: clang-cl: Accept /std:c11, /std:c17 flags

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, kristof.beyls. Herald added a reviewer: jansvoboda11. thakis requested review of this revision. clang-cl already defaults to C17 for .c files, but no harm in accepting these flags. Fixes PR48185. https:/

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319936. thakis edited the summary of this revision. thakis added a comment. Seems like there are no strong opinions, so now with actual code. I went with "VC/Tools/MSVC/XXX" and "Windows Kits/10" since that seems like the obvious thing. CHANGES SINCE LAST A

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319938. thakis added a comment. add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/cl-sysroot.cp

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319949. thakis marked an inline comment as done. thakis added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Tool

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:75 + for (llvm::sys::fs::directory_iterator DirIt(Directory, EC), DirEnd; + DirIt != DirEnd && !EC; DirIt.increment(EC)) { +if (!llvm::sys::fs::is_directory(DirIt->path()))

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added inline comments. Comment at: clang/test/Driver/cl-sysroot.cpp:10 + +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include" +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/atlmfc/include" hans wrote: > could the

<    5   6   7   8   9   10   11   12   13   14   >