[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/32938/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llv

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. It's more important to remove it from the cmakelists file than to delete the source file ;) Please revert the whole thing instead of just removing the test coverage though. You can reland when the test is figured out, and that makes sure this doesn't stay in without cov

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. Why? This is a fairly small CL. It should be easy to reland, and there shouldn't be any rebasing pain. You should at least check with your reviewers that they're fine relanding this without test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

thakis added a comment. What makes me an improper clang reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LG Do you have commit permission, or do you want me to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://rev

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd29f8a5f8350: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener (authored by lgxbslgx, committed by thakis). Repositor

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

thakis added a comment. Thanks for the patch1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://reviews.llvm.org/D123452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

thakis added a comment. ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://reviews.llvm.org/D123452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/56334/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.ll

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Reverted in a29d9ba1f584745c1a169da5d08f10b27623cfb0 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Err, actually in dd47ab750b584a320bf61d58a3965a03f3871c1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655 ___ cfe-commits mailing list c

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/33656/step_7.txt Please take a look and revert for now if it takes a while to fix. (Maybe just needs an explicit triple?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

thakis added a comment. Thanks, that did the trick :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

thakis added a comment. Please add a clear comment to the new library's CMakeLists.txt file that explains when to put code there and when in clang/lib/Basic. (The patch description does say it, but the patch description is harder to find than a comment in the cmake file.) Repository: rG LLV

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Hm, is adding this flag the right thing to do? Looking at clang's -S output for (say) ` -target arm64-apple-macos -darwin-target-variant arm64-apple-ios13.1-macab`, it emits lines like: .build_version macos, 12, 0 sdk_version 12, 3 .build_version macC

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

thakis added a comment. As far as I can tell, this broke tests everywhere, e.g. http://45.33.8.238/linux/74221/step_7.txt https://lab.llvm.org/buildbot/#/builders/109/builds/36986 etc Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHA

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

thakis added a comment. I think your revert to fix the aix CI broke CI everywhere: http://45.33.8.238/linux/74239/step_7.txt Please take a look and reland for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Xcode's clang seems to support this: % clang -target arm64-apple-macos -target-variant arm64-apple-ios13.1-macabi foo.s -c % otool -l foo.o | rg -A2 BUILD

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

thakis added subscribers: yln, thakis. thakis added a comment. I think this might've broken check-clangd: http://45.33.8.238/linux/74320/step_9.txt The output isn't very useful though, I'm guessing @yln's recent gtest runner change it's not getting printed. Repository: rG LLVM Github Monore

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

thakis added a subscriber: ychen. thakis added a comment. Sorry, @ychen, not @yln (D122251 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124180/new/ https://reviews.llvm.org/D124180 _

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added a comment. Is there any background information anywhere what this pseudo parser is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114790/new/ https://reviews.llvm.org/D114790 ___ cfe-commits

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/CMakeLists.txt:3 + +add_clang_library(clangSyntaxPseudo + Grammar.cpp (i think the usual name would be "clangToolingSyntaxPseudo") Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added inline comments. Comment at: clang/unittests/Tooling/Syntax/Pseudo/CMakeLists.txt:6 +add_clang_unittest(ClangPseudoTests + GrammarTests.cpp +) ``` thakis@thakis:~/src/llvm-project$ ls clang/unittests/**/*Test.cpp | wc -l 127 thakis@thakis:~/src/llvm

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added a comment. In D114790#3293777 , @sammccall wrote: > In D114790#3293764 , @thakis wrote: > >> Is there any background information anywhere what this pseudo parser is? > > Design doc: > https://docs.go

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. > @pkasting Note, this patch makes the outcome non-deterministic when the > auto-detection kicks in. We are stamping the command-line the .PDB file, see > https://github.com/llvm/llvm-project/blob/main/lld/COFF/PDB.cpp#L1402 - and > some live-code-patching tools rely on

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I think this looks great. maskray, I kind of see where you're coming from. And I'm _very_ sympathetic to keeping Support small(er). On the other hand, this is a single file that doesn't requi

[PATCH] D111100: enable plugins for clang-tidy

thakis added a comment. This is still breaking tests on our bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8822909450036830977/+/u/package_clang/stdout?format=raw FAIL: Clang Tools :: clang-tidy/CTTestTidyModule.cpp (17913 of 89667) TEST 'Clang

[PATCH] D119446: [clang-cl] Accept the "legacy'"-target flag spelling

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119446/new/ https://reviews.llvm.org/D119446 ___

[PATCH] D118070: Make lld-link work in a non-MSVC shell

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b2538df100: [lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot: (authored by pkasting, committed by thakis). Changed prior to comm

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. I went ahead and landed this for now. It's easy to move the 3 new files to their own library later on if we decide it's something we want to do. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: dang. thakis requested review of this revision. Less typing than `-fprofile-instr-use`, and means the same thing. https://reviews.llvm.org/D119574 Files: clang/include/clang/Driver/Options.td clang/test/

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Thanks for the revert! Is there any documentation for that LLVM_ENABLE_MODULES build config anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _

[PATCH] D119574: [clang] Expose -fprofile-use in clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1147f825d0: [clang] Expose -fprofile-use in clang-cl (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo C

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added inline comments. Comment at: llvm/include/llvm/Support/MSVCPaths.h:15 +#include "llvm/Option/ArgList.h" +#include "llvm/Support/VirtualFileSystem.h" +#include aprantl wrote: > This introduces a cyclic dependency that breaks the `-DLLVM_ENABLE_MODULE

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Relanded in 73e585e44d68cf77e2e3274e98c9615156a7d909 , with the new files in a new WindowsDriver library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

thakis added a comment. Very cool! Looks like it broke lldb builds though: http://45.33.8.238/linux/68321/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 __

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis created this revision. thakis added a reviewer: lld-macho. Herald added subscribers: ormris, steven_wu, hiraditya. thakis requested review of this revision. - ld64.lld now completely supports -export_dynamic (D119372 ), so map -rdynamic to -export_dynamic

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242 } else if (D.getLTOMode() == LTOK_Thin) // If we are using thin LTO, then create a directory instead. TmpPathName = D.GetTemporaryDirectory("thinlto"); lgrey:

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. It fails on this: // Validate that the default triple is used when run an empty tools dir is specified // RUN: %clang_cl -vctoolsdir "" -### -- %s 2>&1 | FileCheck %s --check-prefix VCTOOLSDIR // VCTOOLSDIR: "-triple" "{{[a-zA-Z0-9_-]*}}-pc-windows-msvc19.20.0" Wi

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. Thanks for the revert! FWIW, also failed on https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/2069/overview / https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8822456541383185105/+/u/package_clang/stdout?format=raw . So maybe it's no

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. (reopening for fixing things + relanding) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 __

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. (also marking as "request changes" for the Optional change we need) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Relanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 _

[PATCH] D118070: Make lld-link work in a non-MSVC shell

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5fb05f663f2: Reland: Make lld-link work in a non-MSVC shell, add /winsysroot: (authored by pkasting, committed by thakis). Repository: rG LLVM Gi

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. > Oh, I added a NFC fix previously in > https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3. > I think it should be reverted too? I am going to revert it. I did that in 5d110ed4cd4

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. The bot that broke last time stayed green on the reland: https://lab.llvm.org/staging/#/builders/204/builds/1591 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

thakis added a comment. (I wish there was a flag that said "clang, never ever read any env vars please". Some people think that builds should be deterministic and not depend on random env vars people might have set (and then not do correct incremental rebuilds when the value of such env var fla

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above a

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409243. thakis added a comment. undo no_deduplicate bit again for now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-ld-lto.c cl

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409254. thakis added a comment. Pass `-B` with `-fuse-ld=lld` since the latter flag only has an effect if ld64.lld exists on disk, and clang/test doesn't depend on lld (and shouldn't). Also move object_path_lto to its own file since it can run fine on non-dar

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Any idea what's going on in that Modules/cxx20-export-import.cpp failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added a comment. lld-macho folks, any concerns with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Sure, sounds good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

thakis added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:18 + clangBasic + clangFrontend + ) Making clang/lib/Testing depend on clangFrontend (and hence on basically everything) seems pretty heavy. Maybe this should be in a new library? Re

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

thakis added a comment. (In general, be wary when you write a CL desc that goes "people currently do X in the following N ways, so let's add a N+1th way". This feels short-term good for you since the N+1th way is written exactly like you'd write it – you wrote it, after all! But for everyone el

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/56771/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.ll

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Reverted in 8dbc6b560055ff5068ff45b550482ba62c36b5a5 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Thanks! Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

This revision was automatically updated to reflect the committed changes. Closed by commit rGf69328049e9e: [cc1as] Add support for emitting the build version load command for -darwin… (authored by bc-lee, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D124280: [git-clang-format] Change run line from python to python3

thakis created this revision. thakis added a reviewer: MyDeveloperDay. Herald added a project: All. thakis requested review of this revision. Several systems no longer ship `python`. https://reviews.llvm.org/D124280 Files: clang/tools/clang-format/git-clang-format Index: clang/tools/clang-f

[PATCH] D124282: [git-clang-format] Add some examples to the help text

thakis created this revision. thakis added reviewers: MyDeveloperDay, curdeius. Herald added a project: All. thakis requested review of this revision. https://reviews.llvm.org/D124282 Files: clang/tools/clang-format/git-clang-format Index: clang/tools/clang-format/git-clang-format ===

[PATCH] D124282: [git-clang-format] Add some examples to the help text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa45764f2f9cf: [git-clang-format] Add some examples to the help text (authored by thakis). Herald added a project: clang. Repository: rG LLVM Githu

[PATCH] D124280: [git-clang-format] Change run line from python to python3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc94a02e0e223: [git-clang-format] Change run line from python to python3 (authored by thakis). Herald added a project: clang. Repository: rG LLVM G

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

thakis added a comment. This broke check-clangd everywhere, e.g.: https://lab.llvm.org/buildbot/#/builders/109/builds/37635 http://45.33.8.238/linux/75019/step_9.txt http://45.33.8.238/macm1/34369/step_9.txt http://45.33.8.238/win/57278/step_9.txt Please run tests before committing, please watch

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

thakis added a comment. > So I went ahead and just fixed this in > ac5f7be6a8688955a282becf00eebc542238a86b > . As far as we can tell, this broke clang-move/move-used-helper-decls.cpp on our windows bot. D124563

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. Thanks for the patch! Two comments, more specific, one general: 1. This broke compilation of (at least) one TU in chromium, see https://bugs.chromium.org/p/chromium/issues/detail?id=1323014#c5 . Can you look into if that's expected? (We've worked around this for now.)

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

thakis added a comment. This breaks check-clang on mac: http://45.33.8.238/macm1/39907/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

thakis added a comment. Bot's happy again. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D129563: [docs] Document git-clang-format

thakis created this revision. thakis added reviewers: curdeius, MyDeveloperDay. Herald added a project: All. thakis requested review of this revision. clang-format's documentation documented the more general clang-format-diff.py script. Add documentation for the less general but arguably easier-to

[PATCH] D129563: [docs] Document git-clang-format

thakis added a comment. (does anyone know why git-clang-format isn't implemented in terms of clang-format-diff.py? I suppose it's easier to use if it's standalone?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129563/new/ https://reviews.llvm.org/D129563 _

[PATCH] D129226: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd489268392d2: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx… (authored by thakis). Herald added a project: clang. Reposi

[PATCH] D129569: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

thakis created this revision. thakis added a reviewer: akyrtzi. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. Like https://reviews.llvm.org/D129226, but for iOS. No behavior change. https://reviews.llvm.org/D129569 Files: clang/inc

[PATCH] D129569: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

This revision was automatically updated to reflect the committed changes. Closed by commit rG953ba18fda92: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos… (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D129563: [docs] Document git-clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rG422e6e762935: [docs] Document git-clang-format (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129563/new/

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

thakis added a comment. In D122258#3478727 , @davide wrote: > Compact unwind was developed as a goal to replace the DWARF unwind. Some apps > did not work if the OS was missing DWARF unwind, so we kept both for Intel. > The binary compatibility issue is

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/UsersManual.rst:853 + * ``no-compact-unwind`` - Only emit DWARF unwind when compact unwind encodings +aren't available. This is the defau

[PATCH] D125529: Revert MSVC compatibility feature that breaks conformant code

thakis resigned from this revision. thakis added a comment. This can be closed, it landed elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125529/new/ https://reviews.llvm.org/D125529 ___ cfe-com

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

thakis added a comment. One of your 3 commits in https://github.com/llvm/llvm-project/compare/3d888b0491f8...34ac048aef29 broke check-clang on Windows: http://45.33.8.238/win/57870/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monor

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

thakis added a comment. https://github.com/llvm/llvm-project/commit/21feafaeb85aad2847db44aa2208999b166ba4a9 fixed it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124674/new/ https://reviews.llvm.org/D124674

[PATCH] D124736: [CodeGen] Use ABI alignment for C++ new expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG93a8225da1f9: [CodeGen] Use ABI alignment for C++ new expressions (authored by BertalanD, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. I don't think you need to build chromium. https://bugs.chromium.org/p/chromium/issues/detail?id=1323014#c5 has a stand-alone reproducer attached that you can download. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124613/ne

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

thakis added a comment. Updating the tests makes sense to me, fwiw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

thakis added a comment. Also fails on linux: https://lab.llvm.org/buildbot/#/builders/109/builds/38285 And on mac: http://45.33.8.238/macm1/35024/step_7.txt (On some platforms, the bot redness was masked by D124552 breaking the bots first.) But yes, please fi

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added a comment. We now have clang-offload-bundler, clang-offload-packager, clang-offload-wrapper. Do we really need that many distinct binaries for offloading? Any chance we could combine some of those? Comment at: clang/test/Driver/linker-wrapper.c:5 -// RUN: %clan

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added inline comments. Comment at: clang/test/Driver/linker-wrapper.c:5 -// RUN: %clang -cc1 %s -triple x86_64-unknown-linux-gnu -emit-obj -o %t.o \ -// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,openmp,nvptx64-nvida-cuda,sm_70 \ -// RUN: -fembed-offload-obj

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added a comment. We could add a "clang-offload-bundler and clang-offload-wrapper are deprecated, replace them with $whatever" in the release notes and then remove them a release later, assuming the replacement is straightforward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

thakis added a comment. In D125165#3506477 , @yaxunl wrote: > In D125165#3506448 , @thakis wrote: > >> We could add a "clang-offload-bundler and clang-offload-wrapper are >> deprecated, replace them with $whateve

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. Given that: - This is not needed for system headers - Before the change, users had to fix their standards-noncompliant code, but with it, users have to change their previously-compiling, standards-compliant code - The change is a no-op for C++20 and up anyways - There's

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. It seems to not affect a ton of code, so I don't think there's a huge hurry. I would like to hear an answer about the question "what is this for?" though, and your thoughts on how this relates to the goals in https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJH

[PATCH] D125338: [HLSL] add -D option for dxc mode.

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

thakis added a comment. Hello, one of your three commits in https://github.com/llvm/llvm-project/compare/562ce1592456...d2396d896ee1 broke building on mac: - http://45.33.8.238/macm1/35247/step_4.txtp - https://green.lab.llvm.org/green/job/clang-stage1-RA/ Please take a look, and revert for n

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

thakis added a comment. Looking at that error some more, it must've been D125429 . Moving the comment over there, sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125422/new/ https://reviews.llv

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

thakis added a comment. Hello, this broke building on mac: - http://45.33.8.238/macm1/35247/step_4.txtp - https://green.lab.llvm.org/green/job/clang-stage1-RA/ Please take a look, and revert for now if it takes a while to fix. (Here's the error: In file included from ../../clang/lib/AST/Comm

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

thakis added a comment. Thanks, reverted in e0fcdf5496ca686c8cebb63b63af86e666b42ab3 for now. In D124613#3511098 , @frederic-tingaud-sonarsource wrote: > I realized that this current

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/76033/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D1

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

thakis added a comment. https://github.com/llvm/llvm-project/commit/25862f53cce966cef2957825095861dec631d4f1 fixed the build, thanks! No opinion off the top of my head on changing the signature. Might be a good idea, maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

thakis added a comment. Seems generally ok. Comment at: clang/include/clang/Driver/Options.td:6663 def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">; Can you

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks good to me after addressing Hans's comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://

<    3   4   5   6   7   8   9   10   11   12   >