[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

thakis added a comment. Do we still need this? I was surprised by clang not using faddrsing on Andriod by default. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56456/new/ https://reviews.llvm.org/D56456 ___ cfe-comm

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

thakis added a comment. This breaks the build everywhere (e.g. http://45.33.8.238/linux/18283/step_4.txt) and has been in for over an hour. Please watch bots after landing. (I think changes that are created more recently automatically get presubmit compile testing on phab.) Reverted in 1108f5c

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

thakis added a comment. About the patch itself: Project-specific checks like this usually go in clang-tidy, not in the static analyzer (which ships with the compiler binary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77177/new/ https://reviews

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; Are you sure this is correct? MSVC prod

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; zequanwu wrote: > thakis wrote: > > Are

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

thakis added a comment. This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt Please take a look and revert if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80197/new/ https://reviews.llvm.org

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

thakis added a comment. This breaks check-clang-tools on windows: http://45.33.8.238/win/16485/step_8.txt Looks like you need to optionally allow a .exe suffix in the test. Please take a look, and revert if it takes a while until you can fix. (I'm on a phone, else I'd fix myself.) Repository

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

thakis accepted this revision. thakis added a comment. Test fix looks good as far as I can tell. Landing and seeing what the bot says is ok. It's fine for some of the bots to be red for a short while as long as it isn't hours. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. The change description says something about PWD (which makes me worried about build determinism, like amccarth), but I don't see anything about that in the diff. The diff as-is looks fine to me with hans's comment about duplication resolved in some form. Please don't ad

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. We're seeing some build warnings in ffmpeg due to this not being in yet. Could you try to land it soon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.org/D82699 ___

[PATCH] D83759: [clangd] Fixes in lit tests

thakis added a comment. Looks like this breaks tests on macOS (and probably with non-gnu greps): http://45.33.8.238/mac/17611/step_9.txt Please take a look, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D83592: [Coverage] Add comment to skipped regions

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/20315/step_7.txt Please take a look, and if it takes a while to investigate please revert while you look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592

[PATCH] D83817: [clangd] Add option to use remote index as static index

thakis added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@ hans wrote: > I'm guessing this should be @CLANGD_ENABLE_REMOTE@ > The gn build w

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

thakis added a comment. This breaks check-clang on Windows: http://45.33.8.238/win/20850/step_7.txt Please take a look, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://r

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

thakis added a comment. Looks like it's still failing with that change: http://45.33.8.238/win/20885/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 _

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

thakis added a comment. That did the trick, thanks! The bot was broken for > 5h and 43 builds. We got lucky that nothing else broke in the meantime, but red bots make it more difficult to analyze new regressions that appear when the bots are already red. Next time, please revert while you inve

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. grimar, andrewng: You both have checkout and build on different drives too, yes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77184/new/ https://reviews.llvm.org/D77184 ___ cfe

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 . Let me know if you still see issues. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. In D77184#1961220 , @rsmith wrote: > In D77184#1961214 , @rsmith wrote: > > > In D77184#1961208 , @rsmith wrote: > > > > > This has broken my ability

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. > Can you describe your symlink setup in enough detail that I can recreate it > locally please? I've landed a workaround that should make things go for you again in 7db64e202f9 . I'd still be curious

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

thakis added a comment. Broke clang-tools-extra again: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/46759/steps/build%20stage%201/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77112/new/ https://reviews.llvm.org/D77112

[PATCH] D62445: [test] Fix plugin tests

thakis added inline comments. Comment at: cfe/trunk/test/CMakeLists.txt:140 - set_target_properties(check-clang-analyzer PROPERTIES FOLDER "Clang tests") - - if (LLVM_WITH_Z3) Did you intentionally delete the 2 targets here? Repository: rL LLVM CHANGES SI

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, mgorny. This has been unnecessary since https://reviews.llvm.org/D37756. https://reviews.llvm.org/D37838 removed it for llvm. This removes it for clang, lld, clang-tools-

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

thakis added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:3 +// in intrinsic headers. +// Preprocess file to workaround no warnings in system headers. +// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E 2>&1 \ Does Wsyste

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: clang/test/CMakeLists.txt:113 -set(ANALYZER_TEST_PARAMS - USE_Z3_SOLVER=0) hans wrote: > This and ANALYZER_TEST_PARAMS_Z3 are just dropped because they're unused, > right?

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

This revision was automatically updated to reflect the committed changes. Closed by commit rG448b777b864a: Stop passing site cfg files via --param to llvm-lit. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. This seems to break tests on Windows: http://45.33.8.238/win/12320/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76768/new/ https://reviews.llvm.org/D76768 ___ cfe-co

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. Thanks for checking. Let me try the tests locally over here tonight. I'll get back to you in a few hours. > But what about **SemaObjC/parameterized_classes_subst.m**, I strongly doubt > the reason is in this patch. That's a known unrelated flake, see thread for "[clang]

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. Sorry for the slow reply. I repro'd this locally now, and here I see this error: ''' command stderr: === 'perl' is not recognized as an internal or external command, operable program or batch file. ''' perl wasn't required to run tests on Win for a long time

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. In D76768#1971420 , @ASDenysPetrov wrote: > @thakis > > > 'perl' is not recognized as an internal or external command, > > I think you got another problem, that Perl isn't just presented in your PATH. > It is not the case for buil

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. If I add scan-build to clang/test/CMakeLists.txt and undo my other changes, the test passes for me. I guess you always build that target, which is why you didn't see this problem. But I wonder why this isn't needed on non-Windows. Repository: rG LLVM Github Monorepo

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. (Also, that dep should only be added if CLANG_INSTALL_SCANBUILD isn't set to OFF, and I suppose the tests should only run if it isn't off too.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76768/new/ https://reviews.llvm.o

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. In D76768#1974044 , @thakis wrote: > If I add scan-build to clang/test/CMakeLists.txt and undo my other changes, > the test passes for me. I guess you always build that target, which is why > you didn't see this problem. But I won

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. In D76768#1974255 , @ASDenysPetrov wrote: > @thakis > Let me explain what works for me. > This is in my **PATH**: > > - C:\Perl\c\bin > - C:\Perl\perl\site\bin > - C:\Perl\perl\bin > - D:\llvm-project\buildn\bin ^ This is not u

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

thakis added a comment. test fails on win: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/15191/steps/stage%201%20check/logs/stdio CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 __

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

thakis added a comment. For CDE and MVE, the sema inc file is called arm_foo_builtin_sema. Does it make sense to call the sve one arm_sve_builtin_sema instead of arm_sve_sema_rangechecks too, for consistency? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

thakis added a comment. Breaks Windows due to slashiness in the test: http://45.33.8.238/win/12984/step_8.txt Please take a look, and revert if it takes a while to investigate. (I'd find the diag easier to read without the "the": just "is disabled in") Repository: rG LLVM Github Monorepo C

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

thakis added a comment. i attemtped a fix in 99e4061bd800a525ce1d7e2cbd6672b2fe0ec33d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. We don't store physical absolute paths in pdbs if you hold things right. Look for /pdbsourcepath: in http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html . rnk's change seems to store the main TU's dir as cwd, which likely either takes the dir from

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

thakis added a comment. The clang-cl spelling of this is /Gy and /Gw. If you want to use the gcc spelling, you can do that through the /clang: flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81203/new/ https://reviews.llvm.org/D81203 __

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. In other words: The point of clang-cl is to use cl.exe flag spellings where they exist. So unless there's some good reason for adding this, I don't think we should add it. Reposito

[PATCH] D59520: [WebAssembly] Address review comments on r352930

thakis added a comment. This breaks check-clang everywhere, e.g. here http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/39534/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Awarning-flags.c Please take a look and revert if it takes a while to fix. Going forward, ple

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. This is still failing on Windows: http://45.33.8.238/win/16970/step_7.txt Please take a look and revert for now if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.ll

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits maili

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Still broken: http://45.33.8.238/win/16976/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits mailing list cfe

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

thakis added a comment. Hi, this broke check-clang on mac: http://45.33.8.238/mac/14998/step_7.txt Please take a look, and if it takes a while to fix please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/ ht

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

thakis added inline comments. Comment at: clang/test/CodeGen/asan-globals.cpp:14 int blacklisted_global; +int __attribute__((section(".foo.bar"))) sectioned_global; nickdesaulniers wrote: > /Users/thakis/src/llvm-project/clang/test/CodeGen/asan-globals.cpp:14:

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I patched this in and verified that it fixes the test on a mac I have access to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81306/new/ https:

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. The recommit again broke tests on mac and windows: http://45.33.8.238/win/17004/step_7.txt http://45.33.8.238/mac/15014/step_7.txt This is like the 8th distinct build break today (most not yours, of course). Let's revert and call it a weekend, and try again next week. R

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Even fails on some linux bots: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/49595/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ahip-host-cpu-macros.cu Re-reverted in 2920348063221a0603ee96909536bc480f43a7ac

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. One more example failure: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16333 (Note I had re-reverted your reland, see the 2 comments above your comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8117

[PATCH] D80979: [clang] Implement VectorType logic not operator.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/17077/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___

[PATCH] D80979: [clang] Implement VectorType logic not operator.

thakis added a comment. Reverted in abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

thakis added a comment. Breaks tests on Mac: http://45.33.8.238/mac/15120/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75414/new/ https://reviews.llvm.org/D75414 ___ cfe-commits mailing lis

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

thakis added a comment. reverted in f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75414/new/ https://reviews.llvm.org/D75414

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

thakis added a comment. Hello, this breaks check-clang everywhere, e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/69062/steps/test-check-all/logs/FAIL%3A%20Clang-Unit%3A%3ATestReturnValueUnderConstructionChecker.ReturnValueUnderConstructionChecker Please

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

thakis added a comment. Breaks tests on windows: http://45.33.8.238/win/17229/step_9.txt Please take a look and revert if it takes a while to fix. (Might just be the usual delayed template parsing thing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

thakis added a comment. > Thank you, I think I fixed it now. I worked on it for hours, because it > involved lots of git branch changes and the the rebuild was slow. Thanks for the fix! If you notice that fixing a bot will take more than a few minutes, please revert the commit while you work on

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

thakis added a comment. This breaks check-clang on mac: http://45.33.8.238/mac/15258/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D7

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

thakis added a comment. This breaks mac again: http://45.33.8.238/mac/15259/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 ___ cfe-commits mailing l

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

thakis added a comment. This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt Please take a look, and please revert for now if fixing takes a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

thakis added inline comments. Comment at: clang/test/CoverageMapping/coroutine.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping %s | FileCheck %s + -

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

thakis added a comment. That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986 _

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

thakis added a comment. This seems to break tests everywhere, eg http://45.33.8.238/linux/22152/step_7.txt or http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/11251 Please take a look and revert if the fix takes a while. Repository: rG LLVM Github Monorepo

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt The output contains 5: clang: warning: argument unused during compilation: '--rocm-path=/Users/thakis/src/llvm-project/clang/test/Driver/Inputs/rocm' [-Wunused-command-line-argument] which if t

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. …oh, njames said that already 5h ago :) I guess I'll wait another hour or two, and then I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930 __

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. Great, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/mac/15751/step_10.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

thakis added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c:3 // RUN: %clang_cc1 -D__ARM_FEATURE_SVE -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1 -Werror -Wall -emit

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Failing on Windows too, actually: http://45.33.8.238/win/17931/step_10.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 ___ cfe-commi

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. This is still broken; bots have been red for a few hours now. Can we revert and analyze async, to keep the bots green please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is happy so it's not broken on all Windows machines. Guess I'll take a look on what's going on. You can hold off on the revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. I took a look. It consistently fails for me on mac and on Windows in a `git bash` shell, but it passes in cmd with unxutils. Maybe this needs something like eac56724fd955af0f8521557cacc57a83f371649 ?

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

thakis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen) All other tblgen outputs are called .inc, not .h

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

thakis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen) jdoerfert wrote: > clementval wrote: > > thakis

[PATCH] D82362: Move default module cache from system temporary directory

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/mac/16222/step_11.txt Please take a look and revert for now if this takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm

[PATCH] D82362: Move default module cache from system temporary directory

thakis added a comment. Reverted for now in 4d5c4489435dc1cb3d4989614e96b157c74afdea Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm.org/D82362

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

thakis added a comment. This seems to cause build errors sometimes when buildling libclang. Maybe there are more missing dependencies? Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8876400305251533648/+/steps/gclient_runhooks/0/stdout Repositor

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. This breaks chevk-clang-tools in mac: http://45.33.8.238/mac/16292/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.o

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. It's the only change on the blame list, things pass consistently before the change, and fail consistently after it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 ___

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. I reverted this in 8f73c4432b5fa8510c99a5053c07dc70a610e1fb and check-clang-tools stopped failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/ne

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. In D82188#2119393 , @njames93 wrote: > @thakis Do those bots use `gn`, could that be the cause of the failures? It's possible, but unlikely, given that your change doesn't touch any build files. …and indeed, I checked out `8f73c

[PATCH] D82606: [clangd] Config: config struct propagated through Context

thakis added a comment. The test fails on mac and win: http://45.33.8.238/mac/16341/step_9.txt http://45.33.8.238/win/18704/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606 _

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

thakis added a comment. This (or a follow-up) broke tests on windows: http://45.33.8.238/win/18877/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://revie

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/13855/step_9.txt Please take a look and revert while you do if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.l

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

thakis added inline comments. Comment at: clang/lib/CrossTU/CMakeLists.txt:13 clangIndex + clangTooling + clangSerialization We've been very careful to make clang (the compiler binary) only depend on clangToolingCore and not on the much bigger clangTooling

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

thakis added a comment. Looks like this also breaks tests on Windows and Mac, eg http://45.33.8.238/win/13902/step_7.txt It probably makes sense to revert while you investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://rev

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

thakis added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]); ---

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. Is there more background on this somewhere? What's the advantage of using Python3_EXECUTABLE instead of just PYTHON_EXECUTABLE? Having Python3_EXECUTABLE be python 2 seems pretty surprising to me. Also, this doesn't update some PYTHON_EXECUTABLEs, e.g. the one in lld/tes

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I believe this breaks check-builtins on macOS. See https://bugs.chromium.org/p/chromium/issues/detail?id=1076480 for details. The `split()` on the subprocess output throws since it wants a b'.' on py3, but that code has an unqualified except block. That means (I think) w

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I attempted a fix in e071ea48e923651ae21b9b684b0473248630322c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

thakis created this revision. thakis added a reviewer: hans. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The approach in D3 assumes that the '/' returned by path::begin() is the first element for absolute paths, but that's not true

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

thakis updated this revision to Diff 261481. thakis edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Lexer/case-insensitive-include-ms.c clang/test/Lexer/ca

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis created this revision. thakis added a reviewer: compnerd. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Currently, normalize() for posix replaces backslashes to slashes, except that two backslashes in sequence are kept as-is. clang calls normalize() to convert \ to /

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

thakis added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:390 +for nameless_value in nameless_values: +if re.fullmatch(nameless_value.ir_prefix + r'[0-9]+?', var, re.IGNORECASE): +warn("Change IR value name '%s' to prevent possible c

[PATCH] D84005: Introduce ns_error_domain attribute.

thakis added a comment. Looks like this breaks check-clangd on Windows: http://45.33.8.238/win/21943/step_9.txt Please take a look, and revert while you investigate if the fix takes a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

thakis added a comment. Looks like this breaks check-clang on Windows: http://45.33.8.238/win/14483/step_7.txt And some other bots: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/37883/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aacle_sve_dupq.c http://lab.llvm.

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis added a comment. In D79265#2018770 , @compnerd wrote: > What happens if you encounter a `"\t"` as a string? This would convert that > to a `"/t"` would it not? Although, I suppose that in practice the treatment > of escaped characters is not imp

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis updated this revision to Diff 261980. thakis added a comment. restore else CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79265/new/ https://reviews.llvm.org/D79265 Files: clang/test/Lexer/case-insensitive-include-ms.c llvm/lib/Support/Path.cpp llvm/unittests/Support/Path.c

<    1   2   3   4   5   6   7   8   9   10   >