thakis added a comment.

In D79265#2018770 <https://reviews.llvm.org/D79265#2018770>, @compnerd wrote:

> What happens if you encounter a `"\t"` as a string?  This would convert that 
> to a `"/t"` would it not?  Although, I suppose that in practice the treatment 
> of escaped characters is not important.  I think I still prefer the `} else 
> {` here over the early return.


`"\t"` is converted to `"/t"`. That's also the behavior before this change 
though – only '\' followed by '\' was handled specially before, not '\' 
followed by anything else.

I restored the else and removed the early return.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79265/new/

https://reviews.llvm.org/D79265



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to