[PATCH] D116059: [Clang][CFG] check children statements of asm goto

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a604fdbcd5f: [Clang][CFG] check children statements of asm goto (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675 + HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || +ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; + + // Check features that are manually disabled by command li

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

nickdesaulniers added a comment. Linus Torvalds thoughts on the patches as a result of this change. > Those uses of 1E6L were perhaps strange, but they were only used in > constant compile-tim

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79ebc3b0dd13: [llvm][test] rewrite callbr to use i rather than X constraint NFC (authored by nickdesaulniers). Changed prior to commit: https://re

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8463fd22b1f: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests (authored by nickdesaulniers). Changed prior to commit:

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c562f62a4ee: [clang] number labels in asm goto strings after tied inputs (authored by nickdesaulniers). Changed prior to commit: https://reviews.

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

This revision was automatically updated to reflect the committed changes. Closed by commit rG73ee4e1cbd64: [clang][ARM] only check -mtp=cp15 for non-asm sources (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114124/new/

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820 +// semantic analysis passes. +while (isa(Ex)) + Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr()); + Q: are there any unary operators that are not cas

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820 +// semantic analysis passes. +while (isa(Ex)) + Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr()); + void wrote: > nickdesaulniers wrote: > > Q: are t

[PATCH] D115311: [WIP] alternative approach to D114895

nickdesaulniers created this revision. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested in: https://reviews.llvm.org/D114895#3177794. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115311 Fil

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers created this revision. Herald added subscribers: wenlei, pengfei, asbirlea, zzheng, kbarton, hiraditya, nemanjai. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In D115311

[PATCH] D115311: [WIP] alternative approach to D114895

nickdesaulniers updated this revision to Diff 392983. nickdesaulniers added a comment. Herald added subscribers: llvm-commits, pengfei, hiraditya. Herald added a project: LLVM. - write an actual commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 392984. nickdesaulniers retitled this revision from "[WIP] alternative approach to D114895" to "[clang][CGStmt] emit i constraint rather than X for asm goto indirect dests". nickdesaulniers edited the summary of this revision. nickdesaulniers added a

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers updated this revision to Diff 392988. nickdesaulniers added a comment. Herald added subscribers: cfe-commits, wenlei, asbirlea, zzheng, kbarton, nemanjai. Herald added a project: clang. - I'm just wrestling with arc at this point Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 392990. nickdesaulniers added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files: llvm/test/Assembler/call-arg-is-callee.ll llvm/te

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 392993. nickdesaulniers added a comment. - phab sux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files: llvm/test/Assembler/call-arg-is-callee.ll llvm/

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers updated this revision to Diff 392994. nickdesaulniers added a comment. - phab sux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115409/new/ https://reviews.llvm.org/D115409 Files: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers added inline comments. Comment at: llvm/test/Verifier/callbr.ll:41 ; the asm goto is in the arg list to the asm). - callbr void asm sideeffect "${0:l} ${1:l} ${2:l}", "X,X,X"(i8* blockaddress(@test3, %4), i8* blockaddress(@test3, %2), i8* blockaddress(@test3

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8556 unsigned ResNo = 0; // ResNo - The result number of the next output. - unsigned NumMatchingOps = 0; for (auto &

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 393001. nickdesaulniers added a comment. - try to update this correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115311/new/ https://reviews.llvm.org/D115311 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/callbr-asm-bb-exports.ll:23 +; CHECK-NEXT: t30: ch,glue = inlineasm_br t22, {{.*}}, t22:1 +; CHECK-NEXT: t32: ch = br t30, BasicBlock:ch @craig.topper can you triple check this change to t

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, efriedma, jyknight, craig.topper. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that the following case would compile in Clang but not

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers added a comment. In D115471#3184384 , @jyknight wrote: > It's rather sad that GCC made the quite-unintuitive decision to number the > arguments in this way -- LONG AFTER clang had already implemented the other > way... I doubt it was in

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 393577. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - note this semantic change in the release notes, add links to GCC docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 393630. nickdesaulniers added a comment. - fix typo in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/ https://reviews.llvm.org/D115471 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNotes.rst:157 ABI stability. +- When using ``asm goto`` with outputs whose constraint modifier is ``"+"``, we + now change the numbering of the labels to occur after hidden tied inputs for x

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. In D115409#3190589 , @jyknight wrote: > OK, I do think that special case definitely needs to be deleted. It's > assuming that the block args are in a particular place in the argume

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 394403. nickdesaulniers added a comment. - rebase onto D115688 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files: llv

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %retur

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 394406. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase onto D115688 + D115410 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 394415. nickdesaulniers added a comment. - rebase onto D115688 +D115410 +D115311 , add notes to clang/docs/LanguageExtensions.rst Repository: rG

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

nickdesaulniers added a comment. Thanks for the patch. You're right about this change, sorry I made the mistake! Comment at: clang/test/CodeGen/stack-protector-guard.c:1-12 +// RUN: %clang_cc1 -mstack-protector-guard=sysreg -triple x86_64-unknown-unknown \ +// RUN: -mstack-p

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %retur

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, jyknight, jyu2, efriedma. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When performing CFG based analyses, don't forget to check the child stat

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:3359 + + return VisitStmt(G, asc); } I think this should actually be `return VisitChildren(G);`; it produces a simpler CFG with the

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers updated this revision to Diff 395539. nickdesaulniers added a comment. - VisitChildren rather than VisitStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 Files: clang/lib/Analysis/CFG

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] = MayUninitial

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/x86-outline-atomics.c:1-7 +// RUN: %clang -target x86_64 -moutline-atomics -S %s -### 2>&1 | FileCheck %s -check-prefix=C

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return)) + callbr void asm sideeffect "", "i,i,~{dirfl

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers created this revision. nickdesaulniers added reviewers: nathanchance, ardb, peter.smith. Herald added a subscriber: kristof.beyls. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This conditional check for -m

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3219-3226 // Check whether the target subarch supports the hardware TLS register - if (arm::getARMSubArchVersionNumber(EffectiveT

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3219-3226 // Check whether the target subarch supports the hardware TLS register - if (arm::getARMSubArchVersionNumber(EffectiveTriple) < 7 && - llvm::ARM::parseArch(Effe

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3219-3226 // Check whether the target subarch supports the hardware TLS register - if (arm::getARMSubArchVersionNumber(EffectiveTriple) < 7 && - llvm::ARM::parseArch(Effe

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-cortex-cpus.c:445 +// RUN: %clang -target armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s +// RUN: %clang -target arm -march=armv9.3a -mlittle-endian -### -c %s 2>&1 | File

[PATCH] D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd284b7ac061: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Let's drop the Android part, too? Update the description (commit message), too? I checked our oldest supported kernel version, and we don't use `-B` either: https:/

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2657509 , @MaskRay wrote: > gcc does not understand options in `-Wa,` so `-Wa,--version` needs to be used > this way: `gcc -Wa,--version -c -x assembler /dev/null -o /dev/null` > The verbose syntax makes it not t

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added inline comments. Comment at: clang/test/Driver/as-version.s:9 +// RUN: | FileCheck --check-prefix=GAS %s +// GAS: GNU assembler What happens if we run this on windows (where I suspect that GAS isn't available)? Perhaps a `CHECK-NOT: clan

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. ah, sorry, I think we're missing a `// REQUIRES: linux` in the newly added test? I've pushed a revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 _

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2662990 , @jcai19 wrote: > We can probably remove the -fno-integraetd-as case. Or split it out into a separate test file with `// REQUIRES: linux`. Either actually is fine by me. Repository: rG LLVM Github

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

nickdesaulniers accepted this revision. nickdesaulniers added a comment. I don't foresee this affecting Linux kernel builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 _

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

nickdesaulniers added a comment. > Let's first give users tools to weed out the cases where the pointer > passed into function's argument is underaligned. Isn't there already `-Walign-mismatch` in clang? We definitely have 1 unresolved case of that affecting the Linux kernel ATM: https://githu

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. > -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame > while > -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address > produces .eh_frame. Does this patch change that behavior? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. In D100251#2684083 , @MaskRay wrote: > In D100251#2684074 , > @nickdesaulniers wrote: > >>> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame >>> while >>>

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/Function.h:156 + static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers created this revision. nickdesaulniers added reviewers: xiangzhangllvm, efriedma, MaskRay. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. I still have some todos that I will get to tomorrow, but posting this early for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 __

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) TODO: can we re-use `AArch64SysReg::lookup

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Pretty sure I need to do something with non-zero values of `-mstack-protector-guard-offset=0`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://rev

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Nice idea to create `Function::createWithDefaultAttr` then reuse for multiple purposes! Comment at: llvm/lib/IR/Function.cpp:333 Function *Function::cre

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

nickdesaulniers added a comment. Compiler crash reported in: https://bugs.llvm.org/show_bug.cgi?id=48695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78105/new/ https://reviews.llvm.org/D78105 ___ cfe-c

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

nickdesaulniers added a comment. Much thanks for the patch! Comment at: clang/test/Driver/sigpipe-handling.c:2 +// REQUIRES: shell +// RUN: %clang -E -fno-integrated-cc1 %s | tee /dev/null | head -n1 | FileCheck %s + Looks like clang -E -fno-integrated-c

[PATCH] D94442: clang: Always pass PowerPC endian information to GNU as

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a23fbd28c75: clang: Always pass PowerPC endian information to GNU as (authored by nathanchance, committed by nickdesaulniers). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repos

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

nickdesaulniers added a comment. See also: https://github.com/ClangBuiltLinux/linux/issues/1477. Surprising that this didn't show up in newer kernels, just older (but still supported) kernel versions. Sorry I missed that in my tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

nickdesaulniers added a comment. Also reported here: https://lore.kernel.org/llvm/1817774243.12566.1634255267713@localhost/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 ___

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added a subscriber: nathanchance. nickdesaulniers added a comment. Yes; GCC does behave this way. It does not consider a non-gnu-inline redefinition an error, and it does seem to prefer the non-gnu-inline redeclaration when both are present, AFAICT. The test is verifying that

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added subscribers: aaron.ballman, rsmith. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1302 // in case the function pointer is referenced somewhere. - if (FD->isInlineBuiltinDeclaration() && Fn) { + if (Fn) { s

[PATCH] D112135: [ARM] Fix inline assembly referencing floating point registers on soft-float targets

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112135/new/ https://reviews.llvm.org/D112135 _

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added a comment. Bumping for an update here. We can tolerate a build breakage for our older kernels over the weekend, but we should really try to get this resolved by EOW, otherwise we need to look into reverting: - 3d6f49a56995b845c40be5827ded5d1e3f692cec

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1302 // in case the function pointer is referenced somewhere. - if (FD->isInlineBuiltinDeclaration() && Fn) { + if (Fn) { std::string FDInlineName = (Fn->getName() + ".inline").str(

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1302 // in case the function pointer is referenced somewhere. - if (FD->isInlineBuiltinDeclaration() && Fn) { + if (Fn) { std::string FDInlineName = (Fn->getName() + ".inline").str(

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1302 // in case the function pointer is referenced somewhere. - if (FD->isInlineBuiltinDeclaration() && Fn) { + if (Fn) { std::string FDInlineName = (Fn->getName() + ".inline").str(

[PATCH] D106030: [Clang] add support for error+warning fn attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG846e562dcc6a: [Clang] add support for error+warning fn attrs (authored by nickdesaulniers). Changed prior to commit: https://reviews.llvm.org/D106030?vs=366717&id=368678#toc Repository: rG LLVM Githu

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. I'm getting test failures for the newly added llvm/test/CodeGen/X86/attr-dontcall.ll, thought there's not much info other than > Exit Code: 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://revie

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. Fixup: https://reviews.llvm.org/D108718 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 ___ cfe-commits mailing list cfe-commit

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1890 -if (auto FD = dyn_cast(D)) - return CGM.GetAddrOfFunction(FD); +if (auto FD = dyn_cast(D)) { + auto *C = CGM.GetAddrOfFunction(FD); fix linter warnin

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

nickdesaulniers added a comment. In D107420#2929115 , @craig.topper wrote: > In D107420#2929039 , @aaron.ballman > wrote: > >> In D107420#2928975 , @craig.topper >> wro

<    11   12   13   14   15   16