nickdesaulniers added a comment. Thanks for the patch. You're right about this change, sorry I made the mistake!
================ Comment at: clang/test/CodeGen/stack-protector-guard.c:1-12 +// RUN: %clang_cc1 -mstack-protector-guard=sysreg -triple x86_64-unknown-unknown \ +// RUN: -mstack-protector-guard-reg=sp_el0 -mstack-protector-guard-offset=1024 \ +// RUN: -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -mstack-protector-guard=sysreg -triple powerpc64le-linux-gnu \ +// RUN: -mstack-protector-guard-reg=sp_el0 -mstack-protector-guard-offset=1024 \ +// RUN: -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -mstack-protector-guard=sysreg -triple arm-eabi-c \ ---------------- `sp_el0` doesn't make sense for these targets; it's an aarch64 specific MSR. Let's delete these lines from the test? ================ Comment at: clang/test/CodeGen/stack-protector-guard.c:16 +// RUN: -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -emit-llvm %s -triple x86_64-unknown-unknown -o - \ +// RUN: | FileCheck --check-prefix=CHECK-NONE %s ---------------- `x86_64-linux-gnu` ================ Comment at: clang/test/CodeGen/stack-protector-guard.c:16-23 +// RUN: %clang_cc1 -emit-llvm %s -triple x86_64-unknown-unknown -o - \ +// RUN: | FileCheck --check-prefix=CHECK-NONE %s +// RUN: %clang_cc1 -emit-llvm %s -triple powerpc64le-linux-gnu -o - \ +// RUN: | FileCheck --check-prefix=CHECK-NONE %s +// RUN: %clang_cc1 -emit-llvm %s -triple arm-eabi-c -o - \ +// RUN: | FileCheck --check-prefix=CHECK-NONE %s +// RUN: %clang_cc1 -emit-llvm %s -triple thumbv7-eabi-c -o - \ ---------------- nickdesaulniers wrote: > `x86_64-linux-gnu` Or let's just delete these? ================ Comment at: clang/test/CodeGen/stack-protector-guard.c:20 +// RUN: | FileCheck --check-prefix=CHECK-NONE %s +// RUN: %clang_cc1 -emit-llvm %s -triple arm-eabi-c -o - \ +// RUN: | FileCheck --check-prefix=CHECK-NONE %s ---------------- `arm-linux-gnueabi` ================ Comment at: clang/test/CodeGen/stack-protector-guard.c:22 +// RUN: | FileCheck --check-prefix=CHECK-NONE %s +// RUN: %clang_cc1 -emit-llvm %s -triple thumbv7-eabi-c -o - \ +// RUN: | FileCheck --check-prefix=CHECK-NONE %s ---------------- `thumbv7-linux-gnueabi` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116003/new/ https://reviews.llvm.org/D116003 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
