[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for fixing this! Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:351 + EXPECT_DECLS("TemplateArgumentLoc", {"template class ...T"}); + Flags.clea

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Now that consteval and constinit are possible values, 1 bit is no longer enough.

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

nridge added a comment. Not sure if clangd is the best place to test this. I'm open to other suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/ https://reviews.llvm.org/D111971 ___ c

[PATCH] D112403: [clangd] Respect diagnostic suppression during preamble build

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/clangd

[PATCH] D111120: [clangd] Find explicit references in the base-specifier of an enum decl

nridge abandoned this revision. nridge added a comment. Yep, thanks very much for the more complete fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20/new/ https://reviews.llvm.org/D20 ___ cfe

[PATCH] D112403: [clangd] Respect diagnostic suppression during preamble build

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6a971b1baec: [clangd] Respect diagnostic suppression during preamble build (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112403/new/

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:538 +for (size_t I = 0; I < FD->getNumParams(); ++I) { + if (const auto *Param = FD->getParamDecl(I)) { +auto T = Param->getType(); tom-anders wrote: > sa

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Thanks for the update! Looks pretty good, just a few minor comments from me. Will leave approval to Sam. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 std::vector Tokens; + std::map> ExtraModifiers; const HeuristicResolver *Re

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Thanks for the updates! LGTM from my side. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:555 + // Iterate over the types of the function parameters. + // If any of them are non-const reference paramteres, add it as a + // h

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:346 + + static const size_t TypeNameLimit = 32; }; I'm open to suggestions for what the length limit should be, here I made a fairly arbitrary choice. Repository: rG LLVM Git

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge added a comment. (The relevant issue is https://github.com/clangd/clangd/issues/824_ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108972/new/ https://reviews.llvm.org/D108972 ___ cfe-commits mail

[PATCH] D108975: [clangd] Omit default template arguments from type hints

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge added a comment. In D108972#2981893 , @kadircet wrote: > A stepping stone would be to just truncate all the template arguments (e.g. > `tuple, foo>` becomes `tuple<...>` even if `tuple, > foo<...>>` could fit under the limit). I was thinking the

[PATCH] D108972: [clangd] Omit type hints that are too long

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2810f2c1655: [clangd] Omit type hints that are too long (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108972/new/ https://reviews.llv

[PATCH] D108975: [clangd] Omit default template arguments from type hints

nridge updated this revision to Diff 370994. nridge marked an inline comment as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108975/new/ https://reviews.llvm.org/D108975 Files: clang-tools-ex

[PATCH] D108975: [clangd] Omit default template arguments from type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e03d92e2f4a: [clangd] Omit default template arguments from type hints (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. I'm happy to commit it. Did you want to make the `SmallVector<1>` --> `uint32_t` change, or should I just commit it as is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a85f9b1d48c: Add semantic token modifier for non-const reference parameter (authored by tom-anders, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Apologies, forgot about this. Commited now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320 ___ cfe-commits mailing list cfe-commits@l

<    9   10   11   12   13   14