nridge added a comment.
Thanks for the updates! LGTM from my side.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:555
+ // Iterate over the types of the function parameters.
+ // If any of them are non-const reference paramteres, add it as a
+ // highlighting modifier to the corresponding expression
----------------
nit: still a typo here ("paramteres")
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:562
+ // Is this parameter passed by non-const reference?
+ // FIXME The condition !T->idDependentType() could be relaxed a bit,
+ // e.g. std::vector<T>& is dependent but we would want to highlight it
----------------
nit: typo (idDependentType)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108320/new/
https://reviews.llvm.org/D108320
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
