[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fa7e4adcafb: [clang-format] NFC Correct clang-format headers file so documentation can be… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

This revision was automatically updated to reflect the committed changes. Closed by commit rG14198ccfb383: [clang-format] Fix lambda with ellipsis in return type (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. You will need to rebase as the non related rst changes have been handled by D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated CHANGES SINCE LAST ACTION https://review

[PATCH] D79022: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b8bd0f8d55: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79020: [clang-format] Correct the AfterControlStatement configuration option output style

This revision was automatically updated to reflect the committed changes. Closed by commit rG573322694ad3: [clang-format] Correct the AfterControlStatement configuration option output… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. These tests still fail running the following in the build directory (if your build directory is side-by-side with the llvm-project directory): c:/Python37/python ./bin/llvm-lit.py -v ./tools/clang/test/Format $ ./run_format_lit_tests.sh llvm-lit.py: C:\cygw

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:2693 + llvm::vfs::FileSystem *FS, +

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. See https://bugs.llvm.org/show_bug.cgi?id=45626 void f() { (void)static_cast<::std::uint32_t>(1); (void)static_cast< ::std::uint32_t >(1); }

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___ cfe-commits mailing li

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: sylvestre.ledru, sammccall, krasimir, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. Follow on from D78879: [clang-format] [PR45357] Fix issue found with operator spacing to

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

MyDeveloperDay updated this revision to Diff 261340. MyDeveloperDay added a comment. Update so the pre-merge checks do there thing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79172/new/ https://reviews.llvm.org/D79172 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/For

[PATCH] D79172: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading space before :: operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG511868dcf3b9: [clang-format] [PR45626] SpacesInAngles does not insert or preserve leading… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D79204: [clang-format] NFC - clang-format the FormatTests

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. Ensure the clang-format unit tests are themselves clang-formatted Having areas of the llvm code which are clang-format clean, give us mo

[PATCH] D79204: [clang-format] NFC - clang-format the FormatTests

This revision was automatically updated to reflect the committed changes. Closed by commit rGece7e95f02cd: [clang-format] NFC - clang-format the FormatTests (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79204/new/ https

[PATCH] D79292: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing /bigobj

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: ABataev, jdoerfert, aaron.ballman, rnk. MyDeveloperDay added a project: clang. Herald added a subscriber: mgorny. Unable to build sema library on MSVC with Debug target C:\clang\llvm-project\clang\lib\Sema\SemaOpenMP.cpp : fa

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, hans, krasimir, mitchell-stellar, sammccall, pawels. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. Fix to address https://bugs.llvm.org/show_bug.cgi?id=45218 T

[PATCH] D79292: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing /bigobj

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e194a3b9356: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 261656. MyDeveloperDay added a comment. Update for pre-merge checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay added a comment. In D79293#2016410 , @rmansfield wrote: > Couple examples: > > void foo(int x) { > > for (unsigned int i = 0; i < x >> 1; i++) { } > > } > > and > > int i = 0; > > if (i < x >> 1) {} > > > } I don't deny there

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 261705. MyDeveloperDay added a comment. Add more test cases to try to ensure TemplateOpener/Closer type isn't assigned incorrectly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 Files: clang/lib/

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. > For what is worth, with lambdas in unevaluated context (C++20), you can get a > semicolon between template opener/closer easily: I actually no longer need the check for the semi if the TemplateOpener/Closer is co

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 261748. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Remove tok::semi check as its not actually needed now we label the < and > correctly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://re

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay updated this revision to Diff 261768. MyDeveloperDay added a comment. Remove extraneous cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp I

[PATCH] D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, Wawha, duncan-llvm. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45791 Lambda with line comment is incorrectly formatted auto k = []() // comment { return;

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. Its currently not possible to recreate the GNU style using the `BreakBeforeBraces: Custom` style due to a lack of missing `BeforeWhile`

[PATCH] D79326: [clang-format] ensure dump_format_style.py works with Python3 correctly

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall, owenpan. MyDeveloperDay added projects: clang, clang-format. Python2 has been removed from cygwin, this means anyone running the dump_format_style.py in a cygwin shell could pick up python

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, marejde, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=34574 https://bugs.llvm.org/show_bug.cgi?id=38401 template class [[nodiscard]] resul

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

MyDeveloperDay added a comment. If we are concerned about affecting other workflows about if we added a new command line option to trigger your behavior? I'd also like to see some lit tests in clang/test/Format to exercise the -lines so we really understand its usage I also wonder if anyone el

[PATCH] D79372: [clang-format] [PR45126] Help text is missing all available formats

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45126 GNU and Microsoft styles are built in supported styles but are not displayed in the help te

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45639 clang-format incorrectly splits the `[[` in a long argument list void SomeLongClassName::

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a subscriber: VelocityRa. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm struggling with the simplicity of your solution ;-) (that's a compliment!) I've pulled this patch and built it locally. It ce

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

MyDeveloperDay added a comment. In D79000#2009813 , @jbcoe wrote: > public int Style2 > { get; set } > > > appears in MS examples > https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/properties > > public int Style2

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added a comment. bool FormatTokenLexer::tryMergeAtTry() { if (Tokens.size() < 2) return false; auto &At = *(Tokens.end() - 2); auto &Try = *(Tokens.end() - 1); if (!At->is(tok::at) || !String->is(tok::try)) return false; At->Tok.setKind(tok::try);

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can we abandon this review now we have the style=file:? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/ https

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. You need to regenerate the ClangFormatStyleOption.rst file using docs/tools/dump_format_style.py Comment at: clang/include/clang/Format/Format.h:965 bool AfterExternBlock; +enum ExternBlock { + /// Break extern blocks before the cu

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. If there is no additional comments from others then I'm fine giving this a LGTM, if it means we can encourage other big projects to go full clang-format CHANGES SINCE LAST ACT

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. In D79388#2019985 , @JakeMerdichAMD wrote: > @MyDeveloperDay, you're right about what this issue addresses: it surprised > me a lot when an unrelated edit caused something to 'randomly' add spaces > elsewhere, since it's

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79414/new/ https://reviews.llvm.org/D79414

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. In D78869#2019933 , @DaanDeMeyer wrote: > (I don't have commit access so it'd be great if someone could merge this for > me, at least that's how my other contributions have been handled) You really should think about gett

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. In D79388#2020320 , @JakeMerdichAMD wrote: > Sure, I'll get started on that. It mainly comes from charging headfirst into > the edge cases, but I think I have a decent grasp of clang-format internals > now, and I'm defini

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay added a comment. In D79354#2020722 , @krasimir wrote: > I have an example where this goes wrong in ObjC (modulo indentation): > > I think we should try harder to detect the beginning of an attribute > specifier. I think there may be a helpe

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay updated this revision to Diff 262231. MyDeveloperDay added a comment. Reduce false formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cp

[PATCH] D79465: Fix line lengths w/ comments in align

MyDeveloperDay added a comment. I don't seem to be able to reproduce the original problem (either will your test case or the bad.h) It would be good if the PR had the exact .clang-format file being used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. In D78869#2022850 , @mitchell-stellar wrote: > I often: I develop and run on windows (using a cygwin shell), but with visual studio compiler (configured with CMake for ninja) 0.5 after doing git add of the files, I d

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

MyDeveloperDay added a comment. > You could adapt that code to not break before the second `TT_AttributeSquare` > in `[[` or `]]`; this will have the same effect and generalize. sounds good... let me try that change and see if we like it better Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2405 tok::kw___attribute, tok::kw___declspec, -

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay updated this revision to Diff 262662. MyDeveloperDay added a comment. Change to TT_AttributeSquare CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTe

[PATCH] D79372: [clang-format] [PR45126] Help text is missing all available formats

This revision was automatically updated to reflect the committed changes. Closed by commit rG305a4abfd3a1: [clang-format] [PR45126] Help text is missing all available formats (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D79326: [clang-format] ensure dump_format_style.py works with Python3 correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rG3125aa99593d: [clang-format] ensure dump_format_style.py works with Python3 correctly (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b8ffb414200: [clang-format] [PR45791] BeforeLambdaBody is confused by comment inside lambda (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2170 parseBlock(/*MustBeDeclaration=*/false); -if (Style.BraceWrapping.IndentBraces) +if (Style.BraceWrapping.IndentBraces || S

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 262727. MyDeveloperDay added a comment. Handle addition calse if (w>, 1>::t) return true; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 Files: clang/lib/Format/TokenAnnotator.cpp clang/unitte

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

MyDeveloperDay updated this revision to Diff 262725. MyDeveloperDay added a comment. Simplify to ensure we don't break in between the two `TT_AttributeSquares` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79401/new/ https://reviews.llvm.org/D79401 Files: clang/lib/Format/TokenAnnota

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a4ddbd69db2: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay updated this revision to Diff 262764. MyDeveloperDay added a comment. Address review comments and ensure existence of closing `]` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2431 +// Consume the closing TT_AttributeSquare. +nextToken(); + } krasimir wrote: > slight concern: c

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 262768. MyDeveloperDay added a comment. I'm returning to this revision which I'd left to think about, this update is really just a rebase and also to remove the dual configuation. For now I will still with just Left/Right const to avoid confusion. I'

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 262772. MyDeveloperDay added a comment. remove macros from the unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 262779. MyDeveloperDay added a comment. Refactor the analyse function to reduce the function size CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clan

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG31fd12aa0956: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay added a comment. I've been able to reproduce and the patch looks good, I've just not had a chance to read the review in-depth (I don't know this section of the code as well as other parts). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#1976981 , @bbassi wrote: > @MyDeveloperDay hey, I am currently working on this, and adding a new option > called BreakBeforeClosingBracket. I have some questions to understand the > existing code, they might not

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#2028254 , @bbassi wrote: > @MyDeveloperDay Thanks. This would be my first revision and I have few > questions before I start coding. Would you be able to answer those over > email? They are mainly about the desig

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay added a comment. gentle ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay added a comment. @Abpostelnicu as you requested changes I need an "Accept" from you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, owenpan, jbcoe, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. This is a starting point to improve the handling of concepts in clang-format. There is currently no real formatting of

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 263494. MyDeveloperDay added a reviewer: saar.raz. MyDeveloperDay added a subscriber: saar.raz. MyDeveloperDay added a comment. Add additional parsing of concept and require keywords to allow formatting Include some more of @saar.raz examples in the te

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1924 return TT_BinaryOperator; } This change it to resolve the missing gap between `&&` and `Concept2`, clang-f

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2eb43931757: [clang-format] Fix AlignConsecutive on PP blocks (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https:

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGc82243d0675b: [clang-format] : Fix additional pointer alignment for overloaded operators (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay added a reviewer: abrachet. https://bugs.llvm.org/show_bug.cgi?id=44476 template [[nodiscard]] int a(

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sammccall, curdeius. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=44345 When namespaces get long the namespace end comment wraps onto the

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Assuming you either work for google and understand their style or are qualified to say this is their style then this LGTM What I couldn't see from the link was where the google

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:417 +LineLengthAfter += Changes[j].TokenLength; +} unsigned ChangeMaxColumn = Style.ColumnLimit - LineLengthAfter; could you help us here with a comment, I d

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

MyDeveloperDay added a comment. I think we can abandon this revision now we support --style=file: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34252/new/ https://reviews.llvm.org/D34252 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

MyDeveloperDay added a comment. I'm ok with your suggestion if you want to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79000/new/ https://reviews.llvm.org/D79000 ___ cfe-commits mailing li

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. ping @tnorth are you planning on fixing this as its currently reverted. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, owenpan, sylvestre.ledru. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay retitled this revision from "[clang-format] Incorrectly indents [[nodiscard]] attribute fu

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. let me try that.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

MyDeveloperDay added a comment. In D79990#2038207 , @Abpostelnicu wrote: > @MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see > if there is any fallout. I wonder is there a documented way to run clang-format over the gekco sou

[PATCH] D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sylvestre.ledru, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45942 With Chromium style (although that is not important) it

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

MyDeveloperDay updated this revision to Diff 264231. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Change to const & CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 Files: clang/lib/Format/UnwrappedLineParser

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay updated this revision to Diff 264235. MyDeveloperDay added a comment. Use BeforeWhile and not IndentBraces to wrap the line Update the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325 Files: clang/docs/ClangFormatSt

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

MyDeveloperDay updated this revision to Diff 264319. MyDeveloperDay added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79935/new/ https://reviews.llvm.org/D79935 Files: clang/lib/Format/NamespaceEndCommentsFixer.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8ea35e63f50: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

MyDeveloperDay updated this revision to Diff 264325. MyDeveloperDay added a comment. pre-merge tests showed I wasn't quite rebased however it overlaps with D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration However I feel I mad

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

MyDeveloperDay updated this revision to Diff 264327. MyDeveloperDay edited the summary of this revision. MyDeveloperDay added a comment. Correct the typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79905/new/ https://reviews.llvm.org/D79905 Files: clang/lib/Format/TokenAnnotator.cp

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: ghvg1313, krasimir, jolesiak, Eugene.Zelenko. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. The release notes for `ObjCBreakBeforeNestedBlockParam` was placed between the

[PATCH] D80041: [clang-format] [PR45198] deletes whitespace inside of a noexcept specifier

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, rianquinn, JakeMerdichAMD, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45198 The following: template< typename T, enable_if_t::value> = t

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:114 + this occurs when the use of the ``extern`` keyword is neglected in the + declaration of a variable in a header file. In some cases, no specifi

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM just drop the `Noindent` it will encourage inconsistency people can read the manual (plus you don't check it in the tests) Comment at: clang/lib/Format

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

MyDeveloperDay closed this revision. MyDeveloperDay added a comment. I missed the Differential Revision off the commit message https://reviews.llvm.org/rG49c9a68d7fc62aabdf4d625fcb2954555496772b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80031/n

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465 ___

[PATCH] D47521: [clang-format] Fix parsing lambdas with noexcept

MyDeveloperDay added a comment. This was addressed with D56909: [clang-format] Fix line parsing for noexcept lambdas can we please abandon Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47521/new/ https://reviews.llvm.org/D47521

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 264485. MyDeveloperDay added a comment. Missed some cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/BreakableToken.cpp clang/lib

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, klimek, owenpan, sammccall, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay updated this revision to Diff 264485. MyDeveloperDay added a comment. Missed s

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 264492. MyDeveloperDay added a comment. Remove erroneous changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/BreakableToken.cpp cl

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 264495. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/BreakableToken.cpp clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. In D75791#2040558 , @MarcusJohnson91 wrote: > In D75791#2040532 , @MyDeveloperDay > wrote: > > > LGTM > > > So what's the next step? I've never committed to LLVM before. In my min

<    2   3   4   5   6   7   8   9   10   11   >