MyDeveloperDay added a comment. In D79388#2019985 <https://reviews.llvm.org/D79388#2019985>, @JakeMerdichAMD wrote:
> @MyDeveloperDay, you're right about what this issue addresses: it surprised > me a lot when an unrelated edit caused something to 'randomly' add spaces > elsewhere, since it's in a different ifdef block (whether or not it has the > same condition). The code that's aligned should always be across lines that > are visually consecutive, and those ones weren't (in most cases, they aren't > even logically consecutive). > > You're also right that I don't have commit access; this is my first commit in > LLVM. > > > I'm struggling with the simplicity of your solution ;-) (that's a > > compliment!) > > Thank you! You are welcome, Given your obvious level of understanding could I encourage you to gain commit access? (its a relative simple process) The reason I ask is we need people able to review and accept code reviews (this requires commit access), I wonder if you'd be interested in participating in future reviews? Its always nice to have new people on board. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
