[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4995 + verifyFormat("c()->f();"); + verifyFormat("x()->foo<1>;"); + verifyFormat("x = p->foo<3>();"); curdeius wrote: > Wha

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1732489 , @thakis wrote: > Since this was reverted: are you looking into relanding this? I'm not totally sure how they reproduced the UBSAN issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D53482: Add clang-format stability check with FormatTests

MyDeveloperDay added a comment. As @krasimir said we wouldn't normally commit tests which just break as they'd fail on the buildbot and someone would revert your change within 24 hours.. however, what you have here raises an interesting conversation This bug of instability is often raised, I've

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1733946 , @thakis wrote: > The revert message said: > > Vlad Tsyrklevich via cfe-commits > Tue, Oct 29, 1:51 PM (7 days ago) > to via, mydeveloperday > > I've reverted this commit as it was causing UBSan

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. see D69854: [clang-format] [RELAND] Remove the dependency on frontend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, vlad.tsyrklevich, klimek, mitchell-stellar. MyDeveloperDay added projects: clang-format, clang. Herald added a subscriber: mgorny. relanding D68969: [clang-format] Remove the dependency on frontend

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227952. MyDeveloperDay marked an inline comment as done. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Ensure the deduction guides follow a template Add additional test cases raised durin

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

MyDeveloperDay added a comment. In D69854#1734222 , @merge_guards_bot wrote: > Build result: fail - 33803 tests passed, 1 failed and 462 were skipped. > > failed: LLVM.Object/macho-invalid.test > > Log files: console-log.txt >

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

This revision was automatically updated to reflect the committed changes. Closed by commit rG76ec6b1ef69f: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D69577?vs=227952&id=228008#toc Reposi

[PATCH] D69752: clang-format: Add a fallback style to Emacs mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGf349cc37cc48: clang-format: Add a fallback style to Emacs mode (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D69752?vs=227584&id=228010#toc Repository: rG LLVM Githu

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay updated this revision to Diff 228009. MyDeveloperDay marked 9 inline comments as done. MyDeveloperDay added a comment. Address a few grammatical review comments After modifications F10640074: image.png CHANGES SINCE LAST ACTION https://revi

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2001 LS_Latest, -/// Auto: Automatic detection based on the input. -/// Parse using the latest language version. Format based on detected input. +/// Automatic detection based

[PATCH] D56345: [clang-format] Assert that filenames are not empty

MyDeveloperDay updated this revision to Diff 228014. MyDeveloperDay added a reviewer: mitchell-stellar. MyDeveloperDay added a comment. remove the asserts at least for now. This fix is important for people using clang-format integrated into some editor tools. CHANGES SINCE LAST ACTION https

[PATCH] D56345: [clang-format] Assert that filenames are not empty

MyDeveloperDay commandeered this revision. MyDeveloperDay edited reviewers, added: jr; removed: MyDeveloperDay. MyDeveloperDay added a comment. This revision now requires review to proceed. @jr As there is no response from you, I wonder if you are ok with me taking this over, I'd like to recommen

[PATCH] D56345: [clang-format] Assert that filenames are not empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7681435de148: [clang-format] Assert that filenames are not empty (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56345/new/ http

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

MyDeveloperDay added a comment. Do you need help landing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://reviews.llvm.org/D38446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:310 SourceManager Sources(*Diags, Files); FileID FileID = createInMemoryFile(AssumedFileName, Code.get(), Sources,

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

MyDeveloperDay added a comment. Do you need help landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68568/new/ https://reviews.llvm.org/D68568 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked 2 inline comments as done. Closed by commit rG3ddac7e56363: [clang-format] [RELAND] Remove the dependency on frontend (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGeadb65f273c0: [clang-format] [NFC] update the documentation in Format.h to allow… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, klimek, mitchell-stellar, vlad.tsyrklevich. MyDeveloperDay added projects: clang-format, clang. Review comments in D69854: [clang-format] [RELAND] Remove the dependency on frontend rec

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay updated this revision to Diff 228133. MyDeveloperDay added a comment. Remove unused `Ranges` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69921/new/ https://reviews.llvm.org/D69921 Files: clang/tools/clang-format/ClangFormat.cpp Index: clang/tools/clang-format/Clang

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

MyDeveloperDay added a comment. > But I can still land it if you think it still relevant on its own. I think the design of working through the vector of files is more elegant, especially if we want to consider looking for other files in the future. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall, owenpan. MyDeveloperDay added projects: clang, clang-format. Format.h is used to generate ClangFormatStyleOptions.rst, the layout of the comments is critical to the rst file. Accidentally cl

[PATCH] D53482: Add clang-format stability check with FormatTests

MyDeveloperDay added a comment. In D53482#1737203 , @aardappel wrote: > @MyDeveloperDay thanks for your thoughts.. while `-stable` would be helpful > once you know you have the issue (or to permanently turn on in a git > pre-submit), it does not help dev

[PATCH] D69972: clang-format: [JS] test declared fields.

MyDeveloperDay added a comment. Thanks for this patch, this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69972/new/ https://reviews.llvm.org/D69972 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D69971: clang-format: [JS] support null operators.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69971/new/ https://reviews.llvm.org/D69971 ___

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

MyDeveloperDay added a comment. Just in case you want proof the generated html looks the same: F10665472: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70003/new/ https://reviews.llvm.org/D70003 __

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall, owenpan. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay added a comment. Just in case you want proof the generated html looks the same: F10665472: image.png

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf9e88ae4a4: [clang-format] update comments in clang-format.py for python3 compatibility (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D38446?vs=117280&id=228419#toc

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. mitchell-stellar wrote: > Can this

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. mitchell-stellar wrote: > MyDevelop

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay updated this revision to Diff 228446. MyDeveloperDay added a comment. remove one set of // clang-format on/off that has no visual impact to the html NOTE: it does change the baseline .rst which is why its been added into the review. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay updated this revision to Diff 228491. MyDeveloperDay marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69951/new/ https://reviews.llvm.org/D69951 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: cl

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. gentle ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573 ___ cfe-commits ma

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. In D69764#1740582 , @sammccall wrote: > (Sorry for arriving at this late) > > At a strategic level, I have some concerns here: the fact that clang-format > generally doesn't touch the token sequence isn't an accident. > e.

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:304 - StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + Mgr.AddNewSourceBuffer( + MemoryBuffer::getMemBuffer(StartBu

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. I definitely agree with the default being "do nothing", its not just google style, nearly everyone is using a style which is derived from one of these base styles, that said turning on a const style by default would IMHO be a mistake, the level of churn could be

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay updated this revision to Diff 228826. MyDeveloperDay added a comment. Move adding the source file to the source mgr outside the replacements loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69921/new/ https://reviews.llvm.org/D69921 Files: clang/tools/clang-format/Cl

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa75f8d98d7ac: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. NOTE: Add foo() const override and foo() const override LLVM_READONLY test examples as these currently fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-c

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 228842. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Fix an issue with foo() const override/final Be more specific about this being turned off in all the base styles CHANGES SINCE LAST

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 228843. MyDeveloperDay added a comment. Make the patch file correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Form

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, This LGTM, in the future, just a small nit for the future, can you ensure the diff is a full context diff with something like `@git diff --cached -U99

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. I realize this is an old diff, and you and I have just spoke about it on twitter https://twitter.com/NIV_Anteru/status/1193792307386081281?s=20 would you consider rebasing as the /brief style isn't used any more It would help the approval process if you could hig

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. sorry searching through old issues, are you still interested in this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___ cfe-commits mai

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

This revision was automatically updated to reflect the committed changes. Closed by commit rG335ac2eb662c: Allow additional file suffixes/extensions considered as source in main include… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D67750?vs=228872&id=228953#t

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. I'm thinking this is the same as BraceWrapping.AfterEnum, if you think your use case is covered would you consider Abandoning this revision so we know this functionality exists already, if not let work out what is missing if (Right.is(TT_InlineASMBrace)) r

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. It feels like it should somehow be following `BreakBeforeBraces` style but understand it might not Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. In D54628#1744108 , @koalo wrote: > Yes it does not. Therefore, I have followed the same pattern as the the other > AllowShort* options. I'm not completely sure, but I don't think its quite the same, the AllowShort* opti

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG52980576ee4a: [clang-format] refactor the use of the SMDiagnostics in replacement warnings (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. Ironically the LLVM style guide says enumerators should be written out as you requested, but from what I can tell its not actually possible to get that format without this sort of change, do you agree? F10735507: image.png R

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a subscriber: mitchell-stellar. MyDeveloperDay added a comment. Thanks for rebasing, I think this is a good idea I'm just not sure about how the option presents itself, would you consider changing it? Comment at: clang/lib/Format/TokenAnnotator.cpp:3109

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. In D54628#1745645 , @koalo wrote: > Yes, that is at least my understanding. I just rebased to master. > > In my understanding, "short" means "put it on a single line if it fits > considering the current maximum line length"

[PATCH] D19031: clang-format: Flexible line endings

MyDeveloperDay added a comment. Sorry I'm reviewing very old revisions, @mxbOctasic are you still interested in a patch like this? > It's not clang-format's task to clean up files with mixed line endings This is an interesting thought given that clang-format does exactly that based on how many

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. ok sounds good, @koalo do you have the tests to ensure AfterEnum=true and AllowShortEnumsOnASingleIne=true show on a single line? otherwise perhaps we are already good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D5

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. Nit: you should use a full context diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D70249: [clang-format] Fixed edge-case with `Style.SpacesInSquareBrackets` with trailing bare `&` lambda capture

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70249/new/ https://reviews.llvm.org/D70249 __

[PATCH] D19031: [clang-format] Flexible line endings

MyDeveloperDay added a subscriber: STL_MSFT. MyDeveloperDay added a comment. I suspect this patch might need a rebase, but I personally don't see anything wrong with it. I think this could really help. I'm pretty sure the Unix line ending requirement is in almost every major style guide (I saw

[PATCH] D19031: [clang-format] Flexible line endings

MyDeveloperDay added a comment. In D19031#1746705 , @STL_MSFT wrote: > MSVC's STL currently uses CRLF (DOS) line endings, not LF (Unix). I wrote a > validator, > https://github.com/microsoft/STL/blob/58bb49d63d92e7a0346a05af29816aeea6b4cf0f/tools/validat

[PATCH] D19031: [clang-format] Flexible line endings

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, I think this could help more than people might at first realize. I love the idea that I can use clang-format in dry-run (-n) mode to now make line endings seem a com

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this patch. I'm sorry it took so long, I think this is a perfectly reasonable idea and helps cover the functionality that visual studio also supports. (which ulti

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. @Anteru thanks for the patch this got landed today, I got burnt by the 100755 mode change on the file, but thanks to @sylvestre.ledru it got resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. In D6920#1748764 , @sylvestre.ledru wrote: > Would be nice to add this to the release notes too ;) Addressing this and other missing release notes in D70355: [clang-format] [NFC] add recent changes to release notes

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

MyDeveloperDay updated this revision to Diff 229690. MyDeveloperDay added a comment. Address review comments Remove excessive newlines Remove trailing whitespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/ https://reviews.llvm.org/D70355 Files: clang/docs/ReleaseNotes.rs

[PATCH] D70305: clang-format: fix regression in middle pointer alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG5987cc1bb5d5: [clang-format] fix regression in middle pointer alignment (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70305/new

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a7c1259e8a: [clang-format] Add SpaceBeforeBrackets (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D6920?vs=229612&id=229686#toc Repository: rG LLVM Github Monorepo

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sylvestre.ledru, sammccall. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added a comment. @Eugene.Zelenko I've noticed you are a

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added a comment. @Eugene.Zelenko I've noticed you are always giving excellent review feedback in clang-tidy especially around the documentation, I'd appreciate your eyes on finding the right level of documentation here. Reposito

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b5f6c16476c: [clang-format] [NFC] add recent changes to release notes (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 229996. MyDeveloperDay added a comment. - Rebase - Add Release note - Remove repeated lines cause by patch creation artefact CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFo

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1110 + /// Different const alignment styles. + enum ConstAlignmentStyle { +/// Don't change const to either East const or West const. -

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 230124. MyDeveloperDay added a comment. -update with missing files -clang-format test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Relea

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added a comment. Can you rebase it and add a release note in docs/ReleaseNote.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14382 + verifyFormat("if ( !a )\n return;", Spaces); + verifyFormat("if ( a )\n return;", Spaces); + verifyFormat("if constexpr ( a )\n return;", Spaces); show "else if"

[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. I tend to agree, I'm not keen on the silent searching for the files.. this happens too much as it is, with Microsoft releasing VisualStudio with a clang-format.exe (v5.0), I suddenly find that binary is in my path, then all of a sudden all the 5.0 bugs we fixed

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14386 + verifyFormat("while ( a )\n return;", Spaces); + verifyFormat("while ( (a && b) )\n return;", Spaces); + verifyFormat("do {\n} while ( 1 != 0 );", Spaces); is thi

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added a comment. Could you update the ClangStyleOption.rst (using the tool in docs/tools) and as you are adding a new option would you add a line or two in the docs/ReleaseNotes.rst in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I can tell from https://zed0.co.uk/clang-format-configurator/ that it's not possible to get it to the form you suggested, I'm not opposed to accepting this, I'm just

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. klimek wrote: > Personally, I'm somewhat

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1651 + /// parameters in a fuction call. + bool ObjCDontBreakBeforeNestedBlockParam; + gribozavr2 wrote: > I don't know much about ClangFormat, but I'd prefer to keep the opti

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. aaron.ballman wrote: > MyDeveloperDay wr

[PATCH] D70864: update trailing newline treatment in clang-format.py

MyDeveloperDay added a comment. I guess this isn't something we could test with lit right? Can you explain how this goes wrong, I've not seen it myself and I use the vim plugin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added a comment. so now I think this is better because it's encased inside your TT_ObjCMethodExpr method which means it should only impact ObjectiveC Nit on the documentation Nit missing parse tests but otherwise you are pretty close, make those changes and I'll mark accepted

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. As a consensus how about I drop Before/After and Keep Left/Right and West/East const support? (as no one is asking for Before/After?) can we handle having 2 options to aid language issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https:/

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: lib/Format/Format.cpp:455 +IO.mapOptional("BitFieldDeclarationsOnePerLine", Style.BitFieldDeclarationsOnePerLine); IO.mapO

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM A little advice as you fix each comment check the "Done" button. I notice you are a new user, will you need help landing it? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D70864: update trailing newline treatment in clang-format.py

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864 ___ cfe-commits mailing li

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

MyDeveloperDay added a comment. I recently hit this issue where I was clang-formatting generated code out of a source tree, which was then copied into a source tree. This failed my post build clang-format validation check and I couldn't understand why. it was only later I realised that unless I

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

MyDeveloperDay added a comment. Drive by comment: (I have no vested interested other than seeing cool new checkers) FWIW, I work on a system with a multi million line legacy 25+ years old C++ codebase, where we now have clang-tidy integrated into a CI system and we have > 100,000 firings of cl

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:14468 + "NSNumber *v) {\n" \ + " u = v;\n" \"

[PATCH] D70864: [clang-format] update trailing newline treatment in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e03ff50389: [clang-format] update trailing newline treatment in clang-format.py (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D70664: [clang-format] update string comparison in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f8c20e2cb6: update string comparison in clang-format.py (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D70664?vs=230873&id=232591#toc Repository: rG LLVM Github Mon

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. In D69764#1775835 , @ilya wrote: > In D69764#1732235 , @aaron.ballman > wrote: > > > I like the functionality, but am slightly opposed to using "east/west" > > terminology -- that's

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. > But I don't know if this can be (easily) supported in a .clang-format file, > since the style options are defined as (static) enums. I realize my proposal > might be out of the scope of this patch, but I wanted to get some opinions > from the community. just t

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849 + } while (FormatTok->is(tok::comment)); +} if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except, can you use `FormatTok->getNextNonComment()`?

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849 + } while (FormatTok->is(tok::comment)); +} if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except, Bigcheese wrote: > MyDeveloperDay wrote: > > ca

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:586 verifyFormat("if (true) {\n" - " ff();\n" "}", any reason you are changing existing t

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 __

<    13   14   15   16   17   18   19   20   21   22   >