MyDeveloperDay added a comment. In D69764#1775835 <https://reviews.llvm.org/D69764#1775835>, @ilya wrote:
> In D69764#1732235 <https://reviews.llvm.org/D69764#1732235>, @aaron.ballman > wrote: > > > I like the functionality, but am slightly opposed to using "east/west" > > terminology -- that's not a ubiquitous phrase and it takes a bit of > > thinking before it makes sense. I think "left/right" is likely to be more > > universally understood. > > > > Also, should this apply to other qualifiers like `volatile` or `restrict`? > > If so, the name `ConstStyle` should probably be `CVQualifierStyle` or > > something else. > > > +1. > In addition to `volatile` and `restrict`, in my organization we'd also be > interested in applying this to address space qualifiers (custom keywords > added in our downstream fork). Can this be generalized to accept a map of > qualifier keywords and its desired orientation? Could you give me an example of what you mean? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
