[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca created this revision. mojca added a reviewer: carlosgalvezp. mojca added a project: clang. Herald added subscribers: usaxena95, kadircet, yaxunl. mojca requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. I've been trying to address the following issue in

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Well, even after this patch neither `clang` nor `clangd` work correctly for me (I need some patches in llvm/clang sources, there are some issues with Microsoft's libraries; I wasn't able to make the linker work even after that), and CMake doesn't fully support CUDA + Clan

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. And thanks to Carlos for accepting the patch. (In case it's not a super demanding task, I would be willing to invest a bit of time towards making CUDA + Clang on Windows work better, but it would help to have "a supervisor" I could turn to when I get stuck or when I have

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; kadircet

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; carlosgal

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca updated this revision to Diff 389678. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114326/new/ https://reviews.llvm.org/D114326 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp ==

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca created this revision. mojca added reviewers: tra, carlosgalvezp, Hahnfeld. mojca added a project: clang. Herald added a subscriber: yaxunl. mojca requested review of this revision. Herald added a subscriber: cfe-commits. This is heavily related to https://reviews.llvm.org/D114326 and uses a

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. I opened https://reviews.llvm.org/D114601. I wasn't sure if that's something that should have been combined with this ticket or not because it can be merged or rejected independently. I also opened a ticket for Microsoft STL on https://github.com/microsoft/STL/issues/235

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:138 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( - D.SysRoot + "/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v" + -

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389811. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Somewhat off-topic from a discussion earlier in the thread. What's the purpose of the following code then if users are supposed to explicitly specify the `-L` flag anyway? c++ if (HostTriple.isArch64Bit() && FS.exists(InstallPath + "/lib64")) LibPath = Inst

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. @tra: what should be done about the unit test that checks whether CUDA SDK 8.0 specifically has been found? Apparently you are taking care of the buildbot configuration performing those tests. And how should we proceed in general, what can I do next? Thanks. Repository:

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. @tra: this is not yet 100% ready since the unit tests are now failing (expecting to find CUDA 8.0). I can fix the unit test, but I suppose that someone needs to install additional SDK somewhere into the infrastructure as well? In D114326#3158913

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:137 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( tra wrote: > Do we want to keep this as the fall-back for cases when

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. What can/should I do next in order to proceed with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. In D114601#3223155 , @tra wrote: > Ping. @mojca, do you need help landing the patch? Yes, please. I don't have commit access yet. You can attribute it to mojca at macports.org, for example. We also need a fix for unit tests on the

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. Also, I would like to get to do some further "baby steps" towards better support of CUDA on Windows in particular, but I would need some guidelines. I requested a special channel that would allow a bit of discussion https://discord.com/channels/636084430946959380/. What wo