mojca added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:137
} else if (HostTriple.isOSWindows()) {
- for (const char *Ver : Versions)
- Candidates.emplace_back(
----------------
tra wrote:
> Do we want to keep this as the fall-back for cases when `CUDA_PATH` is not
> set?
>
> Otherwise, we're risking to break existing users.
That was going to be my question as well (for which I wanted your input).
From the initial comments in the other review (D114326) I understood that
eventually you wanted to get rid of the hardcoded list of versions (but I
didn't fully understand the intent).
(Technically speaking this won't break existing users since they were only able
to access CUDA versions up to 8.0 until now, and we would just remove support
for anything older that CUDA 10.0.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114601/new/
https://reviews.llvm.org/D114601
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
