[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 428538. hctim marked an inline comment as done. hctim added a comment. (comment) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 Files: llvm/include/llvm/DebugInfo/DI

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added inline comments. Comment at: llvm/test/tools/llvm-symbolizer/data-location.s:7 + +# CHECK: x +# CHECK-NEXT: 14572 4 jhenderson wrote: > hctim wrote: > > jhenderson wrote: > > > hctim wrote: > > > > jhenderson wrote: > > > > > It might be useful t

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3504789 , @rnk wrote: > This seems reasonable, but I worry about the consequences of creating lots of > unnamed global variables. What will gdb do with so many unnamed globals? What > will the PDB linker do with all the

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3509667 , @rnk wrote: > That's fine, a Windows machine shouldn't be necessary. This patch has to > change the AsmPrinter for DWARF, so it makes sense that it should do the same > for CodeView. I think it should be suffi

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 429121. hctim added a comment. Herald added a subscriber: ormris. update patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 Files: clang/lib/CodeGen/CGDebugInfo.cp

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 429276. hctim added a comment. Remove test based on removed invariant (DIGlobalVariables no longer need a name). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 Files:

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 429783. hctim marked 2 inline comments as done. hctim added a comment. Patch update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 Files: llvm/include/llvm/DebugInf

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:769-783 +DataExtractor Data(Location.Expr, /*IsLittleEndian=*/true, 8); +uint64_t DataOffset = 0; +uint8_t Operation = Data.getU8(&DataOffset); +if (Operation == dwarf::DW_OP_addr) { +

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 429799. hctim added a comment. Touch ups from comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/C

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4680982b36a8: [dwarf] Emit a DIGlobalVariable for constant strings. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Done, I'll take a look and resubmit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Why, on Fuchsia, on WIndows, the DIs are in the order `q -> p -> r` is beyond me (instead of the file order and my order `p -> q -> r`. Looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://revie

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 430494. hctim added a comment. Fix the fuchsia windows bot by making the DILocalVariables in the test order-independent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa1fa0a0a07: Reland "[dwarf] Emit a DIGlobalVariable for constant strings." (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 430509. hctim marked an inline comment as done. hctim added a comment. Explicitly only match 'DW_OP_addr[x] [+ DW_OP_plus_uconst]' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.or

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:769-783 +DataExtractor Data(Location.Expr, /*IsLittleEndian=*/true, 8); +uint64_t DataOffset = 0; +uint8_t Operation = Data.getU8(&DataOffset); +if (Operation == dwarf::DW_OP_addr) { +

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3525533 , @paulkirth wrote: > We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the > new changes to DWARF introduced in this patch. It appears as if CGo is > confused because it found a `DW_TAG_

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim created this revision. hctim added reviewers: vitalybuka, kstoimenov. Herald added subscribers: ormris, jdoerfert, steven_wu, hiraditya. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commit

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim created this revision. hctim added reviewers: paulkirth, dblaikie. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D12353 added inline strings to the DWARF info pro

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 431463. hctim marked 4 inline comments as done. hctim added a comment. David's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 Files: llvm/include/llvm/Debu

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcead4eceb01b: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals (authored by hctim). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim planned changes to this revision. hctim added a comment. Pulled out the IR-specific changes to D126100 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 __

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 431508. hctim added a comment. Add an extra Global creation path from the frontend, and fix up a comment from Kirill on the other revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://revie

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. It sounds like the consensus is what's represented in the release notes, "if this new feature breaks you, then you need to fix yourself". Does anyone have any concerns with the specific text, or does it LGTY? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

hctim added a comment. Looks like this patch broke the MSan buildbots, PTAL (repro instructions https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild): http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/46239/steps/check-clang%20msan/logs/stdio FAIL: Clang ::

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

hctim added a comment. Not a known issue - no, but MSan doesn't play nice with uninistrumented libraries (including things like libcxx) - and so it can be tricky to ensure your build is properly sanitized, which is why I'd recommend the build script :). Repository: rG LLVM Github Monorepo

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM - I'm assuming this doesn't regress performance because there's no latency of the additional store due to its locality? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90424/new/ https://reviews.llvm.org/D90424 ___ cfe

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim created this revision. hctim added reviewers: cryptoad, pcc. Herald added subscribers: phosek, mgorny. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch moves -fsanitize=scudo to link the standalon

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added a comment. In D102543#2763749 , @cryptoad wrote: > I think one of the remaining things to address is the supported architectures: > > set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${M

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345906. hctim marked 2 inline comments as done. hctim added a comment. Address Kostya's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Dri

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345939. hctim added a comment. Add arm32 to supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345977. hctim added a comment. Let's submit the "adding archs" part of the patch first, then land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/l

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC +

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 347814. hctim marked an inline comment as done. hctim added a comment. Address Vitaly's suggestions, make some slight changes so that cross-compilation and running under QEMU doesn't require staging the runtimes in the host compiler. Repository: rG LLVM Gi

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG694d8cbe: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests. (authored by hctim). Changed prior to commit: https://reviews.llvm.org/D102543?vs=347814&id=348011#toc Repository: rG LLVM G

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 348116. hctim added a comment. Move lit tests behind the cmake guard: "if(COMPILER_RT_INCLUDE_TESTS AND COMPILER_RT_HAS_SCUDO_STANDALONE)" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://review

[PATCH] D103218: [Fuchsia][CMake] Add missing include path.

hctim added a comment. Thanks for the keen eye on the Fuchsia bots, I didn't see this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103218/new/ https://reviews.llvm.org/D103218 ___ cfe-commits mailing l

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. In D102543#2783516 , @cryptoad wrote: > I saw some bots failure for preinit.c: > > FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) > TEST 'ScudoStandalone-i386 :: preinit.c' FAILED > **

[PATCH] D106908: Improve UBSan documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG65e9d7efb090: Improve UBSan documentation (authored by hctim). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D106908?vs=362138&

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

hctim added a comment. Hi, looks like this change caused a regression on the sanitizer buildbots (https://lab.llvm.org/buildbot/#/builders/169/builds/1290/steps/25/logs/stdio). Error copied below for your convenience. Can be repro'd using the bot instructions at https://github.com/google/sanit

[PATCH] D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030

hctim added a comment. Hello, it looks like this change broke the MSan and ASan buildbots. http://lab.llvm.org:8011/#/builders/5/builds/5327 FAIL: LLVM :: CodeGen/AMDGPU/GlobalISel/readcyclecounter.ll (39307 of 74613) TEST 'LLVM :: CodeGen/AMDGPU/GlobalISel/readcyclecou

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

hctim added a comment. In D96120#2615085 , @russell.gallop wrote: > In D96120#2597877 , @kcc wrote: > >> I am afraid we will have to delete the older (non-standalone) variant >> entirely. >> (And the sooner the b

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

hctim added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131806/new/ https://reviews.llvm.org/D131806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. Glad to see that refactoring the sanitizer metadata made someone's life easier ;) (now allowing for disabling hwasanificiation of globals) Patch looks reasonable to me. Can you please add the negative test (that vtables under the vanilla ABI still have hwasan)? I wans't

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. In D132425#3753065 , @leonardchan wrote: > We have a generic long term solution for hwasan+RV which I think might also > be applicable for MTE+RV. For hwasan, since it's mainly the IR pass that > converts usages of the vtable (wi

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. Hi, this looks like a candidate for breaking the MSan bot: https://lab.llvm.org/buildbot/#/builders/5/builds/30139 Still looking into it and bisecting, will let you know when I have more info. To reproduce the bots, the best way (because MSan setup is tricky because it r

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4009447 , @hctim wrote: > Hi, this looks like a candidate for breaking the MSan bot: > https://lab.llvm.org/buildbot/#/builders/5/builds/30139 > > Still looking into it and bisecting, will let you know when I have more i

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4010856 , @ilinpv wrote: > It would be great to have more details how to setup up your bot, using > buildbot_fast.sh on x86_64 Ubuntu 22.04 LTS leads to error ( pthreads > installed ): > > CMake Error at > /usr/share

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4011372 , @ilinpv wrote: > Regular builds works fine for me, pthreads located here > "/lib/x86_64-linux-gnu/libpthread.so" > "/usr/lib/x86_64-linux-gnu/libpthread.so". Enabling > "-DLLVM_USE_SANITIZER=Memory" resulted

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012276 , @ilinpv wrote: > I've managed to reproduce "MemorySanitizer: use-of-uninitialized-value" error > locally, thank you @hctim for help! > If I understand it right, it seems **MSan didn't handle correctly > SmallV

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012854 , @ilinpv wrote: > I don't think `std::equal` is underlying cause here. We have > featuresStrs_size() comparison before calling it: > > if (CurClones && NewClones && > (CurClones->featuresStrs_size(

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 486093. hctim added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang/test/CodeGen/memtag-globals-asm.cpp llvm/lib/CodeGen/GlobalMerge

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, abrachet, phosek, cryptoad. Herald added a project: All. hctim requested review of this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, MaskRay. Herald added projects: clang,

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 476241. hctim marked 2 inline comments as done. hctim added a comment. Remove unrelated diff from doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 Files: clang/li

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added inline comments. Comment at: llvm/docs/GwpAsan.rst:174 ++-++ -| PerfectlyRightAlign| false | When allocations are right-aligned, should we

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. In D138157#3935173 , @phosek wrote: > Is the plan to eventually rename `scudo_standalone` to `scudo` once the > santiizer-based Scudo implementation is deleted? Ideally, yes (as well as make scudo_standalone not be in a subfolder)

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 493642. hctim marked 2 inline comments as done. hctim added a comment. Rebase for submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang/test/CodeGen/me

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4edfcff71e15: [MTE] Add AArch64GlobalsTagging Pass (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added a comment. In D133392#4094524 , @dyung wrote: > Hi @hctim, the test you added is failing on buildbots where AArch64 is not > built, can you either update the test to not require that backend, or mark > the test as requiring it? > > https://l

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

hctim added a comment. Hey, looks like this broke the x86_64-linux sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/19910 You can reproduce the bot using the instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (substitute `buildbot_fast.sh

[PATCH] D139395: Add CFI integer types normalization

hctim added a comment. Hey folks, looks like this caused a failure on the msan buildbot: https://lab.llvm.org/buildbot/#/builders/237/builds/785 It's been had a long-running bug that I'm still tracking down but seems like this is a new failure caused by this patch. The track-origins log is copi

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rG8db981d463ee: Add sanitizer-specific GlobalValue attributes. (authored by hctim). Repository: rG LLVM Gith

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim created this revision. hctim added a reviewer: pcc. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Enna1. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Cur

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:767 + if (IsAArch64) { +Res |= SanitizerKind::MemtagGlobals; + } eugenis wrote: > Hmm why are all the other memtag* not here? Yeah, just r

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim updated this revision to Diff 436059. hctim marked 2 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 Files: clang/include/clang/Basic/Feature

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Deprecated by D127544 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119367/new/ https://reviews

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

hctim added a comment. Looks like this broke the ASan buildbot (and may have been missed because the bot was already red at the time): https://lab.llvm.org/buildbot/#/builders/5/builds/24588 Instructions on how to repro the bot are here: https://github.com/google/sanitizers/wiki/SanitizerBotRe

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 436484. hctim marked 4 inline comments as done. hctim added a comment. Final review touch-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGe

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:101 + llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( + llvm::Type::getInt1Ty(VMContext), Meta.IsDynInit)), llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( --

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 436485. hctim added a comment. Remove one unnecessary set of brackets before submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenM

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7766972a679: Add sanitizer metadata attributes to clang IR gen. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. Thanks for the heads up. Reverted, and now re-landing. Unfortunately I don't have a Windows machine so I've made my best guesses about fixing (mostly seems to just symbol name mangling / global attributes that change on the windows target). I'll keep an eye on that specif

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. LGTM: http://45.33.8.238/win/60042/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list cfe-commits@

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45d88cd00846: [clang] Add -fsanitize=memtag-globals (no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437355. hctim marked 6 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > Spurious whitespace change? unfortunately there's no way in my editor to trim trailing whitespace only on changed lines :(

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim added a comment. In D127163#3587115 , @thakis wrote: > FYI: If you change serialized opts in a def file, you have to bump the pch > version, else with builds that don't embed the llvm revision > (LLVM_APPEND_VC_REV=OFF) won't notice they have to i

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, ormris, hiraditya. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits.

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 437385. hctim added a comment. Small test fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/SanitizerM

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. Yeah, I'll look at landing it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. (thanks for the bump - this one fell off the radar) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list cfe-comm

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim marked an inline comment as done. hctim added a comment. In D126224#3534643 , @probinson wrote: > I see some unrelated whitespace changes, we generally don't like mixing those > with "real" changes. But the description seems fine to me. Looks lik

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim updated this revision to Diff 437717. hctim marked an inline comment as done. hctim added a comment. Change a small amount of wording, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 Files:

[PATCH] D126224: Add DWARF string debug to clang release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011e0604ebc9: Add DWARF string debug to clang release notes. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Integrated slowly and surely as part of the stack leading up to D127911 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > hctim wrote: > > aaron.ballman wrote: > > > Spurious whitespace change? > > unfortu

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437734. hctim marked 2 inline comments as done. hctim added a comment. Create test input files rather than synthesizing on the fly, fix tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. friendly ping @vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3605774 , @MaskRay wrote: >> This saves about ~0.275% of the optimised clang binary. > > Worth clarifying a bit which -O level and whether -g is used. `clang-15` binary, no `-g`, `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_BUI

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf5e0ec737a: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439880. hctim added a comment. Rebase on main / landed changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609312 , @hubert.reinterpretcast wrote: > This is causing "unsupported architecture" errors on bots. Looking, I see this on the sanitizer-ppc64 bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. Sent fadc98b06befb674fa47da4f3d8606bf61bed681 to fix-forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609343 , @hubert.reinterpretcast wrote: > In D127544#3609335 , @hctim wrote: > >> Sent fadc98b06befb674fa47da4f3d8606bf61bed681 >>

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. I see that the clang-ppc64le-linux bot is green with the second attempt (https://lab.llvm.org/buildbot/#/builders/105/builds/27200). Please let me know if you have further issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(;

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439912. hctim marked 2 inline comments as done. hctim added a comment. Vitaly's comments - round 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/C

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address | Sanit

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439918. hctim marked 3 inline comments as done. hctim added a comment. Vitaly's comments, round 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/Co

<    1   2   3   >