hctim marked 2 inline comments as done.
hctim added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100
+ GlobalVariable *Metadata = CreateMetadataGlobal(
+ M, Initializer, llvm::demangle(std::string(G->getName())));
----------------
vitalybuka wrote:
> was this demanded before?
removed, think this got accidentally added during a sweep of demangling names
for the produced metadata, which is necessary now that clang doesn't produce
the info.
================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2330
+ ConstantInt::get(IntptrTy, Meta.IsDynInit),
+ ConstantInt::get(IntptrTy, 0),
ConstantExpr::getPointerCast(ODRIndicator, IntptrTy));
----------------
vitalybuka wrote:
> MD was fine, less changed lines
done
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127911/new/
https://reviews.llvm.org/D127911
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
