[clang-tools-extra] r269402 - clang-rename: check that the source location we find actually has the old name

Author: vmiklos Date: Fri May 13 04:17:32 2016 New Revision: 269402 URL: http://llvm.org/viewvc/llvm-project?rev=269402&view=rev Log: clang-rename: check that the source location we find actually has the old name This more general check could have prevented the specific problem "getSourceOrder()

Re: [PATCH] D20216: clang-rename: check that the source location we find actually has the old name

This revision was automatically updated to reflect the committed changes. Closed by commit rL269402: clang-rename: check that the source location we find actually has the old name (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20216?vs=57140&id=57144#toc Repository:

[PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. Blind fix for . http://reviews.llvm.org/D20253 Files: clang-rename/CMakeLists.txt Index: clang-rename/CMakeLists.txt

Re: [PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos abandoned this revision. vmiklos added a comment. Ah, already fixed by http://reviews.llvm.org/D20240, sorry for the noise. :-) http://reviews.llvm.org/D20253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Thanks for fixing the problem I introduced. :-) http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D20296: clang-rename: avoid StringRef members in USRLocFindingASTVisitor

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. Even if this is defined in the .cpp file and only used as part of the function (so here it's safe), usually storing StringRefs in the class is dangerous, so don't do so. http://reviews.llvm.org/D20296 Files: clang-ren

Re: [PATCH] D20296: clang-rename: avoid StringRef members in USRLocFindingASTVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL269796: clang-rename: avoid StringRef members in USRLocFindingASTVisitor (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20296?vs=57385&id=57503#toc Repository: rL LLVM http

[clang-tools-extra] r269796 - clang-rename: avoid StringRef members in USRLocFindingASTVisitor

Author: vmiklos Date: Tue May 17 13:17:16 2016 New Revision: 269796 URL: http://llvm.org/viewvc/llvm-project?rev=269796&view=rev Log: clang-rename: avoid StringRef members in USRLocFindingASTVisitor Even if this is defined in the .cpp file and only used as part of the function (so here it's safe)

[PATCH] D20356: clang-rename: handle non-inline ctor definitions when renaming classes

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The result of the test was C::D(), not D::D(). http://reviews.llvm.org/D20356 Files: clang-rename/USRLocFinder.cpp test/clang-rename/CtorDefTest.cpp Index: test/clang-rename/CtorDefTest.cpp

Re: [PATCH] D20356: clang-rename: handle non-inline ctor definitions when renaming classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL269952: clang-rename: handle non-inline ctor definitions when renaming classes (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20356?vs=57582&id=57641#toc Repository: rL LLVM

[clang-tools-extra] r269952 - clang-rename: handle non-inline ctor definitions when renaming classes

Author: vmiklos Date: Wed May 18 11:12:48 2016 New Revision: 269952 URL: http://llvm.org/viewvc/llvm-project?rev=269952&view=rev Log: clang-rename: handle non-inline ctor definitions when renaming classes The result of the test was C::D(), not D::D(). Reviewers: cfe-commits, klimek Differential

[PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y). http://reviews.llvm.org/D20446 Files: clang-rename/USRLocFinder.cpp test/clang-rename/MemberExprMacro.cpp Index: test/clang-rename/MemberExprMacro.cpp =

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

vmiklos updated this revision to Diff 57921. vmiklos added a comment. Done. http://reviews.llvm.org/D20446 Files: clang-rename/USRLocFinder.cpp test/clang-rename/MemberExprMacro.cpp Index: test/clang-rename/MemberExprMacro.cpp ===

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL270204: clang-rename: fix renaming members when referenced as macro arguments (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20446?vs=57921&id=57923#toc Repository: rL LLVM

[clang-tools-extra] r270204 - clang-rename: fix renaming members when referenced as macro arguments

Author: vmiklos Date: Fri May 20 06:43:59 2016 New Revision: 270204 URL: http://llvm.org/viewvc/llvm-project?rev=270204&view=rev Log: clang-rename: fix renaming members when referenced as macro arguments The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y). Reviewers: klimek Differentia

[PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. This makes it easier for external tools to parse lines starting with clang-rename, as 'renamed at:' lines already end with a newline. http://reviews.llvm.org/D18957 Files: clang-rename/to

Re: [PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos added a comment. Hi, Can I help anything to get this reviewed, please? Thanks, Miklos http://reviews.llvm.org/D18957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos added a comment. Thanks! Is there anything I have to do to get this actually committed or I just have to be patient? http://reviews.llvm.org/D18957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D20537: clang-rename: fix renaming non-members variables when referenced as macro arguments

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y). http://reviews.llvm.org/D20537 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DeclRefExpr.cpp Index: test/clang-rename/DeclRefExpr.cpp ===

[clang-tools-extra] r270599 - clang-rename: fix renaming non-members variables when referenced as macro arguments

Author: vmiklos Date: Tue May 24 14:08:53 2016 New Revision: 270599 URL: http://llvm.org/viewvc/llvm-project?rev=270599&view=rev Log: clang-rename: fix renaming non-members variables when referenced as macro arguments The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y). Reviewers: kl

Re: [PATCH] D20537: clang-rename: fix renaming non-members variables when referenced as macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL270599: clang-rename: fix renaming non-members variables when referenced as macro… (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20537?vs=58136&id=58290#toc Repository: rL

[PATCH] D20635: clang-rename: fix renaming heap allocations

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. The check failed, 'Cla *C = new Cla();' was renamed 'D *C = new Cla();'. http://reviews.llvm.org/D20635 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ConstructExpr.cpp Index: test/clang-rename/ConstructExp

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

vmiklos added a comment. Can I help anything with reviewing this, please? http://reviews.llvm.org/D20635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r271572 - clang-rename: fix renaming heap allocations

Author: vmiklos Date: Thu Jun 2 15:00:22 2016 New Revision: 271572 URL: http://llvm.org/viewvc/llvm-project?rev=271572&view=rev Log: clang-rename: fix renaming heap allocations The check failed, 'Cla *C = new Cla();' was renamed to 'D *C = new Cla();'. Reviewers: klimek Differential Revision:

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

This revision was automatically updated to reflect the committed changes. Closed by commit rL271572: clang-rename: fix renaming heap allocations (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20635?vs=58467&id=59447#toc Repository: rL LLVM http://reviews.llvm.org/D

[PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. "Derived" in static_cast(...) wasn't renamed, nor in its pointer equivalent. http://reviews.llvm.org/D21012 Files: clang-rename/USRLocFinder.cpp test/clang-rename/StaticCastExpr.cpp Ind

Re: [PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

vmiklos updated this revision to Diff 59695. vmiklos added a comment. Done. http://reviews.llvm.org/D21012 Files: clang-rename/USRLocFinder.cpp test/clang-rename/StaticCastExpr.cpp Index: test/clang-rename/StaticCastExpr.cpp =

[clang-tools-extra] r271933 - clang-rename: implement renaming of classes inside static_cast

Author: vmiklos Date: Mon Jun 6 14:40:12 2016 New Revision: 271933 URL: http://llvm.org/viewvc/llvm-project?rev=271933&view=rev Log: clang-rename: implement renaming of classes inside static_cast "Derived" in static_cast(...) wasn't renamed, nor in its pointer equivalent. Reviewers: klimek Dif

Re: [PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL271933: clang-rename: implement renaming of classes inside static_cast (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21012?vs=59695&id=59766#toc Repository: rL LLVM http:/

[PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Refactor to do the same as what is done already for static_cast. http://reviews.llvm.org/D21120 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DynamicCastExpr.cpp Index: test/cl

[clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Author: vmiklos Date: Wed Jun 8 13:38:23 2016 New Revision: 272188 URL: http://llvm.org/viewvc/llvm-project?rev=272188&view=rev Log: clang-rename: implement renaming of classes inside dynamic_cast Refactor to do the same as what is done already for static_cast. Reviewers: klimek Differential R

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL272188: clang-rename: implement renaming of classes inside dynamic_cast (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21120?vs=60001&id=60073#toc Repository: rL LLVM http:

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos added a comment. Hmm, http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332/steps/test/logs/stdio fails with "error: cannot use dynamic_cast with -fno-rtti"; is there some way to detect if "-fno-rtti" is the default, and in that case don't execute the

[PATCH] D21186: clang-rename: mark the DynamicCastExpr test unsupported on ps4

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. It has no RTTI, so the test would always fail in a non-interesting way. http://reviews.llvm.org/D21186 Files: test/clang-rename/DynamicCastExpr.cpp Index: test/clang-rename/DynamicCastExp

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos added a comment. Possible solution posted as http://reviews.llvm.org/D21186. Repository: rL LLVM http://reviews.llvm.org/D21120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Hi Galina, On Thu, Jun 09, 2016 at 10:15:27AM -0700, Galina Kistanova wrote: > This revision broke tests on one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332 Please accept if it's the correct fix. It fix

Re: [PATCH] D21186: clang-rename: fix the DynamicCastExpr test on ps4

vmiklos retitled this revision from "clang-rename: mark the DynamicCastExpr test unsupported on ps4" to "clang-rename: fix the DynamicCastExpr test on ps4". vmiklos updated the summary for this revision. vmiklos updated this revision to Diff 60320. vmiklos added a comment. Ah, then the fix is sim

Re: [PATCH] D21186: clang-rename: fix the DynamicCastExpr test on ps4

vmiklos updated this revision to Diff 60324. vmiklos added a comment. Correct diff this time. http://reviews.llvm.org/D21186 Files: test/clang-rename/DynamicCastExpr.cpp Index: test/clang-rename/DynamicCastExpr.cpp === --- test/

Re: [PATCH] D21186: clang-rename: fix the DynamicCastExpr test on ps4

This revision was automatically updated to reflect the committed changes. Closed by commit rL272381: clang-rename: fix the DynamicCastExpr test on ps4 (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21186?vs=60324&id=60326#toc Repository: rL LLVM http://reviews.llvm

[clang-tools-extra] r272381 - clang-rename: fix the DynamicCastExpr test on ps4

Author: vmiklos Date: Fri Jun 10 03:29:02 2016 New Revision: 272381 URL: http://llvm.org/viewvc/llvm-project?rev=272381&view=rev Log: clang-rename: fix the DynamicCastExpr test on ps4 It has RTTI disabled by default, so need to enable it explicitly. Reviewers: silvas Differential Revision: http

[PATCH] D21270: clang-rename: implement handling of remaining named casts

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. const_cast<> and reinterpret_cast<>. http://reviews.llvm.org/D21270 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ConstCastExpr.cpp test/clang-rename/ReinterpretCastExpr.cpp

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

vmiklos added a comment. Yes, if there will be a way to avoid hooking into each and every AST callback, that sounds more effective. :-) I'm aware of one more bug around destructors when renaming a class, but then I'm (as a user) quite happy about the current state. http://reviews.llvm.org/D21

[clang-tools-extra] r272574 - clang-rename: implement handling of remaining named casts

Author: vmiklos Date: Mon Jun 13 13:50:45 2016 New Revision: 272574 URL: http://llvm.org/viewvc/llvm-project?rev=272574&view=rev Log: clang-rename: implement handling of remaining named casts const_cast<> and reinterpret_cast<>. Reviewers: klimek Differential Revision: http://reviews.llvm.org/D

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL272574: clang-rename: implement handling of remaining named casts (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21270?vs=60479&id=60572#toc Repository: rL LLVM http://revi

[PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Work in progress, not complete yet. Current result: clang-rename -offset 135 -new-name=Bar DtorDefTest.cpp -- - handles "Foo" from "Foo::~Foo" correctly - handles "~Foo" from "Foo::~Foo

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos added a comment. Thanks, sounds like exactly what I need. http://reviews.llvm.org/D21364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated the summary for this revision. vmiklos updated this revision to Diff 60799. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp =

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated this revision to Diff 60800. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp === --- /dev/null +++ test/clang-rename/

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated this revision to Diff 60801. vmiklos added a comment. Now the correct patch. :-) http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp ==

[clang-tools-extra] r272816 - clang-rename: implement renaming of classes with a dtor

Author: vmiklos Date: Wed Jun 15 13:35:41 2016 New Revision: 272816 URL: http://llvm.org/viewvc/llvm-project?rev=272816&view=rev Log: clang-rename: implement renaming of classes with a dtor The declaration wasn't renamed. Also neither part of the declaration wasn't renamed. Reviewers: klimek Di

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

This revision was automatically updated to reflect the committed changes. Closed by commit rL272816: clang-rename: implement renaming of classes with a dtor (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21364?vs=60801&id=60869#toc Repository: rL LLVM http://review

[PATCH] D21517: clang-rename: add a -old-name option

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. This is similar to -offset with the following differences: 1) -offset can refer to local variables as well. 2) -old-name makes it easier to refer to e.g. ClassName::MemberName by spe

Re: [PATCH] D21517: clang-rename: add a -old-name option

vmiklos updated this revision to Diff 61255. vmiklos added a comment. Added a getNamedDeclFor() for the fully qualified name-based search. http://reviews.llvm.org/D21517 Files: clang-rename/USRFinder.cpp clang-rename/USRFinder.h clang-rename/USRFindingAction.cpp clang-rename/USRFindingA

[clang-tools-extra] r273304 - clang-rename: add a -old-name option

Author: vmiklos Date: Tue Jun 21 14:48:57 2016 New Revision: 273304 URL: http://llvm.org/viewvc/llvm-project?rev=273304&view=rev Log: clang-rename: add a -old-name option This is similar to -offset with the following differences: 1) -offset can refer to local variables as well. 2) -old-name mak

Re: [PATCH] D21517: clang-rename: add a -old-name option

This revision was automatically updated to reflect the committed changes. Closed by commit rL273304: clang-rename: add a -old-name option (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21517?vs=61255&id=61430#toc Repository: rL LLVM http://reviews.llvm.org/D21517

[clang-tools-extra] r273314 - Fix build of ClangRenameTests

Author: vmiklos Date: Tue Jun 21 15:30:40 2016 New Revision: 273314 URL: http://llvm.org/viewvc/llvm-project?rev=273314&view=rev Log: Fix build of ClangRenameTests Adapt the test to the code change introduced in r273304. Modified: clang-tools-extra/trunk/unittests/clang-rename/USRLocFindingT

Re: [clang-tools-extra] r273304 - clang-rename: add a -old-name option

Hi Galina, On Tue, Jun 21, 2016 at 06:17:52PM -0700, Galina Kistanova wrote: > This revision broke one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7435 Yes, sorry. Should be fixed by r273314. Regards, Miklos

[PATCH] D21676: clang-rename: add a -s (suffix) option

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Use case: a class is declared in a header, and defined in two translation units. clang-rename is asked to rename a class member that's referenced in both translation units. Using -i is not p

Re: [PATCH] D21676: clang-rename: add a -s (suffix) option

vmiklos updated this revision to Diff 61833. vmiklos added a comment. This version solves the problem outline in the commit message by implementing an -export-fixes commandline option, quite similar to clang-tidy's matching option. http://reviews.llvm.org/D21676 Files: clang-rename/tool/Cla

Re: [clang-tools-extra] r273786 - [clang-tidy] Add modernize-use-using

Hi, On Sat, Jun 25, 2016 at 06:37:54PM -, Krystyna Gajczyk via cfe-commits wrote: > Author: krystynka > Date: Sat Jun 25 13:37:53 2016 > New Revision: 273786 > > URL: http://llvm.org/viewvc/llvm-project?rev=273786&view=rev > Log: > [clang-tidy] Add modernize-use-using Thanks, sounds like a

[clang-tools-extra] r273910 - clang-rename: add a -export-fixes option

Author: vmiklos Date: Mon Jun 27 14:34:47 2016 New Revision: 273910 URL: http://llvm.org/viewvc/llvm-project?rev=273910&view=rev Log: clang-rename: add a -export-fixes option Use case: a class is declared in a header, and defined in two translation units. clang-rename is asked to rename a class m

Re: [PATCH] D21676: clang-rename: add a -export-fixes option

This revision was automatically updated to reflect the committed changes. Closed by commit rL273910: clang-rename: add a -export-fixes option (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21676?vs=61833&id=62004#toc Repository: rL LLVM http://reviews.llvm.org/D216

[clang-tools-extra] r273941 - clang-rename: try to make ClassTestReplacements more reliable

Author: vmiklos Date: Mon Jun 27 16:04:53 2016 New Revision: 273941 URL: http://llvm.org/viewvc/llvm-project?rev=273941&view=rev Log: clang-rename: try to make ClassTestReplacements more reliable As it failed on e.g.

Re: [PATCH] D21676: clang-rename: add a -export-fixes option

vmiklos added a comment. Something related: currently in case multiple symbols is to be renamed in the same translation unit, clang-rename has to be invoked multiple times. This is problematic from a performance point of view, in case the symbols are in common headers of a codebase (and clang-r

[PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. This way parsing the source input multiple times for multiple renames can be avoided. http://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. Manuel, do you have an opinion on this, please? http://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is reviewed? The two patches conflict with each other, I fear. Thanks. :-) http://reviews.llvm.org/D22091 ___ cfe-

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. Kirill: OK, so you're in the camp marked as b) by Manuel. Sure, the vim integration is nice (I'm also a vim user), now that you mentioned it, I need to go and try it myself. ;-) Given the above patch, probably it's obvious that I'm more in camp a). I don't insist on hav

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

vmiklos added a comment. In http://reviews.llvm.org/D22091#476756, @vmiklos wrote: > Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is > reviewed? The two patches conflict with each other, I fear. Thanks. :-) Ignore this, that one won't land as-is after all. http://r

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. As far as I see `tooling::CommonOptionsParser` (in its current form) does not handle cl::SubCommand instances. Should I fix that or would it be OK to switch to using `cl::ParseCommandLineOptions` directly in clang-rename? http://reviews.llvm.org/D21814 _

[PATCH] D22237: clang-rename: fix renaming member functions

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Testcase by Kirill Bobyrev. http://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp ==

Re: [PATCH] D22102: [clang-rename] extend testset

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Can you please avoid adding VirtualFunction.cpp? http://reviews.llvm.org/D22237 would add it as well, but without the FIXME. Thanks! :-) http://reviews.llvm.org/D22102 ___ cfe-commits ma

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos updated this revision to Diff 64025. https://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp === --- /dev/null +++ test/clan

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos added a comment. Forgot to add asserts for main() in the testcase. https://reviews.llvm.org/D22237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos updated this revision to Diff 64027. https://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp === --- /dev/null +++ test/clan

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. The alternative is to change the `CommonOptionsParser` ctor to take a vector of `OptionCategory&`, and in that case we can add the -extra-arg-before and other options to all subcommands, but that means he'll have to adapt all client code, i.e. all tools in clang-tools-e

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. I'm a bit confused. On one hand, I want to use tooling::CommonOptionsParser to parse the options, which needs a cl::OptionCategory as a parameter. On the other hand, I want to parse the options, based on that I'll know what subcommand was requested, and then I can choo

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos updated this revision to Diff 64204. https://reviews.llvm.org/D21814 Files: clang-rename/tool/ClangRename.cpp test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassReplacements.cpp test/clang-rename/ClassSimpleRenaming.cpp test/clang-rename/ClassTest.cpp test/clang-rena

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. I've implemented the requested split of options, now there are two new rename-at and rename-all subcommands. The only common options is -i and -new-name, nothing else is shared, apart from the common options added by `tooling::CommonOptionsParser`. The code is modeled a

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos abandoned this revision. vmiklos added a comment. I see your point, then let me abandon this. https://reviews.llvm.org/D22237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 64231. https://reviews.llvm.org/D21814 Files: clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassReplacements.cpp test/clang-rename/ClassSimpleRena

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. In https://reviews.llvm.org/D21814#486204, @omtcyfz wrote: > - Can you please update diff? I changed most of the tests recently. Sure, I actually wanted to ask if those test additions were meant to be test renames. :-) > - I think you should update `doc/clang-rename` i

<    1   2