[PATCH] D21012: clang-rename: implement renaming of classes inside static_cast

[Miklos Vajna via cfe-commits]

vmiklos created this revision.
vmiklos added a reviewer: klimek.
vmiklos added a subscriber: cfe-commits.

"Derived" in static_cast<Derived&>(...) wasn't renamed, nor in its
pointer equivalent.

http://reviews.llvm.org/D21012

Files:
  clang-rename/USRLocFinder.cpp
  test/clang-rename/StaticCastExpr.cpp

Index: test/clang-rename/StaticCastExpr.cpp
===================================================================
--- /dev/null
+++ test/clang-rename/StaticCastExpr.cpp
@@ -0,0 +1,28 @@
+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=150 -new-name=X %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+class Base
+{
+};
+
+class Derived : public Base
+{
+public:
+  int getValue() const
+  {
+      return 0;
+  }
+};
+
+int main()
+{
+  Derived D;
+  const Base &Reference = D;
+  const Base *Pointer = &D;
+
+  static_cast<const Derived&>(Reference).getValue(); // CHECK: 
static_cast<const X&>
+  static_cast<const Derived*>(Pointer)->getValue(); // CHECK: 
static_cast<const X*>
+}
+
+// Use grep -FUbo 'Derived' <file> to get the correct offset of foo when 
changing
+// this file.
Index: clang-rename/USRLocFinder.cpp
===================================================================
--- clang-rename/USRLocFinder.cpp
+++ clang-rename/USRLocFinder.cpp
@@ -123,6 +123,23 @@
     return true;
   }
 
+  bool VisitCXXStaticCastExpr(clang::CXXStaticCastExpr *Expr) {
+    clang::QualType Type = Expr->getType();
+    // See if this a cast of a pointer.
+    const RecordDecl* Decl = Type->getPointeeCXXRecordDecl();
+    if (!Decl) {
+      // See if this is a cast of a reference.
+      Decl = Type->getAsCXXRecordDecl();
+    }
+
+    if (Decl && getUSRForDecl(Decl) == USR) {
+      SourceLocation Location = 
Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc();
+      LocationsFound.push_back(Location);
+    }
+
+    return true;
+  }
+
   // Non-visitors:
 
   // \brief Returns a list of unique locations. Duplicate or overlapping



Index: test/clang-rename/StaticCastExpr.cpp
===================================================================
--- /dev/null
+++ test/clang-rename/StaticCastExpr.cpp
@@ -0,0 +1,28 @@
+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=150 -new-name=X %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+class Base
+{
+};
+
+class Derived : public Base
+{
+public:
+  int getValue() const
+  {
+      return 0;
+  }
+};
+
+int main()
+{
+  Derived D;
+  const Base &Reference = D;
+  const Base *Pointer = &D;
+
+  static_cast<const Derived&>(Reference).getValue(); // CHECK: static_cast<const X&>
+  static_cast<const Derived*>(Pointer)->getValue(); // CHECK: static_cast<const X*>
+}
+
+// Use grep -FUbo 'Derived' <file> to get the correct offset of foo when changing
+// this file.
Index: clang-rename/USRLocFinder.cpp
===================================================================
--- clang-rename/USRLocFinder.cpp
+++ clang-rename/USRLocFinder.cpp
@@ -123,6 +123,23 @@
     return true;
   }
 
+  bool VisitCXXStaticCastExpr(clang::CXXStaticCastExpr *Expr) {
+    clang::QualType Type = Expr->getType();
+    // See if this a cast of a pointer.
+    const RecordDecl* Decl = Type->getPointeeCXXRecordDecl();
+    if (!Decl) {
+      // See if this is a cast of a reference.
+      Decl = Type->getAsCXXRecordDecl();
+    }
+
+    if (Decl && getUSRForDecl(Decl) == USR) {
+      SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc();
+      LocationsFound.push_back(Location);
+    }
+
+    return true;
+  }
+
   // Non-visitors:
 
   // \brief Returns a list of unique locations. Duplicate or overlapping

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits