[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

mibintc added inline comments. Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Basic/SanitizerSpecialCaseList.h" vitalybuka wrote: > dexonsmith wrote: > > vitaly

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

mibintc updated this revision to Diff 325191. mibintc added a comment. Herald added a subscriber: mgorny. What do you recommend as next steps, incrementally? Is there more clarity about option names? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64fcdf8d53c: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc updated this revision to Diff 326412. mibintc added a comment. I rebased the patch and basically made no other changes. On the review there's a suggestion that 'blocklist' isn't the best word choice, do you have suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc added a comment. In D96203#2587942 , @echristo wrote: > Exclusion list? or exclude? In 2a4317bfb319e , (Fangrui Song 2020-06-19) changed option name fsanitize-coverage-whitelis

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 349644. mibintc added a comment. I made a change to ActOnParenExpr to check that the parenthesized expression is not an lvalue before inserting the call to builtin __arithmetic_fence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. question for @aaron.ballman Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated. If

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350307. mibintc added a comment. This patch addresses all of @craig.topper comments and adds documentation for the new intrinsic to the language reference as requested by @LuoYuanke nke Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350700. mibintc added a comment. I corrected error in LangRef documentation that @pengfei pointed out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files: llvm/doc

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350912. mibintc retitled this revision from "[llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level" to "[llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level". mib

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rG8daac3714083: [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D74436?vs=345526&id=351156#toc Repository:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1501 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This is the default behavior. + * ``precis

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. The bot is showing a fail due to this patch, see https://lab.llvm.org/buildbot#builders/110/builds/4007 It looks like my updates to LNT earlier this week haven't been migrated to the bot, is that right? See https://reviews.llvm.org/rTccc86f938839d02de3a6564b2d80fb47a60

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. Reply to @joerg proposing new wording for the option description Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-poi

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. I’ve been trying to commit this patch. However, when I commit, the tests fail some 21 floating point tests in LNT. Also there is both performance improvement as well as regression which shouldn’t happen because the sum total of my clang patch + my LNT patch should effe

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 353719. mibintc added a comment. Herald added subscribers: jdoerfert, hiraditya. This patch addresses almost all the review comments, not yet sure about @aaron.ballman 's question about CoreOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc created this revision. mibintc added a reviewer: aaron.ballman. mibintc added a project: clang. Herald added subscribers: kerbowa, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. mibintc requested review of this revision. Herald added a subscriber: aheejin. In the

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354009. mibintc added a comment. The patch I uploaded for review yesterday wasn't correct, not sure what happened. This one looks better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://revi

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 9 inline comments as done. mibintc added a comment. A couple inline replies to go along with the updated patch Comment at: clang/include/clang/Driver/Options.td:1757 + LangOpts<"ProtectParens">, DefaultFalse, + PosFlag Should this option also be exposed to clan

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354061. mibintc marked 2 inline comments as done. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files:

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 11 inline comments as done. mibintc added a comment. some inline replies. I think this is all set now. Comment at: clang/lib/Sema/SemaExpr.cpp:4026 + !E->isLValue() && + (ExprTy->isFloatingType() || (ExprTy->isComplexType( { +return BuildBuilti

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 354300. mibintc added a comment. Rebasing. Hope this clears lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files: llvm/docs/LangRef.rst llvm/include/ll

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354301. mibintc added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Builtins.def

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#2917357 , @haowei wrote: > We are seeing float related unit tests failing in Fuchsia after this patch. > What flags should we add to our build to match llvm's previous float point > behavior? This option: ffp-contract=

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a subscriber: kbsmith1. mibintc added a comment. There was a long discussion on cfe-dev about this issue approximately January-February 2020 including @scanon @andrew.w.kaylor and many others. While there wasn't 100% consensus to move to ffp-contract=on there are many reasons to

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG931e95687d6d: [llvm][clang][fpenv] Create new intrinsic llvm.arith.fence to control FP… (authored by mibintc). Repository: rG LLVM Github Monorepo

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c02b0c3f454: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1238e44d80: [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github Mo

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. buildbot fails on lldb need to update this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 _

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. buildbot fails in lldb, will submit updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/ https://reviews.llvm.org/D104729 __

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbe1c675fe9: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to c

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. More buildbot failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/ https://reviews.llvm

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaba37187fda: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was automatically updated to reflect the committed changes. Closed by commit rGe773216f4636: [clang][patch] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc created this revision. mibintc added reviewers: ABataev, aaron.ballman. Herald added a subscriber: kristof.beyls. mibintc requested review of this revision. Herald added a project: clang. In the bug report, @DavidKreitzer wrote: clang should be giving an error for this test, because we hav

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc updated this revision to Diff 327446. mibintc added a comment. @aaron.ballman Is this what you have in mind to improve the diagnostic? There are other places in the file that assume FDecl can be null so I just copied that code. Also since the arm warning diagnostic is exactly similar,

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc updated this revision to Diff 327465. mibintc added a comment. Thanks I'll wait to see if there are any more remarks, and push it later today or tomorrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97764/new/ https://reviews.llvm.org/D97

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc3d25be0116: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines… (authored by mibintc). Repository: rG LLVM Github Mo

[PATCH] D97945: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. Thanks @ABataev ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97945/new/ https://reviews.llvm.org/D97945 __

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

mibintc created this revision. mibintc added reviewers: kpn, erichkeane, rjmccall. mibintc requested review of this revision. Herald added a project: clang. Currently, the CurFPFeatures state is set to command line settings before semantic analysis of the nested member functions and initializatio

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

mibintc added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3419 // delayed attributes. SourceLocation SavedPrevTokLocation = PrevTokLocation; I remember worrying about this issue when I wrote the initial patch but I can't remember wh

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. Herald added subscribers: jansvoboda11, dexonsmith. I got a bug report about this patch, see https://bugs.llvm.org/show_bug.cgi?id=49479. I put a patch to fix it here, https://reviews.llvm.org/D98211 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG33b1f3f42cb9: [clang][patch] Solve PR49479, File scope fp pragma should propagate to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251699. mibintc retitled this revision from "Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary" to "Move FPFeatures from BinaryOperator bitfields to Trailing storage". mibintc added a comment. This revision has been rebased, the

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. In D76384#1929774 , @mibintc wrote: > There's a bug in this patch that i haven't solved yet. I think it's just 1 > bug. The bug is that the AST statement visitor is going to the "fallback"

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251746. mibintc added a comment. This revision fixes the clang-tidy,clang-format and removes the redundant accessors. Ready for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://rev

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1934785 , @rjmccall wrote: > Let's make this patch be purely a representation change. I wouldn't expect > *any* test changes from that; if there are, we should understand why. You > can then add the stuff about tracki

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 252469. mibintc added a comment. I think this addresses all the feedback from @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. I don't see those Harbormaster fails, using trunk and RHEL8 on architecture x86_64, Debug build of clang;clang-tools-extra and check-all. I ran all the failed lit tests separately and each passed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:3465 +SubExprs[RHS] = rhs; +hasFPFeatures = true; +isCompoundAssign = 1; rjmccall wrote: > Okay, so this is *always* adding trailing st

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 253341. mibintc marked 12 inline comments as done. mibintc added a comment. @rjmccall Many thanks for your code review. Please take a look at this when you get a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added a comment. I added some inline replies to John. I'm not certain I have everything yet exactly the way he wants it. Comment at: clang/include/clang/AST/Expr.h:2573 + FPOptions FPFeatures; + rjmccall wr

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. On my RHEL8 system building Debug clang;clang-tools-extra, check-all is passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 ___ cf

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 253983. mibintc added a comment. Here's another revision, I believe this handles all of @rjmccall 's requests. Thank you, John, for your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https:

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 246285. mibintc marked an inline comment as done. mibintc added a comment. This patch is code complete and ready for your review and consideration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

mibintc added a comment. Added a couple inline comments Comment at: clang/docs/ReleaseNotes.rst:62 + permit non-power of 2 integers, exposing the LLVM integer types. Since a major + motivating use case for these types is to limit 'bit' useage, these types don't + automatic

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 12 inline comments as done. mibintc added a comment. Herald added a subscriber: rnkovacs. some inline replies and comments Comment at: clang/include/clang/AST/Stmt.h:1104 +static_assert(sizeof(*this) <= 16, "changing bitfields changed sizeo

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point optzns. CODEGENOPT(UnwindTables , 1,

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227283. mibintc added a comment. I followed up on some code review remarks from @rjmccall. I dropped the CODEGEN option and fixed some code formatting. I changed the spelling of the enumeration values for RoundingMode and ExceptionMode to match those propose

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:1152 +def frounding_math : Flag<["-"], "frounding-math">, Group, Flags<[CC1Option]>; +def fno_rounding_math : Flag<["-"], "fno-rounding-math">, Group, Flag

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227470. mibintc added a comment. Respond to recent code review from @rjmccall ; I modified the test cases and added functions for translating between the LangOptions enumeration and llvm enumeration for rounding-mode and exception-behavior. I wasn't able to

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) { I added these 2 functions, is this what you ha

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227527. mibintc added a comment. Recoded ToConstrainedRoundingMD and ToConstrainedExceptionMD as requested by @rjmccall CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227532. mibintc added a comment. Made a couple functions static per @rjmccall request Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/includ

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) { rjmc

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227960. mibintc retitled this revision from "Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

This revision was automatically updated to reflect the committed changes. Closed by commit rG759948467ea3: Reapply "Fix crash on switch conditions of non-integer types in templates" (authored by mibintc). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc closed this revision. mibintc added a comment. Don't know why the commit id didn't get linked when I pushed the change. Here's the closure info: commit af57dbf12e54f3a8ff48534bf1078f4de104c1cd Author: Melanie Blower

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null. I start by adding a

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. The incorrect code is actually in the IRBuilder which is part of a different patch... In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm working on a patch. Previously there was no support > > for frounding-math (unimplement

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Reopening since patch was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 229893. mibintc added a reviewer: kpn. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/include/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I added a nullptr check in IRBuilder.h and a test case to cover the segfault reported in https://bugs.llvm.org/show_bug.cgi?id=44048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1750412 , @kpn wrote: > Does anyone think a warning is appropriate because the new flags are > exercising experimental, incomplete code in both clang and llvm? The warning > would be removed when we believe the feature

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked 4 inline comments as done. mibintc added a comment. inline replies to Michele, will upload a new patch shortly Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2408 +case options::OPT_frounding_math: + // The default setting for frounding-math is True a

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 230128. mibintc added a comment. Here's an update in response to comments from @michele.scandale I fixed the assertion error and added a test case I fixed the setting of ftrapping-math in CodeGenOpts I deleted an incorrect comment I added a diagnostic when -f

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 231758. mibintc added a comment. This commit was reverted in 30e7ee3c4bac because a null deref error occurred in IRBuilder.h when setting strictfp attribute, see https://bugs.llvm.org/sho

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked 9 inline comments as done. mibintc added a comment. I added inline comments describing what I did in this version of the patch to address the bug https://bugs.llvm.org/show_bug.cgi?id=44048 Comment at: clang/include/clang/AST/DeclBase.h:1539 +/// Indicates i

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I've pushed the updated patch, commit cdbed2dd856c14687efd741c2d8321686102acb8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I reverted it again because build break on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list cfe-com

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I fixed the lit test problem and pushed it again commit 7f9b5138470db1dc58f3bc05631284c653c9ed7a Author: Melanie Blower Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1773854 , @michele.scandale wrote: > I've noticed you removed the change for `CompilerInvocation.cpp` about the > initialization of the codegen option `NoTrappingMath`. Was that an accident? I checked the old and new

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1778597 , @michele.scandale wrote: > >> I've noticed you removed the change for `CompilerInvocation.cpp` about the > >> initialization of the codegen option `NoTrappingMath`. Was that an > >> accident? Thanks again M

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1780597 , @cameron.mcinally wrote: > I don't see a problem with this, but it would be nice to make the > `-f[no-]trapping-math` command line option work. GNU compatibility is good. Thanks Cameron, I'll go that way R

[PATCH] D71671: [clang] Remove -Wexperimental-float-control.

mibintc added a comment. thanks for taking care of this. looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71671/new/ https://reviews.llvm.org/D71671 ___ cfe-commits mailing list cfe-commi

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1790211 , @rupprecht wrote: > In D62731#1789122 , @rupprecht wrote: > > > In D62731#1788902 , > > @andrew.w.kaylor wrote: > > > > > In D62

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

mibintc added a comment. In D69272#1717021 , @kpn wrote: > Is there a way forward to support having the #pragma at the start of any > block inside a function? The effect won't be restricted to that block, true, > but the standard does say the #pragma is

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4085 // this should improve codegen just a little. -RHS = Visit(E->getRHS()); -LHS = EmitCheckedLValue(E->getLHS(), CodeGenFunction::TCK_Store); +

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I got an email like this "Harbormaster failed remote builds in B48237 : Diff 248536!" but there is no further information. It builds OK from my workstation. I did have to paste the review because an upload to Phabricator exceeded the s

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#1911330 , @rjmccall wrote: > In D72841#1908084 , @mibintc wrote: > > > @rjmccall suggested that I needed to remove FPOptions from the Stmt class > > since the sizeof assertion fai

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. I'm working on a patch that will move FPOptions to Trailing storage, part of https://reviews.llvm.org/D72841 ; hope to have another revision uploaded today or tomorrow. I got feedback that moving the field to BinaryOperator isn't adequate. Repository: rG LLVM Githu

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. well, it would probably be quickest to separate the trailing storage into a separate patch. i'll try to get that submitted today. shall i submit that as a phabricator review or is there a different, preferred way to do that? Repository: rG LLVM Github Monorepo CHA

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. @rjmccall Since CompoundAssignmentOperator derives from BinaryOperator, it's not simple to add Trailing storage here. I think I will have to fold CompoundAssignmentOperator into BinaryOperator and then add the 2 extra fields needed by CompoundAssignmentOperator into Tr

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. I ran into an obstacle trying to add Trailing storage onto binary operator. it will probably take me longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75443/new/ https://reviews.llvm.org/D75443 _

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. In D72675#1919685 , @spatel wrote: > In D72675#1917844 , @wristow wrote: > > > Revisiting this patch. I think that before fixing the `-ffp-contract=off` > > problem I originally raised her

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. This patch, which hasn't been committed, contains modifications to the UserManual with many details concerning 'floating point semantic modes" and the relation to floating point command line options. This is from a discussion that @andrew.w.kaylor initiated on the discu

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. @David.Bolvansky told me “https://lnt.llvm.org/ -> Test suite nts -> watch for > LNT-Broadwell-AVX2-O3__clang_PROD__x86_64:1364” The fails were seen on aarch too and a couple other arch. AFAIK the old results are no longer availble. i scraped the list of fails, pastin

<    1   2   3   4   5   >