mibintc marked 11 inline comments as done.
mibintc added a comment.
some inline replies. I think this is all set now.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:4026
+ !E->isLValue() &&
+ (ExprTy->isFloatingType() || (ExprTy->isComplexType()))) {
+ return BuildBuiltinCallExpr(R, Builtin::BI__arithmetic_fence, E);
----------------
mibintc wrote:
> aaron.ballman wrote:
> > Do you have to worry about vector types here as well?
> Oh yes, i didn't get this one.
Yes thanks, i also added a little test case for this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100118/new/
https://reviews.llvm.org/D100118
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
