[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. In https://reviews.llvm.org/D34158#905596, @jyknight wrote: > I'd still _very_ much like a solution that is acceptable for all libc to use, > and have that on by default. > > However, I guess this is fine. > > Only concern I have is that it seems odd that so many test-ca

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. In https://reviews.llvm.org/D34158#905637, @mibintc wrote: > In https://reviews.llvm.org/D34158#905596, @jyknight wrote: > > > I'd still _very_ much like a solution that is acceptable for all libc to > > use, and have that on by default. > > > > However, I guess this is

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. I pulled out all the test changes and the only one that is needed presently is Clang :: Driver/crash-report.c; huh, that's different than what I encountered earlier in the summer. Now I'll recheck those extra tests. https://reviews.llvm.org/D34158 _

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc created this revision. mibintc created this object with visibility "All Users". Herald added subscribers: fedor.sergeev, arichardson, Anastasia, sdardis, klimek. As reported in llvm bugzilla 32377. Here’s a patch to add preinclude of stdc-predef.h for gcc >= 4.8 The gcc documentation say

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 102382. mibintc added a comment. forgot to add the new lit test https://reviews.llvm.org/D34158 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h lib/Driver/ToolChains/Linux.

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 102605. mibintc added a comment. Thanks for your review, Fedor. I moved AddGnuIncludeArgs out of GCCInstallation, like you suggested, and put it along where the library includes are added. I also pulled out the change for MipsLinux since I don't have a wa

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. In https://reviews.llvm.org/D34158#782467, @fedor.sergeev wrote: > LGTM wrt your update to sources. > And sorry, I'm not that qualified to answer your question on failing tests. > > Probing existence of this header would make a sense, yet you are including it > w/o a fu

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc planned changes to this revision. mibintc added a comment. I'm submitting another revision which checks for the existence of stdc-predef.h before inserting the -include option. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc abandoned this revision. mibintc added a comment. I want to submit a modified patch Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 103871. mibintc added a comment. Here's a modified revision which checks if stdc-predef.h exists before adding a -include option to that file. this is only for Linux using gcc 4.8 and higher. Several tests needed to be fixed because of this change - i fix

[PATCH] D44426: Fix llvm + clang build with Intel compiler

mibintc added a comment. I added some inline comments. You are using the Intel 18.0 compiler on Windows - what version of Visual Studio is in the environment? Comment at: include/llvm-c/Target.h:25 -#if defined(_MSC_VER) && !defined(inline) +#if defined(_MSC_VER) && !defined

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc created this revision. mibintc added reviewers: cfe-commits, erichkeane, rsmith. Herald added subscribers: jdoerfert, jfb. Herald added a project: clang. Clang considers the type of a statement expression that returns the value of an _Atomic(ty) to be atomic, and this makes the statement

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc marked 2 inline comments as done. mibintc added a comment. Thanks for test suggestions, will follow up Comment at: test/Sema/atomic-expr-stmt.c:7 + //CHECK: %atomic-load = load atomic i32, i32* %a.addr seq_cst, align 4 + //CHECK: store atomic i32 %atomic-load, i32* %t

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1427665 , @jfb wrote: > From an offline discussion, I'm told that @jwakely uses this in GCC headers > and expects some semantics from it? Jonathan, why?!?! Yes this is how I stumbled into the issue. Repository: rC

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1427663 , @jfb wrote: > Thinking some more, this is really a silly gotcha in code. We should probably > follow what we're about to do with wg21.link/P1152 > and ban chaining. Statement e

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1427644 , @jfb wrote: > I think you also want to test C++ `std::atomic` ... The bug described in https://bugs.llvm.org/show_bug.cgi?id=41033 doesn't occur using C++ atomic, I rewrote the test case this way, and it comp

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1428145 , @jfb wrote: > In D59307#1428101 , @mibintc wrote: > > > In D59307#1427644 , @jfb wrote: > > > > > I think you also want to test C

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1427853 , @erichkeane wrote: > This is my concern here: > https://godbolt.org/z/icS4fa > The patch will change template instantiation. > > GCC doesn't seem to allow using _Atomic in C++ mode, which is perhaps a > nece

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc abandoned this revision. mibintc added a comment. The bug should be fixed at the atomic-load (drop _Atomic qualifier) then this patch won't be needed in StmtExpr Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59307/new/ https://reviews.llvm.org/D59307

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc created this revision. mibintc added reviewers: clang-c, fedor.sergeev. mibintc added a project: clang. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Intel is developing an offload compiler based on clang (that will eventually be contributed to open source). In th

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc marked an inline comment as done. mibintc added a comment. added an inline comment about the use of strncmp Comment at: lib/Frontend/DependencyFile.cpp:279 + if (DependencyFilter.size() && + strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) ==

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. Another ping. Is it possible to approve this modification, or alternatively, let me know that it won't be approved indefinitely? I understand that it's a controversial change. Thanks! https://reviews.llvm.org/D34158 ___

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 114820. mibintc added a comment. I heard that @jyknight is still interested in this functionality, updating the patch to latest sources, to do this i needed to make a small change to a couple of driver tests. Other than that it's the same as previous submiss

[PATCH] D34624: extra test modifications for D34158

mibintc updated this revision to Diff 114887. mibintc added a comment. Updating to latest version. No change other than that. https://reviews.llvm.org/D34624 Files: test/clang-tidy/llvm-include-order.cpp test/pp-trace/pp-trace-conditional.cpp test/pp-trace/pp-trace-ident.cpp test/pp-tra

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. Hey @jyknight I heard from @erichkeane that you may want a couple more changes to this patch. Please let me know if you have some changes to recommend. @joerg thought this was OK for submission. Thanks --Melanie https://reviews.llvm.org/D34158 _

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc abandoned this revision. mibintc added a comment. I'll modify this to be a cc1 only option, there doesn't seem to be community interest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___ c

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, kpn. Herald added a subscriber: mgorny. Herald added a project: LLVM. This is part of RFC to support language options -fp-model and -fp-speculation. This makes a small modification to D53157

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc created this revision. mibintc added a reviewer: chandlerc. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Intel would like to contribute a patch to implement support for these Intel- and Microsoft -fp options. This message is to describe the options and request

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. I've posted a small change to this patch here, https://reviews.llvm.org/D62730 and there's a patch to add clang fp options here, https://reviews.llvm.org/D62731 Comment at: include/llvm/IR/IRBuilder.h:234 + /// Set the exception handling to be used w

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added inline comments. Comment at: include/llvm/IR/IRBuilder.h:234 + /// Set the exception handling to be used with constrained floating point + void setDefaultConstrainedExcept(MDNode *NewExcept) { +DefaultConstrainedExcept = NewExcept; kpn wrote

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +FPM_Strict, +FPM_Fast + }; + kpn wrote: > lebedev.ri wrote: > > All this needs comm

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. In D53157#1525311 , @kpn wrote: > Oh, this ticket is not going to die from neglect. It is true that D43515 > is a higher priority, but I need this > IRBuilder work done as well. My department hea

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc abandoned this revision. mibintc added a comment. I'm abandoning this patch in deference to @kpn 's patch under review D53157 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730 ___

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. This works for me, I redid my patches adding fp-model options to work with this newest changeset, (but I haven't yet uploaded them.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 211770. mibintc added a comment. Herald added subscribers: hiraditya, mgorny. The IRBuilder now has been taught about constrained fadd and friends. I simply updated my patches to work with the committed revision. Note that this diff now contains what was

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. The proposed llvm changes are now part of https://reviews.llvm.org/D62731 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 ___ cfe-commits mailing list

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added a comment. Thanks for your review >>! In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > >> I think it would be convenient to have an "u

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 214003. mibintc edited the summary of this revision. mibintc added a comment. Compared to the 2nd revision, this patch moves all the changes into clang, removing the FPState file. In the summary, I've copied information from Microsoft about the fp-model opt

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > > > I think it would be convenient to have an "unset" setting for the different > > constrained modes, otherwise you

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1603030 , @kpn wrote: > I actually don't have much of an opinion on what the command line argument > form should be. It may be helpful for it to be the same as one of the > commonly deployed compilers. The worst I think

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1619908 , @lebedev.ri wrote: > In D62731#1619892 , @mibintc wrote: > > > Compared to the 2nd revision, this patch moves all the changes into clang, > > removing the FPState file.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1620174 , @andrew.w.kaylor wrote: > I'm not entirely caught up on this review. I've only read the most recent > comments, but I think I've got enough context to comment on the metadata > arguments. > > Based only on

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. Here's a summary of how the rm and eb options are set if user requests fp-model=strict, then the ConstrainedIntrinsic will be built with ( rmDynamic, ebStrict ) if user requests fp-model=except or fp-model=noexcept then the ConstrainedIntrinsic will be built with eb se

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215225. mibintc added a comment. I added documentation for the new floating point options into clang/docs Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManua

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; kpn wrote: > Wait, so "fast" and "precise" are the same thi

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as not done. mibintc added a comment. I added an inline reply and unmarked some things that had been inadvertently marked done. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fas

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215666. mibintc marked an inline comment as not done. mibintc edited the summary of this revision. mibintc added a comment. I addressed some comments from @kpn: I corrected the documentation formatting and added some details, and used Diag instead of llvm_unr

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc updated this revision to Diff 199082. mibintc added a comment. respond to suggestion from @xbolva00 (thanks). Added a test case where prefix fails to match CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 Files: docs/ClangCommandLineR

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc added a comment. @dexonsmith Can you take a look at this patch or recommend someone who can review it? Many thanks. --Melanie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___ cfe-commits

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc added a comment. @rjmccall Can you take a look at this patch or recommend someone who can review it? Many thanks. --Melanie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___ cfe-commits ma

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code gene

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223090. mibintc added a comment. In the previous review, @rjmccall asked me to redo the existing floating point option documentation before submitting this patch. I got the floating point documentation update committed, and I've worked on this patch more to

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

mibintc created this revision. mibintc added reviewers: erichkeane, cfe-commits, majnemer. Herald added a subscriber: llvm-commits. Microsoft doesn't support _Float16, so this patch invents a mangling using the technique that was used for _Complex, putting _Float16 into __clang namespace. What

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223908. mibintc added a comment. I made a couple wording changes suggested by @rjmccall Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/incl

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1341 + has been selected, then the compiler will issue a diagnostic warning + that the override has occurred. + rjmccall wrote: > That's not typica

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:927 def fdenormal_fp_math_EQ : Joined<["-"], "fdenormal-fp-math=">, Group, Flags<[CC1Option]>; +def ffp_model_EQ : Joined<["-"], "ffp-model=">, Group, Fla

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223911. mibintc added a comment. clean up some dead code Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/CodeGenOptions.

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223940. mibintc added a comment. I added a test case to show the warning diagnostics when options conflicting with fp-model are provided. I fixed a couple bugs in RenderFloatingPointOptions when issueing diagnostics. still owe a test case showing how the fp

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 224136. mibintc retitled this revision from "[RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1330 + and ``fast``. + Details: + rjmccall wrote: > rjmccall wrote: > > "provided by other, single-purpose floating point options." > I don't know

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I looked over the codegen testcase fpconstrained.c and it looks pretty good, so i think this is ready for your review comments. I'll be off the grid for a couple days but looking forward to receiving your feedback. I inserted a

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. Ping. Hoping for code review so I can move this forward. Affirmative or negative, please let me know. Thank you! --Melanie Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + rjmccall wrote: > rjmccall wrote: > > "represent *the* corresponding IEEE rounding rules" > A few

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226738. mibintc added a comment. I adopted the language that @rjmccall recommended for documenting frounding-math., also adding a sentence to describe effects on exception behavior control. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226907. mibintc added a comment. In response to comments from @rjmccall I inserted into the UsersManual the one-line summary of frounding-math that had been omitted and changed the semantics of frounding-math to not also set exception-behavior to strict Re

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1724290 , @rjmccall wrote: > Is the exception-strictness of `-frounding-math` actually considered to be > specified behavior, or is it just a consequence of the current > implementation? There are definitely some optim

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

This revision was automatically updated to reflect the committed changes. Closed by commit rG827be690dce1: [clang] FastMathFlags.allowContract should be initialized only from FPFeatures. (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

mibintc added a comment. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. Herald added a subscriber: sstefan1. I documented the issue reported by @yaxunl here, https://bugs.llvm.org/show_bug.cgi?id=46166, and take ownership of the bug. Thanks for the report. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 255301. mibintc added a comment. I beleive this patch responds to all @rjmccall 's review comments, except I don't know how to program a solution to his StmtVisitor remark. I'll add more info about that. This patch optionally allocates the trailing storage

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. If I change StmtVisitor to send compound assignment opcodes to BinaryOperator, then 12 clang LIT tests fail, all related to compound assignment mishandling, i.e. this patch - a/clang/include/clang/AST/StmtVisitor.h +++ b/clang/include/clang/AST/StmtVisitor.h @@ -143,7

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. It seems like the macro's in StmtVisitor.h only work if CAO and BinaryOperator are separate classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 _

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 256648. mibintc added a comment. I finally decided that combining BinaryOperator and CompoundAssignOperator was too difficult, this patch uses the trailing object approach similar to that used in CallExpr. @rjmccall thank you once again for all your reviews

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 256998. mibintc added a comment. I made the changes requested by @rjmccall ; I also used clang-format on the tip. check-clang is passing. Look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ http

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257055. mibintc added a comment. Responded to @rjmccall 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. Adding an inline reply for John. rebased the patch, also re-applied clang-format. What do you think? Comment at: clang/lib/Analysis/BodyFarm.cpp:120 +VK_RValue, OK_Ordinary, Sou

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257704. mibintc added a comment. Lost power in Monday's storm, back online today. I made the changes requested by @rjmccall. Look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257789. mibintc added a comment. Responding to @rjmccall 's review. John, after this is approved I want to proceed with pragma float_control as proposed in D72841 . Can you recommend an approach, do you think I will need to

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > In D76384#1984498 , @mibintc wrote: > > > Responding to @rjmccall 's review. John, after this is approved I want to > > proceed with pragma float_con

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > I *would* like an NFC patch first that renames `FPFeatures` to something like > `CurFPFeatures` in order to more clearly distinguish it from `FPOptions` in > Sema code, though. That should

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba4e3a4598b: Move BinaryOperators.FPOptions to trailing storage (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://rev

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc created this revision. mibintc added a reviewer: rjmccall. Herald added subscribers: llvm-commits, dexonsmith. Herald added projects: clang, LLVM. mibintc marked an inline comment as done. mibintc added a comment. @rjmccall You suggested that the FPFeatures could be delta instead of absolu

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc marked an inline comment as done. mibintc added a comment. @rjmccall You suggested that the FPFeatures could be delta instead of absolute settings, I think this is approximately what you mean. This is a rough patch employing that idea, would welcome your early comments. There are 2 cla

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 271188. mibintc added a comment. This version passes all the lit tests, i believe it's functional tho' maybe not elegant. I still need to add a test case that PCH behaves as desired, and that the floating point command line options from PCH create do not clo

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272536. mibintc added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. This revision rewrites FPOptionsOverride like @rjmccall suggests. There are a couple problems, i'll add inline comments in the trouble areas Repository:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc marked 6 inline comments as done. mibintc added a subscriber: yaxunl. mibintc added a comment. @rjmccall I added some inline questions and comments for you. Thanks a lot for your review. Comment at: clang/include/clang/AST/ExprCXX.h:172 + FPOptionsOverride getFPFeatu

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272798. mibintc added a comment. I responded to review from @riccibruno and @rjmccall : I put the dump() routines into the .cpp file and changed them to use the x-macros. I moved CXXOperatorCall.FPOptionsOverride from the Expr bits into the OperatorCall it

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272808. mibintc added a comment. The difference between this patch and the earlier one today is that I modified the new test case I misunderstood why the test case was failing. The BENIGN_LANGOPT is working as desired and those pch diagnostics are no longer

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc added a comment. I need to make another revision that makes a couple more of the fp options, like ffp-contract, "benign" and add a test case that demonstrates fp options don't carry over from pch-create to pch-use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 273133. mibintc added a comment. I decided that I shouldn't make float options that define a macro, like -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior and rounding-mode BENIGN, I modified the pch test case to test that the beni

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc added a comment. In D81869#2116752 , @yaxunl wrote: > Would you please add the following lit test > > F12245277: diff.pch.txt > > If you change FastMath, FiniteMathOnly and UnsafeFPMath to > COMPATIBLE_LANGOPT,

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. @rjmccall Can you check the patch added last night here, commit 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf Author: Benjamin Kramer Date: Thu Apr 16 11:45:02 2020 +0200 LangOptions cannot depend on

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added a subscriber: martong. mibintc added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6821 + E->getFPFeatures(Importer.getFromContext()), + importChecked(Err, ToComputationLHSType), + importChecked(E

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1986525 , @mibintc wrote: > @rjmccall Can you check the patch added last night here, commit > 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf > > Author: B

[PATCH] D78305: [NFC] Rename Sema.FPFeatures to CurFPFeatures and accessor to getCurFPFeatures

mibintc created this revision. Herald added a project: clang. Companion patch to reviews.llvm.org/D76384 this patch renames 2 identifiers Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78305 Files: clang/include/clang/Sema/Sema.h clang/li

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. I also added this patch which is a companion to this. commit 8812b0cc5cc09f350d8e89bff99f185c5e1a5d4d Author: Melanie Blower Date: Thu Apr 16 08:45:26 2020 -0700 [NFC] Rename Sema.FPFeatures to Cu

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. added a couple inline explanatory comments Comment at: clang/include/clang/Basic/LangOptions.h:307 + bool denormalIsIEEE = false; + I added this boolean as part of validating the correctness

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc created this revision. mibintc added reviewers: rjmccall, sepavloff, andrew.w.kaylor. Herald added a project: clang. mibintc marked an inline comment as done. mibintc added a comment. added an inline comment Comment at: clang/include/clang/AST/Stmt.h:618 // Only me

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. noted bug in an inline comment. i will upload a fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 ___ cfe-commits mailing list cfe-co

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc marked an inline comment as done. mibintc added a comment. added an inline comment Comment at: clang/include/clang/AST/Stmt.h:618 // Only meaningful for floating point types. -unsigned FPFeatures : 8; +unsigned FPFeatures : 14; }; This c

  1   2   3   4   5   >