[PATCH] D130689: [LLVM] Update C++ standard to 17

mstorsjo added a comment. In D130689#3700094 , @thakis wrote: > In D130689#3696186 , @thieta wrote: > >> @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it >> can be built with CXX_STAND

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. In D126676#3703024 , @jansvoboda11 wrote: > Also, I'd like to test this patch internally to see if it affects anything on > our end. I should be able to do so next week. Ping @jansvoboda11 - any update on testing this? Repos

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo updated this revision to Diff 451434. mstorsjo added a comment. Rebased, to fix (trivial) conflicts in the release notes file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126676/new/ https://reviews.llvm.org/D126676 Files: clang/docs/

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rGc843c921a1a3: [clang] Require strict matches for defines for PCH in GCC style directories (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D126676?vs=451434&id=451605#toc Repos

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

mstorsjo created this revision. mstorsjo added reviewers: rnk, STL_MSFT, efriedma, DavidSpickett. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. mstorsjo requested review of this revision. Herald added projects: clang, LLVM. This seems to work, but would it need more testing for a

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a comment. This broke some cases for me, where the output is missing some newlines, breaking the output badly. I’ll try to provide a repro… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a comment. In D104601#2906588 , @mstorsjo wrote: > This broke some cases for me, where the output is missing some newlines, > breaking the output badly. I’ll try to provide a repro… https://martin.st/temp/repro.tar.xz clang -target x86_6

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

mstorsjo added a comment. Thanks! I can confirm that this fixes the issue I ran into. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924 ___ cfe-commits mailing li

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

mstorsjo added a subscriber: tstellar. mstorsjo added a comment. @Meinersbur After landing this, can you coordinate with @tstellar to get an ack for backporting this to the 13.x release branch, which also suffers from the regression? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added subscribers: phosek, mstorsjo. mstorsjo added a comment. FWIW I think D116689 interacts with this somewhat. I think D116689 is useful for the fixes I want to do wrt libcxxabi integration on Windows (but I haven'

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added subscribers: xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. In MinGW mode, it's possible to build LLVM/Clang with LLVM_LINK_LLVM_DYLI

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

mstorsjo added a comment. @rnk Can you have a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121687/new/ https://reviews.llvm.org/D121687 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e7a8aab759a: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. The patch itself seems sensible to me. Comment at: clang/include/clang/Driver/Options.td:2496 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def fopenmp_ass

[PATCH] D123300: [Clang] Enable opaque pointers by default

mstorsjo added a comment. This triggered (or exposed) assertion failures: $ cat inlinecost.cpp typedef char a; typedef unsigned b; typedef int c; typedef struct { b d[]; } e; e f(void *) {} typedef void *fptr; fptr g; template void h(fptr i) { int (*j)(const void *) =

[PATCH] D123300: [Clang] Enable opaque pointers by default

mstorsjo added a comment. In D123300#3444903 , @nikic wrote: > @mstorsjo Thanks for the report, the issue should be fixed by > https://github.com/llvm/llvm-project/commit/8d5c8d57c637d898094af323d1888ea5a3364f8c. Awesome, thanks! Unfortunately, there se

[PATCH] D123300: [Clang] Enable opaque pointers by default

mstorsjo added a comment. In D123300#3446823 , @aeubanks wrote: > In D123300#3446023 , @nikic wrote: > >> @mstorsjo Thanks! I've reduced this to a crash in `-argpromotion`: >> >> efine void @caller() { >> ca

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

mstorsjo added a comment. Should there be tests for the LLVM side of this too, not only on the clang side? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ c

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

mstorsjo accepted this revision. mstorsjo added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032 ___ cfe-commits mailing list cfe-commit

[PATCH] D118980: Don't dllexport reference temporaries

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, seems reasonable! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118980/new/ https://reviews.llvm.org/D118980

[PATCH] D119234: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

mstorsjo created this revision. mstorsjo added reviewers: mati865, rnk. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119234 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/test/Driver/mingw-msvcr

[PATCH] D119234: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079b6d02d1f5: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D119326: [clang] [MinGW] Default to DWARF 4

mstorsjo created this revision. mstorsjo added reviewers: dblaikie, rnk, mati865. mstorsjo requested review of this revision. Herald added a project: clang. Neither LLDB nor GDB seem to work with DWARF 5 debug information on Windows right now. This applies the same change as in 9c6272861032f511a2

[PATCH] D110485: Support [[no_unique_address]] for all targets.

mstorsjo added a comment. To pick up the thread here again, `[[no_unique_address]]` is done and settled in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is accepted, without any warning (in C++20 mode), but it has no effect. (This, not related to LLVM, but because they h

[PATCH] D110485: Support [[no_unique_address]] for all targets.

mstorsjo added a comment. In D110485#3308854 , @mstorsjo wrote: > To pick up the thread here again, `[[no_unique_address]]` is done and settled > in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is > accepted, without any warning

[PATCH] D119326: [clang] [MinGW] Default to DWARF 4

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf64b2d2858: [clang] [MinGW] Default to DWARF 4 (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119326/new/ https://reviews.llvm.org/

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mstorsjo added a comment. In D121175#3486104 , @phosek wrote: > In D121175#3481547 , @MaskRay wrote: > >> Probably no from my view, as I got another internal feedback that "this >> seems rather crufty". >> It see

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extr

[PATCH] D129798: [clang-tidy] Add a "clang-" namespace prefix to the make-confusable-target executable

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added projects: LLVM, clang-tools

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extr

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo added a comment. As the name of the tool becomes somewhat public and stable at this point, feel free to suggest shorter/neater names in D129798 too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129799/n

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

mstorsjo added subscribers: phosek, hans, thakis, rnk. mstorsjo added a comment. In D121141#3655323 , @ldionne wrote: > The `experimental-library-flag` test is currently failing on Windows because > on Windows, `-stdlib=libc++` seems to be ignored and we

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG315072b45011: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo added a comment. I don't find any existing instances of `CLANG_TOOLS_INSTALL_DIR` anywhere in the current monorepo - that doesn't seem right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362 ___

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo added a comment. In D130362#3672886 , @mstorsjo wrote: > I don't find any existing instances of `CLANG_TOOLS_INSTALL_DIR` anywhere in > the current monorepo - that doesn't seem right? (I looked in a slightly outdated working dir that I hadn't u

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. This broke building of Clang, when it's set up by symlinking `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake configure errors out like this: -- Configuring done CMake Error in tools/clang/tools/clang-fuzzer/handle-cxx/CMakeLists.txt: T

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added a comment. I gave it a quick readthrough, but I don't think I can give a qualified review of the bulk of it... I noticed a couple minor details though. Comment at: libcxx/CMakeLists.txt:260 else() -set(LIBCXX_CXX_ABI_LIBNAME "default") +set(LIBCXX_CXX

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use.

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

mstorsjo added a comment. It looks like this patch still lacks compatibility handling for all external users that are setting this option, which need to be able to set the option in this way at least until after the 15.0.0 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

mstorsjo added a comment. In D125683#3516883 , @ldionne wrote: > In D125683#3515675 , @mstorsjo > wrote: > >> It looks like this patch still lacks compatibility handling for all external >> users that are settin

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

mstorsjo added inline comments. Comment at: libcxx/cmake/caches/MinGW.cmake:3 -set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "") +set(LIBCXX_CXX_ABI libcxxabi-objects CACHE STRING "") set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") Unfortunately, setting `LIBCXX

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

mstorsjo added a comment. In D66556#1648591 , @hans wrote: > In D66556#1648118 , @dexonsmith > wrote: > > > In D66556#1648109 , @rnk wrote: > > > > > I'm not sure what happe

[PATCH] D36072: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

mstorsjo created this revision. This fixes a dependency inconsistency, where addMinGWDefines in Targets.cpp (used from other architectures than X86) called the addCygMingDefines function in X86.h. This was inconsistently split in SVN r308791 (https://reviews.llvm.org/D35701). https://reviews.

[PATCH] D36072: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309598: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC) (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36072?vs=108865&id=108954#toc Repository:

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. Windows/ARM64 is a LLP64 environment, so don't set this default define. https://reviews.llvm.org/D36098 Files: lib/Basic/Targets/AArch64.cpp test/Preprocessor/init.c Index: test/Prepro

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36099 Files: test/Preprocessor/init.c Index: test/Preprocessor/init.c === --- test/Preprocessor/init.c +++ tes

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36100 Files: include/clang/Basic/Attr.td test/Sema/dllimport.c Index: test/Sema/dllimport.c === --- test/Sem

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. This is similar to what's done on arm and x86_64, where these calling conventions are silently ignored, as in SVN r245076 (https://reviews.llvm.org/D12034). https://reviews.llvm.org/D36105

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:466-467 + case CC_X86ThisCall: + case CC_X86FastCall: + case CC_X86VectorCall: +return CCCR_Ignore; rnk wrote: > Do they really ignore __fastcall and __vectorcall on arm64? > > I as

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") Shouldn't these be limited to MSVC mode only? Have a look at `BuiltinsARM.def`, where there's case

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL309618: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36099?vs=108969&id=108990#toc Repositor

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36100?vs=108971&id=108992#toc Repository:

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL309619: [AArch64] Don't define __LP64__ when targeting Windows (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36098?vs=108968&id=108991#toc Repository: rL LLVM https://re

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") mgrang wrote: > mstorsjo wrote: > > Shouldn't these be limited to MSVC mode only? Have a look at >

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added a comment. In https://reviews.llvm.org/D36111#826878, @mgrang wrote: > @mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and > _WriteStatusReg intrinsics for ARM64. I think I would need to implement them > in llvm. Do you know where can I find a doc explaining thei

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:466-467 + case CC_X86ThisCall: + case CC_X86FastCall: + case CC_X86VectorCall: +return CCCR_Ignore; mstorsjo wrote: > rnk wrote: > > Do they really ignore __fastcall and __vectorcall

[PATCH] D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test

mstorsjo created this revision. Herald added subscribers: kristof.beyls, Anastasia, rengolin, aemerson. This test was only intended to test compiling C, not OpenCL. https://reviews.llvm.org/D36363 Files: test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. The machine name `arm64pe` passed to the linker is completely made up; gnu binutils doesn't (afaik) support this, so it only has to match what the corresponding (not yet merged) lld linker s

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:122-131 if (TC.getArch() == llvm::Triple::x86) CmdArgs.push_back("i386pe"); - if (TC.getArch() == llvm::Triple::x86_64) + else if (TC.getArch() == llvm::Triple::x86_64) CmdArgs.push_back("i

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo updated this revision to Diff 109916. mstorsjo added a comment. Updated to use a switch, added a mapping of a missed case of thumb while reformatting the if to a switch. https://reviews.llvm.org/D36364 Files: lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:129 + else if (TC.getArch() == llvm::Triple::aarch64) +CmdArgs.push_back("arm64pe"); + else martell wrote: > I believe the reason I used thumb2pe for the arm triple is because MS ga

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:130 + case llvm::Triple::arm: + case llvm::Triple::thumb: CmdArgs.push_back("thumb2pe"); martell wrote: > I believe this was left incase someone wanted to do windows ce in future.

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo updated this revision to Diff 109935. mstorsjo added a comment. Added a fixme comment about this being incorrect for WinCE. https://reviews.llvm.org/D36364 Files: lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/AArch64.h lib/Driver/ToolChains/CrossWindows.

[PATCH] D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test

This revision was automatically updated to reflect the committed changes. Closed by commit rL310222: [test] Remove an unintentional -x cl flag in an aarch64-windows test (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36363?vs=109889&id=109936#toc Repository: rL LL

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo added a comment. Ping @mgrang, can you check the above with MSVC? I'd like to move forward with this in one form or another. https://reviews.llvm.org/D36105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo added a comment. In https://reviews.llvm.org/D36105#834225, @mgrang wrote: > In https://reviews.llvm.org/D36105#834007, @mstorsjo wrote: > > > Ping @mgrang, can you check the above with MSVC? I'd like to move forward > > with this in one form or another. > > > Yes, I checked with MSVC f

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL310303: [AArch64] Ignore stdcall and similar on aarch64/windows (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36105?vs=108977&id=110082#toc Repository: rL LLVM https://r

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added a comment. @compnerd - are you ok with this one as well? https://reviews.llvm.org/D36364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL310798: [AArch64] Add support for a MinGW AArch64 target (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36364?vs=109935&id=110886#toc Repository: rL LLVM https://reviews.

[PATCH] D36931: Update LLVM 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36931 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/Release

[PATCH] D36931: Update LLVM 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL311359: Update Clang 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64 (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36931?vs=111857&id=112022#toc Repositor

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo created this revision. https://reviews.llvm.org/D37133 Files: utils/merge_archives.py Index: utils/merge_archives.py === --- utils/merge_archives.py +++ utils/merge_archives.py @@ -120,6 +120,8 @@ files = glob.glo

[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

mstorsjo created this revision. Herald added a subscriber: mgorny. In cross build setups, the ar used in merge_archives.py might not be the right one for the target (and the invocation doesn't include the 's' modifier for updating the archive index); make sure to rebuild the index for the static

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. This broke my builds. A configure test that tries to compile `int main (void) { for( int i = 0; i < 9; i++ ); return 0; }` (a single line source file), with `-Wall` enabled, now triggers failed asserts: clang-10: ../tools/clang/lib/Parse/ParseStmt.cpp:1236: static un

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. In D71037#1799792 , @mstorsjo wrote: > This broke my builds. I pushed a revert for this for now, to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. In D71037#1803574 , @Tyker wrote: > In D71037#1803361 , @xbolva00 wrote: > > > Can you add a test case for that crash? Otherwise OK. > > > as i said. the bug can only occur for one line fil

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo added a comment. Ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://reviews.llvm.org/D71572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

mstorsjo updated this revision to Diff 236664. mstorsjo retitled this revision from "[ItaniumCXXABI] Make tls wrappers comdat on Windows" to "[ItaniumCXXABI] Make tls wrappers properly comdat". mstorsjo edited the summary of this revision. mstorsjo added a comment. Making the tls wrappers comdat

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

mstorsjo added a comment. @rsmith - does this look right to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://reviews.llvm.org/D71572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

mstorsjo added inline comments. Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:269 + const_cast(CRCI)->HandleCrash( + (int)ExceptionInfo->ExceptionRecord->ExceptionCode, ExceptionInfo); This implicitly converts a pointer to `uintptr_t`, which is an

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

mstorsjo added a comment. @rnk and/or @rsmith - can either of you have a look at the new version of this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://reviews.llvm.org/D71572 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

This revision was automatically updated to reflect the committed changes. Closed by commit rG810b28edb3f6: [ItaniumCXXABI] Make tls wrappers properly comdat (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://rev

[PATCH] D87517: [MinGW] Use lib prefix for libraries

mstorsjo added a comment. Herald added a reviewer: JDevlieghere. What's the practical effect of this? I see that a number of libraries already have a lib prefix prepended, like libclang/liblldb - I presume this changes the name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?

[PATCH] D87517: [MinGW] Use lib prefix for libraries

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This looks good to me! I can push it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87517/new/ https://reviews.llvm.org/D87517 __

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This should be ok, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547 __

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. In D87539#2269385 , @mati865 wrote: > We had this patch at MSYS2 for years and I'm not aware of any issues with the > static library. > I think the library looks fine: > > $ nm lib/liblibclang.a | grep __imp_ >

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. In D87539#2269442 , @mati865 wrote: > `bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export` > shows nothing. That's the import library, not the static library. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM then! Can apply it a bit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539 _

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb613044b680: [MinGW][clang-shlib] Build by default on MinGW (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8754

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

This revision was automatically updated to reflect the committed changes. Closed by commit rG7da941939902: [MinGW][libclang] Allow simultaneous shared and static lib (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D87517: [MinGW] Use lib prefix for libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc76965b1908: [MinGW] Use lib prefix for libraries (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87517/new/ ht

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. This broke a few tests for me (generating code that now gives the fail result at runtime). I'm not entirely sure which bit is the culprit, but the difference in output (that breaks tests) for one object file is available at https://martin.st/temp/vc1_block-diff-aarch6

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2282502 , @nikic wrote: > Based on an initial look, the changes in comparison predicates here are > probably a red herring. If I understand right, those predicates are switching > from signed to unsigned comparison (e.

[PATCH] D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons

mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth, thakis, hans. Herald added subscribers: llvm-commits, hiraditya. Herald added projects: clang, LLVM. mstorsjo requested review of this revision. When cross compiling with clang-cl, clang splits the INCLUDE env variable aroun

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth. Herald added a project: clang. mstorsjo requested review of this revision. GCC 8 changed behaviour wrt this, and made it consistent for cross compilation cases. While it's a change, it's a more sensible behaviour going forwa

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

This revision was automatically updated to reflect the committed changes. Closed by commit rGead7c3cdc34c: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8800

<    1   2   3   4   5   6   7   8   9   10   >