mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land.
The patch itself seems sensible to me. ================ Comment at: clang/include/clang/Driver/Options.td:2496 Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group<f_Group>, - Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, +def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group<f_Group>, + Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, ---------------- thieta wrote: > Do we mind removing these trailing whitespaces in the same commit? I can fix > that - but they shouldn't be there anyway. I think it'd be fine to just push such a commit without taking it through review, marked as NFC (no functional changes). Or keep it here but split it out into a separate commit before pushing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
