[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

mstorsjo added a comment. In D105169#3069220 , @aqjune wrote: > It seems the original code has a use of an uninitialized variable. > Line 4420 at seek-preproc.c (function `ff_seek_frame_binary`): > >int64_t pos_min=pos_min, pos_max=pos_max, pos, pos_l

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

mstorsjo added a comment. In D105169#3069555 , @aqjune wrote: > I see, the crash is happening at the line because SimplifyCFG removes the > `sti->index_entries` null pointer check (which seems valid to me). > If `stl->index_entries` was null, it would le

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

mstorsjo added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME: !DIFil

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a comment. In D111457#3073726 , @keith wrote: > In D111457#3066508 , @mstorsjo > wrote: > >> Wouldn't this one also be solved pretty much the same, but differently, by >> changing `if (llvm::sys::

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

mstorsjo created this revision. mstorsjo added a reviewer: MaskRay. mstorsjo requested review of this revision. Herald added a project: clang. This string isn't a plain architecture name, but contains the whole subdir name used for the sysroot, which often is equal to the target triple. Reposito

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo added a comment. In D111952#3068680 , @mstorsjo wrote: > I guess a downside of this solution, is that if an `i686` sysroot exists next > to the clang binary, it becomes practically impossible to test codegen > differences when you run it with v

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo updated this revision to Diff 381795. mstorsjo added a comment. Moved the fixup into `computeTargetTriple`, so it's only done after applying the `-m32`/`-m64` options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111952/new/ https://revi

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a subscriber: rnk. mstorsjo added a comment. In D111457#3085273 , @keith wrote: > Yep this makes sense. I would rather not scope that into this if that's ok. > Since this test was already invalid and broken (actual fix in > https://review

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

mstorsjo added a comment. In D42225#2962348 , @ldionne wrote: > @pcc @mstorsjo Are we aware of anyone using these extensions? > > I would like to suggest that we either remove this extension if it's not > useful, or make it unconditional (not only on Wind

[PATCH] D109265: [X86][mingw] Modify the alignment of __m128/__m256/__m512 vector type for mingw

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Thanks, this does seem to do the right thing in the testcase you provided. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109265/new/ https:/

<    8   9   10   11   12   13